On 22/06/2010, at 10:29, Nick Thompson wrote:
> On 21/06/10 19:38, Delio Brignoli wrote:
>> Hello Nick,
>> 
>> On 21/06/2010, at 11:27, Nick Thompson wrote:
>>> The following restructuring and optimisations increase the SPI
>>> read performance from 1.3MiB/s (on da850) to 2.87MiB/s (on da830):
>> 
>> Using this patch I get 2.21MiB/s on my L138 EVM (da850), quite 
>> an improvement! I would like to see how much my original patch can
>> be improved using some of your changes without splitting the code
>> to handle the three cases. I will try later this week.
> 
> Not testing the txp and rxp pointers in the loop was a significant
> gain for me and pipe-lining the TX and RX operations is going to be
> a little trickier, but give it a go by all means.

Yes, it's unlikely I will be able to get my version to work as fast as yours 
because of all the extra uncached memory access, which makes me
wonder if we shouldn't just bite the bullet and enable dcache for
da830/da850, so we can keep the code simpler.

> Thanks for the review.

Thank you for the patch.
--
Delio


_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to