Re: [U-Boot] [PATCH] - add dns

2009-07-19 Thread Mike Frysinger
On Sunday 19 July 2009 19:30:43 Robin Getz wrote: > On Sat 18 Jul 2009 21:15, Mike Frysinger pondered: > > On Saturday 18 July 2009 20:27:00 Robin Getz wrote: > > > Does it make sense to have 4 different ones? (not to me)... > > > > > > Or something new & common in ./net.c:random_port() > > > > i w

Re: [U-Boot] [PATCH] - add dns

2009-07-19 Thread Robin Getz
On Sat 18 Jul 2009 21:15, Mike Frysinger pondered: > On Saturday 18 July 2009 20:27:00 Robin Getz wrote: > > On Sat 18 Jul 2009 18:11, Mike Frysinger pondered: > > > keep the modulus something with only 1 bit set so gcc will optimize into > > > a simple and operation. probably add a comment about

Re: [U-Boot] [PATCH] - add dns

2009-07-19 Thread Robin Getz
On Sun 19 Jul 2009 03:48, Wolfgang Denk pondered: > Dear Robin Getz, > In message <200907172120.50413.rg...@blackfin.uclinux.org> you wrote: > > On Fri 17 Jul 2009 16:55, Wolfgang Denk pondered: > > > Please keep list sorted. > > > > sorted how? What we have today is: > > > > COBJS-y += net.o > >

Re: [U-Boot] [PATCH] - add dns

2009-07-19 Thread Wolfgang Denk
Dear Robin Getz, In message <200907172120.50413.rg...@blackfin.uclinux.org> you wrote: > On Fri 17 Jul 2009 16:55, Wolfgang Denk pondered: > > > Index: net/Makefile > > > === > > > --- net/Makefile (revision 1968) > > > +++ net/Makef

Re: [U-Boot] [PATCH] - add dns

2009-07-18 Thread Mike Frysinger
On Saturday 18 July 2009 20:27:00 Robin Getz wrote: > On Sat 18 Jul 2009 18:11, Mike Frysinger pondered: > > keep the modulus something with only 1 bit set so gcc will optimize into > > a simple and operation. probably add a comment about it too: > > /* make src port a little random, but use s

Re: [U-Boot] [PATCH] - add dns

2009-07-18 Thread Robin Getz
On Sat 18 Jul 2009 18:11, Mike Frysinger pondered: > On Saturday 18 July 2009 01:14:25 Robin Getz wrote: > > + DnsOurPort = 1 + (get_timer(0) % 4096); > > 4096 port range seems kind of small. i dont think the requests really need > to > be greater than 1. not sure if services would g

Re: [U-Boot] [PATCH] - add dns

2009-07-18 Thread Mike Frysinger
On Saturday 18 July 2009 01:14:25 Robin Getz wrote: > + DnsOurPort = 1 + (get_timer(0) % 4096); 4096 port range seems kind of small. i dont think the requests really need to be greater than 1. not sure if services would get pissed about being below the 1024 limit though, so this is

Re: [U-Boot] [PATCH] - add dns

2009-07-17 Thread Robin Getz
On Fri 17 Jul 2009 18:01, Wolfgang Denk pondered: > Dear Robin Getz, > > In message <200907171745.36176.rg...@blackfin.uclinux.org> you wrote: > > > > > You probably should add a doc/README.* file to explain how that is > > > supposed to be used. > > > > Will do. > > > > What is the rule for whe

Re: [U-Boot] [PATCH] - add dns

2009-07-17 Thread Robin Getz
On Fri 17 Jul 2009 16:55, Wolfgang Denk pondered: > > Index: net/Makefile > > === > > --- net/Makefile(revision 1968) > > +++ net/Makefile(working copy) > > @@ -34,6 +34,7 @@ > > COBJS-y += eth.o > > COBJS-y += nfs.o > > COB

Re: [U-Boot] [PATCH] - add dns

2009-07-17 Thread Robin Getz
On Fri 17 Jul 2009 18:01, Wolfgang Denk pondered: > Dear Robin Getz, > > In message <200907171745.36176.rg...@blackfin.uclinux.org> you wrote: > > > > > You probably should add a doc/README.* file to explain how that is > > > supposed to be used. > > > > Will do. > > > > What is the rule for whe

Re: [U-Boot] [PATCH] - add dns

2009-07-17 Thread Wolfgang Denk
Dear Robin Getz, In message <200907171745.36176.rg...@blackfin.uclinux.org> you wrote: > > > You probably should add a doc/README.* file to explain how that is > > supposed to be used. > > Will do. > > What is the rule for when things go in ./doc/README.* vs ./README ? Size - anything that take

Re: [U-Boot] [PATCH] - add dns

2009-07-17 Thread Robin Getz
On Fri 17 Jul 2009 16:55, Wolfgang Denk pondered: > Dear Robin Getz, > > In message <200907171553.08108.rg...@blackfin.uclinux.org> you wrote: > > On 04 Oct 2008 Pieter posted a dns implementation for U-Boot. > > > > http://www.mail-archive.com/u-boot-us...@lists.sourceforge.net/msg10216.html > >

Re: [U-Boot] [PATCH] - add dns

2009-07-17 Thread Wolfgang Denk
Dear Robin Getz, In message <200907171553.08108.rg...@blackfin.uclinux.org> you wrote: > On 04 Oct 2008 Pieter posted a dns implementation for U-Boot. > > http://www.mail-archive.com/u-boot-us...@lists.sourceforge.net/msg10216.html > > > DNS can be enabled by setting CFG_CMD_DNS. After performin

[U-Boot] [PATCH] - add dns

2009-07-17 Thread Robin Getz
On 04 Oct 2008 Pieter posted a dns implementation for U-Boot. http://www.mail-archive.com/u-boot-us...@lists.sourceforge.net/msg10216.html > DNS can be enabled by setting CFG_CMD_DNS. After performing a query, the > serverip environment var is updated. > > Probably there are some cosmetic issues