Re: [U-Boot] [PATCH v3 1/3] AM335x : Add USB support for AM335x in u-boot

2012-07-04 Thread Ilya Yanok
Hi, On Sun, Jul 1, 2012 at 9:33 PM, Harman Sohanpal wrote: > > Thanks for your review. > But I believe you are talking of version 3 of the patches. > Kindly have a look at the version 4 I have sent. > Yes, my bad. I've seen your fourth version just after sending my comment. > I have used the s

Re: [U-Boot] [PATCH v3 1/3] AM335x : Add USB support for AM335x in u-boot

2012-07-01 Thread Harman Sohanpal
On Sat, Jun 30, 2012 at 9:38 PM, Ilya Yanok wrote: > Hi, > > Harman Sohanpal ti.com> writes: >> +/* Control Module Registers */ >> +#define CM_REGISTERS CTRL_BASE >> +#define USB_CTRL0_REG_OFFSET (0x628) >> +#define USB_CTRL1_REG_OFFSET (0x680) Hi llya, Thanks for your review. But

Re: [U-Boot] [PATCH v3 1/3] AM335x : Add USB support for AM335x in u-boot

2012-06-30 Thread Ilya Yanok
Hi, Harman Sohanpal ti.com> writes: > +/* Control Module Registers */ > +#define CM_REGISTERS CTRL_BASE > +#define USB_CTRL0_REG_OFFSET (0x628) > +#define USB_CTRL1_REG_OFFSET (0x680) USB_CTRL1 seems to be unused. Furthermore, both values seems to be incorrect: according to the R

Re: [U-Boot] [PATCH v3 1/3] AM335x : Add USB support for AM335x in u-boot

2012-06-29 Thread Sohanpal, Harman
> -Original Message- > From: Tom Rini [mailto:tom.r...@gmail.com] On Behalf Of Rini, Tom > Sent: Wednesday, June 27, 2012 10:50 PM > To: Sohanpal, Harman > Cc: u-boot@lists.denx.de; Gene Zarkhin > Subject: Re: [U-Boot] [PATCH v3 1/3] AM335x : Add USB support for

Re: [U-Boot] [PATCH v3 1/3] AM335x : Add USB support for AM335x in u-boot

2012-06-27 Thread Tom Rini
On Tue, Jun 26, 2012 at 03:08:01PM +0530, Harman Sohanpal wrote: > From: Gene Zarkhin > > Adds USB support in uboot for AM335x. > By default the USB 1 module is enabled. > The support for USB 0 can be enabled by changing the > USB base address and the phy control register address > in the header

[U-Boot] [PATCH v3 1/3] AM335x : Add USB support for AM335x in u-boot

2012-06-26 Thread Harman Sohanpal
From: Gene Zarkhin Adds USB support in uboot for AM335x. By default the USB 1 module is enabled. The support for USB 0 can be enabled by changing the USB base address and the phy control register address in the header file am335x.h. USB 1 has a full size connector so acts in host mode and USB 0 h