Hi, On Sun, Jul 1, 2012 at 9:33 PM, Harman Sohanpal <harmansohan...@gmail.com>wrote:
> > Thanks for your review. > But I believe you are talking of version 3 of the patches. > Kindly have a look at the version 4 I have sent. > Yes, my bad. I've seen your fourth version just after sending my comment. > I have used the same approach which Tom has mentioned > for control register offset also. > Yes, I've seen. I still think that it's a bit misguiding to conditionally define USB_CTRL0 but the general approach is ok. Other than that I think it's good to have boards.cfg entries for both options. And how much have you tested these patches? I tried them on my beaglebone and have issues both with host and device modes. In device mode I tried to use CDC ACM. My Linux host sees the device and /dev/ttyACM0 node shows up. I can put stdout in U-Boot to usbtty and this works nice too. But once I try to reassign stdin also I got my picocom hanged (only killable with kill -9). I host mode I tried with two flashdisks (512MB and 4GB) and card-reader (32MB SD and 8GB microSD cards). Only 512MB stick works as expected. With others I got: 1. 4GB flashdisk -- 0 device found, second "usb start" command seems to wedge the board 2. 8GB card -- scanning bus for storage devices... Device NOT ready Request Sense returned 00 00 00. Second "usb start" is lethal too. 3. 32MB card -- scanning bus for storage devices... READ_CAP ERROR Regards, Ilya.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
