Re: [PATCH v2 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-24 Thread Amit Tomar
Well, you tell me! At the moment I don't see much preventing people from > enabling it on the S900, and your compatible string listing in the > driver includes the S900 one. > I just checked, it's DMA descriptor structure that differs between two but I think This is not relevant here. Only thing

Re: [PATCH v2 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-23 Thread André Przywara
On 23/12/2020 12:29, Amit Tomar wrote: > Hi, > > Thanks again for the detailed review > > + > > >  3 files changed, 407 insertions(+) > >  create mode 100644 drivers/mmc/owl_mmc.c > > > > diff --git a/drivers/mmc/Kconfig b/drivers/m

Re: [PATCH v2 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-23 Thread Amit Tomar
Hi, Thanks again for the detailed review + > > 3 files changed, 407 insertions(+) > > create mode 100644 drivers/mmc/owl_mmc.c > > > > diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig > > index 14d7913..61f9c67 100644 > > --- a/drivers/mmc/

Re: [PATCH v2 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-23 Thread André Przywara
On 23/12/2020 04:25, Jaehoon Chung wrote: > On 12/23/20 11:22 AM, Amit Tomer wrote: >> On Wed, Dec 23, 2020 at 5:57 AM André Przywara >> wrote: >>> >>> On 19/12/2020 14:51, Amit Singh Tomar wrote: From: Amit Singh Tomar This commit adds support for MMC controllers found on Actions

RE: [PATCH v2 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-23 Thread Peng Fan
Thanks for Cc. > Subject: Re: [PATCH v2 5/6] mmc: actions: add MMC driver for Actions OWL > S700 > > Hi Amit, > > On 12/23/20 2:59 PM, Amit Tomar wrote: > > Hi Jaehoon > > > > I had already mentioned about making more readable than now. > > > >&

Re: [PATCH v2 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-22 Thread Jaehoon Chung
Hi Amit, On 12/23/20 2:59 PM, Amit Tomar wrote: > Hi Jaehoon > > I had already mentioned about making more readable than now. > >> >> if (rate <= 100) { >> rdelay = wdelay = OWL_SD_DELAY_LOW_CLK; >> } else if ( ...) { >> rdelay = wdelay = OWL_SD_DELAY_MID_CLK; >> } else if (.

Re: [PATCH v2 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-22 Thread Amit Tomar
Hi Jaehoon I had already mentioned about making more readable than now. > > if (rate <= 100) { > rdelay = wdelay = OWL_SD_DELAY_LOW_CLK; > } else if ( ...) { > rdelay = wdelay = OWL_SD_DELAY_MID_CLK; > } else if () { > rdelay = OWL_SD_RDELAY_HIGH; > wdelay

Re: [PATCH v2 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-22 Thread Jaehoon Chung
On 12/23/20 11:22 AM, Amit Tomer wrote: > On Wed, Dec 23, 2020 at 5:57 AM André Przywara wrote: >> >> On 19/12/2020 14:51, Amit Singh Tomar wrote: >>> From: Amit Singh Tomar >>> >>> This commit adds support for MMC controllers found on Actions OWL >>> S700 SoC platform. >>> >>> Signed-off-by: Ami

Re: [PATCH v2 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-22 Thread Amit Tomer
On Wed, Dec 23, 2020 at 5:57 AM André Przywara wrote: > > On 19/12/2020 14:51, Amit Singh Tomar wrote: > > From: Amit Singh Tomar > > > > This commit adds support for MMC controllers found on Actions OWL > > S700 SoC platform. > > > > Signed-off-by: Amit Singh Tomar > > --- > > Changes since pre

Re: [PATCH v2 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-22 Thread André Przywara
On 19/12/2020 14:51, Amit Singh Tomar wrote: > From: Amit Singh Tomar > > This commit adds support for MMC controllers found on Actions OWL > S700 SoC platform. > > Signed-off-by: Amit Singh Tomar > --- > Changes since previous version > * Corrected block count to 512. > * Changed t

Re: [PATCH v2 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-22 Thread André Przywara
On 22/12/2020 23:37, Jaehoon Chung wrote: > On 12/19/20 11:51 PM, Amit Singh Tomar wrote: >> From: Amit Singh Tomar >> >> This commit adds support for MMC controllers found on Actions OWL >> S700 SoC platform. >> >> Signed-off-by: Amit Singh Tomar >> --- >> Changes since previous version >>

Re: [PATCH v2 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-22 Thread Jaehoon Chung
On 12/19/20 11:51 PM, Amit Singh Tomar wrote: > From: Amit Singh Tomar > > This commit adds support for MMC controllers found on Actions OWL > S700 SoC platform. > > Signed-off-by: Amit Singh Tomar > --- > Changes since previous version > * Corrected block count to 512. > * Changed

[PATCH v2 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-19 Thread Amit Singh Tomar
From: Amit Singh Tomar This commit adds support for MMC controllers found on Actions OWL S700 SoC platform. Signed-off-by: Amit Singh Tomar --- Changes since previous version * Corrected block count to 512. * Changed the command timeout value to 30ms. * Used readl_poll_t