Re: [PATCH v2 4/4] net: add NFSv1 support

2023-06-25 Thread Tom Rini
On Sun, Jun 25, 2023 at 05:23:34PM +0200, Pali Rohár wrote: > On Saturday 24 June 2023 12:57:58 Tom Rini wrote: > > On Sat, Jun 24, 2023 at 11:08:59AM +0200, Pali Rohár wrote: > > > On Tuesday 13 June 2023 09:55:26 Peter Robinson wrote: > > > > > I can help with reviews in this area. In this case,

Re: [PATCH v2 4/4] net: add NFSv1 support

2023-06-25 Thread Pali Rohár
On Saturday 24 June 2023 12:57:58 Tom Rini wrote: > On Sat, Jun 24, 2023 at 11:08:59AM +0200, Pali Rohár wrote: > > On Tuesday 13 June 2023 09:55:26 Peter Robinson wrote: > > > > I can help with reviews in this area. In this case, please CC me. > > > > > > I suggest adding yourself to the MAINTAIN

Re: [PATCH v2 4/4] net: add NFSv1 support

2023-06-24 Thread Pali Rohár
On Sunday 11 June 2023 17:24:50 Christian Gmeiner wrote: > Am So., 11. Juni 2023 um 17:10 Uhr schrieb Pali Rohár : > > > > On Sunday 11 June 2023 16:57:07 Christian Gmeiner wrote: > > > Hello > > > > > > > > > > > Hello! I must admit that this patch is broken and does not add any NFSv1 > > > > supp

Re: [PATCH v2 4/4] net: add NFSv1 support

2023-06-24 Thread Pali Rohár
On Tuesday 13 June 2023 09:55:26 Peter Robinson wrote: > > I can help with reviews in this area. In this case, please CC me. > > I suggest adding yourself to the MAINTAINERS file as a reviewer, > people won't know you've offered and in a year Tom may not remember. Once people stop sending me unre

Re: [PATCH v2 4/4] net: add NFSv1 support

2023-06-24 Thread Tom Rini
On Sat, Jun 24, 2023 at 11:05:11AM +0200, Pali Rohár wrote: > On Sunday 11 June 2023 17:24:50 Christian Gmeiner wrote: > > Am So., 11. Juni 2023 um 17:10 Uhr schrieb Pali Rohár : > > > > > > On Sunday 11 June 2023 16:57:07 Christian Gmeiner wrote: > > > > Hello > > > > > > > > > > > > > > Hello! I

Re: [PATCH v2 4/4] net: add NFSv1 support

2023-06-24 Thread Tom Rini
On Sat, Jun 24, 2023 at 11:08:59AM +0200, Pali Rohár wrote: > On Tuesday 13 June 2023 09:55:26 Peter Robinson wrote: > > > I can help with reviews in this area. In this case, please CC me. > > > > I suggest adding yourself to the MAINTAINERS file as a reviewer, > > people won't know you've offered

Re: [PATCH v2 4/4] net: add NFSv1 support

2023-06-13 Thread Tom Rini
On Tue, Jun 13, 2023 at 12:24:44PM +0100, Peter Robinson wrote: > > > To clarify a fact: I am happy with the patch. I am unhappy with the > > > wrong "naming" that my old > > > employer used and influenced this patch. Also the company is shipping > > > thousands of devices per > > > year where thes

Re: [PATCH v2 4/4] net: add NFSv1 support

2023-06-13 Thread Christian Gmeiner
Am Di., 13. Juni 2023 um 13:24 Uhr schrieb Peter Robinson : > > > > To clarify a fact: I am happy with the patch. I am unhappy with the > > > wrong "naming" that my old > > > employer used and influenced this patch. Also the company is shipping > > > thousands of devices per > > > year where these

Re: [PATCH v2 4/4] net: add NFSv1 support

2023-06-13 Thread Peter Robinson
> > To clarify a fact: I am happy with the patch. I am unhappy with the > > wrong "naming" that my old > > employer used and influenced this patch. Also the company is shipping > > thousands of devices per > > year where these patches are used. > > Further clean-ups and clarifications to the suppor

Re: [PATCH v2 4/4] net: add NFSv1 support

2023-06-13 Thread Peter Robinson
> I can help with reviews in this area. In this case, please CC me. I suggest adding yourself to the MAINTAINERS file as a reviewer, people won't know you've offered and in a year Tom may not remember.

Re: [PATCH v2 4/4] net: add NFSv1 support

2023-06-12 Thread Pali Rohár
On Monday 12 June 2023 12:29:46 Tom Rini wrote: > On Sun, Jun 11, 2023 at 05:24:50PM +0200, Christian Gmeiner wrote: > > Am So., 11. Juni 2023 um 17:10 Uhr schrieb Pali Rohár : > > > > > > On Sunday 11 June 2023 16:57:07 Christian Gmeiner wrote: > > > > Hello > > > > > > > > > > > > > > Hello! I mu

Re: [PATCH v2 4/4] net: add NFSv1 support

2023-06-12 Thread Tom Rini
On Sun, Jun 11, 2023 at 05:24:50PM +0200, Christian Gmeiner wrote: > Am So., 11. Juni 2023 um 17:10 Uhr schrieb Pali Rohár : > > > > On Sunday 11 June 2023 16:57:07 Christian Gmeiner wrote: > > > Hello > > > > > > > > > > > Hello! I must admit that this patch is broken and does not add any NFSv1 >

Re: [PATCH v2 4/4] net: add NFSv1 support

2023-06-11 Thread Christian Gmeiner
Am So., 11. Juni 2023 um 17:10 Uhr schrieb Pali Rohár : > > On Sunday 11 June 2023 16:57:07 Christian Gmeiner wrote: > > Hello > > > > > > > > Hello! I must admit that this patch is broken and does not add any NFSv1 > > > support. Just look below > > > > > > > So .. let see what happend here. >

Re: [PATCH v2 4/4] net: add NFSv1 support

2023-06-11 Thread Pali Rohár
On Sunday 11 June 2023 16:57:07 Christian Gmeiner wrote: > Hello > > > > > Hello! I must admit that this patch is broken and does not add any NFSv1 > > support. Just look below > > > > So .. let see what happend here. > > > On Friday 10 March 2023 10:51:55 Christian Gmeiner wrote: > > > From

Re: [PATCH v2 4/4] net: add NFSv1 support

2023-06-11 Thread Christian Gmeiner
Am So., 11. Juni 2023 um 15:02 Uhr schrieb Peter Robinson : > > On Sun, Jun 11, 2023 at 1:54 PM Pali Rohár wrote: > > > > Hello! I must admit that this patch is broken and does not add any NFSv1 > > support. Just look below > > > > On Friday 10 March 2023 10:51:55 Christian Gmeiner wrote: > >

Re: [PATCH v2 4/4] net: add NFSv1 support

2023-06-11 Thread Christian Gmeiner
Hello > > Hello! I must admit that this patch is broken and does not add any NFSv1 > support. Just look below > So .. let see what happend here. > On Friday 10 March 2023 10:51:55 Christian Gmeiner wrote: > > From: Thomas RIENOESSL > > > > NFSv1 support added by Christian Gmeiner, Thomas Ri

Re: [PATCH v2 4/4] net: add NFSv1 support

2023-06-11 Thread Peter Robinson
On Sun, Jun 11, 2023 at 1:54 PM Pali Rohár wrote: > > Hello! I must admit that this patch is broken and does not add any NFSv1 > support. Just look below > > On Friday 10 March 2023 10:51:55 Christian Gmeiner wrote: > > From: Thomas RIENOESSL > > > > NFSv1 support added by Christian Gmeiner,

Re: [PATCH v2 4/4] net: add NFSv1 support

2023-06-11 Thread Pali Rohár
Hello! I must admit that this patch is broken and does not add any NFSv1 support. Just look below On Friday 10 March 2023 10:51:55 Christian Gmeiner wrote: > From: Thomas RIENOESSL > > NFSv1 support added by Christian Gmeiner, Thomas Rienoessl, > September 27, 2018. As of now, NFSv3 is the d

[PATCH v2 4/4] net: add NFSv1 support

2023-03-10 Thread Christian Gmeiner
From: Thomas RIENOESSL NFSv1 support added by Christian Gmeiner, Thomas Rienoessl, September 27, 2018. As of now, NFSv3 is the default choice. if the server does not support NFSv3, we fall back to versions 2 or 1. Signed-off-by: Thomas RIENOESSL --- net/nfs.c | 42 +