> > To clarify a fact: I am happy with the patch. I am unhappy with the > > wrong "naming" that my old > > employer used and influenced this patch. Also the company is shipping > > thousands of devices per > > year where these patches are used. > > Further clean-ups and clarifications to the support here in terms of > what it does and doesn't provide are good. But to the point on reviews, > yes, I do wish we had more people interested in various areas, and with > time to devote to reviewing code as well. Sadly, we don't always, and I > took this particular set of patches as being small enough of a global > impact while (hopefully!) making future contributions both in this area > and the related platforms using it more likely.
I understand your sentiment but even feedback for things like having it behind a Kconfig option to opt into, especially for a default on option, and CI weren't even addressed, it was just landed without additional revisions. I feel some of those negate the "just land it" sentiment. Peter
