Re: [REGRESSION] Re: [PATCH v2 16/24] clk: imx: Convert clock-osc-* back to osc_*

2025-04-18 Thread Adam Ford
On Thu, Apr 17, 2025 at 6:31 AM Marek Vasut wrote: > > On 4/17/25 12:51 PM, Adam Ford wrote: > > On Thu, Apr 17, 2025 at 2:24 AM Marek Vasut wrote: > >> > >> On 4/17/25 1:58 AM, Fabio Estevam wrote: > >>> On Wed, Apr 16, 2025 at 8:47 PM Marek Vasut wrote: > >>> > You are not supposed to use

Re: [REGRESSION] Re: [PATCH v2 16/24] clk: imx: Convert clock-osc-* back to osc_*

2025-04-18 Thread Marek Vasut
On 4/17/25 2:34 PM, Adam Ford wrote: On Thu, Apr 17, 2025 at 6:31 AM Marek Vasut wrote: On 4/17/25 12:51 PM, Adam Ford wrote: On Thu, Apr 17, 2025 at 2:24 AM Marek Vasut wrote: On 4/17/25 1:58 AM, Fabio Estevam wrote: On Wed, Apr 16, 2025 at 8:47 PM Marek Vasut wrote: You are not suppo

Re: [REGRESSION] Re: [PATCH v2 16/24] clk: imx: Convert clock-osc-* back to osc_*

2025-04-17 Thread Fabio Estevam
Hi Marek, On Thu, Apr 17, 2025 at 4:24 AM Marek Vasut wrote: > It would be good to include the patch inline in this email, not in a > link to some paste site which will go away. > > This also does not work in case 24 MHz or 32 kHz clock are provided by > something else than an xtal , and it will

Re: [REGRESSION] Re: [PATCH v2 16/24] clk: imx: Convert clock-osc-* back to osc_*

2025-04-17 Thread Marek Vasut
On 4/17/25 12:51 PM, Adam Ford wrote: On Thu, Apr 17, 2025 at 2:24 AM Marek Vasut wrote: On 4/17/25 1:58 AM, Fabio Estevam wrote: On Wed, Apr 16, 2025 at 8:47 PM Marek Vasut wrote: You are not supposed to use "clock-output-names" for clock look up. You are supposed to use "clocks"/"clock-n

Re: [REGRESSION] Re: [PATCH v2 16/24] clk: imx: Convert clock-osc-* back to osc_*

2025-04-17 Thread Adam Ford
On Thu, Apr 17, 2025 at 2:24 AM Marek Vasut wrote: > > On 4/17/25 1:58 AM, Fabio Estevam wrote: > > On Wed, Apr 16, 2025 at 8:47 PM Marek Vasut wrote: > > > >> You are not supposed to use "clock-output-names" for clock look up. > >> You are supposed to use "clocks"/"clock-names" DT properties and

Re: [REGRESSION] Re: [PATCH v2 16/24] clk: imx: Convert clock-osc-* back to osc_*

2025-04-17 Thread Marek Vasut
On 4/17/25 1:58 AM, Fabio Estevam wrote: On Wed, Apr 16, 2025 at 8:47 PM Marek Vasut wrote: You are not supposed to use "clock-output-names" for clock look up. You are supposed to use "clocks"/"clock-names" DT properties and then resolve the remote clock from information in those. What do yo

Re: [REGRESSION] Re: [PATCH v2 16/24] clk: imx: Convert clock-osc-* back to osc_*

2025-04-16 Thread Marek Vasut
On 4/17/25 1:35 AM, Adam Ford wrote: [...] if (!parent) @@ -113,6 +114,9 @@ int clk_mux_fetch_parent_index(struct clk *clk, struct clk *parent) for (i = 0; i < mux->num_parents; i++) { if (!strcmp(parent->dev->name, mux->parent_names[i]))

Re: [REGRESSION] Re: [PATCH v2 16/24] clk: imx: Convert clock-osc-* back to osc_*

2025-04-16 Thread Fabio Estevam
On Wed, Apr 16, 2025 at 8:58 PM Fabio Estevam wrote: > What do you think about registering the osc clocks like this? > > https://paste.debian.net/1369857/ With this patch, "ums 0 mmc 1" works on the imx8mp-evk.

Re: [REGRESSION] Re: [PATCH v2 16/24] clk: imx: Convert clock-osc-* back to osc_*

2025-04-16 Thread Fabio Estevam
On Wed, Apr 16, 2025 at 8:47 PM Marek Vasut wrote: > You are not supposed to use "clock-output-names" for clock look up. > You are supposed to use "clocks"/"clock-names" DT properties and then > resolve the remote clock from information in those. What do you think about registering the osc clock

Re: [REGRESSION] Re: [PATCH v2 16/24] clk: imx: Convert clock-osc-* back to osc_*

2025-04-16 Thread Adam Ford
On Wed, Apr 16, 2025 at 9:19 AM Christoph Niedermaier wrote: > > From: Francesco Dolcini > Sent: Wednesday, April 16, 2025 11:27 AM > > On Tue, Apr 15, 2025 at 02:13:30PM -0300, Fabio Estevam wrote: > >> On Tue, Apr 15, 2025 at 1:55 PM Marek Vasut wrote: > >>> Do you have af9cdd1ccd2d ("Revert "

Re: [REGRESSION] Re: [PATCH v2 16/24] clk: imx: Convert clock-osc-* back to osc_*

2025-04-16 Thread Adam Ford
On Wed, Apr 16, 2025 at 5:34 PM Adam Ford wrote: > > On Wed, Apr 16, 2025 at 9:19 AM Christoph Niedermaier > wrote: > > > > From: Francesco Dolcini > > Sent: Wednesday, April 16, 2025 11:27 AM > > > On Tue, Apr 15, 2025 at 02:13:30PM -0300, Fabio Estevam wrote: > > >> On Tue, Apr 15, 2025 at 1:5

RE: [REGRESSION] Re: [PATCH v2 16/24] clk: imx: Convert clock-osc-* back to osc_*

2025-04-16 Thread Christoph Niedermaier
From: Francesco Dolcini Sent: Wednesday, April 16, 2025 11:27 AM > On Tue, Apr 15, 2025 at 02:13:30PM -0300, Fabio Estevam wrote: >> On Tue, Apr 15, 2025 at 1:55 PM Marek Vasut wrote: >>> Do you have af9cdd1ccd2d ("Revert "arm64: dts: imx8mn: Include 32kHz >>> oscillator clock in SPL DTs"") in pl

Re: [REGRESSION] Re: [PATCH v2 16/24] clk: imx: Convert clock-osc-* back to osc_*

2025-04-16 Thread Francesco Dolcini
On Tue, Apr 15, 2025 at 02:13:30PM -0300, Fabio Estevam wrote: > On Tue, Apr 15, 2025 at 1:55 PM Marek Vasut wrote: > > Do you have af9cdd1ccd2d ("Revert "arm64: dts: imx8mn: Include 32kHz > > oscillator clock in SPL DTs"") in place ? If so, try and revert it, does > > it help ? > > It seems I ha

Re: [REGRESSION] Re: [PATCH v2 16/24] clk: imx: Convert clock-osc-* back to osc_*

2025-04-15 Thread Adam Ford
On Tue, Apr 15, 2025 at 12:13 PM Fabio Estevam wrote: > > On Tue, Apr 15, 2025 at 1:55 PM Marek Vasut wrote: > > > Do you have af9cdd1ccd2d ("Revert "arm64: dts: imx8mn: Include 32kHz > > oscillator clock in SPL DTs"") in place ? If so, try and revert it, does > > it help ? > > It seems I have no

Re: [REGRESSION] Re: [PATCH v2 16/24] clk: imx: Convert clock-osc-* back to osc_*

2025-04-15 Thread Fabio Estevam
On Tue, Apr 15, 2025 at 1:55 PM Marek Vasut wrote: > Do you have af9cdd1ccd2d ("Revert "arm64: dts: imx8mn: Include 32kHz > oscillator clock in SPL DTs"") in place ? If so, try and revert it, does > it help ? It seems I have not pushed the "Revert "arm64: dts: imx8mn: Include 32kHz oscillator cl

Re: [REGRESSION] Re: [PATCH v2 16/24] clk: imx: Convert clock-osc-* back to osc_*

2025-04-15 Thread Marek Vasut
On 4/15/25 5:03 PM, Francesco Dolcini wrote: On Tue, Apr 15, 2025 at 09:43:12AM -0500, Adam Ford wrote: On Tue, Apr 15, 2025 at 9:28 AM Francesco Dolcini wrote: Hello Marex, Fabio, all On Sun, Mar 23, 2025 at 04:58:45PM +0100, Marek Vasut wrote: Convert clock-osc-24m back to osc_24m and clo

[REGRESSION] Re: [PATCH v2 16/24] clk: imx: Convert clock-osc-* back to osc_*

2025-04-15 Thread Francesco Dolcini
Hello Marex, Fabio, all On Sun, Mar 23, 2025 at 04:58:45PM +0100, Marek Vasut wrote: > Convert clock-osc-24m back to osc_24m and clock-osc-32k back to osc_32k. > These are the clock which match clock tables in Linux. This is now > possible because the clock drivers now resolve clock names based on

Re: [REGRESSION] Re: [PATCH v2 16/24] clk: imx: Convert clock-osc-* back to osc_*

2025-04-15 Thread Francesco Dolcini
On Tue, Apr 15, 2025 at 09:43:12AM -0500, Adam Ford wrote: > On Tue, Apr 15, 2025 at 9:28 AM Francesco Dolcini > wrote: > > > > Hello Marex, Fabio, all > > > > On Sun, Mar 23, 2025 at 04:58:45PM +0100, Marek Vasut wrote: > > > Convert clock-osc-24m back to osc_24m and clock-osc-32k back to osc_32

Re: [REGRESSION] Re: [PATCH v2 16/24] clk: imx: Convert clock-osc-* back to osc_*

2025-04-15 Thread Adam Ford
On Tue, Apr 15, 2025 at 9:28 AM Francesco Dolcini wrote: > > Hello Marex, Fabio, all > > On Sun, Mar 23, 2025 at 04:58:45PM +0100, Marek Vasut wrote: > > Convert clock-osc-24m back to osc_24m and clock-osc-32k back to osc_32k. > > These are the clock which match clock tables in Linux. This is now

[PATCH v2 16/24] clk: imx: Convert clock-osc-* back to osc_*

2025-04-05 Thread Marek Vasut
Convert clock-osc-24m back to osc_24m and clock-osc-32k back to osc_32k. These are the clock which match clock tables in Linux. This is now possible because the clock drivers now resolve clock names based on clock-names DT property in the CCM DT node. Signed-off-by: Marek Vasut --- Cc: Adam Ford