Re: [PATCH v2 1/7] common: avb_verify: don't call mmc_switch_part for SD

2024-02-13 Thread Mattijs Korpershoek
Hi Igor, On mar., févr. 13, 2024 at 12:19, Igor Opaniuk wrote: > Hi Mattijs, > > On Tue, Feb 13, 2024 at 9:13 AM Mattijs Korpershoek > wrote: >> >> Hi Igor, >> >> On lun., févr. 12, 2024 at 09:05, Igor Opaniuk >> wrote: >> >> > Hi Dan, >> > >> > On Mon, Feb 12, 2024 at 8:05 AM Dan Carpenter

Re: [PATCH v2 1/7] common: avb_verify: don't call mmc_switch_part for SD

2024-02-13 Thread Igor Opaniuk
Hi Mattijs, On Tue, Feb 13, 2024 at 9:13 AM Mattijs Korpershoek wrote: > > Hi Igor, > > On lun., févr. 12, 2024 at 09:05, Igor Opaniuk wrote: > > > Hi Dan, > > > > On Mon, Feb 12, 2024 at 8:05 AM Dan Carpenter > > wrote: > >> > >> On Fri, Feb 09, 2024 at 08:20:39PM +0100, Igor Opaniuk wrote: >

Re: [PATCH v2 1/7] common: avb_verify: don't call mmc_switch_part for SD

2024-02-13 Thread Mattijs Korpershoek
Hi Igor, On lun., févr. 12, 2024 at 09:05, Igor Opaniuk wrote: > Hi Dan, > > On Mon, Feb 12, 2024 at 8:05 AM Dan Carpenter > wrote: >> >> On Fri, Feb 09, 2024 at 08:20:39PM +0100, Igor Opaniuk wrote: >> > From: Igor Opaniuk >> > >> > mmc_switch_part() is used for switching between hw partitio

Re: [PATCH v2 1/7] common: avb_verify: don't call mmc_switch_part for SD

2024-02-12 Thread Igor Opaniuk
Hi Dan, On Mon, Feb 12, 2024 at 8:05 AM Dan Carpenter wrote: > > On Fri, Feb 09, 2024 at 08:20:39PM +0100, Igor Opaniuk wrote: > > From: Igor Opaniuk > > > > mmc_switch_part() is used for switching between hw partitions > > on eMMC (boot0, boot1, user, rpmb). > > There is no need to do that for

Re: [PATCH v2 1/7] common: avb_verify: don't call mmc_switch_part for SD

2024-02-11 Thread Dan Carpenter
On Fri, Feb 09, 2024 at 08:20:39PM +0100, Igor Opaniuk wrote: > From: Igor Opaniuk > > mmc_switch_part() is used for switching between hw partitions > on eMMC (boot0, boot1, user, rpmb). > There is no need to do that for SD card. > Is this a clean up or a bugfix? What are the visible effects f

Re: [PATCH v2 1/7] common: avb_verify: don't call mmc_switch_part for SD

2024-02-09 Thread Dragan Simic
On 2024-02-09 20:20, Igor Opaniuk wrote: From: Igor Opaniuk mmc_switch_part() is used for switching between hw partitions on eMMC (boot0, boot1, user, rpmb). There is no need to do that for SD card. Reviewed-by: Mattijs Korpershoek Signed-off-by: Igor Opaniuk Looking good to me. Reviewed-

[PATCH v2 1/7] common: avb_verify: don't call mmc_switch_part for SD

2024-02-09 Thread Igor Opaniuk
From: Igor Opaniuk mmc_switch_part() is used for switching between hw partitions on eMMC (boot0, boot1, user, rpmb). There is no need to do that for SD card. Reviewed-by: Mattijs Korpershoek Signed-off-by: Igor Opaniuk --- Changes in v2: - Mattijs Korpershoek R-b tag applied common/avb_veri