Re: [PATCH v2 1/1] mtd: nand: raw: atmel: Add error handling when rb-gpios missing

2023-09-27 Thread Eugen Hristev
On 9/23/23 19:50, Michael Nazzareno Trimarchi wrote: On Fri, Sep 22, 2023 at 11:40 AM Eugen Hristev wrote: On 9/22/23 12:08, Alexander Dahl wrote: Adapt behaviour to Linux kernel driver. The return value of gpio_request_by_name_nodev() was not checked before, and thus in case 'rb-gpios' was

Re: [PATCH v2 1/1] mtd: nand: raw: atmel: Add error handling when rb-gpios missing

2023-09-23 Thread Michael Nazzareno Trimarchi
On Fri, Sep 22, 2023 at 11:40 AM Eugen Hristev wrote: > > On 9/22/23 12:08, Alexander Dahl wrote: > > Adapt behaviour to Linux kernel driver. > > > > The return value of gpio_request_by_name_nodev() was not checked before, > > and thus in case 'rb-gpios' was missing in DT, rb.type was set to > > A

Re: [PATCH v2 1/1] mtd: nand: raw: atmel: Add error handling when rb-gpios missing

2023-09-22 Thread Eugen Hristev
On 9/22/23 12:08, Alexander Dahl wrote: Adapt behaviour to Linux kernel driver. The return value of gpio_request_by_name_nodev() was not checked before, and thus in case 'rb-gpios' was missing in DT, rb.type was set to ATMEL_NAND_GPIO_RB nevertheless, leading to output like this for example (on

[PATCH v2 1/1] mtd: nand: raw: atmel: Add error handling when rb-gpios missing

2023-09-22 Thread Alexander Dahl
Adapt behaviour to Linux kernel driver. The return value of gpio_request_by_name_nodev() was not checked before, and thus in case 'rb-gpios' was missing in DT, rb.type was set to ATMEL_NAND_GPIO_RB nevertheless, leading to output like this for example (on sam9x60-curiosity with the line removed fr