Re: [PATCH v2 09/10] pci: Add driver for Broadcom STB PCIe controller

2020-05-12 Thread Jim Quinlan
On Tue, May 12, 2020 at 12:42 PM Sylwester Nawrocki wrote: > > Hi Jim, > > On 08.05.2020 16:25, Jim Quinlan wrote: > static int brcm_pcie_probe(struct udevice *dev) > +{ > + struct udevice *ctlr = pci_get_controller(dev); > + struct pci_controller *hose = dev_get_uc

Re: [PATCH v2 09/10] pci: Add driver for Broadcom STB PCIe controller

2020-05-12 Thread Sylwester Nawrocki
Hi Jim, On 08.05.2020 16:25, Jim Quinlan wrote: static int brcm_pcie_probe(struct udevice *dev) +{ + struct udevice *ctlr = pci_get_controller(dev); + struct pci_controller *hose = dev_get_uclass_priv(ctlr); + struct brcm_pcie *pcie = dev_get_priv(dev); >

Re: [PATCH v2 09/10] pci: Add driver for Broadcom STB PCIe controller

2020-05-08 Thread Simon Glass
Hi Jim, On Fri, 8 May 2020 at 08:25, Jim Quinlan wrote: > > On Fri, May 8, 2020 at 5:50 AM Nicolas Saenz Julienne > wrote: > > > > Hi, I'll try to add my two cents. > > > > On Wed, 2020-05-06 at 08:47 -0600, Simon Glass wrote: > > > > +config PCI_BRCMSTB > > > > + bool "Broadcom STB PCIe c

Re: [PATCH v2 09/10] pci: Add driver for Broadcom STB PCIe controller

2020-05-08 Thread Nicolas Saenz Julienne
Hi Jim, On Fri, 2020-05-08 at 10:25 -0400, Jim Quinlan wrote: > > > > +static int brcm_pcie_probe(struct udevice *dev) > > > > +{ > > > > + struct udevice *ctlr = pci_get_controller(dev); > > > > + struct pci_controller *hose = dev_get_uclass_priv(ctlr); > > > > + struct brcm_pci

Re: [PATCH v2 09/10] pci: Add driver for Broadcom STB PCIe controller

2020-05-08 Thread Jim Quinlan
On Fri, May 8, 2020 at 5:50 AM Nicolas Saenz Julienne wrote: > > Hi, I'll try to add my two cents. > > On Wed, 2020-05-06 at 08:47 -0600, Simon Glass wrote: > > > +config PCI_BRCMSTB > > > + bool "Broadcom STB PCIe controller" > > > + depends on DM_PCI > > > + depends on ARCH_BCM

Re: [PATCH v2 09/10] pci: Add driver for Broadcom STB PCIe controller

2020-05-08 Thread Simon Glass
Hi Sylwester, On Fri, 8 May 2020 at 05:46, Sylwester Nawrocki wrote: > > Hi Simon, > > On 06.05.2020 16:47, Simon Glass wrote: > > On Mon, 4 May 2020 at 06:45, Sylwester Nawrocki > > wrote: > > >> --- > >> drivers/pci/Kconfig| 6 + > >> drivers/pci/Makefile | 1 + > >> driver

Re: [PATCH v2 09/10] pci: Add driver for Broadcom STB PCIe controller

2020-05-08 Thread Sylwester Nawrocki
Hi Simon, On 06.05.2020 16:47, Simon Glass wrote: > On Mon, 4 May 2020 at 06:45, Sylwester Nawrocki > wrote: >> --- >> drivers/pci/Kconfig| 6 + >> drivers/pci/Makefile | 1 + >> drivers/pci/pcie_brcmstb.c | 594 >> + >> 3 files ch

Re: [PATCH v2 09/10] pci: Add driver for Broadcom STB PCIe controller

2020-05-08 Thread Nicolas Saenz Julienne
Hi, I'll try to add my two cents. On Wed, 2020-05-06 at 08:47 -0600, Simon Glass wrote: > > +config PCI_BRCMSTB > > + bool "Broadcom STB PCIe controller" > > + depends on DM_PCI > > + depends on ARCH_BCM283X > > + help > > + Say Y here if you want to enable Broadcom

Re: [PATCH v2 09/10] pci: Add driver for Broadcom STB PCIe controller

2020-05-06 Thread Simon Glass
Hi Sylwester, On Mon, 4 May 2020 at 06:45, Sylwester Nawrocki wrote: > > This patch adds basic driver for the Broadcom STB PCIe host controller. > The code is based on Linux upstream driver (pcie-brcmstb.c) with MSI > handling removed. The inbound access memory region is not currently > parsed fr

Re: [PATCH v2 09/10] pci: Add driver for Broadcom STB PCIe controller

2020-05-06 Thread Sylwester Nawrocki
Hi Nicolas, On 05.05.2020 17:45, Nicolas Saenz Julienne wrote: > If it's OK with you, as I'm already familiar with the driver from maintaining > it on the Linux kernel, I wouldn't mind doing it here too. > > Sylwester, if you're also interested I can send a patch adding both of us. Of course, I

Re: [PATCH v2 09/10] pci: Add driver for Broadcom STB PCIe controller

2020-05-06 Thread Sylwester Nawrocki
On 05.05.2020 16:13, Nicolas Saenz Julienne wrote: > On Mon, 2020-05-04 at 14:45 +0200, Sylwester Nawrocki wrote: >> This patch adds basic driver for the Broadcom STB PCIe host controller. >> The code is based on Linux upstream driver (pcie-brcmstb.c) with MSI >> handling removed. The inbound acces

Re: [PATCH v2 09/10] pci: Add driver for Broadcom STB PCIe controller

2020-05-05 Thread Nicolas Saenz Julienne
Hi All. On Mon, 2020-05-04 at 14:45 +0200, Sylwester Nawrocki wrote: > This patch adds basic driver for the Broadcom STB PCIe host controller. > The code is based on Linux upstream driver (pcie-brcmstb.c) with MSI > handling removed. The inbound access memory region is not currently > parsed from

Re: [PATCH v2 09/10] pci: Add driver for Broadcom STB PCIe controller

2020-05-05 Thread Nicolas Saenz Julienne
On Mon, 2020-05-04 at 14:45 +0200, Sylwester Nawrocki wrote: > This patch adds basic driver for the Broadcom STB PCIe host controller. > The code is based on Linux upstream driver (pcie-brcmstb.c) with MSI > handling removed. The inbound access memory region is not currently > parsed from dma-range

[PATCH v2 09/10] pci: Add driver for Broadcom STB PCIe controller

2020-05-04 Thread Sylwester Nawrocki
This patch adds basic driver for the Broadcom STB PCIe host controller. The code is based on Linux upstream driver (pcie-brcmstb.c) with MSI handling removed. The inbound access memory region is not currently parsed from dma-ranges DT property and a fixed 4GB region is used. The patch has been tes