Re:Re: [PATCH v2 06/11] video: rockchip: Add VOP2 support

2025-03-03 Thread Andy Yan
Hi Danq, At 2025-03-02 12:09:34, "Dang Huynh" wrote: >Hi Chaoyi Chen, > >On Thursday, February 27, 2025 6:29:13 AM UTC Chaoyi Chen wrote: >> >> Could you use a naming prefix like "rkvop2" to explicitly indicate the >> use of vop2, thereby distinguishing it from rk_vop.c? >> >Yes. This will be

Re: [PATCH v2 06/11] video: rockchip: Add VOP2 support

2025-03-03 Thread Dang Huynh
Hi Chaoyi Chen, On Monday, March 3, 2025 9:48:14 AM UTC Chaoyi Chen wrote: > Hi Dang, > > On 2025/3/2 12:09, Dang Huynh wrote: > >>> + struct rk3568_vop_esmart *esmart = priv->regs + > > > > VOP2_ESMART_OFFSET(0); > > > >> You are assuming that the RK356X is always used ESMART0, which generally

Re: [PATCH v2 06/11] video: rockchip: Add VOP2 support

2025-03-03 Thread Chaoyi Chen
Hi Dang, On 2025/3/2 12:09, Dang Huynh wrote: Hi Chaoyi Chen, On Thursday, February 27, 2025 6:29:13 AM UTC Chaoyi Chen wrote: Could you use a naming prefix like "rkvop2" to explicitly indicate the use of vop2, thereby distinguishing it from rk_vop.c? Yes. This will be in v3. Thank you!

Re: [PATCH v2 06/11] video: rockchip: Add VOP2 support

2025-03-01 Thread Dang Huynh
Hi Chaoyi Chen, On Thursday, February 27, 2025 6:29:13 AM UTC Chaoyi Chen wrote: > > Could you use a naming prefix like "rkvop2" to explicitly indicate the > use of vop2, thereby distinguishing it from rk_vop.c? > Yes. This will be in v3. > > + struct rk3568_vop_esmart *esmart = priv->regs +

Re: [PATCH v2 06/11] video: rockchip: Add VOP2 support

2025-02-27 Thread Chaoyi Chen
Hi Dang, On 2025/2/23 20:13, Dang Huynh wrote: VOP2 (Video Output Processor v2) is a display controller on Rockchip SoCs. It can be found on RK3566/8 and RK3588. This commit currently only supports RK3566/8. Signed-off-by: Dang Huynh --- arch/arm/include/asm/arch-rockchip/vop_rk3568.h | 249

[PATCH v2 06/11] video: rockchip: Add VOP2 support

2025-02-23 Thread Dang Huynh
VOP2 (Video Output Processor v2) is a display controller on Rockchip SoCs. It can be found on RK3566/8 and RK3588. This commit currently only supports RK3566/8. Signed-off-by: Dang Huynh --- arch/arm/include/asm/arch-rockchip/vop_rk3568.h | 249 + drivers/video/rockchip/Makefile