Re: [PATCH v2 01/10] spi: dw: Convert calls to debug to log_*

2020-08-20 Thread Marek Vasut
On 8/21/20 2:08 AM, Tom Rini wrote: > On Thu, Aug 20, 2020 at 03:36:31PM +0200, Marek Vasut wrote: >> On 8/20/20 3:26 PM, Simon Glass wrote: >>> On Fri, 7 Aug 2020 at 08:43, Sean Anderson wrote: This allows different log levels to be enabled or disabled depending on the desired leve

Re: [PATCH v2 01/10] spi: dw: Convert calls to debug to log_*

2020-08-20 Thread Tom Rini
On Thu, Aug 20, 2020 at 03:36:31PM +0200, Marek Vasut wrote: > On 8/20/20 3:26 PM, Simon Glass wrote: > > On Fri, 7 Aug 2020 at 08:43, Sean Anderson wrote: > >> > >> This allows different log levels to be enabled or disabled depending on the > >> desired level of verbosity. In particular, it allow

Re: [PATCH v2 01/10] spi: dw: Convert calls to debug to log_*

2020-08-20 Thread Marek Vasut
On 8/20/20 3:26 PM, Simon Glass wrote: > On Fri, 7 Aug 2020 at 08:43, Sean Anderson wrote: >> >> This allows different log levels to be enabled or disabled depending on the >> desired level of verbosity. In particular, it allows for general debug >> information to be printed while excluding more v

Re: [PATCH v2 01/10] spi: dw: Convert calls to debug to log_*

2020-08-20 Thread Simon Glass
On Fri, 7 Aug 2020 at 08:43, Sean Anderson wrote: > > This allows different log levels to be enabled or disabled depending on the > desired level of verbosity. In particular, it allows for general debug > information to be printed while excluding more verbose logging which may > interfere with tim

Re: [PATCH v2 01/10] spi: dw: Convert calls to debug to log_*

2020-08-08 Thread Heinrich Schuchardt
On 8/8/20 1:07 PM, Sean Anderson wrote: > On 8/8/20 1:14 AM, Heinrich Schuchardt wrote: >> On 8/7/20 4:43 PM, Sean Anderson wrote: >>> This allows different log levels to be enabled or disabled depending on the >>> desired level of verbosity. In particular, it allows for general debug >>> informati

Re: [PATCH v2 01/10] spi: dw: Convert calls to debug to log_*

2020-08-08 Thread Sean Anderson
On 8/8/20 1:14 AM, Heinrich Schuchardt wrote: > On 8/7/20 4:43 PM, Sean Anderson wrote: >> This allows different log levels to be enabled or disabled depending on the >> desired level of verbosity. In particular, it allows for general debug >> information to be printed while excluding more verbose

Re: [PATCH v2 01/10] spi: dw: Convert calls to debug to log_*

2020-08-07 Thread Heinrich Schuchardt
On 8/7/20 4:43 PM, Sean Anderson wrote: > This allows different log levels to be enabled or disabled depending on the > desired level of verbosity. In particular, it allows for general debug > information to be printed while excluding more verbose logging which may > interfere with timing. > > Sign

Re: [PATCH v2 01/10] spi: dw: Convert calls to debug to log_*

2020-08-07 Thread Sean Anderson
On 8/7/20 10:49 AM, Marek Vasut wrote: > On 8/7/20 4:43 PM, Sean Anderson wrote: > [...] >> +#define LOG_CATEGORY UCLASS_SPI >> #include >> #include >> #include >> @@ -139,7 +140,7 @@ static int request_gpio_cs(struct udevice *bus) >> return 0; >> >> if (ret < 0) { >> -

Re: [PATCH v2 01/10] spi: dw: Convert calls to debug to log_*

2020-08-07 Thread Marek Vasut
On 8/7/20 4:43 PM, Sean Anderson wrote: [...] > +#define LOG_CATEGORY UCLASS_SPI > #include > #include > #include > @@ -139,7 +140,7 @@ static int request_gpio_cs(struct udevice *bus) > return 0; > > if (ret < 0) { > - printf("Error: %d: Can't get %s gpio!\n"

[PATCH v2 01/10] spi: dw: Convert calls to debug to log_*

2020-08-07 Thread Sean Anderson
This allows different log levels to be enabled or disabled depending on the desired level of verbosity. In particular, it allows for general debug information to be printed while excluding more verbose logging which may interfere with timing. Signed-off-by: Sean Anderson --- Changes in v2: - New