On 8/7/20 10:49 AM, Marek Vasut wrote: > On 8/7/20 4:43 PM, Sean Anderson wrote: > [...] >> +#define LOG_CATEGORY UCLASS_SPI >> #include <common.h> >> #include <log.h> >> #include <asm-generic/gpio.h> >> @@ -139,7 +140,7 @@ static int request_gpio_cs(struct udevice *bus) >> return 0; >> >> if (ret < 0) { >> - printf("Error: %d: Can't get %s gpio!\n", ret, bus->name); >> + log_err("Error: %d: Can't get %s gpio!\n", ret, bus->name); > > Can't we use dev_info() / pr_info() , same as the linux kernel does ? >
We can. It doesn't matter much to me. Simon, does U-Boot prefer a particular log style for new code? --Sean