Re: [PATCH v2 0/4] USB-PD TCPM improvements

2025-03-27 Thread Nicolas Frattaroli
On Wednesday, 26 February 2025 19:44:43 Central European Standard Time Sebastian Reichel wrote: > Hi, > > I have a couple of fixes/improvements for the TCPM code. Three are fixing > actual problems I noticed on the Rock 5B, which prevented booting up the > system. One of them simply adds an error

Re: [PATCH v2 0/4] USB-PD TCPM improvements

2025-03-07 Thread Soeren Moch
On 06.03.25 20:00, Anand Moon wrote: Apologies, I had not applied the whole series of patches Please add my Reviewed-by: Anand Moon Tested-by: Anand Moon After applying enabling debug I am convinced this works on my Rock Pi 5b Board. U-Boot 2025.04-rc3-00057-g671ac2d744b2 (Mar 06 2025 - 23:

Re: [PATCH v2 0/4] USB-PD TCPM improvements

2025-03-06 Thread Anand Moon
Hi Sebastian, On Tue, 4 Mar 2025 at 20:20, Anand Moon wrote: > > Hi Sebastian, > > On Tue, 4 Mar 2025 at 18:12, Sebastian Reichel > wrote: > > > > Hi, > > > > On Tue, Mar 04, 2025 at 10:35:03AM +0530, Anand Moon wrote: > > > However, I have a question regarding the Type-C controller's > > > conn

Re: [PATCH v2 0/4] USB-PD TCPM improvements

2025-03-04 Thread Anand Moon
Hi Sebastian, On Tue, 4 Mar 2025 at 18:12, Sebastian Reichel wrote: > > Hi, > > On Tue, Mar 04, 2025 at 10:35:03AM +0530, Anand Moon wrote: > > However, I have a question regarding the Type-C controller's > > connection to the PMIC via I2C. I didn't see a corresponding > > controller node in the

Re: [PATCH v2 0/4] USB-PD TCPM improvements

2025-03-04 Thread Sebastian Reichel
Hi, On Tue, Mar 04, 2025 at 10:35:03AM +0530, Anand Moon wrote: > However, I have a question regarding the Type-C controller's > connection to the PMIC via I2C. I didn't see a corresponding > controller node in the device tree source (dts) file that would > support this function. > > I feel this

Re: [PATCH v2 0/4] USB-PD TCPM improvements

2025-03-03 Thread Anand Moon
Hi Sebastian, On Mon, 3 Mar 2025 at 21:36, Sebastian Reichel wrote: > > Hi Anand, > > On Mon, Mar 03, 2025 at 01:08:24PM +0530, Anand Moon wrote: > > On Sat, 1 Mar 2025 at 23:41, Peter Robinson wrote: > > > On Thu, 27 Feb 2025 at 06:01, Anand Moon wrote: > > >> On Thu, 27 Feb 2025 at 00:15, Seb

Re: [PATCH v2 0/4] USB-PD TCPM improvements

2025-03-03 Thread Sebastian Reichel
Hi Anand, On Mon, Mar 03, 2025 at 01:08:24PM +0530, Anand Moon wrote: > On Sat, 1 Mar 2025 at 23:41, Peter Robinson wrote: > > On Thu, 27 Feb 2025 at 06:01, Anand Moon wrote: > >> On Thu, 27 Feb 2025 at 00:15, Sebastian Reichel > >> wrote: > >> > > >> > Hi, > >> > > >> > I have a couple of fixe

Re: [PATCH v2 0/4] USB-PD TCPM improvements

2025-03-02 Thread Anand Moon
Hi Peter / Sebastian, On Sat, 1 Mar 2025 at 23:41, Peter Robinson wrote: > > > > On Thu, 27 Feb 2025 at 06:01, Anand Moon wrote: >> >> Hi Sebastian, >> >> On Thu, 27 Feb 2025 at 00:15, Sebastian Reichel >> wrote: >> > >> > Hi, >> > >> > I have a couple of fixes/improvements for the TCPM code. T

Re: [PATCH v2 0/4] USB-PD TCPM improvements

2025-03-01 Thread Peter Robinson
On Thu, 27 Feb 2025 at 06:01, Anand Moon wrote: > Hi Sebastian, > > On Thu, 27 Feb 2025 at 00:15, Sebastian Reichel > wrote: > > > > Hi, > > > > I have a couple of fixes/improvements for the TCPM code. Three are fixing > > actual problems I noticed on the Rock 5B, which prevented booting up the

Re: [PATCH v2 0/4] USB-PD TCPM improvements

2025-02-26 Thread Anand Moon
Hi Sebastian, On Thu, 27 Feb 2025 at 00:15, Sebastian Reichel wrote: > > Hi, > > I have a couple of fixes/improvements for the TCPM code. Three are fixing > actual problems I noticed on the Rock 5B, which prevented booting up the > system. One of them simply adds an error print before potentially

[PATCH v2 0/4] USB-PD TCPM improvements

2025-02-26 Thread Sebastian Reichel
Hi, I have a couple of fixes/improvements for the TCPM code. Three are fixing actual problems I noticed on the Rock 5B, which prevented booting up the system. One of them simply adds an error print before potentially committing hara-kiri by triggering a hard reset, which helps people understanding