Hi Sebastian, On Tue, 4 Mar 2025 at 20:20, Anand Moon <linux.am...@gmail.com> wrote: > > Hi Sebastian, > > On Tue, 4 Mar 2025 at 18:12, Sebastian Reichel > <sebastian.reic...@collabora.com> wrote: > > > > Hi, > > > > On Tue, Mar 04, 2025 at 10:35:03AM +0530, Anand Moon wrote: > > > However, I have a question regarding the Type-C controller's > > > connection to the PMIC via I2C. I didn't see a corresponding > > > controller node in the device tree source (dts) file that would > > > support this function. > > > > > > I feel this might be causing issues in maintaining the power state? > > > > > > [1] > > > https://github.com/u-boot/u-boot/blob/master/drivers/usb/tcpm/fusb302.c#L1285-L1316 > > > > There is no direct connection between the PMIC and the fusb302. Not > > in the driver, not in DT and not on the hardware. The > > fusb302_get_connector_node() > > function you are referencing is for the USB-C connector devicetree node. > > You can find it here: > > > > https://github.com/u-boot/u-boot/blob/master/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi#L35 > > > Thanks, I completely missed this part. sorry for the noise. > I was checking the upstream dts dir.
Apologies, I had not applied the whole series of patches Please add my Reviewed-by: Anand Moon <linux.am...@gmail.com> Tested-by: Anand Moon <linux.am...@gmail.com> After applying enabling debug I am convinced this works on my Rock Pi 5b Board. U-Boot 2025.04-rc3-00057-g671ac2d744b2 (Mar 06 2025 - 23:51:44 +0530) Model: Radxa ROCK 5B SoC: RK3588 DRAM: 8 GiB fusb302 usb-typec@22: probing Type-C port manager...fusb302 usb-typec@22: fusb302 device ID: 0x91 fusb302 usb-typec@22: TCPM: set voltage limit = 0 mV fusb302 usb-typec@22: TCPM: set current limit = 0 mA fusb302 usb-typec@22: fusb302 start drp toggling fusb302 usb-typec@22: TCPM: init finished fusb302 usb-typec@22: TCPM: CC connected in CC2 as UFP fusb302 usb-typec@22: TCPM: set voltage limit = 5000 mV fusb302 usb-typec@22: TCPM: set current limit = 3000 mA fusb302 usb-typec@22: CC activities detected, delay handling fusb302 usb-typec@22: CC activities detected, delay handling fusb302 usb-typec@22: Initiating hard-reset, which might result in machine power-loss. fusb302 usb-typec@22: TCPM: PD transmit data failed: -110 fusb302 usb-typec@22: TCPM: set voltage limit = 5000 mV fusb302 usb-typec@22: TCPM: set current limit = 3000 mA fusb302 usb-typec@22: CC activities detected, delay handling fusb302 usb-typec@22: CC activities detected, delay handling fusb302 usb-typec@22: TCPM: PD chip enter low power mode Core: 362 devices, 34 uclasses, devicetree: separate MMC: mmc@fe2c0000: 1, mmc@fe2d0000: 2, mmc@fe2e0000: 0 Thanks -Anand
