Re: [PATCH v2][ 3/3] board: tbs2910: Add support for generic distro configuration

2020-01-30 Thread Soeren Moch
On 28.01.20 22:27, Denis 'GNUtoo' Carikli wrote: > On Tue, 28 Jan 2020 18:51:26 +0100 > Soeren Moch wrote: > >> As already discussed, the bootm_size environment variable is not >> necessary, otherwise  somewhat dangerous with this value. > Sorry, for the mistake, I've fixed it now. > > I'll send a

Re: [PATCH v2][ 3/3] board: tbs2910: Add support for generic distro configuration

2020-01-29 Thread Soeren Moch
On 28.01.20 22:27, Denis 'GNUtoo' Carikli wrote: > On Tue, 28 Jan 2020 18:51:26 +0100 > Soeren Moch wrote: > >> As already discussed, the bootm_size environment variable is not >> necessary, otherwise  somewhat dangerous with this value. > Sorry, for the mistake, I've fixed it now. > > I'll send a

Re: [PATCH v2][ 3/3] board: tbs2910: Add support for generic distro configuration

2020-01-28 Thread Denis 'GNUtoo' Carikli
On Tue, 28 Jan 2020 18:51:26 +0100 Soeren Moch wrote: > As already discussed, the bootm_size environment variable is not > necessary, otherwise  somewhat dangerous with this value. Sorry, for the mistake, I've fixed it now. I'll send a v3 after some feedback from my response to your other points

Re: [PATCH v2][ 3/3] board: tbs2910: Add support for generic distro configuration

2020-01-28 Thread Denis 'GNUtoo' Carikli
On Tue, 28 Jan 2020 18:51:26 +0100 Soeren Moch wrote: > There are a lot of unrelated/unexplained changes in tbs2910_defconfig. > This probably should not be part of this patch. I changed only 2 things here: - I added CONFIG_DISTRO_DEFAULTS=y - I added CONFIG_DEFAULT_FDT_FILE="imx6q-tbs2910.dtb"

Re: [PATCH v2][ 3/3] board: tbs2910: Add support for generic distro configuration

2020-01-28 Thread Soeren Moch
On 28.01.20 18:04, Denis 'GNUtoo' Carikli wrote: > This keeps the compatibility with the old bootcmd. > > The fdtfile environment variable also needed to be set to > imx6q-tbs2910.dtb to enable booting mainline kernels > otherwise with extlinux.conf it tries to load > mx6-tbs2910.dtb instead. >

[PATCH v2][ 3/3] board: tbs2910: Add support for generic distro configuration

2020-01-28 Thread Denis 'GNUtoo' Carikli
This keeps the compatibility with the old bootcmd. The fdtfile environment variable also needed to be set to imx6q-tbs2910.dtb to enable booting mainline kernels otherwise with extlinux.conf it tries to load mx6-tbs2910.dtb instead. Signed-off-by: Denis 'GNUtoo' Carikli --- configs/tbs2910_defc