Re: [PATCH v1 1/2] cmd: bind: Fix driver binding on a device

2021-04-16 Thread Patrice CHOTARD
Hi Simon On 4/14/21 9:38 PM, Simon Glass wrote: > On Fri, 9 Apr 2021 at 08:36, Patrice Chotard > wrote: >> >> Fix a regression brings by commit 84f8e36f03fa ("cmd: bind: allow to >> bind driver with driver data") >> >> As example, the following bind command doesn't work: >> >>bind /soc/usb-ot

Re: [PATCH v1 1/2] cmd: bind: Fix driver binding on a device

2021-04-14 Thread Simon Glass
On Fri, 9 Apr 2021 at 08:36, Patrice Chotard wrote: > > Fix a regression brings by commit 84f8e36f03fa ("cmd: bind: allow to > bind driver with driver data") > > As example, the following bind command doesn't work: > >bind /soc/usb-otg@4900 usb_ether > > As usb_ether driver has no compatib

Re: [PATCH v1 1/2] cmd: bind: Fix driver binding on a device

2021-04-09 Thread Patrice CHOTARD
On 4/9/21 3:41 PM, Andy Shevchenko wrote: > On Fri, Apr 09, 2021 at 09:13:12AM -0400, Sean Anderson wrote: >> On 4/9/21 8:05 AM, Patrice CHOTARD wrote: >>> On 4/9/21 1:01 PM, Andy Shevchenko wrote: On Fri, Apr 9, 2021 at 1:32 PM Patrice CHOTARD wrote: > On 4/9/21 11:48 AM, Andy Sh

Re: [PATCH v1 1/2] cmd: bind: Fix driver binding on a device

2021-04-09 Thread Andy Shevchenko
On Fri, Apr 09, 2021 at 09:13:12AM -0400, Sean Anderson wrote: > On 4/9/21 8:05 AM, Patrice CHOTARD wrote: > > On 4/9/21 1:01 PM, Andy Shevchenko wrote: > > > On Fri, Apr 9, 2021 at 1:32 PM Patrice CHOTARD > > > wrote: > > > > On 4/9/21 11:48 AM, Andy Shevchenko wrote: > > > > > On Fri, Apr 9, 202

Re: [PATCH v1 1/2] cmd: bind: Fix driver binding on a device

2021-04-09 Thread Sean Anderson
On 4/9/21 8:05 AM, Patrice CHOTARD wrote: On 4/9/21 1:01 PM, Andy Shevchenko wrote: On Fri, Apr 9, 2021 at 1:32 PM Patrice CHOTARD wrote: On 4/9/21 11:48 AM, Andy Shevchenko wrote: On Fri, Apr 9, 2021 at 12:28 PM Patrice CHOTARD wrote: On 4/9/21 11:16 AM, Andy Shevchenko wrote: On Fri, A

Re: [PATCH v1 1/2] cmd: bind: Fix driver binding on a device

2021-04-09 Thread Patrice CHOTARD
On 4/9/21 1:01 PM, Andy Shevchenko wrote: > On Fri, Apr 9, 2021 at 1:32 PM Patrice CHOTARD > wrote: >> On 4/9/21 11:48 AM, Andy Shevchenko wrote: >>> On Fri, Apr 9, 2021 at 12:28 PM Patrice CHOTARD >>> wrote: On 4/9/21 11:16 AM, Andy Shevchenko wrote: > On Fri, Apr 9, 2021 at 10:37 AM

Re: [PATCH v1 1/2] cmd: bind: Fix driver binding on a device

2021-04-09 Thread Andy Shevchenko
On Fri, Apr 9, 2021 at 1:32 PM Patrice CHOTARD wrote: > On 4/9/21 11:48 AM, Andy Shevchenko wrote: > > On Fri, Apr 9, 2021 at 12:28 PM Patrice CHOTARD > > wrote: > >> On 4/9/21 11:16 AM, Andy Shevchenko wrote: > >>> On Fri, Apr 9, 2021 at 10:37 AM Patrice Chotard > >>> wrote: ... > +

Re: [PATCH v1 1/2] cmd: bind: Fix driver binding on a device

2021-04-09 Thread Patrice CHOTARD
On 4/9/21 11:48 AM, Andy Shevchenko wrote: > On Fri, Apr 9, 2021 at 12:28 PM Patrice CHOTARD > wrote: >> On 4/9/21 11:16 AM, Andy Shevchenko wrote: >>> On Fri, Apr 9, 2021 at 10:37 AM Patrice Chotard >>> wrote: > > ... > + if (drv) { +

Re: [PATCH v1 1/2] cmd: bind: Fix driver binding on a device

2021-04-09 Thread Andy Shevchenko
On Fri, Apr 9, 2021 at 12:28 PM Patrice CHOTARD wrote: > On 4/9/21 11:16 AM, Andy Shevchenko wrote: > > On Fri, Apr 9, 2021 at 10:37 AM Patrice Chotard > > wrote: ... > >> + if (drv) { > >> + if (drv == entry) > >> +

Re: [PATCH v1 1/2] cmd: bind: Fix driver binding on a device

2021-04-09 Thread Patrice CHOTARD
Hi Andy On 4/9/21 11:16 AM, Andy Shevchenko wrote: > On Fri, Apr 9, 2021 at 10:37 AM Patrice Chotard > wrote: >> >> Fix a regression brings by commit 84f8e36f03fa ("cmd: bind: allow to >> bind driver with driver data") >> >> As example, the following bind command doesn't work: >> >>bind /soc/

Re: [PATCH v1 1/2] cmd: bind: Fix driver binding on a device

2021-04-09 Thread Andy Shevchenko
On Fri, Apr 9, 2021 at 10:37 AM Patrice Chotard wrote: > > Fix a regression brings by commit 84f8e36f03fa ("cmd: bind: allow to > bind driver with driver data") > > As example, the following bind command doesn't work: > >bind /soc/usb-otg@4900 usb_ether > > As usb_ether driver has no compa

[PATCH v1 1/2] cmd: bind: Fix driver binding on a device

2021-04-09 Thread Patrice Chotard
Fix a regression brings by commit 84f8e36f03fa ("cmd: bind: allow to bind driver with driver data") As example, the following bind command doesn't work: bind /soc/usb-otg@4900 usb_ether As usb_ether driver has no compatible string, it can't be find by lists_bind_fdt(). In bind_by_node_pat