Re: [PATCH 5/5] ds414: Add sample u-boot update command

2021-03-04 Thread Phil Sutter
On Thu, Mar 04, 2021 at 02:34:53PM +0100, Stefan Roese wrote: > On 04.03.21 14:28, Phil Sutter wrote: > > On Thu, Mar 04, 2021 at 02:09:34PM +0100, Stefan Roese wrote: > >> On 03.03.21 01:55, Phil Sutter wrote: > >>> Signed-off-by: Phil Sutter > >> > >> It's common practice to add some minimal tex

Re: [PATCH 5/5] ds414: Add sample u-boot update command

2021-03-04 Thread Stefan Roese
On 04.03.21 14:28, Phil Sutter wrote: On Thu, Mar 04, 2021 at 02:09:34PM +0100, Stefan Roese wrote: On 03.03.21 01:55, Phil Sutter wrote: Signed-off-by: Phil Sutter It's common practice to add some minimal text in the commit text, even for simple patches. I should learn to put less meaning

Re: [PATCH 5/5] ds414: Add sample u-boot update command

2021-03-04 Thread Phil Sutter
On Thu, Mar 04, 2021 at 02:09:34PM +0100, Stefan Roese wrote: > On 03.03.21 01:55, Phil Sutter wrote: > > Signed-off-by: Phil Sutter > > It's common practice to add some minimal text in the commit text, > even for simple patches. I should learn to put less meaningful subjects in those cases so I

Re: [PATCH 5/5] ds414: Add sample u-boot update command

2021-03-04 Thread Stefan Roese
On 03.03.21 01:55, Phil Sutter wrote: Signed-off-by: Phil Sutter It's common practice to add some minimal text in the commit text, even for simple patches. One short question below... --- include/configs/ds414.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/in

[PATCH 5/5] ds414: Add sample u-boot update command

2021-03-02 Thread Phil Sutter
Signed-off-by: Phil Sutter --- include/configs/ds414.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/include/configs/ds414.h b/include/configs/ds414.h index a2248cf75ad72..c8b45066cc75a 100644 --- a/include/configs/ds414.h +++ b/include/configs/ds414.h @@ -88,7 +88,12