Re: [PATCH 4/5] sandbox: Audit config.h and common.h usage

2023-12-02 Thread Simon Glass
Hi Tom, On Sat, 18 Nov 2023 at 11:04, Tom Rini wrote: > > Splitting this in to two different threads.. > > On Sat, Nov 18, 2023 at 10:58:50AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Sat, 18 Nov 2023 at 10:45, Tom Rini wrote: > > > > > > On Sat, Nov 18, 2023 at 10:09:55AM -0700, Simon Gl

Re: [PATCH 4/5] sandbox: Audit config.h and common.h usage

2023-12-02 Thread Simon Glass
Hi Tom, On Sat, 18 Nov 2023 at 11:44, Tom Rini wrote: > > On Sat, Nov 18, 2023 at 10:58:50AM -0700, Simon Glass wrote: > > [snip] > > I found these: > > > > https://patchwork.ozlabs.org/project/uboot/list/?series=262148&state=* > > http://patchwork.ozlabs.org/project/uboot/patch/20210925121958.26

Re: [PATCH 4/5] sandbox: Audit config.h and common.h usage

2023-11-18 Thread Tom Rini
On Sat, Nov 18, 2023 at 10:58:50AM -0700, Simon Glass wrote: [snip] > I found these: > > https://patchwork.ozlabs.org/project/uboot/list/?series=262148&state=* > http://patchwork.ozlabs.org/project/uboot/patch/20210925121958.26001-1-p...@kernel.org/ > > IMO the second one from Pali makes sense,

Re: [PATCH 4/5] sandbox: Audit config.h and common.h usage

2023-11-18 Thread Tom Rini
Splitting this in to two different threads.. On Sat, Nov 18, 2023 at 10:58:50AM -0700, Simon Glass wrote: > Hi Tom, > > On Sat, 18 Nov 2023 at 10:45, Tom Rini wrote: > > > > On Sat, Nov 18, 2023 at 10:09:55AM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Fri, 17 Nov 2023 at 15:54, Tom R

Re: [PATCH 4/5] sandbox: Audit config.h and common.h usage

2023-11-18 Thread Simon Glass
Hi Tom, On Sat, 18 Nov 2023 at 10:45, Tom Rini wrote: > > On Sat, Nov 18, 2023 at 10:09:55AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 17 Nov 2023 at 15:54, Tom Rini wrote: > > > > > > Remove and replace common.h and config.h in sandbox when it's not needed > > > and add some explici

Re: [PATCH 4/5] sandbox: Audit config.h and common.h usage

2023-11-18 Thread Tom Rini
On Sat, Nov 18, 2023 at 10:09:55AM -0700, Simon Glass wrote: > Hi Tom, > > On Fri, 17 Nov 2023 at 15:54, Tom Rini wrote: > > > > Remove and replace common.h and config.h in sandbox when it's not needed > > and add some explicit includes where needed. > > > > Signed-off-by: Tom Rini > > --- > >

Re: [PATCH 4/5] sandbox: Audit config.h and common.h usage

2023-11-18 Thread Simon Glass
Hi Tom, On Fri, 17 Nov 2023 at 15:54, Tom Rini wrote: > > Remove and replace common.h and config.h in sandbox when it's not needed > and add some explicit includes where needed. > > Signed-off-by: Tom Rini > --- > arch/sandbox/cpu/cache.c | 1 - > arch/sandbox/cpu/cpu.c | 1 -

[PATCH 4/5] sandbox: Audit config.h and common.h usage

2023-11-17 Thread Tom Rini
Remove and replace common.h and config.h in sandbox when it's not needed and add some explicit includes where needed. Signed-off-by: Tom Rini --- arch/sandbox/cpu/cache.c | 1 - arch/sandbox/cpu/cpu.c | 1 - arch/sandbox/cpu/sdl.c | 2 +- arch/sandbox/cpu/spl.c