Re: [PATCH 3/3] sunxi: psci: implement PSCI on R528

2023-08-18 Thread Sam Edwards
On 8/18/23 07:27, Andre Przywara wrote: Hi Andre, So instead of trying to derive some pattern from where there is none, I'd rather do: config SUNXI_CPU_HOTPLUG_ADDRESS hex default 0x01c000bc if MACH_SUN8I_R40 But the hotplug flag register is at 0x01c000b8 for R40? ..

Re: [PATCH 3/3] sunxi: psci: implement PSCI on R528

2023-08-18 Thread Andre Przywara
On Tue, 15 Aug 2023 18:48:49 -0700 Sam Edwards wrote: Hi Sam, > On 8/15/23 15:59, Andre Przywara wrote: > > Hi Sam, > > Hi Andre, > > > So that's a bit more nasty indeed. I don't even know if R_CPUCFG really > > makes sense here, as the _R_ term typically refers to the management > > process

Re: [PATCH 3/3] sunxi: psci: implement PSCI on R528

2023-08-15 Thread Sam Edwards
On 8/15/23 15:59, Andre Przywara wrote: Hi Sam, Hi Andre, So that's a bit more nasty indeed. I don't even know if R_CPUCFG really makes sense here, as the _R_ term typically refers to the management processor, which the D1/R528 don't have. Or at least the always-on power domain, but then agai

Re: [PATCH 3/3] sunxi: psci: implement PSCI on R528

2023-08-15 Thread Andre Przywara
On Tue, 15 Aug 2023 13:17:33 -0600 Sam Edwards wrote: Hi Sam, > On 8/14/23 08:16, Andre Przywara wrote: > > Hi Sam, > > > >> This patch adds the necessary code to make nonsec booting and PSCI > >> secondary core management functional on the R528/T113. > > > > Unfortunately this patch break

Re: [PATCH 3/3] sunxi: psci: implement PSCI on R528

2023-08-15 Thread Sam Edwards
On 8/14/23 08:16, Andre Przywara wrote: Hi Sam, This patch adds the necessary code to make nonsec booting and PSCI secondary core management functional on the R528/T113. Unfortunately this patch breaks the build on older 32-bit SoCs, as SUNXI_CPUX_BASE is not defined there. That's a typical p

Re: [PATCH 3/3] sunxi: psci: implement PSCI on R528

2023-08-14 Thread Andre Przywara
On Fri, 11 Aug 2023 18:30:55 -0600 Sam Edwards wrote: Hi Sam, > This patch adds the necessary code to make nonsec booting and PSCI > secondary core management functional on the R528/T113. Unfortunately this patch breaks the build on older 32-bit SoCs, as SUNXI_CPUX_BASE is not defined there. Th

[PATCH 3/3] sunxi: psci: implement PSCI on R528

2023-08-11 Thread Sam Edwards
This patch adds the necessary code to make nonsec booting and PSCI secondary core management functional on the R528/T113. Signed-off-by: Sam Edwards Tested-by: Maksim Kiselev --- arch/arm/cpu/armv7/sunxi/psci.c | 47 - arch/arm/mach-sunxi/Kconfig | 2 ++ inc