On 8/14/23 08:16, Andre Przywara wrote:
Hi Sam,

This patch adds the necessary code to make nonsec booting and PSCI
secondary core management functional on the R528/T113.

Unfortunately this patch breaks the build on older 32-bit SoCs, as
SUNXI_CPUX_BASE is not defined there. That's a typical problem of the
"C-if" approach, but typically there is a clean, albeit not trivial,
solution:

It seems like SUNXI_CPUX_BASE and SUNXI_CPUCFG_BASE are mutually
exclusive, and I actually carry a "#define SUNXI_CPUCFG_BASE 0" hack in my
patches already.
So I wonder if we should unify those two into SUNXI_CPUCFG_BASE, with the
following rework:

The SUNXI_CPUX_BASE -> SUNXI_CPUCFG_BASE rename worked excellently. We're having the same problem with SUNXI_R_CPUCFG_BASE as well, though. How do you want to handle that?

Thanks,
Sam

Reply via email to