Re: [PATCH 2/4] riscv: dts: Add QSPI NAND device node

2022-10-19 Thread Padmarao.Begari
Hi Conor, > On Wed, 2022-10-19 at 16:59 +0100, Conor Dooley wrote: > > On Wed, Oct 19, 2022 at 08:23:20PM +0530, Padmarao Begari wrote: > > > riscv: dts: Add QSPI NAND device node > > I didn't notice this on 1/3, but I think we need to mention which > board > that this is being added for in the

Re: [PATCH 2/4] riscv: dts: Add QSPI NAND device node

2022-10-19 Thread Padmarao.Begari
Hi Tudor, > On Wed, 2022-10-19 at 15:28 +, Tudor Ambarus - M18064 wrote: > On 10/19/22 17:53, Padmarao Begari wrote: > > + flash0: spi-nand@0 { > > the node should have generic name according to the dt specification, > so please s/spi-nand/flash. > Ok, will use "flash" Regards Padmar

Re: [PATCH 2/4] riscv: dts: Add QSPI NAND device node

2022-10-19 Thread Conor Dooley
On Wed, Oct 19, 2022 at 08:23:20PM +0530, Padmarao Begari wrote: > riscv: dts: Add QSPI NAND device node I didn't notice this on 1/3, but I think we need to mention which board that this is being added for in the shortlog. Thanks, Conor. > Add QSPI NAND device node to the Microchip PolarFire SoC

Re: [PATCH 2/4] riscv: dts: Add QSPI NAND device node

2022-10-19 Thread Tudor.Ambarus
On 10/19/22 17:53, Padmarao Begari wrote: > + flash0: spi-nand@0 { the node should have generic name according to the dt specification, so please s/spi-nand/flash. -- Cheers, ta

[PATCH 2/4] riscv: dts: Add QSPI NAND device node

2022-10-19 Thread Padmarao Begari
Add QSPI NAND device node to the Microchip PolarFire SoC Icicle kit device tree Signed-off-by: Padmarao Begari --- arch/riscv/dts/microchip-mpfs-icicle-kit.dts | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/riscv/dts/microchip-mpfs-icicle-kit.dts b/arch/riscv/dts/micr