Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

2024-11-22 Thread Adam Ford
On Fri, Nov 22, 2024 at 7:17 AM Fabio Estevam wrote: > > On Fri, Nov 22, 2024 at 10:11 AM Adam Ford wrote: > > > Sure. Do you want me to test it against a specific branch or the > > master mainline branch? > > Master branch, please. I should have a response for you by Monday. adam

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

2024-11-22 Thread Fabio Estevam
On Fri, Nov 22, 2024 at 10:11 AM Adam Ford wrote: > Sure. Do you want me to test it against a specific branch or the > master mainline branch? Master branch, please.

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

2024-11-22 Thread Adam Ford
On Fri, Nov 22, 2024 at 6:38 AM Fabio Estevam wrote: > > Hi Adam, > > On Sat, Nov 9, 2024 at 8:23 PM Adam Ford wrote: > > > I did some more investigating, and with the device tree debugging > > turned on, I get the following: > ... > > clk_set_defaults(clock-controller@3038) > > clk_set_defa

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

2024-11-22 Thread Fabio Estevam
Hi Adam, On Sat, Nov 9, 2024 at 8:23 PM Adam Ford wrote: > I did some more investigating, and with the device tree debugging > turned on, I get the following: ... > clk_set_defaults(clock-controller@3038) > clk_set_default_parents: could not read assigned-clock-parents for 970ab8 > clk_get_

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

2024-11-09 Thread Adam Ford
On Mon, Nov 4, 2024 at 11:24 AM Adam Ford wrote: > > On Mon, Nov 4, 2024 at 11:22 AM Michael Nazzareno Trimarchi > wrote: > > > > Hi > > > > On Mon, Nov 4, 2024 at 6:17 PM Adam Ford wrote: > > > > > > On Mon, Nov 4, 2024 at 11:04 AM Michael Nazzareno Trimarchi > > > wrote: > > > > > > > > Hi Ad

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

2024-11-04 Thread Adam Ford
On Mon, Nov 4, 2024 at 11:22 AM Michael Nazzareno Trimarchi wrote: > > Hi > > On Mon, Nov 4, 2024 at 6:17 PM Adam Ford wrote: > > > > On Mon, Nov 4, 2024 at 11:04 AM Michael Nazzareno Trimarchi > > wrote: > > > > > > Hi Adam > > > > > > On Mon, Nov 4, 2024 at 6:01 PM Adam Ford wrote: > > > > >

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

2024-11-04 Thread Michael Nazzareno Trimarchi
Hi On Mon, Nov 4, 2024 at 6:17 PM Adam Ford wrote: > > On Mon, Nov 4, 2024 at 11:04 AM Michael Nazzareno Trimarchi > wrote: > > > > Hi Adam > > > > On Mon, Nov 4, 2024 at 6:01 PM Adam Ford wrote: > > > > > > On Mon, Nov 4, 2024 at 10:29 AM Michael Nazzareno Trimarchi > > > wrote: > > > > > > >

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

2024-11-04 Thread Adam Ford
On Mon, Nov 4, 2024 at 11:04 AM Michael Nazzareno Trimarchi wrote: > > Hi Adam > > On Mon, Nov 4, 2024 at 6:01 PM Adam Ford wrote: > > > > On Mon, Nov 4, 2024 at 10:29 AM Michael Nazzareno Trimarchi > > wrote: > > > > > > Hi Adam > > > > > > On Mon, Nov 4, 2024 at 5:11 PM Adam Ford wrote: > > >

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

2024-11-04 Thread Michael Nazzareno Trimarchi
Hi Adam On Mon, Nov 4, 2024 at 6:01 PM Adam Ford wrote: > > On Mon, Nov 4, 2024 at 10:29 AM Michael Nazzareno Trimarchi > wrote: > > > > Hi Adam > > > > On Mon, Nov 4, 2024 at 5:11 PM Adam Ford wrote: > > > > > > On Sun, Jul 7, 2024 at 3:45 AM Michael Trimarchi > > > wrote: > > > > > > > > The

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

2024-11-04 Thread Adam Ford
On Mon, Nov 4, 2024 at 10:29 AM Michael Nazzareno Trimarchi wrote: > > Hi Adam > > On Mon, Nov 4, 2024 at 5:11 PM Adam Ford wrote: > > > > On Sun, Jul 7, 2024 at 3:45 AM Michael Trimarchi > > wrote: > > > > > > The osc_24m is the clock-output-name and not the one that > > > is used as internal n

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

2024-11-04 Thread Michael Nazzareno Trimarchi
Hi Adam On Mon, Nov 4, 2024 at 5:11 PM Adam Ford wrote: > > On Sun, Jul 7, 2024 at 3:45 AM Michael Trimarchi > wrote: > > > > The osc_24m is the clock-output-name and not the one that > > is used as internal name reference from the strcmp. The clock > > that use osc_24m, will not be able to repa

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

2024-11-04 Thread Adam Ford
On Sun, Jul 7, 2024 at 3:45 AM Michael Trimarchi wrote: > > The osc_24m is the clock-output-name and not the one that > is used as internal name reference from the strcmp. The clock > that use osc_24m, will not be able to reparent it as they should. > We need anyway register the osc_24m clock fixe

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

2024-07-22 Thread Fabio Estevam
On Thu, Jul 11, 2024 at 2:56 AM Michael Nazzareno Trimarchi wrote: > I will rephrase the commit message It looks good as is. Applied all, thanks.

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

2024-07-10 Thread Michael Nazzareno Trimarchi
HI Fabio On Wed, Jul 10, 2024 at 3:43 PM Fabio Estevam wrote: > > On Wed, Jul 10, 2024 at 10:39 AM Michael Nazzareno Trimarchi > wrote: > > > clk dump > > > > It's how uboot is registering the clk in dts. My idea now was not to > > change it to not impact other architectures. > > I have a lot of

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

2024-07-10 Thread Fabio Estevam
On Wed, Jul 10, 2024 at 10:39 AM Michael Nazzareno Trimarchi wrote: > clk dump > > It's how uboot is registering the clk in dts. My idea now was not to > change it to not impact other architectures. > I have a lot of changes but I don't want to address regression and fix > and test before send mo

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

2024-07-10 Thread Michael Nazzareno Trimarchi
Hi On Wed, Jul 10, 2024 at 3:34 PM Fabio Estevam wrote: > > Hi Michael, > > On Sun, Jul 7, 2024 at 5:20 AM Michael Trimarchi > wrote: > > > -static const char *imx8mn_ecspi1_sels[] = {"osc_24m", "sys_pll2_200m", > > "sys_pll1_40m", > > +static const char *imx8mn_ecspi1_sels[] = {"clock-osc-24m"

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

2024-07-10 Thread Fabio Estevam
Hi Michael, On Sun, Jul 7, 2024 at 5:20 AM Michael Trimarchi wrote: > -static const char *imx8mn_ecspi1_sels[] = {"osc_24m", "sys_pll2_200m", > "sys_pll1_40m", > +static const char *imx8mn_ecspi1_sels[] = {"clock-osc-24m", "sys_pll2_200m", > "sys_pll1_40m", The kernel uses osc_24m. Why does U

[PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

2024-07-07 Thread Michael Trimarchi
The osc_24m is the clock-output-name and not the one that is used as internal name reference from the strcmp. The clock that use osc_24m, will not be able to reparent it as they should. We need anyway register the osc_24m clock fixed factor in the clock tree. Fixes: 710c4ffb890 ("clk: imx: clk-imx