Re: [PATCH 07/35] common: Move functions for loading from fat/ext2 to fs.h

2019-12-12 Thread Tom Rini
On Thu, Dec 12, 2019 at 09:31:08AM +0100, Heinrich Schuchardt wrote: > On 12/12/19 1:47 AM, Simon Glass wrote: > > These are filesystem functions and belong in the filesystem header file. > > Move them. > > I am not very fond of having any file system dependencies outside of > disk/ and part/. >

Re: [PATCH 07/35] common: Move functions for loading from fat/ext2 to fs.h

2019-12-12 Thread Heinrich Schuchardt
On 12/12/19 1:47 AM, Simon Glass wrote: These are filesystem functions and belong in the filesystem header file. Move them. I am not very fond of having any file system dependencies outside of disk/ and part/. Do we need the functions do_ext2load() and do_fat_fsload() at all? What is the bene

[PATCH 07/35] common: Move functions for loading from fat/ext2 to fs.h

2019-12-11 Thread Simon Glass
These are filesystem functions and belong in the filesystem header file. Move them. Signed-off-by: Simon Glass --- board/inversepath/usbarmory/usbarmory.c | 1 + cmd/fat.c | 2 +- cmd/pxe.c | 1 + include/common.h