[PATCH] tools: Fix potential memory leak in aisimage.c

2025-04-18 Thread ant . v . moryakov
From: Maks Mishin The 'line' variable is dynamically allocated by getline() function during config file parsing but wasn't being freed before function exit, causing memory leak. This was detected by static analysis. Add missing free() call before closing the file descriptor to prevent memory lea

Re: [PATCH] tools: Fix potential memory leak in aisimage.c

2025-04-18 Thread Quentin Schulz
Hi, On 4/18/25 10:19 AM, ant.v.morya...@gmail.com wrote: From: Maks Mishin We don't really like empty commit logs, could you please provide some information on what this fixes and how? e.g. here you could say something along the lines of: line gets realloc'ed in getline() so we need to f

[PATCH] tools: Fix potential memory leak in aisimage.c

2025-04-18 Thread ant . v . moryakov
From: Maks Mishin Signed-off-by: Maks Mishin --- tools/aisimage.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/aisimage.c b/tools/aisimage.c index b8b3ee32..6091c8d5 100644 --- a/tools/aisimage.c +++ b/tools/aisimage.c @@ -346,6 +346,7 @@ static int aisimage_generate(struct image_t