Re: [PATCH] hush: Fix assignments being misinterpreted as commands

2021-04-13 Thread Tom Rini
On Sun, Feb 28, 2021 at 04:29:51PM -0500, Sean Anderson wrote: > If there were no variable substitutions in a command, then initial > assignments would be misinterpreted as commands, instead of being skipped > over. This is demonstrated by the following example: > > => foo=bar echo baz >

Re: [PATCH] hush: Fix assignments being misinterpreted as commands

2021-03-03 Thread Wolfgang Denk
Dear Tom, In message <20210302133435.GZ10169@bill-the-cat> you wrote: > > > Only the third example is affected by this patch. > > OK. But to what end? Historically we have a buggy but mostly > compatible "hush" that acts like "sh" does. A more flexible shell could > solve a lot of different us

Re: [PATCH] hush: Fix assignments being misinterpreted as commands

2021-03-02 Thread Sean Anderson
On 3/2/21 8:34 AM, Tom Rini wrote: On Tue, Mar 02, 2021 at 08:24:20AM -0500, Sean Anderson wrote: On 3/2/21 8:20 AM, Tom Rini wrote: On Mon, Mar 01, 2021 at 06:07:36PM -0500, Sean Anderson wrote: On 3/1/21 1:26 PM, Heinrich Schuchardt wrote: On 3/1/21 3:17 PM, Tom Rini wrote: On Sun, Feb 28,

Re: [PATCH] hush: Fix assignments being misinterpreted as commands

2021-03-02 Thread Tom Rini
On Tue, Mar 02, 2021 at 08:24:20AM -0500, Sean Anderson wrote: > On 3/2/21 8:20 AM, Tom Rini wrote: > > On Mon, Mar 01, 2021 at 06:07:36PM -0500, Sean Anderson wrote: > > > On 3/1/21 1:26 PM, Heinrich Schuchardt wrote: > > > > On 3/1/21 3:17 PM, Tom Rini wrote: > > > > > On Sun, Feb 28, 2021 at 06:

Re: [PATCH] hush: Fix assignments being misinterpreted as commands

2021-03-02 Thread Sean Anderson
On 3/2/21 8:20 AM, Tom Rini wrote: On Mon, Mar 01, 2021 at 06:07:36PM -0500, Sean Anderson wrote: On 3/1/21 1:26 PM, Heinrich Schuchardt wrote: On 3/1/21 3:17 PM, Tom Rini wrote: On Sun, Feb 28, 2021 at 06:51:53PM -0500, Sean Anderson wrote: On 2/28/21 6:40 PM, Heinrich Schuchardt wrote: Am

Re: [PATCH] hush: Fix assignments being misinterpreted as commands

2021-03-02 Thread Tom Rini
On Mon, Mar 01, 2021 at 06:07:36PM -0500, Sean Anderson wrote: > On 3/1/21 1:26 PM, Heinrich Schuchardt wrote: > > On 3/1/21 3:17 PM, Tom Rini wrote: > > > On Sun, Feb 28, 2021 at 06:51:53PM -0500, Sean Anderson wrote: > > > > On 2/28/21 6:40 PM, Heinrich Schuchardt wrote: > > > > > Am 28. Februar

Re: [PATCH] hush: Fix assignments being misinterpreted as commands

2021-03-01 Thread Sean Anderson
On 3/1/21 1:26 PM, Heinrich Schuchardt wrote: On 3/1/21 3:17 PM, Tom Rini wrote: On Sun, Feb 28, 2021 at 06:51:53PM -0500, Sean Anderson wrote: On 2/28/21 6:40 PM, Heinrich Schuchardt wrote: Am 28. Februar 2021 22:29:51 MEZ schrieb Sean Anderson : If there were no variable substitutions in a

Re: [PATCH] hush: Fix assignments being misinterpreted as commands

2021-03-01 Thread Tom Rini
On Sun, Feb 28, 2021 at 04:29:51PM -0500, Sean Anderson wrote: > If there were no variable substitutions in a command, then initial > assignments would be misinterpreted as commands, instead of being skipped > over. This is demonstrated by the following example: > > => foo=bar echo baz >

Re: [PATCH] hush: Fix assignments being misinterpreted as commands

2021-03-01 Thread Heinrich Schuchardt
On 3/1/21 3:17 PM, Tom Rini wrote: On Sun, Feb 28, 2021 at 06:51:53PM -0500, Sean Anderson wrote: On 2/28/21 6:40 PM, Heinrich Schuchardt wrote: Am 28. Februar 2021 22:29:51 MEZ schrieb Sean Anderson : If there were no variable substitutions in a command, then initial assignments would be misi

Re: [PATCH] hush: Fix assignments being misinterpreted as commands

2021-03-01 Thread Tom Rini
On Sun, Feb 28, 2021 at 06:51:53PM -0500, Sean Anderson wrote: > On 2/28/21 6:40 PM, Heinrich Schuchardt wrote: > > Am 28. Februar 2021 22:29:51 MEZ schrieb Sean Anderson : > > > If there were no variable substitutions in a command, then initial > > > assignments would be misinterpreted as commands

Re: [PATCH] hush: Fix assignments being misinterpreted as commands

2021-02-28 Thread Sean Anderson
On 2/28/21 6:40 PM, Heinrich Schuchardt wrote: Am 28. Februar 2021 22:29:51 MEZ schrieb Sean Anderson : If there were no variable substitutions in a command, then initial assignments would be misinterpreted as commands, instead of being skipped over. This is demonstrated by the following example

Re: [PATCH] hush: Fix assignments being misinterpreted as commands

2021-02-28 Thread Heinrich Schuchardt
Am 28. Februar 2021 22:29:51 MEZ schrieb Sean Anderson : >If there were no variable substitutions in a command, then initial >assignments would be misinterpreted as commands, instead of being >skipped >over. This is demonstrated by the following example: > > => foo=bar echo baz The commit me

[PATCH] hush: Fix assignments being misinterpreted as commands

2021-02-28 Thread Sean Anderson
If there were no variable substitutions in a command, then initial assignments would be misinterpreted as commands, instead of being skipped over. This is demonstrated by the following example: => foo=bar echo baz Unknown command 'foo=bar' - try 'help' Signed-off-by: Sean Anderson