Re: [PATCH] board: tbs2910: Add support for generic distro configuration

2020-01-28 Thread Denis 'GNUtoo' Carikli
On Sun, 26 Jan 2020 01:40:13 +0100 Soeren Moch wrote: > >> Why do you define CONFIG_BOOTCOMMAND here instead of modifying the > >> existing one? > > I'm a bit confused with it: There seem to be many way to do the same > > thing and I'm not sure which one is the best. > > > > Because of that, I

Re: [PATCH] board: tbs2910: Add support for generic distro configuration

2020-01-28 Thread Soeren Moch
On 28.01.20 18:02, Denis 'GNUtoo' Carikli wrote: > On Sun, 26 Jan 2020 01:40:13 +0100 > Soeren Moch wrote: >>> Ahh ok, now I understand. That probably explains the repeated size >>> issues. >> Why? With SPL+u-boot proper it would be even worse, since then there >> is a gap between SPL and u-boo

Re: [PATCH] board: tbs2910: Add support for generic distro configuration

2020-01-28 Thread Denis 'GNUtoo' Carikli
On Sun, 26 Jan 2020 01:40:13 +0100 Soeren Moch wrote: > > Ahh ok, now I understand. That probably explains the repeated size > > issues. > Why? With SPL+u-boot proper it would be even worse, since then there > is a gap between SPL and u-boot, u-boot starts at higher address in > eMMC, and it would

Re: [PATCH] board: tbs2910: Add support for generic distro configuration

2020-01-25 Thread Soeren Moch
On 26.01.20 00:15, Denis 'GNUtoo' Carikli wrote: > On Sat, 25 Jan 2020 20:52:36 +0100 > Soeren Moch wrote: > >> Hi Denis, > Hi, > >> thanks for your patch. In general I think it could be a good idea to >> support distroboot on this board, especially if we can maintain >> compatibility with the exi

Re: [PATCH] board: tbs2910: Add support for generic distro configuration

2020-01-25 Thread Denis 'GNUtoo' Carikli
On Sat, 25 Jan 2020 20:52:36 +0100 Soeren Moch wrote: > Hi Denis, Hi, > thanks for your patch. In general I think it could be a good idea to > support distroboot on this board, especially if we can maintain > compatibility with the existing boot procedure. However, since this > board repeatedly

Re: [PATCH] board: tbs2910: Add support for generic distro configuration

2020-01-25 Thread Tom Rini
On Sat, Jan 25, 2020 at 08:56:12PM +0100, Soeren Moch wrote: > On 25.01.20 17:24, Tom Rini wrote: > > On Sat, Jan 25, 2020 at 02:42:40AM +0100, Denis 'GNUtoo' Carikli wrote: > > > >> This keeps the compatibility with the old bootcmd. > >> > >> Signed-off-by: Denis 'GNUtoo' Carikli > > First, I hav

Re: [PATCH] board: tbs2910: Add support for generic distro configuration

2020-01-25 Thread Soeren Moch
On 25.01.20 17:24, Tom Rini wrote: > On Sat, Jan 25, 2020 at 02:42:40AM +0100, Denis 'GNUtoo' Carikli wrote: > >> This keeps the compatibility with the old bootcmd. >> >> Signed-off-by: Denis 'GNUtoo' Carikli > First, I have concerns about this increasing the size of the board. > >> --- >> includ

Re: [PATCH] board: tbs2910: Add support for generic distro configuration

2020-01-25 Thread Soeren Moch
Hi Denis, thanks for your patch. In general I think it could be a good idea to support distroboot on this board, especially if we can maintain compatibility with the existing boot procedure. However, since this board repeatedly has size problems with the u-boot binary, we carefully need to check b

Re: [PATCH] board: tbs2910: Add support for generic distro configuration

2020-01-25 Thread Tom Rini
On Sat, Jan 25, 2020 at 02:42:40AM +0100, Denis 'GNUtoo' Carikli wrote: > This keeps the compatibility with the old bootcmd. > > Signed-off-by: Denis 'GNUtoo' Carikli First, I have concerns about this increasing the size of the board. > --- > include/configs/tbs2910.h | 39 +++

[PATCH] board: tbs2910: Add support for generic distro configuration

2020-01-24 Thread Denis 'GNUtoo' Carikli
This keeps the compatibility with the old bootcmd. Signed-off-by: Denis 'GNUtoo' Carikli --- include/configs/tbs2910.h | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h index b598fca1