Re: [PATCH] Revert "lib: Improve _parse_integer_fixup_radix base 16 detection"

2020-06-15 Thread Tom Rini
On Sun, Jun 07, 2020 at 01:36:45AM -0400, Sean Anderson wrote: > This reverts commit 0486497e2b5f4d36fa968a1a60fea358cbf70b65. > > The strtoul has well-defined semantics. It is defined by the C standard and > POSIX. To quote the relevant section of the man pages, > > > If base is zero or 16, the

Re: [PATCH] Revert "lib: Improve _parse_integer_fixup_radix base 16 detection"

2020-06-08 Thread Tom Rini
On Mon, Jun 08, 2020 at 01:05:21PM -0400, Sean Anderson wrote: > On 6/8/20 2:24 AM, Michal Simek wrote: > > It is in u-boot mainline from February. Then we had to fix it in April. > > Do you have a link/commit hash for said fix? > > > In the middle of this I have seen IIC one patchset which impro

Re: [PATCH] Revert "lib: Improve _parse_integer_fixup_radix base 16 detection"

2020-06-08 Thread Simon Glass
Hi, On Mon, 8 Jun 2020 at 00:24, Michal Simek wrote: > > On 07. 06. 20 7:36, Sean Anderson wrote: > > This reverts commit 0486497e2b5f4d36fa968a1a60fea358cbf70b65. > > > > The strtoul has well-defined semantics. It is defined by the C standard and > > POSIX. To quote the relevant section of the m

Re: [PATCH] Revert "lib: Improve _parse_integer_fixup_radix base 16 detection"

2020-06-08 Thread Sean Anderson
On 6/8/20 2:24 AM, Michal Simek wrote: > It is in u-boot mainline from February. Then we had to fix it in April. Do you have a link/commit hash for said fix? > In the middle of this I have seen IIC one patchset which improves hex > handling which is likely better way then this. Same for this. >

Re: [PATCH] Revert "lib: Improve _parse_integer_fixup_radix base 16 detection"

2020-06-07 Thread Michal Simek
On 07. 06. 20 7:36, Sean Anderson wrote: > This reverts commit 0486497e2b5f4d36fa968a1a60fea358cbf70b65. > > The strtoul has well-defined semantics. It is defined by the C standard and > POSIX. To quote the relevant section of the man pages, > >> If base is zero or 16, the string may then include

Re: [PATCH] Revert "lib: Improve _parse_integer_fixup_radix base 16 detection"

2020-06-06 Thread Sean Anderson
On 6/7/20 2:40 AM, Heinrich Schuchardt wrote: > On 6/7/20 7:36 AM, Sean Anderson wrote: >> This reverts commit 0486497e2b5f4d36fa968a1a60fea358cbf70b65. >> >> The strtoul has well-defined semantics. It is defined by the C standard and >> POSIX. To quote the relevant section of the man pages, >> >>>

Re: [PATCH] Revert "lib: Improve _parse_integer_fixup_radix base 16 detection"

2020-06-06 Thread Heinrich Schuchardt
On 6/7/20 7:36 AM, Sean Anderson wrote: > This reverts commit 0486497e2b5f4d36fa968a1a60fea358cbf70b65. > > The strtoul has well-defined semantics. It is defined by the C standard and > POSIX. To quote the relevant section of the man pages, > >> If base is zero or 16, the string may then include a

[PATCH] Revert "lib: Improve _parse_integer_fixup_radix base 16 detection"

2020-06-06 Thread Sean Anderson
This reverts commit 0486497e2b5f4d36fa968a1a60fea358cbf70b65. The strtoul has well-defined semantics. It is defined by the C standard and POSIX. To quote the relevant section of the man pages, > If base is zero or 16, the string may then include a "0x" prefix, and the > number will be read in bas