Re: [PATCH v8 4/4] mtd: spi-nor-core: Add support for Macronix Octal flash

2022-07-15 Thread liao jaime
Hi Jagan > > On Fri, Jul 15, 2022 at 2:47 PM liao jaime wrote: > > > > Hi Jagan > > > > > > On Mon, Jul 4, 2022 at 11:43 AM JaimeLiao wrote: > > > > > > > > Adding Macronix Octal flash for Octal DTR support. > > > &

Re: [PATCH v8 4/4] mtd: spi-nor-core: Add support for Macronix Octal flash

2022-07-15 Thread liao jaime
Hi Jagan > > On Mon, Jul 4, 2022 at 11:43 AM JaimeLiao wrote: > > > > Adding Macronix Octal flash for Octal DTR support. > > > > The octaflash series can be divided into the following types: > > > > MX25 series : Serial NOR Flash. > > MX66 series : Serial NOR Flash with stacked die.(Size larger th

Re: [PATCH v8 2/4] mtd: spi-nor-core: Adding different type of command extension in Soft Reset

2022-07-06 Thread liao jaime
Hi Jagan > > On Mon, Jul 4, 2022 at 11:42 AM JaimeLiao wrote: > > > > Power-on-Reset is a method to restore flash back to 1S-1S-1S mode from > > 8D-8D-8D > > in the begging of probe. > > > > Command extension type is not standardized across flash vendors in DTR mode. > > > > For suiting differen

Re: [PATCH] mtd: spi-nor: Parse SFDP Command Sequence to change to Octal DDR(8D-8D-8D) mode

2022-03-15 Thread liao jaime
Hi Tudor > > On 3/15/22 10:45, liao jaime wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > Hi > > > >> Hi, > >> > >> On 3/10/22 08:59, JaimeLiao wrote: > >

Re: [PATCH] mtd: spi-nor: Parse SFDP Command Sequence to change to Octal DDR(8D-8D-8D) mode

2022-03-15 Thread liao jaime
Hi > Hi, > > On 3/10/22 08:59, JaimeLiao wrote: > > +static int spi_nor_generall_octal_dtr_enable(struct spi_nor *nor) > > Is there a disable method too? If not, can we deduce it? Because of difference with flash vendors, I think it is hard to deduce the method "spi_nor_generall_octal_dtr_disable"

Re: [PATCH v6 3/4] mtd: spi-nor-core: Add support for Macronix Octal flash

2022-01-13 Thread liao jaime
Hi Pratyush > > On 03/01/22 10:47AM, tudor.amba...@microchip.com wrote: > > On 12/29/21 7:56 AM, JaimeLiao wrote: > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know > > > the content is safe > > > > > > Adding Macronix Octal flash for Octal DTR support. > > > > > > The

Re: [PATCH v6 1/4] mtd: spi-nor: macronix: add support for Macronix Octal

2022-01-05 Thread liao jaime
Hi Tudor > > Hi, > > On 12/29/21 7:56 AM, JaimeLiao wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > Follow patch "f6adec1af4b2f5d3012480c6cdce7743b74a6156" for adding > > Macronix flash in Octal DTR mode. > > > > Enable Octal DTR

Re: [PATCH v6 1/4] mtd: spi-nor: macronix: add support for Macronix Octal

2022-01-05 Thread liao jaime
Hi Miquel > > Hi Jaime, > > You made a typo on Jagan's address, you might need to resend. Yes your are right, I have re-send the cover letter to Jagan. > > The title does not look correct, maybe you miss a word after Octal. And > is it something Macronix specific? I believe this is generic and y

Re: [PATCH v5 3/3] mtd: spi-nor-core: Add support for Macronix Octal flash

2021-11-26 Thread liao jaime
Hi Tudor > > On 11/18/21 12:13 PM, JaimeLiao wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > Adding Macronix Octal flash for Octal DTR support. > > > > The octaflash series can be divided into the following types: > > > > MX25 seri

Re: [PATCH v5 1/3] mtd: spi-nor: macronix: add support for Macronix Octal

2021-11-25 Thread liao jaime
Hi Tudor > > On 11/26/21 7:28 AM, liao jaime wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > Hi Tudor > > Hi, > > > > >> > >> On 11/18/21 12:13 PM, JaimeLiao wrot

Re: [PATCH v5 2/3] mtd: spi-nor-core: Adding different type of command extension in Soft Reset

2021-11-25 Thread liao jaime
Hi Tudor > > On 11/18/21 12:13 PM, JaimeLiao wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > Power-on-Reset is a method to restore flash back to 1S-1S-1S mode from > > 8D-8D-8D > > in the begging of probe. > > > > Command extensio

Re: [PATCH v5 1/3] mtd: spi-nor: macronix: add support for Macronix Octal

2021-11-25 Thread liao jaime
Hi Tudor > > On 11/18/21 12:13 PM, JaimeLiao wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > Hi, Jaime, > > > Follow patch "f6adec1af4b2f5d3012480c6cdce7743b74a6156" for adding > > Macronix flash in Octal DTR mode. > > > > Enable O

Re: [PATCH v4 1/4] mtd: spi-nor: macronix: add support for Macronix Octal

2021-11-03 Thread liao jaime
Hi Jagan > > On Mon, Oct 18, 2021 at 11:54 AM JaimeLiao wrote: > > > > Follow patch "f6adec1af4b2f5d3012480c6cdce7743b74a6156" for adding > > Macronix flash in Octal DTR mode. > > > > Enable Octal DTR mode with 20 dummy cycles to allow running at the > > maximum supported frequency. > > > > -h

Re: [PATCH v4 2/4] mtd: spi-nor-core: Adding different type of command extension in Soft Reset

2021-10-26 Thread liao jaime
> > On 25/10/21 12:30PM, Jagan Teki wrote: > > On Mon, Oct 18, 2021 at 11:54 AM JaimeLiao wrote: > > > > > > Power-on-Reset is a method to restore flash back to 1S-1S-1S mode from > > > 8D-8D-8D > > > in the begging of probe. > > > > > > Command extension type is not standardized across flash ven

Re: [PATCH v4 4/4] mtd: spi-nor-core: Add support for Macronix Octal flash

2021-10-26 Thread liao jaime
> > On 18/10/21 02:24PM, JaimeLiao wrote: > > Adding Macronix Octal flash for Octal DTR support. > > > > The octaflash series can be divided into the following types: > > > > MX25 series : Serial NOR Flash. > > MX66 series : Serial NOR Flash with stacked die.(Size larger than 1Gb) > > LM/UM series

Re: [PATCH v4 3/4] mtd: spi-nor-core: set 4byte opcode when possible

2021-10-26 Thread liao jaime
> > On 18/10/21 02:24PM, JaimeLiao wrote: > > Following linux kernel to check address width and 4byte flag to enable > > 4byte opcode setting. > > > > Signed-off-by: JaimeLiao > > --- > > drivers/mtd/spi/spi-nor-core.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/mtd

Re: [PATCH v4 4/4] mtd: spi-nor-core: Add support for Macronix Octal flash

2021-10-25 Thread liao jaime
MX66UW2G345G is similar to MX66UW2G345GX0 and MX66UW2G345G's device ID is 0xc2843c actually. So that I correct it and add MX66UW2G345GX0 in IDs table. Pratyush Yadav 於 2021年10月26日 週二 上午3:45寫道: > On 18/10/21 02:24PM, JaimeLiao wrote: > > Adding Macronix Octal flash for Octal DTR support. > > > >

Re: [PATCH v4 2/4] mtd: spi-nor-core: Adding different type of command extension in Soft Reset

2021-10-25 Thread liao jaime
For validating soft_reset after probe, I have test it on my side. It is working with command extension type which got from BFPT. Pratyush Yadav 於 2021年10月26日 週二 上午3:42寫道: > On 25/10/21 12:30PM, Jagan Teki wrote: > > On Mon, Oct 18, 2021 at 11:54 AM JaimeLiao > wrote: > > > > > > Power-on-Reset

Re: [PATCH v3 3/4] mtd: spi-nor-core: set 4byte opcode when possible

2021-09-26 Thread liao jaime
>if (spi_nor_protocol_is_dtr(nor->read_proto)) { > /* Always use 4-byte addresses in DTR mode. */ >nor->addr_width = 4; because of nor->addr_width have been set to 4 when protocol is dtr >} else if (nor->addr_width) { >/* already configured fr

Re: [PATCH v2 2/4] mtd: spi-nor-core: Adding different type of command extension in Soft Reset

2021-08-31 Thread liao jaime
Hi Pratyush Thanks for your reply, I want to create "CONFIG_SPI_EXT_INVERT" to separate extension types. Changed as below, do you have any suggestion? ext = nor->cmd_ext_type; if (!nor->cmd_ext_type) { nor->cmd_ext_type = SPI_NOR_EXT_REPEAT; #ifdef CONFIG_SPI_NOR_EXT_INVER

Re: [PATCH 1/4] mtd: spi-nor: macronix: add support for Macronix octaflash

2021-08-23 Thread liao jaime
Hi Pratyush Thanks for your reply and I have send v2 patch , please help to review. I prefer to have v3 patch for replacing SPI_FLASH_MACRONIX with SPI_FLASH_MACRONIX_OCTAL. It would be great if you could help to review v2 and then I will add the modifications in v3. Thanks Jaime Pratyush Yadav