Re: [U-Boot] [PATCH v3] Tegra: T210: Add QSPI driver

2015-10-22 Thread Yen Lin
Jagan, > This is a port of the existing Tegra SPI driver (tegra114_spi.c). The Tegra > 210 > QSPI controller is compatible with SPI, but had some quirks IIRC - Yen can > comment on that, since he wrote this driver. > There are some minor differences between SPI and QSPI controllers. > > >

Re: [U-Boot] [PATCH 3/3] i2c: tegra: dump alen in debug statements

2014-06-25 Thread Yen Lin
preted. > > Signed-off-by: Stephen Warren LGTM. Reviewed-by: Yen Lin Regards, Yen Lin --- This email message is for the sole use of the intended recipient(s) and may contain confidential informatio

Re: [U-Boot] [PATCH 2/3] i2c: tegra: write clean data to TX FIFO

2014-06-25 Thread Yen Lin
ets()'s > loop's if > (is_write) code mirrors the else (i.e. > read) branch. > > Signed-off-by: Stephen Warren LGME. Reviewed-by: Yen Lin Regards, Yen Lin --- This email message is

Re: [U-Boot] [PATCH 2/3] i2c: tegra: write clean data to TX FIFO

2014-06-25 Thread Yen Lin
> > > > Signed-off-by: Stephen Warren > > LGME. Oops, should be LGTM. > > Reviewed-by: Yen Lin > > Regards, > Yen Lin --- This email message is for the sole use of the inten

Re: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads

2014-06-25 Thread Yen Lin
ing repeated starts to solve this. > > Signed-off-by: Stephen Warren This patch looks good to me. Reviewed-by: Yen Lin Regards, Yen Lin --- This email message is for the sole use of the intended reci

Re: [U-Boot] [PATCH v3 16/23] tegra: Setup PMC scratch info from ap20 setup

2012-04-03 Thread Yen Lin
On Mon, 2012-04-02 at 16:18 -0700, Simon Glass wrote: > From: Yen Lin > > Save SDRAM parameters into the warmboot scratch registers > Signed-off-by: Yen Lin > Signed-off-by: Simon Glass > --- > ---

Re: [U-Boot] [PATCH v3 15/23] tegra: Add warmboot implementation

2012-04-03 Thread Yen Lin
On Mon, 2012-04-02 at 16:18 -0700, Simon Glass wrote: > From: Yen Lin > > Add code to set up the warm boot area in the Tegra CPU ready for a > resume after suspend. > Signed-off-by: Yen Lin > Signed-off-by: Simon Glass > Acked-by: Stephen Warren > --- > Chan

Re: [U-Boot] [PATCH v3 09/23] tegra: Add flow, gp_padctl, fuse, sdram headers

2012-04-03 Thread Yen Lin
On Mon, 2012-04-02 at 16:18 -0700, Simon Glass wrote: > From: Yen Lin > > These headers provide access to additional Tegra features. > > flow - start/stop CPUs > sdram - parameters for SDRAM > fuse - access to on-chip fuses / security settings > gp_padctl - pad con

Re: [U-Boot] [PATCH v3 08/23] tegra: Add crypto library for warmboot code

2012-04-03 Thread Yen Lin
On Mon, 2012-04-02 at 16:18 -0700, Simon Glass wrote: > From: Yen Lin > > Provides an interface to aes.c for the warmboot code. > Signed-off-by: Yen Lin > Signed-off-by: Simon Glass > --- > Changes in v2: > - Rely on compiler to optimise out debug_print_vector()

Re: [U-Boot] [PATCH v3 05/23] Add AES crypto library

2012-04-03 Thread Yen Lin
Hi Simon, On Mon, 2012-04-02 at 16:18 -0700, Simon Glass wrote: > From: Yen Lin > > Add support for AES using an implementation form Karl Malbrain. > This offers small code size (around 5KB on ARM) and supports 128-bit > AES only. > Could you fix "form" to &qu

Re: [U-Boot] [PATCH v3 5/9] tegra: i2c: Add I2C driver

2012-02-09 Thread Yen Lin
On Fri, 2012-02-03 at 17:13 -0800, Simon Glass wrote: > From: Yen Lin > > Add basic i2c driver for Tegra2 with 8- and 16-bit address support. > The driver requires CONFIG_OF_CONTROL to obtain its configuration > from the device tree. > > (Simon Glass: s...@chromium.org

Re: [U-Boot] [PATCH v2 4/7] tegra: Add I2C driver

2012-02-06 Thread Yen Lin
for him. > Don't know how to add a S-o-b line to the patch. Please add "Signed-off-by: Yen Lin " Thanks, Yen --- This email message is for the sole use of the intended recipient(s) and may con

Re: [U-Boot] [PATCH 09/14] tegra: Add warmboot implementation

2012-01-13 Thread Yen Lin
On Fri, 2012-01-13 at 15:08 -0800, Stephen Warren wrote: > On 01/13/2012 04:05 PM, Simon Glass wrote: > > On Fri, Jan 13, 2012 at 2:04 PM, Yen Lin wrote: > >> On Fri, 2012-01-13 at 11:34 -0800, Simon Glass wrote: > >>> On Tue, Jan 10, 2012 at 10:30 AM, Stephen Warr

Re: [U-Boot] [PATCH 09/14] tegra: Add warmboot implementation

2012-01-13 Thread Yen Lin
Hi Simon, On Fri, 2012-01-13 at 11:34 -0800, Simon Glass wrote: > Hi Stephen, > > [Yen please can you read this also?] > > On Tue, Jan 10, 2012 at 10:30 AM, Stephen Warren wrote: > > On 12/26/2011 12:33 PM, Simon Glass wrote: > >> From: Yen Lin > >> >