e reservation of a specific register for it), but that the
implementation uses a register nevertheless because this results in
smaller code?
Maybe add such a comment instead ?
Thanks!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munic
a standalone app can be built without
> it.
>
> Signed-off-by: Paul Barker
> ---
> examples/standalone/hello_world.c | 1 -
> 1 file changed, 1 deletion(-)
Acked-off-by: Wolfgang Denk
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgan
inclluded. I2C was there because
it was needed for reading the environment from an EEPROM, but then
the interface was frozen ano no more new interfices / drivers should
be allowed.
Viele Grüße,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich,
Dear Paul Barker,
In message <20220505153242.1598807-2-paul.bar...@sancloud.com> you wrote:
> On 2010-01-27, an email [1] was sent to the mailing list by Wolfgang
> Denk which clarified the intended licensing exceptions for standalone
> applications. As the "export.h"
*hdr, const char *name)
> {
> - strncpy(image_get_name(hdr), name, IH_NMLEN);
> + char *hdr_name = image_get_name(hdr);
> +
> + strncpy(hdr_name, name, IH_NMLEN - 1);
> + hdr_name[IH_NMLEN - 1] = '\0';
> }
Why don't you use strlcpy() instead? This covers
u should definitely
look into it. I strongly recommend not to try to reinvent that
wheel - poorly - in U-Boot. We have been there before, and got rid
of this approach for a pretty long list of good reasons.
[1] https://sbabic.github.io/swupdate/
Best regards,
Wolfgang Denk
--
DENX Soft
Armstrong2449 (2.6%)
Michael Walle 2312 (2.4%)
Jan Kiszka2125 (2.2%)
...
Developers with the most lines removed
Tom Rini 11969 (26.1%)
Anatolij Gustschin 917 (2.0%)
Patrick Delaunay 813 (1.8%)
Eugen Hristev 526 (1.1%)
ge` to segfault.
>
> This patch removes the label for error handling and instead returns
> immediately which skips the `fclose()` and prevents the segfault. The
> errno is also described in the error message to guide users.
>
> Signed-off-by: Mattias Hansson
Reviewed-by: Wolfgang De
set(&cmd, 0, sizeof(cmd));
@@ -1616,12 +1619,6 @@ static int sb_load_cmdfile(struct sb_image_ctx *ictx)
fclose(fp);
return 0;
-
-err_file:
- fclose(fp);
- fprintf(stderr, "ERR: Failed to load file \"%s\"\n",
- ictx->cfg_filename);
_ADDR
> the size is too small then the message which says the amount of early
> data being coped will the the same as the
>
> +config CIRCBUF
> +bool
> +
> source lib/dhry/Kconfig
Please add a description what this symbos is doing.
Thanks.
Wolfgang Denk
tting the env var.
Suggestion:
Selecting this will allow the Ethernet interface to function
even when the ethaddr variable for that interface is unset.
In this case, a random MAC address in the locally
administered address space is generated. It will be saved to
this as:
=> setenv a hello
=> setenv b world
=> setenv c '${a} ${b}'
=> setenv a goodbye
=> setenv b sunshine
=> setenv foo "setenv d ${c}! ${a}..."
=> run foo
=> printenv d
d=goodbye sunshine! goodbye...
And yes, here you have
ct. Yes,
this is neither perfect nor elegant. But you can use that in C code
as well.
> will be easy get useful features via simple solution ( deep resolve
> all vars by one line )
I understand what you want, but this is not a good way to solve the
problem. I'd really rather see su
nt verion of the hush shell. As far as I
understand, Francis (added to Cc:) has started working on an update
of hush to a current version. We should rather help him with that
instead of implementing non-standard workarounds.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH,
thaddr" environment
variable which is mandatory for correct funktion (query by the user,
passing to Linux).
> So, yes, OK, this is a bug fix, in that NET_RANDOM_ETHADDR was incorrect
> at introduction. That means we do need a v2 of this patch that updates
> the Kconfig help t
ioned in the
specifications, and certainly not a mandatory feature.
That's all copy & paste garbage.
Viele Grüße,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-81
to introduce another change that we won't found out messed
> up a bunch of people on until some new work-around is accepted in to
> Linux or something.
Well, this work-around in Linux is because there have been
incnsistent ways how to store the MAC address in the device tree.
This has n
thaddr fallback in eth.c"; from the changes
then I'm not sure if this was even USB related.
> > If we use some MAC address, it shall be possible to read it using
> > "printenv ethaddr" and to set it using "setenv ethaddr". Anything
> > else is inconsistent crap.
it
invisible to the user who uses documented APIs ("printenv ethaddr").
If we use some MAC address, it shall be possible to read it using
"printenv ethaddr" and to set it using "setenv ethaddr". Anything
else is inconsistent crap.
Best regards,
Wolfgang Denk
--
DENX
the environment already.
If the MAC address is not placed in the environment, then how can a
user query the currently used MAC address? All documentation says
basically: run "printenv ethaddr".
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director
-going
> thread, perhaps "ethmacskip" should play a role in preserving existing
> behavior?
We have way too many ways to do the same thing - nearly, just a
little different :-(
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
befoire it would not
have been read by Linux, so the same should happen here.
[Here it is even less problematic as U-Boot has the very same MAC
address in it's environment.]
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Mu
OTP
> driver in U-Boot.
As Marek pointed out, in this specific case it would be best to
provide such a driver.
> From my end, I think we can conclude the discussion.
ACK.
Thanks.
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich,
environment.
Agreed.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
A girl with
ore or less a management decision how board bringup / inital
commissioning is organized.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-
lid produt data like serial number, MAC
address etc. Yes, this can be done over serial consone as well, but
1) this is slower than network and 2) many commecial products don't
have the connector etc. populated.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Directo
is indeed obvious abuse of a feature which has been designed
for a few specific use cases. It shpould be made clear that this is
nothing to select without thinking.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenst
o use the address I want to have used.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Perfection is re
. And it may be intentional to use a
random MAC address.
There is this old rule:
"UNIX was not designed to stop you from doing stupid things, because
that would also stop you from doing clever things." - Doug Gwyn
If you don't like it, then disable the feature. It is nonstand
andom MAC address is used, then this
_is_ the correct MAC address, as normally (*) U-Boot is just a tool
that does what the user requests.
(*) Exceptions are situations where U-Boot's user interfaces are
locked down for example for security reasons.
Best regards,
Wolfgang Denk
--
D
ates the
needed data, at least dummy versions of it?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
:
me other idea? I'm just thinking out loud here.
Well, why not fix the root cause?
Heiko writes that "an external HDMI firmware" is needed - so the fix
is to provide one, or at least a dummy file which is good enough for
the build to succeed. It should be trivial to cre
ithout doing this kind of workaround for the U-Boot CI.
It's not only not a perfect solution, it is the intentional
introduction of a bug, and thus totally unacceptable.
If there is a file missing in the CI, then add/create it there.
But do remove necessary error handling which would cause har
u expect when you ignore an error and
just continue with garbage data as if nothing happened?
Sorry, but this makes no sense to me. If there is an error, it
should be reported and - if possible - handled. If this is not
possible, then the correct thing is to abort. Ignoring errors and
trying to
if mkimage fails and you continue, the next step is
tools.ReadFile(output_fname) trying to read that file. How is this
possible?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
like:
foo += bar
foo += \ bar
foo += ' bar'
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80
f something else can parse it (libubootenv?) it can
> be done.
Actually I have an even more low-level approach in mind, like the
capability to include (or rather import) binary U-Boot environment
data given in the usual
=\0...=\0\0
form. This might come in handy if your data comes from export
e commit
message and in the related documentation/readme.
2) There should be another, more primitive way to generate
environment settings without these restrictions..
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich,
200
...
You don't like it? Don't do it, then.
Yes, robust programming is something different, but at that time we
were fighting for 10 or 20 byte code size - there were so many
systems where U-Boot, Linux, and root file system had to fit into
4 MB flash or so.
Best regar
legal, too), so
above line should actually set the environment variable "maximum\+"
to "value".
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)
l name character.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Q: How many IBM CPU's does
> We could update it to skip any leading space after the = I think.
So what if you need a leading space?
> I don't like spaces before the = though. It doesn't match the 'print'
> output (which has no space) and it is confusing:
env print also does not add any spaces af
ot;7".
Why not...
In the end it boils down that the file format should be properly
defined and have a clear syntax description. Apparently the
"=\0" format as used in U-Boot persistent storage
should not be taken literally here.
Best regards,
Wolfgang Denk
--
DENX Software Engineeri
d of your variables".
In which way is it worse? For esthetic reasons?
I confirm that '+=' looks better. But '+=" is technically broken.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office:
"=+" instead of "+=" as append operator do not require
such restictions.
Thus, and only for the restictions on variable names:
Naked-by: Wolfgang Denk
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Of
' maxim
> at this point.
In which way is "+=" easier to parse than "=+"? The only extension
you have to make is for the "=[^+]" case to check the first charater
of the value: if it is a backslash, then ignore it.
This has zero influence on doing this manuall
cases / side-effects / position in parsing.
I fully agree that "+=" would be nicer. But it has issues, which
"=+" does not have.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82
tuations I can think of in
a somewhat reasonable way, and it does not need to place new
restrictions on variable names.
> is very confusing.
Is it?
> Since people will be converting their out-of-tree scripts anyway, they
> can check for this sort of madness at the time. There should b
r own escape rules, for example:
var=fredassigns
var=+fred appends "fred"
var=\+fred assignes the value "+fred"
var=++fred appends "+fred"
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH,
bar.c
fred\+=aaa
-> gcc -E bar.c
# 0 "bar.c"
# 0 ""
# 0 ""
# 1 "/usr/include/stdc-predef.h" 1 3 4
# 0 "" 2
# 1 "bar.c"
fred\+=aaa
I do not see this problem...
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Mana
tually this would be also more allowing for variations in white
space, so that "=" could also be written as " =
". which in turn would allow for
foo+ = bar
vs.
foo += bar
.
Just my 2¢...
Best regards,
Wolfgang Denk
--
DENX Software Engineering Gm
sly valid
> environment variables, if this was written in Python say, would we have
> this problem?
A classic tool would be lex ...
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Gro
lash.
I would omit this as it does not provide any relevant information
here, and in addition it is misleading as it could be interpreted
that such characters are only legal at the start of the variable
name. But you can do:
=> setenv .-^-. foo
=> printenv .-^-.
.-^-.=foo
Best regard
g. This should be board//.env , right?
But that's only the cover letter...
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)
of getting the env you want
> using #define
>
> My current motivation is to complete the CONFIG migration, now in its 8th
> year.
I fully understand your motivation and appreciate your efforts.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: W
any good reason for it - yes, your awk
script cannot handle this situation, but I tend to belive the fix is
in a better parser than in placing restrictions on the input data.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, O
1 years no one has been using
> foo+bar, baz+, etc, in their variable names, maybe we just document
> that's not valid and move on?
We cannot know what people have been using in their environemnts.
Even for those boards that are in mainline, the environment settings
used in real life are often tota
m... I can't find it right now but did I not also read about other
restrictions to variable names, like they must noch begin with '_'
when using this new tool?
I feel it is wrong to place new restrictions on something that was
constant for 21 years, just because our parser cannot pa
uot;No prams or dogs or food being eaten!" I mean eating dogs is
bad enough, but eating prams? ? ?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-669
ed in the commit
message, not only in the code.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Command,
oard//.env , right?
Reviewed-by: Wolfgang Denk
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
READ T
foo\+=bar
or
foo+ = bar
?
And please see also my comments about changing the autostart
functionality for the user.
> I haven't seen any positive comments to this series yet...
Maybe many long-term users of U-Boot don't see the current situation
as such a big problem? I
d-off-by: Simon Glass
> Suggested-by: Wolfgang Denk
It should be noted that this commit changes the behaviour of U-Boot
for "autostart" users, thus it has the potential of breaking
existent systems.
The problematic cases are in do_bootelf() [cmd/elf.c] and
do_bootm_standalone() [common/boo
le in a board//env
> directory called .env (or common.env if you want the same
> environment for all boards).
Argh... did you bother to read my comments? Apparently not.
Thus:
NAKed by: Wolfgang Denk
I really think your fixed filename proposal does not work well in
reality. The file name
ting with modern scripts and does not break working
> of earlier versions of boot.scr.
Same comment as before: please document all changes, i. e. the FDT
related changes.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, O
ting with modern scripts and does not break working
> of earlier versions of boot.scr.
The patch also changes FST handling without mentioning it in the
description. Please fix.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235
".env" scheme, and "common.env" does not fit
either, as we have two "common" files.
I wonder if there should rather be a Kconfig option so each board
can select it's env file name; default would be ".env".
what do you think?
Best regards,
Wolfgang Denk
--
source.denx.de all te time, I just didn't look at the
right place.
See https://source.denx.de/u-boot/gitdm
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49
board//env/common.env" in my
.env files, your logic would trigger on the existence of
the common.env file and ignore the .env files.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groe
.de server. It was
not moved to source.denx.de
I will fix this ASAP...
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email
ARM 3 (1.6%)
Intel 3 (1.6%)
...
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142
x27; and the NUL characters.
Adding artificial restrictions now just to enable your custom
notation for appending seems not acceptable to me. You might want
to chose a different notation or implement a proper parser instead.
Thanks.
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing
nv if you want the same
> environment for all boards).
This should be no exclusive "or" here. If a common.env exists, it
should be used for all boards, and if additionally one ore more
.env files exist, these should ALSO be applied to the
respective boards.
Best regards,
W
n
> +When set to a value < 4095 the traffic over
> +Ethernet is encapsulated/received over 802.1q
> +VLAN tagged frames.
Really? I can't see where "vlan" is actually used in the code.
[I looked for it because I could not remember if the values is
interpreted
ate.
So if you think to use this for example for reliable software
updates, then you have a big problem here.
Or am I missing something?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell
ther lines. You might want to fix that, too, while we are at it?
Reviewd-by: Wolfgang Denk
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10
#x27;t trip anything up. Most
> > of the time it's not used with one either, from a quick grep.
>
> I am guessing it was left out by accident. I would not have
> intentionally done that. I can submit a patch to make it consistent
> if you want.
Yes, it should be made xonsis
Signed-off-by: Wolfgang Denk
---
arch/arm/cpu/arm926ejs/cache.c| 1 -
arch/arm/cpu/armv7/psci-common.c | 1 -
arch/arm/cpu/armv8/hisilicon/pinmux.c | 2 --
arch/arm/cpu/armv8/xen/hypercall.S
Signed-off-by: Wolfgang Denk
---
Licenses/lgpl-2.0.txt | 2 +-
Makefile | 4 ++--
arch/arm/include/asm/arch-am33xx/cpu.h| 2 +-
arch/arm/lib/lib1funcs.S | 6 +++---
arch/xtensa/include/asm/arch-de212
Signed-off-by: Wolfgang Denk
---
README| 1 -
arch/arm/mach-mvebu/serdes/a38x/high_speed_env_spec.c | 2 --
arch/xtensa/include/asm/arch-dc232b/core.h| 2 --
arch/xtensa/include/asm/arch-dc232b/tie-asm.h | 4
arch/xtensa
code changes result from this.
I am aware that such a global cosmetic cleanup is always kind of
disruptive, but we are at -rc5, so the code should be pretty stable
for now, and I've done a few rebases before, with little and easy to
fix conflicts.
Wolfgang Denk (4):
WS cleanup: r
I reckon this is a mistake and should be fixed?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
}
Hm... this is (so far) a legal command:
=> setenv foobar+ foo+=bar
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 E
ncorrect arsing.
> + # Is this the start of a new environment variable?
> + if (match($0, "^([^ =][^ =]*)=(.*)", arr)) {
This is not what you document above.
> + if (length(env) != 0) {
> + # Record the value of the variable now comple
> +gatewayip IP address of the Gateway (Router) to use
> +hostname Target hostname
> +ipaddr See above
> +netmaskSubnet Mask
> +rootpath Pathname of the root filesystem on the NFS server
> +serverip see above
> +=
rd). This algorithm uses a symetric
key
1982 and is widely used as a streaming cipher. Different key lengths
are
1983 supported by the algorithm but this command only supports 128
bits
1984 at present.
1985
Best regards,
Wolfgang Denk
--
DENX Software Engi
ll possible
> combinations.
I would recommend to define a timeout (in seconds), this is easier
to understand for the end user - without looking at the source code
they cannot know how a retry count translates into a time interval.
And yes, setting the timeout to 0 could mean it waits forever.
; changes UI interaction.
We can do both, and still solve your problem: make the timeout
adjustable so you can set it to something you can conveniently work
with.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchens
; common/xyzModem.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
Ditto here. Please don't.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-814
ary,
so I recommend NOT to change the behaviour here, especially as it
does not hurt.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)
ashes are no longer found in new
designs, nor does anybody care to keep U-Boot small and tidy.
As a result, knowledge about such optimizations is disappearing.
Hope this helps.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Muni
(say, a month or two), I will finally remove
it.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
How much net work could a network work, if a network could net work?
ot, but
> what if fixing these bugs lead to a board script failing and so a device not
> booting...
The new version should be optional in any case, at least for some
longer migration period to give users time to test their scripts.
If someone selects the new version in his board co
- Simon Glass in
> >
>
> Well you've taken it out of context :-) It would make more sense if
> you mention the need for tests
Testing can show the presense of bugs, but not their absence.
-- Edsger Dijkstr
Best regards,
Wol
users.
Wow.
I think I'll add this to my signature database:
| "Trying to catch [programming errors] in the field at runtime is not
| very kind to your users."
|
| - Simon Glass in
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wol
rors can never happen" does not seem to be a clever approach to
software engineering to me.
I stop here. You know my opinion. You are the maintainer.
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groe
we have now a policy to wave through code, and ask others to
clean it up later? That's ... sad.
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-
doing a
>
> git grep -10 -E 'dev_get(_uclass)?_priv'
>
> and see how many cases you can find where that is followed by a NULL check?
The existence of bad code is not a justification to add more of it.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Manag
t;always_running = dev_read_bool(dev, "always-running");
Ditto.
> + ret = gpio_request_by_name(dev, "gpios", 0, &priv->gpio, GPIOD_IS_OUT);
> + if (ret < 0) {
> + dev_err(dev, "Request for wdt gpio failed: %d\n", ret);
> +
turn;
Do I see this crrectly that you remove here the code which you just
added in patch 02 of this series?
Why not doing it right from the beginning?
> + uclass_foreach_dev(dev, uc) {
> + if (!device_active(dev))
> + continue;
> + priv =
1 - 100 of 16790 matches
Mail list logo
