Dear Simon, In message <CAPnjgZ1tRi5SsqU0K8HXgj-4xCs7i9TLX4Mj0_D=cpj8ban...@mail.gmail.com> you wrote: > > > > Add a feature that brings in a .env file associated with the board > > > config, if present. To use it, create a file in a board/<vendor>/env > > > directory called <board>.env (or common.env if you want the same > > > environment for all boards). > > > > This should be no exclusive "or" here. If a common.env exists, it > > should be used for all boards, and if additionally one ore more > > <board>.env files exist, these should ALSO be applied to the > > respective boards. > > Is it not enough to use #include in the main file? We have a similar > feature with the u-boot.dtsi files and in that case we only choose the > most specific.
1) This requires that the .env files are run through CPP, which is only added in a later patch. 2) Even if I add an "#include board/<vendor>/env/common.env" in my <board>.env files, your logic would trigger on the existence of the common.env file and ignore the <board>.env files. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Work 8 hours, sleep 8 hours; but not the same 8 hours.
