Re: [PATCH] net: fsl_enetc: fix imdio register calculation

2025-04-28 Thread Vladimir Oltean
priv->imdio.read = enetc_mdio_read; > > priv->imdio.write = enetc_mdio_write; > > - priv->imdio.priv = priv->port_regs + ENETC_PM_IMDIO_BASE; > > + priv->imdio.priv = priv->port_regs + data->reg_offset_mac + > > + ENETC_PM_IMDIO_BASE; > > strlcpy(priv->imdio.name, dev->name, MDIO_NAME_LEN); > > if (!miiphy_get_dev_by_name(priv->imdio.name)) > > mdio_register(&priv->imdio); > Reviewed-by: Vladimir Oltean Tested-by: Vladimir Oltean # LS1028A +Fang Wei to confirm/test for i.MX95.

Re: [PATCH v1 2/6] net: mv88e61xx: Configure PHY ports to also pass packets between them

2023-06-01 Thread Vladimir Oltean
Hi Lukasz, On Thu, Jun 01, 2023 at 01:44:30PM +0200, Marek Vasut wrote: > I think after two years, it would be good to drop the RB tags and do another > round of reviews. To expand on Marek's point. In those past 2 years, Tim Harvey has put in a considerable amount of effort to add another drive

Re: [PATCH 01/41] net: phy: aquantia: Staticize PHY driver entries

2023-03-21 Thread Vladimir Oltean
On Tue, Mar 21, 2023 at 03:39:16PM +0100, Michal Simek wrote: > Would be good if you also create cover letter which I can reply. > I have tested this series on Microblaze which is also using MANUAL > relocation (but we are removing it from 2023.07 release) and it is working > fine. Agree that a co

[PATCH] configs: convert NXP LS1028A RDB and QDS to DM_SERIAL

2023-03-15 Thread Vladimir Oltean
touch that. Signed-off-by: Vladimir Oltean --- configs/ls1028aqds_tfa_SECURE_BOOT_defconfig | 3 ++- configs/ls1028aqds_tfa_defconfig | 3 ++- configs/ls1028ardb_tfa_SECURE_BOOT_defconfig | 3 ++- configs/ls1028ardb_tfa_defconfig | 3 ++- 4 files changed, 8 insertions(

Re: [PATCH 5/5] configs: ls208x: enable DM_SERIAL

2023-03-13 Thread Vladimir Oltean
und this part of the change to be unexpected, but an offline discussion with Ioana informed me that this line automatically goes away after a "make savedefconfig". That being said: Reviewed-by: Vladimir Oltean

Re: [PATCH 3/5] arch: arm: dst: fsl-ls2080a.dts: sync serial nodes with Linux

2023-03-13 Thread Vladimir Oltean
On Tue, Feb 28, 2023 at 06:32:10PM +0200, Ioana Ciornei wrote: > Sync the serial nodes of the LS208XA RDB/QDS boards with their > representation in Linux. We also imported the clockgen and sysclk nodes > which are dependencies. > > Signed-off-by: Ioana Ciornei > --- Reviewed-by: Vladimir Oltean

Re: [PATCH 2/5] arch: arm: dst: fsl-ls2080a.dtsi: move the serial nodes under soc

2023-03-13 Thread Vladimir Oltean
dst" instead of "dts". Otherwise: Reviewed-by: Vladimir Oltean

Re: [PATCH 1/5] arch: arm: dst: fsl-ls2080a.dtsi: add an 'soc' node

2023-03-13 Thread Vladimir Oltean
: Ioana Ciornei > --- Reviewed-by: Vladimir Oltean

Re: [PATCH] ls1021atsn: Suggest the NXP RCW github repo

2023-01-13 Thread Vladimir Oltean
d will be deleted on March 31, 2023." > > Point to the NXP RCW github repo instead. > > Signed-off-by: Fabio Estevam > --- Reviewed-by: Vladimir Oltean

Re: [PATCH v9 0/8] Add MV88E6xxx DSA driver and use on gwventana

2022-11-30 Thread Vladimir Oltean
On Wed, Nov 30, 2022 at 03:27:04PM -0800, Tim Harvey wrote: > That's the same head that I based them off of and I just did the > following and it worked fine: > cd /tmp > git clone git://git.denx.de/u-boot.git > cd u-boot > wget https://patchwork.ozlabs.org/series/330704/mbox/ -O mbox > git am mbox

Re: [PATCH v9 0/8] Add MV88E6xxx DSA driver and use on gwventana

2022-11-30 Thread Vladimir Oltean
On Wed, Nov 30, 2022 at 09:42:43AM -0800, Tim Harvey wrote: > This series adds a DSA driver for the MV88E6xxx based on > drivers/net/phy/mv88e61xx and uses it in the gwventana_gw5904_defconfig. I can't apply the patches on the current master, am I doing something wrong? $ git reset --hard origin/

Re: [PATCH v8 4/8] net: dsa: allow rcv() and xmit() to be optional

2022-11-30 Thread Vladimir Oltean
On Tue, Nov 29, 2022 at 04:58:33PM -0800, Tim Harvey wrote: > Yes, it makes sense. How about the following patch instead: > > diff --git a/net/dsa-uclass.c b/net/dsa-uclass.c > index 211a991cdd0d..1ae9adc66eda 100644 > --- a/net/dsa-uclass.c > +++ b/net/dsa-uclass.c > @@ -142,6 +142,9 @@ static in

Re: [PATCH v8 4/8] net: dsa: allow rcv() and xmit() to be optional

2022-11-29 Thread Vladimir Oltean
; > does not care to mangle a packet as in U-Boot only one network port is > > > enabled at a time and thus no packet mangling is necessary. > > > > > > Suggested-by: Vladimir Oltean > > > Signed-off-by: Tim Harvey > > > Reviewed-by: Vladimir Olt

Re: [PATCH v8 0/8] Add MV88E6xxx DSA driver and use on gwventana

2022-10-28 Thread Vladimir Oltean
On Thu, Oct 27, 2022 at 05:49:29PM -0700, Tim Harvey wrote: > This series adds a DSA driver for the MV88E6xxx based on > drivers/net/phy/mv88e61xx and uses it in the gwventana_gw5904_defconfig. Looks good, thanks. To me this is ready to go!

Re: [PATCH v7 7/8] net: add MV88E6xxx DSA driver

2022-10-27 Thread Vladimir Oltean
On Wed, Oct 26, 2022 at 01:59:19PM -0700, Tim Harvey wrote: > not sure honestly - it's in the original drivers/net/phy/mv88e61xxx.c > driver that I based this one off of. You keep saying this; it doesn't matter where it comes from, the point is whether it's useful to keep it in a new driver or not

Re: [PATCH v7 7/8] net: add MV88E6xxx DSA driver

2022-10-26 Thread Vladimir Oltean
This patch looks much better to me. Only one comment. On Wed, Oct 26, 2022 at 09:28:58AM -0700, Tim Harvey wrote: > +static int mv88e6xxx_port_enable(struct udevice *dev, int port, struct > phy_device *phy) > +{ > + struct mv88e6xxx_priv *priv = dev_get_priv(dev); > + int val, ret; > + >

Re: [PATCH v7 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-26 Thread Vladimir Oltean
After the realization from the v6 review, can you please add to this: On Wed, Oct 26, 2022 at 09:28:59AM -0700, Tim Harvey wrote: > diff --git a/arch/arm/dts/imx6qdl-gw5904.dtsi > b/arch/arm/dts/imx6qdl-gw5904.dtsi > index 612b6e068e28..c0790183c013 100644 > --- a/arch/arm/dts/imx6qdl-gw5904.dtsi

Re: [PATCH v6 7/8] net: add MV88E61xx DSA driver

2022-10-26 Thread Vladimir Oltean
Sorry for the late reply. On Thu, Oct 13, 2022 at 11:09:32AM -0700, Tim Harvey wrote: > The SERDES configuration on the 88E6352/88E6240/88E6176/88E6172 (which > I have documentation for) is not in port specific registers so I think > I should move that to the probe function for the switch. It's n

Re: [PATCH v6 7/8] net: add MV88E61xx DSA driver

2022-10-12 Thread Vladimir Oltean
On Mon, Oct 10, 2022 at 09:39:43AM -0700, Tim Harvey wrote: > Add a DSA driver for the MV88E6xxx compatible Ethernet switches. > > Cc: Marek BehĂșn > Cc: Vladimir Oltean > Signed-off-by: Tim Harvey > Reviewed-by: Vladimir Oltean > Reviewed-by: Fabio Estevam > --- >

Re: [PATCH v6 8/8] board: gw_ventana: enable MV88E6XXX DSA support

2022-10-12 Thread Vladimir Oltean
te defconfig to remove old driver and enable new one > - replace mv88e61xx_hw_reset weak override with board_phy_config support >for register configuration that is outside the scope of the DSA driver > > Signed-off-by: Tim Harvey > Reviewed-by: Fabio Estevam > --- Reviewed-by: Vladimir Oltean

Re: [PATCH v6 4/8] net: dsa: allow rcv() and xmit() to be optional

2022-10-12 Thread Vladimir Oltean
Hi Simon, On Mon, Oct 10, 2022 at 04:25:29PM -0600, Simon Glass wrote: > Hi Tim, > > On Mon, 10 Oct 2022 at 10:40, Tim Harvey wrote: > > > > Allow rcv() and xmit() dsa driver ops to be optional in case a driver > > does not care to mangle a packet as in U-Boot only one network port is > > enable

Re: [PATCH v5 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-04 Thread Vladimir Oltean
On Tue, Oct 04, 2022 at 09:49:18AM -0700, Tim Harvey wrote: > Add MV88E61XX DSA support: > - update dt: U-Boot dsa driver requires different device-tree syntax >than the linux driver in order to link the dsa ports to the mdio bus. Not really correct. Better said, U-Boot requires a more restri

Re: [PATCH v5 7/8] net: add MV88E61xx DSA driver

2022-10-04 Thread Vladimir Oltean
Please also rewrite "61xx" from the commit message into "6xxx". On Tue, Oct 04, 2022 at 09:49:17AM -0700, Tim Harvey wrote: > Add a DSA driver for the MV88E61xx compatible GbE Ethernet switches. > > Cc: Marek BehĂșn > Cc: Vladimir Oltean > Signed-off-by:

Re: [PATCH v5 2/8] net: dsa: move cpu port probe to dsa_post_probe

2022-10-04 Thread Vladimir Oltean
On Tue, Oct 04, 2022 at 09:49:12AM -0700, Tim Harvey wrote: > diff --git a/net/dsa-uclass.c b/net/dsa-uclass.c > index 5b7046432ff3..a37e76e25a8f 100644 > --- a/net/dsa-uclass.c > +++ b/net/dsa-uclass.c > @@ -466,7 +466,6 @@ static int dsa_pre_probe(struct udevice *dev) > +static int dsa_post_probe

Re: [PATCH v3 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-06-24 Thread Vladimir Oltean
On Fri, Jun 24, 2022 at 04:16:34PM -0700, Tim Harvey wrote: > On Fri, Jun 24, 2022 at 3:25 AM Vladimir Oltean > wrote: > > > > On Mon, May 23, 2022 at 11:25:49AM -0700, Tim Harvey wrote: > > > Add MV88E61XX DSA support: > > > - update dt: U-Boot dsa driver r

Re: [PATCH v3 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-06-24 Thread Vladimir Oltean
On Mon, May 23, 2022 at 11:25:49AM -0700, Tim Harvey wrote: > Add MV88E61XX DSA support: > - update dt: U-Boot dsa driver requires different device-tree syntax >than the linux driver in order to link the dsa ports to the mdio bus. > - update defconfig > - replace mv88e61xx_hw_reset weak over

Re: [PATCH v3 7/8] net: add MV88E61xx DSA driver

2022-06-23 Thread Vladimir Oltean
On Tue, Jun 21, 2022 at 08:11:06AM -0700, Tim Harvey wrote: > On Tue, Jun 21, 2022 at 12:21 AM Vladimir Oltean > wrote: > > > > On Mon, Jun 20, 2022 at 04:37:45PM -0700, Tim Harvey wrote: > > > On Mon, Jun 20, 2022 at 4:58 AM Vladimir Oltean > > > wrote: >

Re: [PATCH v3 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-06-23 Thread Vladimir Oltean
On Tue, Jun 21, 2022 at 09:57:35AM -0700, Tim Harvey wrote: > > > diff --git a/board/gateworks/gw_ventana/gw_ventana.c > > > b/board/gateworks/gw_ventana/gw_ventana.c > > > index c06630a66b66..bef3f7ef0d2b 100644 > > > --- a/board/gateworks/gw_ventana/gw_ventana.c > > > +++ b/board/gateworks/gw_ve

Re: [PATCH v3 7/8] net: add MV88E61xx DSA driver

2022-06-21 Thread Vladimir Oltean
On Mon, Jun 20, 2022 at 04:37:45PM -0700, Tim Harvey wrote: > On Mon, Jun 20, 2022 at 4:58 AM Vladimir Oltean > wrote: > > > > On Mon, May 23, 2022 at 11:25:48AM -0700, Tim Harvey wrote: > > > +/* bind and probe the switch mdios */ > > > +static int mv88e61x

Re: [PATCH v3 7/8] net: add MV88E61xx DSA driver

2022-06-20 Thread Vladimir Oltean
On Mon, May 23, 2022 at 11:25:48AM -0700, Tim Harvey wrote: > Add a DSA driver for the MV88E61xx compatible GbE Ethernet switches. > > Cc: Marek BehĂșn > Cc: Vladimir Oltean > Signed-off-by: Tim Harvey > Reviewed-by: Vladimir Oltean > --- > v3: > - Added Vladimir

Re: [PATCH v3 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-06-20 Thread Vladimir Oltean
On Mon, May 23, 2022 at 11:25:49AM -0700, Tim Harvey wrote: > Add MV88E61XX DSA support: > - update dt: U-Boot dsa driver requires different device-tree syntax >than the linux driver in order to link the dsa ports to the mdio bus. > - update defconfig > - replace mv88e61xx_hw_reset weak over

Re: [PATCH v3 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-06-14 Thread Vladimir Oltean
Hi Tim, On Tue, Jun 14, 2022 at 10:00:57AM -0700, Tim Harvey wrote: > Vladimir, > > I'm not sure if you've had a chance to look at this latest patch > revision yet. I believe above is what you were describing as the > correct way to do this (without modifying the Linux driver and > improving bind

Re: [PATCH] net: phy: Remove inline definitions from convinience functions

2022-06-08 Thread Vladimir Oltean
gt; > Signed-off-by: Ramon Fried > --- Reviewed-by: Vladimir Oltean

Re: [PATCH] phy: dp83867: add dp83867_{read,write}_mmd helpers

2022-05-24 Thread Vladimir Oltean
On Tue, May 24, 2022 at 01:31:41PM +0200, Rasmus Villemoes wrote: > On 19/05/2022 16.38, Vladimir Oltean wrote: > > Hi Rasmus, > > > > On Tue, May 17, 2022 at 04:27:06PM +0200, Rasmus Villemoes wrote: > >> Since the phy_{read,write}_mmd functions are static inlines

Re: [PATCH] phy: dp83867: add dp83867_{read,write}_mmd helpers

2022-05-19 Thread Vladimir Oltean
Hi Rasmus, On Tue, May 17, 2022 at 04:27:06PM +0200, Rasmus Villemoes wrote: > Since the phy_{read,write}_mmd functions are static inlines using > other static inline functions, they cause code using them to explode. > > Defining local wrappers cuts the size of the generated code by 50%: > > $ s

Re: [PATCH 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-05-19 Thread Vladimir Oltean
Hi Tim, On Wed, May 18, 2022 at 09:15:26AM -0700, Tim Harvey wrote: > On Wed, May 18, 2022 at 7:41 AM Vladimir Oltean > wrote: > > > > On Wed, May 11, 2022 at 05:20:03PM -0700, Tim Harvey wrote: > > > Add MV88E61XX DSA support: > > > - update dt: U-Boot

Re: [PATCH] phy: Fix phy_string_for_interface() function

2022-05-19 Thread Vladimir Oltean
On Thu, May 19, 2022 at 02:49:12PM +0200, Pali Rohár wrote: > Commit c677fb1e3196 ("phy: Move PHY_INTERFACE_MODE_NA to the beginning of > the enum definition") broke function phy_string_for_interface(). And > therefore completely broke support for 2500base-x mode in Armada 3720 > comphy driver. >

Re: [PATCH 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-05-18 Thread Vladimir Oltean
On Wed, May 11, 2022 at 05:20:03PM -0700, Tim Harvey wrote: > Add MV88E61XX DSA support: > - update dt: U-Boot dsa driver requires different device-tree syntax >than the linux driver in order to link the dsa ports to the mdio bus. > - update defconfig > - replace mv88e61xx_hw_reset weak over

Re: [PATCH 7/8] net: add MV88E61xx DSA driver

2022-05-18 Thread Vladimir Oltean
On Wed, May 11, 2022 at 05:20:02PM -0700, Tim Harvey wrote: > Add a DSA driver for the MV88E61xx compatible GbE Ethernet switches. > > Cc: Marek BehĂșn > Cc: Vladimir Oltean > Signed-off-by: Tim Harvey > --- > v2: > - rebase on v2022.07-rc1 (use ofnode_get_phy_

Re: [PATCH 3/8] net: dsa: ensure dsa driver has proper ops

2022-05-18 Thread Vladimir Oltean
On Wed, May 11, 2022 at 05:19:58PM -0700, Tim Harvey wrote: > Add a function to sanity check a dsa driver having proper ops. > > Suggested-by: Vladimir Oltean > Signed-off-by: Tim Harvey > --- Reviewed-by: Vladimir Oltean

Re: [PATCH 4/8] net: dsa: allow rcv() and xmit() to be optional

2022-05-18 Thread Vladimir Oltean
ed-by: Vladimir Oltean > Signed-off-by: Tim Harvey > --- Reviewed-by: Vladimir Oltean

Re: [PATCH 5/8] net: ksz9477: remove unnecessary xmit and recv functions

2022-05-18 Thread Vladimir Oltean
On Wed, May 11, 2022 at 05:20:00PM -0700, Tim Harvey wrote: > Remove the unnecessary xmit and recv functions. > > Signed-off-by: Tim Harvey > --- Reviewed-by: Vladimir Oltean

Re: [PATCH 2/8] net: dsa: move cpu port probe to dsa_post_probe

2022-05-18 Thread Vladimir Oltean
On Wed, May 11, 2022 at 05:19:57PM -0700, Tim Harvey wrote: > In order to ensure that a DSA driver probe gets called before > dsa_ops->port_probe move the port_probe of the cpu_port to > a post-probe function. > > Signed-off-by: Tim Harvey > Reviewed-by: Ramon Fried > --

Re: [PATCH v4 07/16] net: dsa: Fix segmentation fault if master fails to probe

2022-05-18 Thread Vladimir Oltean
the master's private data. This is only safe to do if the master > has been probed first. Fix this by probing the master after we look it > up, and bailing out if we get an error. > > Fixes: fc054d563b ("net: Introduce DSA class for Ethernet switches") > Signed-off-by: S

Re: [PATCH] ls1028a: hdp: Add config support for HDP firmware loading

2022-05-10 Thread Vladimir Oltean
On Tue, May 10, 2022 at 04:18:32PM +0200, Michael Walle wrote: > > From: Alison Wang > > > > This patch adds config support for HDP firmware loading on LS1028A. > > FWIW, I really don't like this as this is just for a downstream kernel. This => what? I only see a config option. I searched the l

Re: [PATCH 5/6] net: add MV88E61xx DSA driver

2022-04-12 Thread Vladimir Oltean
On Tue, Mar 29, 2022 at 03:52:39PM -0700, Tim Harvey wrote: > Add a DSA driver for the MV88E61xx compatible GbE Ethernet switches. > > Signed-off-by: Tim Harvey > --- > drivers/net/Kconfig | 7 + > drivers/net/Makefile| 1 + > drivers/net/mv88e61xx.c | 982 +++

Re: [PATCH 2/2] net: phy: atheros: avoid error in ar803x_of_init() when PHY has no OF node

2022-04-08 Thread Vladimir Oltean
Hi Ramon, On Fri, Apr 01, 2022 at 10:11:13PM +0300, Ramon Fried wrote: > On Thu, Mar 3, 2022 at 9:53 AM Ramon Fried wrote: > > Reviewed-by: Ramon Fried > Applied to u-boot-net/next > Thanks, > Ramon Did you push this commit anywhere? I don't see it here https://source.denx.de/u-boot/custodians/

Re: [PATCH 5/6] net: add MV88E61xx DSA driver

2022-04-07 Thread Vladimir Oltean
On Thu, Apr 07, 2022 at 01:33:58PM -0700, Tim Harvey wrote: > I guess I'll have to invest in tagging packets if you won't accept the > simplistic approach of not having to tag frames knowing that only one > port is active at a time. I genuinely don't know where you got the impression from that I d

Re: [PATCH u-boot-net v3 14/14] net: phy: don't require PHY interface mode during PHY creation

2022-04-06 Thread Vladimir Oltean
= value from phy_find_by_mask call. > > Signed-off-by: Marek Behún > Reviewed-by: Ramon Fried > --- Reviewed-by: Vladimir Oltean

Re: [PATCH u-boot-net v3 09/14] treewide: Rename PHY_INTERFACE_MODE_NONE to PHY_INTERFACE_MODE_NA

2022-04-06 Thread Vladimir Oltean
> Reviewed-by: Ramon Fried > --- Reviewed-by: Vladimir Oltean

Re: [PATCH u-boot-net v3 08/14] treewide: Rename PHY_INTERFACE_MODE_COUNT to PHY_INTERFACE_MODE_MAX

2022-04-06 Thread Vladimir Oltean
On Tue, Mar 29, 2022 at 10:08:39PM +0200, Marek Behún wrote: > From: Marek Behún > > Rename constant PHY_INTERFACE_MODE_COUNT to PHY_INTERFACE_MODE_MAX to > make it compatible with Linux' naming. > > Signed-off-by: Marek Behún > Reviewed-by: Stefan Roese > --- Reviewed-by: Vladimir Oltean

Re: [PATCH u-boot-net v3 06/14] net: phy: fix parsing wrong property

2022-04-06 Thread Vladimir Oltean
On Tue, Mar 29, 2022 at 10:08:37PM +0200, Marek Behún wrote: > From: Marek Behún > > The "phy-interface-type" property should be "phy-connection-type". > > Signed-off-by: Marek Behún > Reviewed-by: Ramon Fried > --- Reviewed-by: Vladimir Oltean

Re: [PATCH u-boot-net v3 05/14] treewide: use dm_mdio_read/write/reset() wrappers

2022-04-06 Thread Vladimir Oltean
iewed-by: Ramon Fried > --- Reviewed-by: Vladimir Oltean

Re: [PATCH u-boot-net v3 04/14] net: mdio-uclass: add wrappers for read/write/reset operations

2022-04-06 Thread Vladimir Oltean
Fried > --- Reviewed-by: Vladimir Oltean

Re: [PATCH u-boot-net v3 02/14] net: mdio-uclass: use ARRAY_SIZE()

2022-04-06 Thread Vladimir Oltean
On Tue, Mar 29, 2022 at 10:08:33PM +0200, Marek Behún wrote: > From: Marek Behún > > Use the ARRAY_SIZE() macro instead of hardcoding sizes of arrays in > macros. > > Signed-off-by: Marek Behún > --- Reviewed-by: Vladimir Oltean > net/mdio-uclass.c | 11 +---

Re: [PATCH u-boot-net v3 01/14] net: mdio-uclass: fix type for phy_mode_str and phy_handle_str

2022-04-06 Thread Vladimir Oltean
On Tue, Mar 29, 2022 at 10:08:32PM +0200, Marek Behún wrote: > From: Marek Behún > > These global variables should both have type > static const char * const > > Signed-off-by: Marek Behún > Reviewed-by: Ramon Fried > --- Reviewed-by: Vladimir Oltean &

Re: [PATCH 5/6] net: add MV88E61xx DSA driver

2022-04-02 Thread Vladimir Oltean
On Fri, Apr 01, 2022 at 01:24:48PM -0700, Tim Harvey wrote: > > > > Why is mv88e61xx_dsa_xmit() no-op? > > > > > > For DSA dsa-uclass calls the switch master eth device send function > > > after calling the dsa_ops->xmit function so that a dsa driver can add > > > any header/footer if needed. The f

Re: [PATCH 4/6] net: fec: add support for DM_MDIO

2022-04-01 Thread Vladimir Oltean
On Fri, Apr 01, 2022 at 10:53:14AM -0700, Tim Harvey wrote: > Can you review 'net: add MV88E61xx DSA driver' for me? I will. I've been thinking all day today about what to say that isn't stupid. Give me some time and I'll provide feedback.

Re: [PATCH 4/6] net: fec: add support for DM_MDIO

2022-03-31 Thread Vladimir Oltean
On Thu, Mar 31, 2022 at 10:48:55AM -0700, Tim Harvey wrote: > > On which branch does this apply? The context above fecmxc_read_rom_hwaddr() > > is different in the branches I've checked: > > https://source.denx.de/u-boot/u-boot/-/blob/master/drivers/net/fec_mxc.c#L1276 > > https://source.denx.de/u-

Re: [PATCH 4/6] net: fec: add support for DM_MDIO

2022-03-31 Thread Vladimir Oltean
On Tue, Mar 29, 2022 at 03:52:38PM -0700, Tim Harvey wrote: > Add support for DM_MDIO by registering a UCLASS_MDIO driver and > attempting to use it. This is necessary if wanting to use a DSA > driver for example hanging off of the FEC MAC. > > Care is taken to fallback to non DM_MDIO as several b

Re: [PATCH 1/2] net: dsa: fix phydev->speed being uninitialized for the CPU port fixed PHY

2022-03-28 Thread Vladimir Oltean
On Mon, Mar 28, 2022 at 03:23:02PM -0700, Tim Harvey wrote: > On Mon, Mar 28, 2022 at 2:26 AM Vladimir Oltean > wrote: > > > > On Fri, Mar 25, 2022 at 02:03:56PM -0700, Tim Harvey wrote: > > > On Fri, Mar 25, 2022 at 11:07 AM Vladimir Oltean > >

Re: [PATCH 1/2] net: dsa: fix phydev->speed being uninitialized for the CPU port fixed PHY

2022-03-28 Thread Vladimir Oltean
On Fri, Mar 25, 2022 at 02:03:56PM -0700, Tim Harvey wrote: > On Fri, Mar 25, 2022 at 11:07 AM Vladimir Oltean > wrote: > > > > Hi Tim, > > > > On Fri, Mar 25, 2022 at 09:53:20AM -0700, Tim Harvey wrote: > > > Vladimir, > > > > > > I came

Re: [PATCH 1/2] net: dsa: fix phydev->speed being uninitialized for the CPU port fixed PHY

2022-03-25 Thread Vladimir Oltean
Hi Tim, On Fri, Mar 25, 2022 at 09:53:20AM -0700, Tim Harvey wrote: > Vladimir, > > I came across this while looking for the best place to configure cpu > port interface mode (ie rgmii id) for the mv88e61xx dsa driver I'm > working on. Note that this patch causes port_probe to be called on the >

[PATCH] video: sandbox: fix missing shim definition of sandbox_sdl_remove_display()

2022-03-11 Thread Vladimir Oltean
Fixes: 8657ad43f353 ("sandbox: video: Add BMP tests for 32bpp and 8bpp modes") Signed-off-by: Vladimir Oltean --- I see Simon's email on the list from January 10 saying: | I see that I broke it...it needs a static inline for | sandbox_sdl_remove_display(). https://lore.kernel.org/all/CAPn

Re: dsa driver for mv88e61xx

2022-03-11 Thread Vladimir Oltean
Hello Tim, On Fri, Mar 11, 2022 at 08:41:48AM -0800, Tim Harvey wrote: > On Thu, Mar 10, 2022 at 3:18 PM Vladimir Oltean wrote: > > > > On Thu, Mar 10, 2022 at 02:35:21PM -0800, Tim Harvey wrote: > > > On Thu, Mar 10, 2022 at 8:50 AM Vladimir Oltean wrote: &

Re: dsa driver for mv88e61xx

2022-03-10 Thread Vladimir Oltean
On Thu, Mar 10, 2022 at 02:35:21PM -0800, Tim Harvey wrote: > On Thu, Mar 10, 2022 at 8:50 AM Vladimir Oltean wrote: > > > > Hello Tim, > > > > On Thu, Mar 10, 2022 at 08:16:13AM -0800, Tim Harvey wrote: > > > Greetings, > > > > > > I wanted

Re: dsa driver for mv88e61xx

2022-03-10 Thread Vladimir Oltean
Hello Tim, On Thu, Mar 10, 2022 at 08:16:13AM -0800, Tim Harvey wrote: > Greetings, > > I wanted to take a stab at adding dsa support for the mv88e61xx which > currently has a driver in drivers/net/phy [1]. The board I have > available to me is the gw5904 which has a mv88e6085 with the upstream >

[PATCH 2/2] net: phy: atheros: avoid error in ar803x_of_init() when PHY has no OF node

2022-02-23 Thread Vladimir Oltean
vention. Fixes: fe6293a80959 ("phy: atheros: add device tree bindings and config") Signed-off-by: Vladimir Oltean --- drivers/net/phy/atheros.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index f922fecd6b5d..fa1fe08518f4

[PATCH 1/2] net: phy: dp83867: avoid error in dp83867_of_init() when PHY has no OF node

2022-02-23 Thread Vladimir Oltean
extra initialization steps which are bypassed when the PHY lacks an OF node, which is undesirable because it will lead to broken networking. Allow the rest of the code to run. Fixes: 085445ca4104 ("net: phy: ti: Allow the driver to be more configurable") Signed-off-by: Vladimir Oltean --- drivers/n

[PATCH 0/2] PHY of_init breakage with non-OF

2022-02-23 Thread Vladimir Oltean
phy_connect(). I've fixed this in the Atheros driver, and also saw the same issue in the TI PHY driver, so I fixed it there as well. Vladimir Oltean (2): net: phy: dp83867: avoid error in dp83867_of_init() when PHY has no OF node net: phy: atheros: avoid error in ar803x_of_init() when PH

Re: [PATCH 2/2] scsi: ceva: Enable PHY and reset support

2022-01-31 Thread Vladimir Oltean
60-revA with sata connector > populated. > > Signed-off-by: Michal Simek > --- Reviewed-by: Vladimir Oltean > > drivers/ata/sata_ceva.c | 44 + > 1 file changed, 44 insertions(+) > > diff --git a/drivers/ata/sata_ceva.c b/

[PATCH v3 16/16] arm: dts: ls1028a-qds: declare in-band autoneg for Ethernet ports

2022-01-03 Thread Vladimir Oltean
ust enable in-band autoneg to fix the breakage. Fixes: e3789a726269 ("net: dsa: felix: configure the in-band autoneg property based on OF node info") Cc: Ramon Fried Signed-off-by: Vladimir Oltean Reviewed-by: Priyanka Jain --- v1->v3: none arch/arm/dts/fsl-ls1028a-qds-1xxx-

[PATCH v3 15/16] arm: dts: ls1028a-rdb: sync device tree with Linux

2022-01-03 Thread Vladimir Oltean
;arm64: dts: ls1028a: add ftm_alarm1 node to be used as wakeup source") b2e2d3e02fb6 ("arm64: dts: ls1028a-rdb: enable pwm0") These will be picked up on the next resync. Signed-off-by: Vladimir Oltean Reviewed-by: Priyanka Jain --- v1->v2: RTC compatible string change broken

[PATCH v3 13/16] arm: dts: ls1028a-rdb: disable I2C buses 1 through 7

2022-01-03 Thread Vladimir Oltean
There is no I2C peripheral on these buses on the reference design board, and the Linux device tree does not enable them either. Signed-off-by: Vladimir Oltean Reviewed-by: Priyanka Jain --- v1->v3: none arch/arm/dts/fsl-ls1028a-rdb.dts | 28 1 file changed,

[PATCH v3 12/16] arm: dts: ls1028a-rdb: disable DSPI nodes

2022-01-03 Thread Vladimir Oltean
There is no SPI peripheral on the LS1028A-RDB, therefore no reason to enable these nodes in the U-Boot device tree (and Linux does not enable them either). Signed-off-by: Vladimir Oltean Reviewed-by: Priyanka Jain --- v1->v3: none arch/arm/dts/fsl-ls1028a-rdb.dts | 12 1 f

[PATCH v3 14/16] arm: dts: ls1028a-rdb: enable PCIe controllers from U-Boot dtsi

2022-01-03 Thread Vladimir Oltean
way, the existing Linux device tree can simply be dropped in. Signed-off-by: Vladimir Oltean --- v2->v3: stop including the -u-boot.dtsi by hand, it gets included automatically arch/arm/dts/fsl-ls1028a-rdb-u-boot.dtsi | 15 +++ arch/arm/dts/fsl-ls1028a-rdb.dts |

[PATCH v3 10/16] arm: dts: ls1028a-rdb: sort nodes alphabetically

2022-01-03 Thread Vladimir Oltean
The nodes in the NXP LS1028A-RDB device tree are out of order, regroup them alphabetically to have a simple delta when the Linux device tree is brought in. Signed-off-by: Vladimir Oltean Reviewed-by: Priyanka Jain --- v1->v3: none arch/arm/dts/fsl-ls1028a-rdb.dts |

[PATCH v3 11/16] arm: dts: ls1028a-rdb: sync Ethernet device tree nodes with Linux

2022-01-03 Thread Vladimir Oltean
esolves that issue. The device tree update also renames the Ethernet PHY labels. Fixes: e3789a726269 ("net: dsa: felix: configure the in-band autoneg property based on OF node info") Cc: Ramon Fried Signed-off-by: Vladimir Oltean Reviewed-by: Priyanka Jain --- v1->v3: none a

[PATCH v3 08/16] arm: dts: lx2160a-rdb: use Linux compatible string for RTC

2022-01-03 Thread Vladimir Oltean
: Vladimir Oltean Reviewed-by: Priyanka Jain --- v1->v3: none arch/arm/dts/fsl-lx2160a-rdb.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/fsl-lx2160a-rdb.dts b/arch/arm/dts/fsl-lx2160a-rdb.dts index 5fbdd907017c..8ca4afa7eaea 100644 --- a/arch/arm/dts/

[PATCH v3 09/16] rtc: pcf2127: remove U-Boot specific compatible string

2022-01-03 Thread Vladimir Oltean
Now that all in-tree boards have been converted to the compatible strings from Linux, delete the support for the ad-hoc "pcf2127-rtc" one. Cc: Simon Glass Signed-off-by: Vladimir Oltean Reviewed-by: Simon Glass --- v1->v3: none drivers/rtc/pcf2127.c | 1 - 1 file changed, 1 dele

[PATCH v3 07/16] arm: dts: ls1028a-rdb: use Linux compatible string for RTC

2022-01-03 Thread Vladimir Oltean
During this board's sync with Linux device trees, it was observed that it doesn't use the same compatible string for the RTC node as in U-Boot. This change makes the RTC compatible strings match, for a smoother sync. Signed-off-by: Vladimir Oltean --- v1->v2: patch is new v2->v3:

[PATCH v3 06/16] arm: dts: ls1028a-qds: use Linux compatible string for RTC

2022-01-03 Thread Vladimir Oltean
is used in both places. This change updates the RTC from the QDS to use the compatible string that was established in Linux. Signed-off-by: Vladimir Oltean Reviewed-by: Priyanka Jain --- v1->v3: none arch/arm/dts/fsl-ls1028a-qds.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v3 05/16] arm: dts: lx2160a-qds: use Linux compatible string for RTC

2022-01-03 Thread Vladimir Oltean
: Vladimir Oltean Reviewed-by: Priyanka Jain --- v1->v3: none arch/arm/dts/fsl-lx2160a-qds.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/fsl-lx2160a-qds.dtsi b/arch/arm/dts/fsl-lx2160a-qds.dtsi index 288607c0347b..69e11cca2da1 100644 --- a/arch/arm/dts/

[PATCH v3 04/16] arm: dts: ls1088a-rdb: use Linux compatible string for RTC

2022-01-03 Thread Vladimir Oltean
: Vladimir Oltean Reviewed-by: Priyanka Jain --- v1->v3: none arch/arm/dts/fsl-ls1088a-rdb.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/fsl-ls1088a-rdb.dts b/arch/arm/dts/fsl-ls1088a-rdb.dts index de92bf22e203..5cdd59815234 100644 --- a/arch/arm/dts/

[PATCH v3 02/16] rtc: pcf2127: sync with Linux compatible strings

2022-01-03 Thread Vladimir Oltean
Allow this driver to be used by boards which inherit their device trees from Linux. Compatibility is temporarily retained with the old compatible string which is U-Boot specific, and will be removed after a few changes. Cc: Simon Glass Signed-off-by: Vladimir Oltean Reviewed-by: Simon Glass

[PATCH v3 00/16] Sync NXP LS1028A-RDB device trees between U-Boot and Linux

2022-01-03 Thread Vladimir Oltean
manifests/focal-20211006-14Nov2021": received unexpected HTTP status: 502 Bad Gateway. The other tests seem to pass. Cc: Heiko Schocher Cc: Simon Glass Cc: Ramon Fried Vladimir Oltean (16): i2c: muxes: pca954x: add PCA9847 variant rtc: pcf2127: sync with Linux compatible strings ar

[PATCH v3 03/16] arm: dts: ls1088a-qds: use Linux compatible string for RTC

2022-01-03 Thread Vladimir Oltean
: Vladimir Oltean Reviewed-by: Priyanka Jain --- v1->v3: none arch/arm/dts/fsl-ls1088a-qds.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/fsl-ls1088a-qds.dtsi b/arch/arm/dts/fsl-ls1088a-qds.dtsi index a7d0edcf0aa9..21c50078c3a4 100644 --- a/arch/arm/dts/

[PATCH v3 01/16] i2c: muxes: pca954x: add PCA9847 variant

2022-01-03 Thread Vladimir Oltean
compatible for the PCA9847 (which is the same as in Linux) and define the same operating parameters for it as for PCA9547. Cc: Heiko Schocher Signed-off-by: Vladimir Oltean Reviewed-by: Heiko Schocher Reviewed-by: Priyanka Jain --- v1->v3: none drivers/i2c/muxes/pca954x.c | 9 -

Re: [PATCH v2 00/16] Sync NXP LS1028A-RDB device trees between U-Boot and Linux

2021-12-23 Thread Vladimir Oltean
On Thu, Dec 23, 2021 at 01:47:48PM +0100, Michael Walle wrote: > Am 2021-12-23 13:44, schrieb Vladimir Oltean: > > On Thu, Dec 23, 2021 at 06:34:13AM +, Priyanka Jain wrote: > > > >The Linux side of device tree patches were merged today, and I see you've > >

Re: [PATCH v2 00/16] Sync NXP LS1028A-RDB device trees between U-Boot and Linux

2021-12-23 Thread Vladimir Oltean
On Thu, Dec 23, 2021 at 06:34:13AM +, Priyanka Jain wrote: > >The Linux side of device tree patches were merged today, and I see you've > >reviewed the U-Boot side of changes too. Could you please pick them up? > > Yes, I will pick the series as part of next pull-request for 2022.04 Thanks. C

Re: [PATCH v2 00/16] Sync NXP LS1028A-RDB device trees between U-Boot and Linux

2021-12-14 Thread Vladimir Oltean
Hi Priyanka, On Tue, Dec 07, 2021 at 10:20:07PM +0200, Vladimir Oltean wrote: > The changes were intended to be minimal, but unfortunately I discovered > some other stuff as well: > - we need to make some changes to the compatible strings of RTC devices > and I2C muxes. This has r

[PATCH v2 15/16] arm: dts: ls1028a-rdb: sync device tree with Linux

2021-12-07 Thread Vladimir Oltean
169-5-vladimir.olt...@nxp.com/T/#m6f63c92e75fa79a01144b2c2c6dc4776e7971395 Signed-off-by: Vladimir Oltean Reviewed-by: Priyanka Jain --- arch/arm/dts/fsl-ls1028a-rdb.dts | 158 --- 1 file changed, 146 insertions(+), 12 deletions(-) diff --git a/arch/arm/dts/fsl-ls

[PATCH v2 16/16] arm: dts: ls1028a-qds: declare in-band autoneg for Ethernet ports

2021-12-07 Thread Vladimir Oltean
ust enable in-band autoneg to fix the breakage. Fixes: e3789a726269 ("net: dsa: felix: configure the in-band autoneg property based on OF node info") Cc: Ramon Fried Signed-off-by: Vladimir Oltean Reviewed-by: Priyanka Jain --- arch/arm/dts/fsl-ls1028a-qds-1xxx-sch-30842.dtsi

[PATCH v2 14/16] arm: dts: ls1028a-rdb: enable PCIe controllers from U-Boot dtsi

2021-12-07 Thread Vladimir Oltean
way, the existing Linux device tree can simply be dropped in. Signed-off-by: Vladimir Oltean --- arch/arm/dts/fsl-ls1028a-rdb-u-boot.dtsi | 15 +++ arch/arm/dts/fsl-ls1028a-rdb.dts | 9 + 2 files changed, 16 insertions(+), 8 deletions(-) create mode 100644 arch/arm/d

[PATCH v2 12/16] arm: dts: ls1028a-rdb: disable DSPI nodes

2021-12-07 Thread Vladimir Oltean
There is no SPI peripheral on the LS1028A-RDB, therefore no reason to enable these nodes in the U-Boot device tree (and Linux does not enable them either). Signed-off-by: Vladimir Oltean Reviewed-by: Priyanka Jain --- arch/arm/dts/fsl-ls1028a-rdb.dts | 12 1 file changed, 12

[PATCH v2 11/16] arm: dts: ls1028a-rdb: sync Ethernet device tree nodes with Linux

2021-12-07 Thread Vladimir Oltean
esolves that issue. The device tree update also renames the Ethernet PHY labels. Fixes: e3789a726269 ("net: dsa: felix: configure the in-band autoneg property based on OF node info") Cc: Ramon Fried Signed-off-by: Vladimir Oltean Reviewed-by: Priyanka Jain --- arch

[PATCH v2 13/16] arm: dts: ls1028a-rdb: disable I2C buses 1 through 7

2021-12-07 Thread Vladimir Oltean
There is no I2C peripheral on these buses on the reference design board, and the Linux device tree does not enable them either. Signed-off-by: Vladimir Oltean Reviewed-by: Priyanka Jain --- arch/arm/dts/fsl-ls1028a-rdb.dts | 28 1 file changed, 28 deletions

[PATCH v2 10/16] arm: dts: ls1028a-rdb: sort nodes alphabetically

2021-12-07 Thread Vladimir Oltean
The nodes in the NXP LS1028A-RDB device tree are out of order, regroup them alphabetically to have a simple delta when the Linux device tree is brought in. Signed-off-by: Vladimir Oltean Reviewed-by: Priyanka Jain --- arch/arm/dts/fsl-ls1028a-rdb.dts | 110 +++ 1

[PATCH v2 08/16] arm: dts: lx2160a-rdb: use Linux compatible string for RTC

2021-12-07 Thread Vladimir Oltean
: Vladimir Oltean Reviewed-by: Priyanka Jain --- arch/arm/dts/fsl-lx2160a-rdb.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/fsl-lx2160a-rdb.dts b/arch/arm/dts/fsl-lx2160a-rdb.dts index 5fbdd907017c..8ca4afa7eaea 100644 --- a/arch/arm/dts/fsl-lx2160a-rdb.dts

[PATCH v2 05/16] arm: dts: lx2160a-qds: use Linux compatible string for RTC

2021-12-07 Thread Vladimir Oltean
: Vladimir Oltean Reviewed-by: Priyanka Jain --- arch/arm/dts/fsl-lx2160a-qds.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/fsl-lx2160a-qds.dtsi b/arch/arm/dts/fsl-lx2160a-qds.dtsi index 288607c0347b..69e11cca2da1 100644 --- a/arch/arm/dts/fsl-lx2160a

  1   2   3   4   5   6   >