Re: [PATCH 1/2] Kconfig: Change SYS_MALLOC_F_LEN default to 0x2000

2022-04-07 Thread Thomas Chou
handle a little more memory usage. --- Kconfig | 9 +++-- configs/10m50_defconfig | 1 + configs/3c120_defconfig | 1 + Reviewed-by: Thomas Chou

Re: [U-Boot] (no subject)

2019-07-03 Thread Thomas Chou
On 7/1/19 9:20 PM, Tom Rini wrote: On Sun, Jun 30, 2019 at 10:06:35AM +0800, Thomas Chou wrote: Add gcc-8.1.0 support to buildman toolchain. The old gcc-7.3.0 has shared libraries issues on Ubuntu 18.04LTS and 19.04. Can you not resolve those shared library issues via one of the toolchain

Re: [U-Boot] (no subject)

2019-07-03 Thread Thomas Chou
Hi Tom, On 7/1/19 9:19 PM, Tom Rini wrote: On Sun, Jun 30, 2019 at 06:31:10PM +0800, Bin Meng wrote: Unfortunately the kernel.org gcc-8.1 toolchain just isn't usable for us due to a number of later-fixed regressions. We need to use gcc-8.3, I think, for something that should work again everywhe

Re: [U-Boot] (no subject)

2019-07-03 Thread Thomas Chou
Hi Bin, On 6/30/19 6:31 PM, Bin Meng wrote: On Sun, Jun 30, 2019 at 10:07 AM Thomas Chou wrote: x86: + efi-x86_app +{standard input}: Assembler messages: +{standard input}:21695: Error: junk at end of line, first unrecognized character is `@' +{standard input}:21740: Error:

Re: [U-Boot] [PATCH] tools: buildman: add gcc-8.1.0 support

2019-07-03 Thread Thomas Chou
Hi Bin, On 6/30/19 6:32 PM, Bin Meng wrote: We should fix all issues before we turn on the 8.1 for buildman, otherwise the travis-ci will break. I agree. It is not ready yet. CHeers, Thomas ___ U-Boot mailing list U-Boot@lists.denx.de https://lists

[U-Boot] [PATCH] tools: buildman: add gcc-8.1.0 support

2019-06-29 Thread Thomas Chou
Add gcc-8.1.0 support to buildman toolchain. The old gcc-7.3.0 has shared libraries issues on Ubuntu 18.04 and 19.04. Signed-off-by: Thomas Chou --- tools/buildman/toolchain.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/buildman/toolchain.py b/tools/buildman

[U-Boot] (no subject)

2019-06-29 Thread Thomas Chou
Add gcc-8.1.0 support to buildman toolchain. The old gcc-7.3.0 has shared libraries issues on Ubuntu 18.04LTS and 19.04. Though both 7.3.0 and 8.1.0 have arc and nds32 compilers, the following errors were generated on Ubuntu 19.04. arc: + iot_devkit

Re: [U-Boot] [PATCH] nios2: 10m50: Add CPU pre-relocation in device tree

2018-09-19 Thread Thomas Chou
On 09/13/2017 02:19 PM, Marek Vasut wrote: On 07/28/2017 07:07 AM, Gan, Yau Wai wrote: Tag CPU with dm-pre-reloc to enable driver before relocation. Signed-off-by: Gan, Yau Wai Cc: Thomas Chou Reviewed-by: Marek Vasut Tom, please apply directly as the maintainer seems N/A. Dear all

Re: [U-Boot] [PATCH] Nios2 altera: add reference to in_be32, out_be32

2017-01-20 Thread Thomas Chou
git://git.denx.de/u-boot.git http://git.denx.de/u-boot.git Best regards, Thomas Chou ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] net: fix m88e1111s PHY auto negotiation timeout

2016-02-24 Thread Thomas Chou
Hi Stefan, On 2016年02月18日 15:47, Stefan Roese wrote: I've also stumbled over this problem on some boards equipped with the Marvell PHY. Could you please take a look at these patches instead: http://patchwork.ozlabs.org/patch/581316/ http://patchwork.ozlabs.org/patch/581317/ Do they work for yo

[U-Boot] [PATCH] net: fix m88e1111s PHY auto negotiation timeout

2016-02-15 Thread Thomas Chou
MEOUT ! Using ethernet@400 device host 192.168.1.5 is alive This is because the auto negotiation control bit was cleared by the new phy_reset(). But the m88es_config() does the soft-reset already, there is no need to reset twice. The extra phy_reset() should be removed. Signed-off-by: Thomas Chou

[U-Boot] [PULL] Please pull u-boot-nios/master

2016-02-05 Thread Thomas Chou
nges up to e4f348ba6f070789e6505cc65cf6683421674637: nios2: set up the debug UART early (2016-02-06 15:14:25 +0800) -------- Thomas Chou (1): nios2: set up the debug UART early arch/nios2/cpu/start.S | 7 +++ 1 file changed, 7

Re: [U-Boot] [PATCH] nios2: set up the debug UART early

2016-02-05 Thread Thomas Chou
On 2015年12月30日 20:32, Thomas Chou wrote: Set up the debug UART early if enabled, so that it is ready to use. Signed-off-by: Thomas Chou --- arch/nios2/cpu/start.S | 7 +++ 1 file changed, 7 insertions(+) Applied to u-boot-nios. ___ U-Boot

Re: [U-Boot] [PATCH 3/7] arm: use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE

2016-01-05 Thread Thomas Chou
Hi Masahiro, On 2016年01月06日 10:22, Masahiro Yamada wrote: Hi Thomas, 2016-01-06 10:57 GMT+09:00 Thomas Chou : Thanks for the explanation. Now I understand. But there is no harm to add list support for building DT to configs. Please review and pick 1/9 and 2/9 of PATCH v2. And leave the rest

Re: [U-Boot] [PATCH 3/7] arm: use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE

2016-01-05 Thread Thomas Chou
Hi Simon, On 2016年01月06日 08:24, Simon Glass wrote: +Masahiro Hi Thomas, On 5 January 2016 at 06:16, Thomas Chou wrote: Hi Simon, On 2016年01月05日 08:56, Simon Glass wrote: One of the benefits of device tree is that we can run the same code paths on multiple boards. Then buildman has less

[U-Boot] [PATCH v2 6/9] microblaze: use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE

2016-01-05 Thread Thomas Chou
Use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE, so that there is no need to list all the dtb for different targets/boards in Makefile. Support list of Device Tree in DEFAULT_DEVICE_TREE. Each DT in the list will be compiled. The first will be used as default to ship. Signed-off-by: Thomas

[U-Boot] [PATCH v2 8/9] sandbox: use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE

2016-01-05 Thread Thomas Chou
Use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE, so that there is no need to list all the dtb for different targets/boards in Makefile. Support list of Device Tree in DEFAULT_DEVICE_TREE. Each DT in the list will be compiled. The first will be used as default to ship. Signed-off-by: Thomas

[U-Boot] [PATCH v2 1/9] devicetree: use wildcard to clean arch subdir

2016-01-05 Thread Thomas Chou
Use wildcard to clean arch subdirectories, as it is cleaner than listing all the arch which builds dtb. Signed-off-by: Thomas Chou Reviewed-by: Bin Meng --- v2 no change dts/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dts/Makefile b/dts/Makefile index

[U-Boot] [PATCH v2 2/9] devicetree: support list of Device Tree in DEFAULT_DEVICE_TREE

2016-01-05 Thread Thomas Chou
Support list of Device Tree in DEFAULT_DEVICE_TREE. Each DT in the list will be compiled. The first will be used as default to ship. Signed-off-by: Thomas Chou --- v2 add list support as Simon suggested. dts/Kconfig | 3 ++- dts/Makefile | 3 ++- 2 files changed, 4 insertions(+), 2

[U-Boot] [PATCH v2 4/9] arc: use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE

2016-01-05 Thread Thomas Chou
Use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE, so that there is no need to list all the dtb for different targets/boards in Makefile. Support list of Device Tree in DEFAULT_DEVICE_TREE. Each DT in the list will be compiled. The first will be used as default to ship. Signed-off-by: Thomas

[U-Boot] [PATCH v2 7/9] powerpc: use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE

2016-01-05 Thread Thomas Chou
Use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE, so that there is no need to list all the dtb for different targets/boards in Makefile. Support list of Device Tree in DEFAULT_DEVICE_TREE. Each DT in the list will be compiled. The first will be used as default to ship. Signed-off-by: Thomas

[U-Boot] [PATCH v2 5/9] arm: use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE

2016-01-05 Thread Thomas Chou
Use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE, so that there is no need to list all the dtb for different targets/boards in Makefile. Support list of Device Tree in DEFAULT_DEVICE_TREE. Each DT in the list will be compiled. The first will be used as default to ship. Signed-off-by: Thomas

[U-Boot] [PATCH v2 3/9] nios2: support list of Device Tree in DEFAULT_DEVICE_TREE

2016-01-05 Thread Thomas Chou
Support list of Device Tree in DEFAULT_DEVICE_TREE. Each DT in the list will be compiled. The first will be used as default to ship. Signed-off-by: Thomas Chou --- v2 add list support as Simon suggested. arch/nios2/dts/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[U-Boot] [PATCH v2 9/9] x86: use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE

2016-01-05 Thread Thomas Chou
Use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE, so that there is no need to list all the dtb for different targets/boards in Makefile. Support list of Device Tree in DEFAULT_DEVICE_TREE. Each DT in the list will be compiled. The first will be used as default to ship. Signed-off-by: Thomas

Re: [U-Boot] [PATCH 3/7] arm: use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE

2016-01-05 Thread Thomas Chou
Hi Simon, On 2016年01月05日 08:56, Simon Glass wrote: One of the benefits of device tree is that we can run the same code paths on multiple boards. Then buildman has less work to do. For example, if it builds 'snow' then we know that 'pit' and 'pi' are good also. If you change the way device trees

Re: [U-Boot] [PATCH v6 08/10] mips: ath79: add spi driver

2016-01-04 Thread Thomas Chou
OT_DRIVER(ath79_spi) = { + .name = "ath79_spi", + .id = UCLASS_SPI, + .of_match = ath79_spi_ids, + .ops= &ath79_spi_ops, + .priv_auto_alloc_size = sizeof(struct ath79_spi_priv), + .probe = ath79_spi_probe, +}; Reviewed-by: Thomas Chou Best regards, Thomas ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v6 01/10] mips: implement to access the KSEG0/1 memory range in map_physmem

2016-01-04 Thread Thomas Chou
Hi Wills, On 2016年01月04日 19:14, Wills Wang wrote: U-boot just use the no MMU virtual address segment(KSEG0/1), this patch enable access the uncached memory range(KSEG1) by flag "MAP_NOCACHE", other flag for KSEG0 access. Signed-off-by: Wills Wang --- Changes in v6: - Remove useless "else" Ch

Re: [U-Boot] [PATCH v6 06/10] ns16550: add support for mips

2016-01-04 Thread Thomas Chou
Hi Wills, On 2016年01月04日 19:14, Wills Wang wrote: MIPS archtecture have no "in_le32/in_be32/out_le32/out_be32" macro, but usually define CONFIG_SYS_BIG_ENDIAN, this patch use readl/writel for register operation in mips when define CONFIG_SYS_NS16550_MEM32. Signed-off-by: Wills Wang --- As Ma

Re: [U-Boot] [PATCH v6 07/10] ns16550: map register base address for debug UART

2016-01-04 Thread Thomas Chou
that we can keep the code and stack usage minimal. My concern is that the uncache mapping in nios2 arch is different between NOMMU and MMU core, which will be decoded from device tree. So it won't work for nios2 until DM initialized. Naked-by: Thomas Chou Best

Re: [U-Boot] [PATCH v6 05/10] mips: ath79: add serial driver for ar933x SOC

2016-01-04 Thread Thomas Chou
void _debug_uart_putc(int c) +{ + void __iomem *regs; + u32 data; + + regs = map_physmem(CONFIG_DEBUG_UART_BASE, +AR933X_UART_SIZE, +MAP_NOCACHE); + + do { + data = readl(regs + AR933X_UART_DATA_REG); +

[U-Boot] [PATCH] nios2: set up the debug UART early

2015-12-30 Thread Thomas Chou
Set up the debug UART early if enabled, so that it is ready to use. Signed-off-by: Thomas Chou --- arch/nios2/cpu/start.S | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/nios2/cpu/start.S b/arch/nios2/cpu/start.S index 54787c5..1caee0c 100644 --- a/arch/nios2/cpu/start.S +++ b

Re: [U-Boot] [PATCH v5 4/5] mips: ath79: add spi driver

2015-12-29 Thread Thomas Chou
Hi Marek and Wills, On 2015年12月30日 08:51, Marek Vasut wrote: Just skimming through the code, it seems like bitbanging the SPI using the generic soft-spi driver might be easier ;-/ I read the data sheet and Linux driver. Now I have clearer picture of this device. In serial flash mode, it read

Re: [U-Boot] [PATCH v5 4/5] mips: ath79: add spi driver

2015-12-29 Thread Thomas Chou
Hi Marek, On 2015年12月29日 21:25, Marek Vasut wrote: On Tuesday, December 29, 2015 at 02:00:27 PM, Thomas Chou wrote: Hi Wills, On 2015年12月29日 19:17, Wills Wang wrote: diff --git a/arch/mips/mach-ath79/Kconfig b/arch/mips/mach-ath79/Kconfig index 1d92a5b..b5668e9 100644 --- a/arch/mips/mach

Re: [U-Boot] [PATCH v5 4/5] mips: ath79: add spi driver

2015-12-29 Thread Thomas Chou
Hi Wills, On 2015年12月29日 19:17, Wills Wang wrote: diff --git a/arch/mips/mach-ath79/Kconfig b/arch/mips/mach-ath79/Kconfig index 1d92a5b..b5668e9 100644 --- a/arch/mips/mach-ath79/Kconfig +++ b/arch/mips/mach-ath79/Kconfig @@ -15,6 +15,7 @@ config SOC_AR933X select SYS_MIPS_CACHE_INIT_RA

Re: [U-Boot] [PATCH v5 3/5] mips: ath79: add serial driver for ar933x SOC

2015-12-29 Thread Thomas Chou
Hi Wills, On 2015年12月29日 19:17, Wills Wang wrote: > +DECLARE_GLOBAL_DATA_PTR; The gd is not used in this patch. It can be removed. +static int ar933x_serial_putc(struct udevice *dev, const char c) +{ + u32 data; + + do { + data = ar933x_serial_read(dev, AR933X_UAR

Re: [U-Boot] [PATCH 3/7] arm: use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE

2015-12-28 Thread Thomas Chou
Hi Simon, On 2015年12月29日 08:22, Simon Glass wrote: Hi Thomas, On 27 December 2015 at 19:16, Bin Meng wrote: On Sun, Dec 27, 2015 at 9:44 PM, Thomas Chou wrote: Use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE, so that there is no need to list all the dtb for different targets/boards

Re: [U-Boot] [PATCH 4/5] altera_qspi: show erase progress

2015-12-28 Thread Thomas Chou
Hi Marek, On 2015年12月28日 13:35, Marek Vasut wrote: On Monday, December 28, 2015 at 02:17:46 AM, Thomas Chou wrote: Hi Marek, On 2015年12月25日 17:58, Marek Vasut wrote: On Friday, December 25, 2015 at 09:33:52 AM, Thomas Chou wrote: Hi Marek, On 2015年12月25日 12:08, Marek Vasut wrote: Well, it

[U-Boot] [PULL] Please pull u-boot-nios/master

2015-12-27 Thread Thomas Chou
nges up to 8e8106dcd540e4c735da6a0b71919747c15ce93a: altera_qspi: allow ctrl-c to abort the erase ops (2015-12-28 09:32:43 +0800) -------- Thomas Chou (5): altera_qspi: call callback even if the erase failed altera_qspi: set fail_addr for

Re: [U-Boot] [PATCH 4/5] altera_qspi: show erase progress

2015-12-27 Thread Thomas Chou
On 2015年12月24日 08:51, Thomas Chou wrote: Show sector erase progress with dot and comma. Signed-off-by: Thomas Chou --- drivers/mtd/altera_qspi.c | 14 ++ 1 file changed, 14 insertions(+) Applied to u-boot-nios. ___ U-Boot mailing

Re: [U-Boot] [PATCH 5/5] altera_qspi: allow ctrl-c to abort the erase ops

2015-12-27 Thread Thomas Chou
On 2015年12月24日 08:51, Thomas Chou wrote: Allow ctrl-c to abort the erase ops. Signed-off-by: Thomas Chou --- drivers/mtd/altera_qspi.c | 9 + 1 file changed, 9 insertions(+) Applied to u-boot-nios. ___ U-Boot mailing list U-Boot

Re: [U-Boot] [PATCH 3/5] altera_qspi: skip erase if the sector is blank

2015-12-27 Thread Thomas Chou
On 2015年12月24日 08:51, Thomas Chou wrote: Skip erase if the sector is blank. The sector erase is slow, and may take 0.7 sec typically or up to 3 sec worst-case. Signed-off-by: Thomas Chou --- drivers/mtd/altera_qspi.c | 39 +-- 1 file changed, 25

Re: [U-Boot] [PATCH 2/5] altera_qspi: set fail_addr for erase ops

2015-12-27 Thread Thomas Chou
On 2015年12月24日 08:51, Thomas Chou wrote: If the erase fails, fail_addr might indicate exactly which block failed. If fail_addr = MTD_FAIL_ADDR_UNKNOWN, the failure was not at the device level or was not specific to any particular block. Signed-off-by: Thomas Chou --- drivers/mtd

Re: [U-Boot] [PATCH 1/5] altera_qspi: call callback even if the erase failed

2015-12-27 Thread Thomas Chou
On 2015年12月24日 08:51, Thomas Chou wrote: Erase is an asynchronous operation. Device drivers are supposed to call instr->callback() whenever the operation completes, even if it completes with a failure. Signed-off-by: Thomas Chou --- drivers/mtd/altera_qspi.c | 1 + 1 file changed

Re: [U-Boot] [PATCH 4/5] altera_qspi: show erase progress

2015-12-27 Thread Thomas Chou
Hi Marek, On 2015年12月25日 17:58, Marek Vasut wrote: On Friday, December 25, 2015 at 09:33:52 AM, Thomas Chou wrote: Hi Marek, On 2015年12月25日 12:08, Marek Vasut wrote: Well, it is only a putc() which is plain and simple. Sure, but then I still don't understand why this cannot be i

[U-Boot] [PATCH 2/7] arc: use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE

2015-12-27 Thread Thomas Chou
Use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE, so that there is no need to list all the dtb for different targets/boards. Signed-off-by: Thomas Chou Cc: Alexey Brodkin --- arch/arc/dts/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arc/dts/Makefile

[U-Boot] [PATCH 6/7] sandbox: use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE

2015-12-27 Thread Thomas Chou
Use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE, so that there is no need to list all the dtb for different targets/boards. Signed-off-by: Thomas Chou --- arch/sandbox/dts/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sandbox/dts/Makefile b/arch/sandbox

[U-Boot] [PATCH 7/7] x86: use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE

2015-12-27 Thread Thomas Chou
Use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE, so that there is no need to list all the dtb for different targets/boards. Signed-off-by: Thomas Chou Cc: Bin Meng --- arch/x86/dts/Makefile | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/arch/x86/dts

[U-Boot] [PATCH 5/7] powerpc: use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE

2015-12-27 Thread Thomas Chou
Use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE, so that there is no need to list all the dtb for different targets/boards. Signed-off-by: Thomas Chou Cc: Wolfgang Denk --- arch/powerpc/dts/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/dts

[U-Boot] [PATCH 3/7] arm: use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE

2015-12-27 Thread Thomas Chou
Use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE, so that there is no need to list all the dtb for different targets/boards. Signed-off-by: Thomas Chou Cc: Albert Aribaud --- arch/arm/dts/Makefile | 192 +- 1 file changed, 1 insertion(+), 191

[U-Boot] [PATCH 4/7] microblaze: use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE

2015-12-27 Thread Thomas Chou
Use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE, so that there is no need to list all the dtb for different targets/boards. Signed-off-by: Thomas Chou Cc: Michal Simek --- arch/microblaze/dts/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/microblaze/dts

[U-Boot] [PATCH 1/7] devicetree: use wildcard to clean arch subdir

2015-12-27 Thread Thomas Chou
Use wildcard to clean arch subdirectories, as it is cleaner than listing all the arch which builds dtb. Signed-off-by: Thomas Chou --- dts/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dts/Makefile b/dts/Makefile index d3122aa..dbde703 100644 --- a/dts/Makefile

Re: [U-Boot] [PATCH v4 4/8] mips: ath79: add serial driver for ar933x SOC

2015-12-27 Thread Thomas Chou
Hi Wills, Please note the following, 1. add this uart to drivers/serial/Kconfig . 2. add debug uart support. see include/debug_uart.h . also add it to Kconfig 3. cp linux/Documentation/devicetree/bindings/serial/qca,ar9330-uart.txt u-boot/doc/device-tree-bindings/serial/ 4. to save chan

Re: [U-Boot] [PATCH v4 4/8] mips: ath79: add serial driver for ar933x SOC

2015-12-27 Thread Thomas Chou
Hi Wills, On 2015年12月26日 21:20, Daniel Schwierzeck wrote: +static int ar933x_serial_probe(struct udevice *dev) +{ + struct ar933x_serial_priv *priv = dev_get_priv(dev); + struct ar933x_serial_platdata *plat = dev_get_platdata(dev); + u32 val; + + priv->regs = plat->regs;

Re: [U-Boot] [PATCH v4 4/8] mips: ath79: add serial driver for ar933x SOC

2015-12-27 Thread Thomas Chou
Hi Wills, On 2015年12月27日 14:28, Wills Wang wrote: +static int ar933x_serial_putc(struct udevice *dev, const char c) +{ +u32 data; + +if (c == '\n') +ar933x_serial_putc(dev, '\r'); remove this, the serial core driver takes care of it + +do { +data = ar933x_serial_re

Re: [U-Boot] [PATCH 4/5] altera_qspi: show erase progress

2015-12-25 Thread Thomas Chou
Hi Marek, On 2015年12月25日 12:08, Marek Vasut wrote: Well, it is only a putc() which is plain and simple. Sure, but then I still don't understand why this cannot be in the common code. Yes, it can be in the common code. Do you have an idea how should it look like? Best regards, Thomas _

Re: [U-Boot] [PATCH v3 2/4] mips: ath79: add serial driver for ar933x SOC

2015-12-24 Thread Thomas Chou
On 2015年12月25日 14:05, Wills Wang wrote: On 12/25/2015 10:39 AM, Thomas Chou wrote: Hi Wills, Is there any reason that you need to support pre-DM serial driver? It should be safe to support DM only. You may add debug_uart support which might be helpful during debug. The ops for DM serial is

Re: [U-Boot] [PATCH v3 2/4] mips: ath79: add serial driver for ar933x SOC

2015-12-24 Thread Thomas Chou
Hi Wills, There is code to set baud rate in Linux kernel, drivers/tty/serial/ar933x_uart.c Best regards, Thomas ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3 2/4] mips: ath79: add serial driver for ar933x SOC

2015-12-24 Thread Thomas Chou
Hi Wills, Is there any reason that you need to support pre-DM serial driver? It should be safe to support DM only. You may add debug_uart support which might be helpful during debug. The ops for DM serial is different to pre-DM though the name look similar. Please see the comments below. I w

Re: [U-Boot] [PATCH 4/5] altera_qspi: show erase progress

2015-12-24 Thread Thomas Chou
Hi Marek, On 2015年12月24日 13:37, Marek Vasut wrote: On Thursday, December 24, 2015 at 06:24:45 AM, Thomas Chou wrote: Hi Marek, On 2015年12月24日 11:42, Marek Vasut wrote: On Thursday, December 24, 2015 at 04:26:57 AM, Thomas Chou wrote: Hi Marek, Hi Thomas, On 2015年12月24日 11:02, Marek

Re: [U-Boot] [PATCH 4/5] altera_qspi: show erase progress

2015-12-23 Thread Thomas Chou
Hi Marek, On 2015年12月24日 11:42, Marek Vasut wrote: On Thursday, December 24, 2015 at 04:26:57 AM, Thomas Chou wrote: Hi Marek, Hi Thomas, On 2015年12月24日 11:02, Marek Vasut wrote: On Thursday, December 24, 2015 at 03:50:57 AM, Thomas Chou wrote: Hi Marek, On 2015年12月24日 09:29, Marek

[U-Boot] [PATCH] sf: call callback even if the mtd erase failed

2015-12-23 Thread Thomas Chou
Erase is an asynchronous operation. Device drivers are supposed to call instr->callback() whenever the operation completes, even if it completes with a failure. Signed-off-by: Thomas Chou --- drivers/mtd/spi/sf_mtd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/spi/sf_mt

Re: [U-Boot] [PATCH 4/5] altera_qspi: show erase progress

2015-12-23 Thread Thomas Chou
Hi Marek, On 2015年12月24日 11:02, Marek Vasut wrote: On Thursday, December 24, 2015 at 03:50:57 AM, Thomas Chou wrote: Hi Marek, On 2015年12月24日 09:29, Marek Vasut wrote: On Thursday, December 24, 2015 at 01:51:23 AM, Thomas Chou wrote: Show sector erase progress with dot and comma. Signed

Re: [U-Boot] [PATCH 3/5] altera_qspi: skip erase if the sector is blank

2015-12-23 Thread Thomas Chou
Hi Marek, On 2015年12月24日 11:01, Marek Vasut wrote: On Thursday, December 24, 2015 at 03:23:05 AM, Thomas Chou wrote: Hi Marek, On 2015年12月24日 09:28, Marek Vasut wrote: On Thursday, December 24, 2015 at 01:51:22 AM, Thomas Chou wrote: Skip erase if the sector is blank. The sector erase is

Re: [U-Boot] [PATCH 4/5] altera_qspi: show erase progress

2015-12-23 Thread Thomas Chou
Hi Marek, On 2015年12月24日 09:29, Marek Vasut wrote: On Thursday, December 24, 2015 at 01:51:23 AM, Thomas Chou wrote: Show sector erase progress with dot and comma. Signed-off-by: Thomas Chou --- Shouldn't this go into common code ? The code to print a dot is minimal. It will cost

Re: [U-Boot] [PATCH 3/5] altera_qspi: skip erase if the sector is blank

2015-12-23 Thread Thomas Chou
Hi Marek, On 2015年12月24日 09:28, Marek Vasut wrote: On Thursday, December 24, 2015 at 01:51:22 AM, Thomas Chou wrote: Skip erase if the sector is blank. The sector erase is slow, and may take 0.7 sec typically or up to 3 sec worst-case. Signed-off-by: Thomas Chou --- drivers/mtd

[U-Boot] [PATCH 5/5] altera_qspi: allow ctrl-c to abort the erase ops

2015-12-23 Thread Thomas Chou
Allow ctrl-c to abort the erase ops. Signed-off-by: Thomas Chou --- drivers/mtd/altera_qspi.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/mtd/altera_qspi.c b/drivers/mtd/altera_qspi.c index 0624ff4..a9148a7 100644 --- a/drivers/mtd/altera_qspi.c +++ b/drivers/mtd

[U-Boot] [PATCH 2/5] altera_qspi: set fail_addr for erase ops

2015-12-23 Thread Thomas Chou
If the erase fails, fail_addr might indicate exactly which block failed. If fail_addr = MTD_FAIL_ADDR_UNKNOWN, the failure was not at the device level or was not specific to any particular block. Signed-off-by: Thomas Chou --- drivers/mtd/altera_qspi.c | 1 + 1 file changed, 1 insertion

[U-Boot] [PATCH 4/5] altera_qspi: show erase progress

2015-12-23 Thread Thomas Chou
Show sector erase progress with dot and comma. Signed-off-by: Thomas Chou --- drivers/mtd/altera_qspi.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/mtd/altera_qspi.c b/drivers/mtd/altera_qspi.c index 8a630a6..0624ff4 100644 --- a/drivers/mtd/altera_qspi.c +++ b

[U-Boot] [PATCH 3/5] altera_qspi: skip erase if the sector is blank

2015-12-23 Thread Thomas Chou
Skip erase if the sector is blank. The sector erase is slow, and may take 0.7 sec typically or up to 3 sec worst-case. Signed-off-by: Thomas Chou --- drivers/mtd/altera_qspi.c | 39 +-- 1 file changed, 25 insertions(+), 14 deletions(-) diff --git a/drivers

[U-Boot] [PATCH 1/5] altera_qspi: call callback even if the erase failed

2015-12-23 Thread Thomas Chou
Erase is an asynchronous operation. Device drivers are supposed to call instr->callback() whenever the operation completes, even if it completes with a failure. Signed-off-by: Thomas Chou --- drivers/mtd/altera_qspi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/

Re: [U-Boot] [PATCH v2 3/4] mips: ath79: add serial driver for ar933x SOC

2015-12-22 Thread Thomas Chou
Hi Wills, On 2015年12月22日 15:44, Wills Wang wrote: Signed-off-by: Wills Wang --- drivers/serial/Makefile| 1 + drivers/serial/serial_ar933x.c | 337 + 2 files changed, 338 insertions(+) create mode 100644 drivers/serial/serial_ar933x.c

Re: [U-Boot] [PATCH v2] net: eth_designware: select PHYLIB in Kconfig

2015-12-19 Thread Thomas Chou
Hi Marek, On 2015年12月19日 13:47, Marek Vasut wrote: On Saturday, December 19, 2015 at 04:56:38 AM, Thomas Chou wrote: Hi Marek, On 2015年12月07日 20:53, Thomas Chou wrote: Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB from legacy board header files. This fixed the warnings when

Re: [U-Boot] [PATCH v2] net: eth_designware: select PHYLIB in Kconfig

2015-12-18 Thread Thomas Chou
Hi Marek, On 2015年12月07日 20:53, Thomas Chou wrote: Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB from legacy board header files. This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE are selected. Signed-off-by: Thomas Chou Reported-by: Pavel Machek Acked-by: Chin

[U-Boot] [PULL] Please pull u-boot-nios/master

2015-12-18 Thread Thomas Chou
to 512kiB nios2: Preconfigure $loadaddr variable nios2: Enable support for fitImage nios2: Soup up the shell experience Thomas Chou (3): nios2: display altera sysid at startup serial-howto: remove altera_jtag_uart and altera_uart from the list altera_qspi:

[U-Boot] [PATCH] altera_qspi: initialize instr.mtd in flash_erase

2015-12-18 Thread Thomas Chou
Initialize instr.mtd in flash_erase(). This fixes the system hang issue when CONFIG_MTD_PARTITIONS is selected. Signed-off-by: Thomas Chou --- drivers/mtd/altera_qspi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/altera_qspi.c b/drivers/mtd/altera_qspi.c index 617bf5d

Re: [U-Boot] [PATCH v2 1/3] serial: uartlite: Move driver to DM

2015-12-18 Thread Thomas Chou
Hi Michal, On 2015年12月18日 15:52, Michal Simek wrote: On 18.12.2015 00:35, Thomas Chou wrote: Hi Michal, On 2015年12月17日 21:58, Michal Simek wrote: On 17.12.2015 14:37, Thomas Chou wrote: Hi Michal, On 2015年12月17日 20:00, Michal Simek wrote: Enable SPL DM too. Signed-off-by: Michal Simek

Re: [U-Boot] [PATCH v2 1/3] serial: uartlite: Move driver to DM

2015-12-17 Thread Thomas Chou
Hi Michal, On 2015年12月17日 21:58, Michal Simek wrote: On 17.12.2015 14:37, Thomas Chou wrote: Hi Michal, On 2015年12月17日 20:00, Michal Simek wrote: Enable SPL DM too. Signed-off-by: Michal Simek --- Changes in v2: - Remove unneeded headers - Use get_dev_addr instead of fdtdec_get_addr - Use

[U-Boot] [PATCH] serial-howto: remove altera_jtag_uart and altera_uart from the list

2015-12-17 Thread Thomas Chou
Since both altera_jtag_uart and altera_uart are converted to driver model, remove them from the list of drivers remaining to convert. Signed-off-by: Thomas Chou --- doc/driver-model/serial-howto.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/doc/driver-model/serial-howto.txt b/doc

Re: [U-Boot] [PATCH v2 1/3] serial: uartlite: Move driver to DM

2015-12-17 Thread Thomas Chou
put) + return in_be32(®s->status) & SR_RX_FIFO_VALID_DATA; + + return in_be32(®s->status) & SR_TX_FIFO_EMPTY; Should be inversed. Otherwise, Reviewed-by: Thomas Chou } -static int uartlite_serial_init(const int port) +static int uartlite_serial_probe(struc

Re: [U-Boot] [PATCH v2 3/3] serial: uartlite: Add uartlite to Kconfig

2015-12-17 Thread Thomas Chou
address */ Reviewed-by: Thomas Chou Best regards, Thomas ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 2/3] serial: uartlite: Add support for debug console

2015-12-17 Thread Thomas Chou
ART_UARTLITE + +#include + +void _debug_uart_init(void) Still missing, static inline Otherwise, Reviewed-by: Thomas Chou +{ + struct uartlite *regs = (struct uartlite *)CONFIG_DEBUG_UART_BASE; + + out_be32(®s->control, 0); + out_be32(®s->control, ULITE_CONTROL

Re: [U-Boot] [PATCH] nios2: display altera sysid at startup

2015-12-16 Thread Thomas Chou
Hi Marek, On 2015年12月16日 21:23, Marek Vasut wrote: On Wednesday, December 16, 2015 at 02:10:26 PM, Thomas Chou wrote: Hi Marek, Hi! On 2015年12月16日 18:25, Marek Vasut wrote: On Wednesday, December 16, 2015 at 09:07:47 AM, Thomas Chou wrote: Display altera sysid at startup, which was once

Re: [U-Boot] [PATCH V2 1/2] nios2: Enable support for fitImage

2015-12-16 Thread Thomas Chou
Hi Marek, On 2015年12月16日 18:26, Marek Vasut wrote: +CONFIG_FIT=y Amended with savedefconfig and applied to u-boot-nios. Thanks. Thanks! How exactly did you regenerate those defconfigs please ? Did you do just make nnn_config ; make savedefconfig ; cp defconfig configs/nnn_defconfig ? Yes,

Re: [U-Boot] [PATCH] nios2: display altera sysid at startup

2015-12-16 Thread Thomas Chou
Hi Marek, On 2015年12月16日 18:25, Marek Vasut wrote: On Wednesday, December 16, 2015 at 09:07:47 AM, Thomas Chou wrote: Display altera sysid at startup, which was once removed during the move. Signed-off-by: Thomas Chou What if the sysid block isn't part of the design ? If the sysid

[U-Boot] [PATCH] nios2: display altera sysid at startup

2015-12-16 Thread Thomas Chou
Display altera sysid at startup, which was once removed during the move. Signed-off-by: Thomas Chou --- arch/nios2/cpu/cpu.c | 8 1 file changed, 8 insertions(+) diff --git a/arch/nios2/cpu/cpu.c b/arch/nios2/cpu/cpu.c index f6d5cd3..be7f99c 100644 --- a/arch/nios2/cpu/cpu.c +++ b

Re: [U-Boot] [PATCH V2 2/2] nios2: Soup up the shell experience

2015-12-15 Thread Thomas Chou
Hi Marek, On 2015年12月16日 08:32, Marek Vasut wrote: Enable command auto completion and enable $version variable. This makes working with U-Boot far more enjoyable. Signed-off-by: Marek Vasut Cc: Thomas Chou --- include/configs/10m50_devboard.h | 2 ++ include/configs/3c120_devboard.h | 2

Re: [U-Boot] [PATCH V2 1/2] nios2: Enable support for fitImage

2015-12-15 Thread Thomas Chou
: Thomas Chou --- configs/10m50_defconfig | 1 + configs/3c120_defconfig | 1 + 2 files changed, 2 insertions(+) V2: Move CONFIG_FIT into Kconfig Drop duplicate CONFIG_OF_LIBFDT definition diff --git a/configs/10m50_defconfig b/configs/10m50_defconfig index 0d18e8d..c179a0f 100644 --- a

Re: [U-Boot] [PATCH 2/3] serial: uartlite: Add support for debug console

2015-12-15 Thread Thomas Chou
Hi Michal, On 2015年12月15日 23:38, Michal Simek wrote: Hi, On 15.12.2015 05:01, Thomas Chou wrote: Hi Michal, On 2015年12月14日 23:50, Michal Simek wrote: Hi, On 14.12.2015 14:14, Thomas Chou wrote: Hi Michal, On 2015年12月11日 19:54, Michal Simek wrote: Signed-off-by: Michal Simek

Re: [U-Boot] [PATCH 3/3] serial: uartlite: Add uartlite to Kconfig

2015-12-15 Thread Thomas Chou
Hi Michal, On 2015年12月15日 23:39, Michal Simek wrote: On 15.12.2015 05:02, Thomas Chou wrote: Hi Michal, On 2015年12月14日 23:42, Michal Simek wrote: On 14.12.2015 15:35, Thomas Chou wrote: Hi Michal, On 2015年12月11日 19:54, Michal Simek wrote: - Move config option out of board file. - Remove

Re: [U-Boot] [PATCH 4/5] nios2: Enable support for fitImage

2015-12-15 Thread Thomas Chou
Hi Marek, On 2015年12月16日 07:18, Marek Vasut wrote: On Tuesday, December 15, 2015 at 02:26:44 PM, Thomas Chou wrote: Hi Marek, On 2015年12月15日 18:26, Marek Vasut wrote: On Tuesday, December 15, 2015 at 06:31:11 AM, Thomas Chou wrote: Hi Marek, On 2015年12月15日 10:09, Marek Vasut wrote: The

Re: [U-Boot] [PATCH 4/5] nios2: Enable support for fitImage

2015-12-15 Thread Thomas Chou
Hi Marek, On 2015年12月15日 18:26, Marek Vasut wrote: On Tuesday, December 15, 2015 at 06:31:11 AM, Thomas Chou wrote: Hi Marek, On 2015年12月15日 10:09, Marek Vasut wrote: The uImage format is legacy for years now, enable support for the fitImage format, which allows combining multiple files

Re: [U-Boot] [PATCH 2/5] nios2: Up the monitor size to 512kiB

2015-12-15 Thread Thomas Chou
Hi Marek, On 2015年12月15日 10:09, Marek Vasut wrote: The monitor is growing much larger with various additions, like fitImage, command line completion, UBI etc. Make the monitor area larger so these features can be safely added. Signed-off-by: Marek Vasut Cc: Thomas Chou --- include/configs

Re: [U-Boot] [PATCH 3/5] nios2: Preconfigure $loadaddr variable

2015-12-15 Thread Thomas Chou
Vasut Cc: Thomas Chou --- include/configs/10m50_devboard.h | 3 ++- include/configs/3c120_devboard.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) Applied to u-boot-nios. Thanks. Best regards, Thomas ___ U-Boot mailing list U-Boot@lists.de

Re: [U-Boot] [PATCH 1/5] nios2: Calculate the env position from monitor size

2015-12-15 Thread Thomas Chou
: Thomas Chou --- include/configs/10m50_devboard.h | 26 +- include/configs/3c120_devboard.h | 26 +- 2 files changed, 26 insertions(+), 26 deletions(-) Applied to u-boot-nios. Thanks. ___ U-Boot mailing

Re: [U-Boot] [PATCH] serial: Use static inline for _debug_uart_init()

2015-12-15 Thread Thomas Chou
Hi Michal, On 2015年12月14日 23:53, Michal Simek wrote: Reported-by: Thomas Chou Signed-off-by: Michal Simek --- drivers/serial/serial_xuartlite.c | 2 +- drivers/serial/serial_zynq.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/serial

Re: [U-Boot] [PATCH 5/5] nios2: Soup up the shell experience

2015-12-14 Thread Thomas Chou
Hi Marek, On 2015年12月15日 10:09, Marek Vasut wrote: Enable command auto completion and enable $version variable. This makes working with U-Boot far more enjoyable. Signed-off-by: Marek Vasut Cc: Thomas Chou --- include/configs/10m50_devboard.h | 3 +++ include/configs/3c120_devboard.h | 3

Re: [U-Boot] [PATCH 4/5] nios2: Enable support for fitImage

2015-12-14 Thread Thomas Chou
: Thomas Chou --- include/configs/10m50_devboard.h | 2 ++ include/configs/3c120_devboard.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/include/configs/10m50_devboard.h b/include/configs/10m50_devboard.h index 608127f..0aa79f7 100644 --- a/include/configs/10m50_devboard.h +++ b/include

Re: [U-Boot] [PATCH 3/5] nios2: Preconfigure $loadaddr variable

2015-12-14 Thread Thomas Chou
Vasut Cc: Thomas Chou --- include/configs/10m50_devboard.h | 3 ++- include/configs/3c120_devboard.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/include/configs/10m50_devboard.h b/include/configs/10m50_devboard.h index 68ef6e5..608127f 100644 --- a/include/configs/10m50_

Re: [U-Boot] [PATCH 1/5] nios2: Calculate the env position from monitor size

2015-12-14 Thread Thomas Chou
: Thomas Chou --- include/configs/10m50_devboard.h | 26 +- include/configs/3c120_devboard.h | 26 +- 2 files changed, 26 insertions(+), 26 deletions(-) diff --git a/include/configs/10m50_devboard.h b/include/configs/10m50_devboard.h index 8a91cdb

Re: [U-Boot] [PATCH 2/5] nios2: Up the monitor size to 512kiB

2015-12-14 Thread Thomas Chou
Hi Marek, On 2015年12月15日 10:09, Marek Vasut wrote: The monitor is growing much larger with various additions, like fitImage, command line completion, UBI etc. Make the monitor area larger so these features can be safely added. Signed-off-by: Marek Vasut Cc: Thomas Chou --- include/configs

  1   2   3   4   5   6   7   8   9   10   >