Pass a valid cmdtp into do_tftpb(), do_ext2load(), and do_get_fat(), to avoid
possible crashes due to null pointer dereferencing.
Signed-off-by: Steven A. Falco
---
Commit d7884e047d08447dfd1374e9fa2fdf7ab36e56f5 does not go far enough. There
is still at least one call chain that can result
Pass a valid cmdtp into do_tftpb(), do_ext2load(), and do_get_fat(), to avoid
possible crashes due to null pointer dereferencing.
Signed-off-by: Steven A. Falco
---
Commit d7884e047d08447dfd1374e9fa2fdf7ab36e56f5 does not go far enough. There
is still at least one call chain that can result
On 05/05/2011 10:08 AM, Steven A. Falco wrote:
> APM errata CHIP_21 for the 405EX/EXr (from the rev 1.09 document dated
> 4/27/11) states that rev D processors may wake up with the wrong feature
> set. This patch implements the APM-proposed workaround.
I have not seen any further co
APM errata CHIP_21 for the 405EX/EXr (from the rev 1.09 document dated
4/27/11) states that rev D processors may wake up with the wrong feature
set. This patch implements the APM-proposed workaround.
To enable this patch for your board, add the appropriate define for your
CPU to your board header
v2:
Correct checkpatch errors/warnings re: whitespace, comment style, etc.
Move PVR logic out of board config file.
Simplify ifdef structure.
APM errata CHIP_21 for the 405EX/EXr (from the rev 1.09 document dated
4/27/11) states that rev D processors may wake up with the wrong feature
set. I've p
On 05/04/2011 04:36 AM, Stefan Roese wrote:
> Hi Steve,
>
> On Tuesday 03 May 2011 18:59:00 Steven A. Falco wrote:
>> APM errata CHIP_21 for the 405EX/EXr (from the rev 1.09 document dated
>> 4/27/11) states that rev D processors may wake up with the wrong feature
>>
APM errata CHIP_21 for the 405EX/EXr (from the rev 1.09 document dated 4/27/11)
states that rev D processors may wake up with the wrong feature set. I've
personally seen that happen. This patch implements the APM-proposed workaround.
Note that you cannot blindly use this workaround. You must ad
> Hi Steve,
>
> On Friday 29 April 2011 18:54:02 Steven A. Falco wrote:
>> We've been bitten by the PPC405EX CHIP_21 erratum.
>
> How did it affect you exactly? Was an incorrect PVR detected? Did this result
> in some problems (Linux etc)?
The problem goes way b
We've been bitten by the PPC405EX CHIP_21 erratum. I've looked through the
U-Boot code, but it doesn't appear that there is a work-around for this one.
The following patch is my adaptation of AMCC's suggestion as to the fix. But
I have to say that I don't care for it, if for no other reason that
Ben Warren wrote:
>
> Hi Wolfgang,
>
> Wolfgang Denk wrote:
>> Dear Ben Warren,
>>
>> In message <[EMAIL PROTECTED]> you wrote:
>>
>>> Why not enable this feature on Sequoia? Wolfgang's argument for
>>> keeping the patch out then goes away. IMHO, eval boards should have
>>> as many options en
Wolfgang Denk wrote:
> Dear Ben Warren,
>
> In message <[EMAIL PROTECTED]> you wrote:
>> Why not enable this feature on Sequoia? Wolfgang's argument for keeping
>> the patch out then goes away. IMHO, eval boards should have as many
>> options enabled by default as possible, and the user then h
Ben Warren wrote:
>
... snip ...
>>
> Why not enable this feature on Sequoia? Wolfgang's argument for keeping
> the patch out then goes away. IMHO, eval boards should have as many
> options enabled by default as possible, and the user then has the option
> to opt out.
I can do that if Stef
This patch adds helper routines needed in support of the PPC4xx SPI driver.
Signed-off-by: Steven A. Falco <[EMAIL PROTECTED]>
---
Changed CONFIG constant to CONFIG_PPC4xx_SPI.
board/amcc/sequoia/sequoia.c | 20
include/configs/sequoia.h|4
2 files c
This patch adds an SPI driver for the 440EPx processor.
Tested on Sequoia.
Signed-off-by: Steven A. Falco <[EMAIL PROTECTED]>
---
Thanks for the comments.
I've added the in/out accessors, and included the other comments made by
reviewers (inlines, etc). The patch passes a chec
This patch adds helper routines needed in support of the 440EPx SPI driver.
Signed-off-by: Steven A. Falco <[EMAIL PROTECTED]>
---
Regarding Wolfgang's comments:
The style I saw in the existing code is to have these three functions in
a board-specific file. That way, the routines
This patch adds an SPI driver for the 440EPx processor.
Tested on Sequoia.
Signed-off-by: Steven A. Falco <[EMAIL PROTECTED]>
---
Regarding Ben's comments:
First, thanks for reviewing. You gave me two different approaches to consider,
1) using in/out functions, and 2) using a str
This patch adds a SPI driver for the PPC440EPx processor.
Signed-off-by: Steven A. Falco <[EMAIL PROTECTED]>
---
Sorry - forgot the subject line, the first time.
cpu/ppc4xx/Makefile |1 +
cpu/ppc4xx/spi.c| 128 +++
include/4xx
This patch adds SPI helper routines for the Sequoia board.
Signed-off-by: Steven A. Falco <[EMAIL PROTECTED]>
---
board/amcc/sequoia/sequoia.c | 20
1 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/board/amcc/sequoia/sequoia.c b/board/amcc/sequoia/seq
The following patch adds an SPI driver for the PPC440EPx processor.
Signed-off-by: Steven A. Falco <[EMAIL PROTECTED]>
---
I've tested this with a Sequoia board.
cpu/ppc4xx/Makefile |1 +
cpu/ppc4xx/spi.c| 128 +++
includ
The definitions of bits in SDR_CFG are incorrect, and not used within
U-Boot. Therefore, they can be removed.
The naming of the sdr_ddrdl/sdr_cfg registers do not follow conventions,
and are unused, so they can be removed too.
A definition for SDR0_DDRCFG is added.
Signed-off-by: Steven A
The definitions of bits in SDR_CFG are incorrect, and not used within
U-Boot. Therefore, they can be removed.
Signed-off-by: Steven A. Falco <[EMAIL PROTECTED]>
---
As per Stefan's request, here is a patch removing the unused, incorrect
definitions.
Note that the AMCC DDR sprea
The bits in ppc440.h for the SDR0_DDRCFG register are incorrect. The
register is numbered in big-endian mode, so for example, the LT2 bit
(bit 23) should be represented as 0x0100 rather than 0x0100.
Signed-off-by: Steven A. Falco <[EMAIL PROTECTED]>
---
diff --git a/include/ppc4
Wolfgang Denk wrote:
> Dear "Steven A. Falco",
>
> In message <[EMAIL PROTECTED]> you wrote:
>> I realized that I should be checking to see if word 163 is applicable to
>> the ATA device in question. To do that, I need to call ata_id_is_cfa() from
>>
Wolfgang Denk wrote:
> Dear "Steven A. Falco",
>
> In message <[EMAIL PROTECTED]> you wrote:
>> I realized that I should be checking to see if word 163 is applicable to
>> the ATA device in question. To do that, I need to call ata_id_is_cfa() from
>>
Wolfgang Denk wrote:
> Dear "Steven A. Falco",
>
> In message <[EMAIL PROTECTED]> you wrote:
>> I realized that I should be checking to see if word 163 is applicable to
>> the ATA device in question. To do that, I need to call ata_id_is_cfa() from
>>
duplicate enums
from ata.h and instead includes libata.h to supply the enums. Then, I
can call ata_id_is_cfa() and more accurately detect PIO 5 and 6.
I believe cleaning up ata.h is a good thing, because duplicating the enums in
both places invites them to get out of sync.
Signed-off-by: Steven A
Jean-Christophe PLAGNIOL-VILLARD wrote:
>> ---
>> common/cmd_ide.c | 52
>> include/ata.h|4 +++-
>> 2 files changed, 55 insertions(+), 1 deletions(-)
>>
>> diff --git a/common/cmd_ide.c b/common/cmd_ide.c
>> index b4d9719..0e435a7 100
Wolfgang Denk wrote:
> Dear "Steven A. Falco",
>
> In message <[EMAIL PROTECTED]> you wrote:
>> The following patch adds the ability to call-out from the ide_ident
>> routine to a board-specific routine to set the PIO mode of an attached
>> devi
The following patch adds the ability to call-out from the ide_ident
routine to a board-specific routine to set the PIO mode of an attached
device.
This feature is controlled by the preprocessor variable CONFIG_TUNE_CFA.
cmd_ide.c is modified to use the "drive identify information" read from the
d
29 matches
Mail list logo
