Re: [PATCH v2] common: usb-hub: Reset USB 3.0 hubs only

2024-02-19 Thread Shantur Rathore
Hi Marek, On Wed, Feb 14, 2024 at 9:55 AM Shantur Rathore wrote: > > Additional testing of the changes introduced in commit 33e06dcbe57a "common: > usb-hub: Reset hub port before scanning") revealed that some USB 2.0 and 3.0 > flash drives didn't work in U-Boot

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-14 Thread Shantur Rathore
On Wed, Feb 14, 2024 at 9:56 AM Shantur Rathore wrote: > > On Wed, Feb 14, 2024 at 3:48 AM Dragan Simic wrote: > > > > Hello Shantur and Marek, > > > > On 2024-02-14 04:18, Dragan Simic wrote: > > > On 2024-02-14 03:04, Andre Przywara wrote: > > >

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-14 Thread Shantur Rathore
On Wed, Feb 14, 2024 at 3:48 AM Dragan Simic wrote: > > Hello Shantur and Marek, > > On 2024-02-14 04:18, Dragan Simic wrote: > > On 2024-02-14 03:04, Andre Przywara wrote: > >> On Mon, 12 Feb 2024 21:19:13 +0100 Marek Vasut wrote: > >>> On 2/12/24 14:41

[PATCH v2] common: usb-hub: Reset USB 3.0 hubs only

2024-02-14 Thread Shantur Rathore
5125-...@shantur.com/T/#u Link: https://lore.kernel.org/u-boot/20240201164604.13315...@donnerap.manchester.arm.com/T/#u Signed-off-by: Shantur Rathore Helped-by: Dragan Simic Tested-by: Andre Przywara Reviewed-by: Dragan Simic --- (no changes since v1) common/usb_hub.c | 6 -- 1 file

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-12 Thread Shantur Rathore
On Mon, Feb 12, 2024 at 1:40 PM Shantur Rathore wrote: > > Thanks Dragan, > > On Sat, Feb 10, 2024 at 7:13 AM Dragan Simic wrote: > > > > Hello Shantur, > > > > On 2024-02-08 15:17, Dragan Simic wrote: > > > On 2024-02-08 15:10, Shantur Rathore wrote:

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-12 Thread Shantur Rathore
Thanks Dragan, On Sat, Feb 10, 2024 at 7:13 AM Dragan Simic wrote: > > Hello Shantur, > > On 2024-02-08 15:17, Dragan Simic wrote: > > On 2024-02-08 15:10, Shantur Rathore wrote: > >> On Thu, Feb 8, 2024 at 1:44 PM Dragan Simic > >> wrote: > >

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-08 Thread Shantur Rathore
On Thu, Feb 8, 2024 at 1:44 PM Dragan Simic wrote: > > On 2024-02-08 14:33, Marek Vasut wrote: > > On 2/8/24 12:30, Shantur Rathore wrote: > >> On Wed, Feb 7, 2024 at 1:07 PM Marek Vasut wrote: > >>> On 2/7/24 11:23, Shantur Rathore wrote: > >>>>

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-08 Thread Shantur Rathore
Hi Marek, On Wed, Feb 7, 2024 at 1:07 PM Marek Vasut wrote: > > On 2/7/24 11:23, Shantur Rathore wrote: > > USB 3.0 spec requires hub to reset device while > > enumeration. Some USB 2.0 hubs / devices don't > > handle this well and after implementation of > &g

[FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-07 Thread Shantur Rathore
ned-off-by: Shantur Rathore --- common/usb_hub.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/common/usb_hub.c b/common/usb_hub.c index 3fb7e14d10..2e054eb935 100644 --- a/common/usb_hub.c +++ b/common/usb_hub.c @@ -174,8 +174,10 @@ static void usb_hub_power

Re: [PATCH v3] common: usb-hub: Reset hub port before scanning

2024-02-07 Thread Shantur Rathore
On Wed, Feb 7, 2024 at 9:22 AM Shantur Rathore wrote: > > Hi Dragan and Andre, > > On Sat, Feb 3, 2024 at 10:39 AM Dragan Simic wrote: > > > > Hello Andre and Shantur, > > > > On 2024-02-02 12:28, Andre Przywara wrote: > > > On Fri, 02 Feb 2024 03:35:

Re: [PATCH v3] common: usb-hub: Reset hub port before scanning

2024-02-07 Thread Shantur Rathore
gt; >> > On Thu, 1 Feb 2024 18:35:28 + Shantur Rathore > >> > wrote: > >> >> On Thu, Feb 1, 2024 at 4:46 PM Andre Przywara > >> >> wrote: > >> >> > On Thu, 1 Feb 2024 09:39:54 + Shantur Rathore > >> >> &

Re: [PATCH v3] common: usb-hub: Reset hub port before scanning

2024-02-01 Thread Shantur Rathore
Hi Andre, On Thu, Feb 1, 2024 at 4:46 PM Andre Przywara wrote: > > On Thu, 1 Feb 2024 09:39:54 +0000 > Shantur Rathore wrote: > > Hi Shantur, > > > On Tue, Jan 30, 2024 at 2:01 PM Andre Przywara > > wrote: > > > > > > On Sat, 9 Dec

Re: [PATCH v3] common: usb-hub: Reset hub port before scanning

2024-02-01 Thread Shantur Rathore
On Thu, Feb 1, 2024 at 2:53 PM Marek Vasut wrote: > > On 2/1/24 12:18, Shantur Rathore wrote: > > On Thu, Feb 1, 2024 at 11:13 AM Marek Vasut wrote: > >> > >> On 2/1/24 10:39, Shantur Rathore wrote: > >>> Hi Andre, > >>> > >>

Re: [PATCH v3] common: usb-hub: Reset hub port before scanning

2024-02-01 Thread Shantur Rathore
On Thu, Feb 1, 2024 at 11:13 AM Marek Vasut wrote: > > On 2/1/24 10:39, Shantur Rathore wrote: > > Hi Andre, > > > > On Tue, Jan 30, 2024 at 2:01 PM Andre Przywara > > wrote: > >> > >> On Sat, 9 Dec 2023 18:10:56 + > >> Shantur Rath

Re: [PATCH v3] common: usb-hub: Reset hub port before scanning

2024-02-01 Thread Shantur Rathore
Hi Andre, On Tue, Jan 30, 2024 at 2:01 PM Andre Przywara wrote: > > On Sat, 9 Dec 2023 18:10:56 +0000 > Shantur Rathore wrote: > > Hi, > > > Currently when a hub is turned on, all the ports are powered on. > > This works well for hubs which have individual power

Re: [PATCH v3] arch: arm: Kconfig: Enable BOOTSTD_FULL for Rockchip SoCs

2024-01-21 Thread Shantur Rathore
Hi Kever, On Thu, Jan 18, 2024 at 3:10 AM Kever Yang wrote: > > Hi Shantur, > > On 2024/1/17 17:38, Shantur Rathore wrote: > > Hi Kever, > > > > On Wed, Jan 17, 2024 at 9:18 AM Kever Yang > > wrote: > >> Hi Shantur, > >> > >>

[PATCH v5] arch: arm: mach-rockchip: Kconfig: Enable BOOTSTD_FULL for RK3399 and RK3588

2024-01-21 Thread Shantur Rathore
Rockchip RK3399 and RK3588 SoCs can support wide range of bootflows. Without full bootflow commands, it can be difficult to figure out issues if any, hence enable by default. Reviewed-by: Simon Glass Signed-off-by: Shantur Rathore --- Changes in v5: - Only enable it for RK3399 and RK3588 as

Re: [PATCH v3] common: usb-hub: Reset hub port before scanning

2024-01-21 Thread Shantur Rathore
On Tue, Jan 16, 2024 at 12:45 AM Marek Vasut wrote: > > On 1/8/24 23:11, Shantur Rathore wrote: > > Hi Marex, > > > > On Sat, Dec 9, 2023 at 6:12 PM Shantur Rathore wrote: > >> > >> Currently when a hub is turned on, all the ports are powered on

Re: [PATCH v3] arch: arm: Kconfig: Enable BOOTSTD_FULL for Rockchip SoCs

2024-01-17 Thread Shantur Rathore
Hi Kever, On Wed, Jan 17, 2024 at 9:18 AM Kever Yang wrote: > > Hi Shantur, > > On 2024/1/17 14:26, Shantur Rathore wrote: > > Hi Kever, > > On Wed, Jan 10, 2024 at 11:58 AM Shantur Rathore wrote: > > Hi Kever, > > On Tue, Jan 9, 2024 at 10:55 AM Kever Yang

Re: [PATCH v1] Kconfig: boot: Imply BOOTSTD_DEFAULT when BOOTSTD_FULL=y

2024-01-16 Thread Shantur Rathore
On Sat, Dec 23, 2023 at 6:53 AM Shantur Rathore wrote: > > We need BOOTSTD_DEFAULT when BOOTSTD_FULL is selected. > > Signed-off-by: Shantur Rathore > --- > > boot/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/boot/Kconfig b/boot/Kconfig > in

Re: [PATCH v3] arch: arm: Kconfig: Enable BOOTSTD_FULL for Rockchip SoCs

2024-01-16 Thread Shantur Rathore
Hi Kever, On Wed, Jan 10, 2024 at 11:58 AM Shantur Rathore wrote: > > Hi Kever, > > On Tue, Jan 9, 2024 at 10:55 AM Kever Yang wrote: > > > > Hi Shantur, Tom, > > > > On 2023/12/10 04:45, Tom Rini wrote: > > > On Sat, Dec 09, 2023 at 07:49:04PM +

Re: [PATCH v3] common: usb-hub: Reset hub port before scanning

2024-01-15 Thread Shantur Rathore
On Mon, Jan 8, 2024 at 10:11 PM Shantur Rathore wrote: > > Hi Marex, > > On Sat, Dec 9, 2023 at 6:12 PM Shantur Rathore wrote: > > > > Currently when a hub is turned on, all the ports are powered on. > > This works well for hubs which have individual power control

Re: [PATCH v3] arch: arm: Kconfig: Enable BOOTSTD_FULL for Rockchip SoCs

2024-01-10 Thread Shantur Rathore
Hi Kever, On Tue, Jan 9, 2024 at 10:55 AM Kever Yang wrote: > > Hi Shantur, Tom, > > On 2023/12/10 04:45, Tom Rini wrote: > > On Sat, Dec 09, 2023 at 07:49:04PM +0000, Shantur Rathore wrote: > >> On Sat, Dec 9, 2023 at 7:18 PM Tom Rini wrote: > >>> O

Re: [PATCH v3] common: usb-hub: Reset hub port before scanning

2024-01-08 Thread Shantur Rathore
Hi Marex, On Sat, Dec 9, 2023 at 6:12 PM Shantur Rathore wrote: > > Currently when a hub is turned on, all the ports are powered on. > This works well for hubs which have individual power control. > > For the hubs without individual power control this has no effect. > Mostly

[PATCH v1] Kconfig: boot: Imply BOOTSTD_DEFAULT when BOOTSTD_FULL=y

2023-12-22 Thread Shantur Rathore
We need BOOTSTD_DEFAULT when BOOTSTD_FULL is selected. Signed-off-by: Shantur Rathore --- boot/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/boot/Kconfig b/boot/Kconfig index 9f5b8a0cb2..fc96aadb27 100644 --- a/boot/Kconfig +++ b/boot/Kconfig @@ -426,6 +426,7 @@ config

Re: [PATCH v3] arch: arm: Kconfig: Enable BOOTSTD_FULL for Rockchip SoCs

2023-12-22 Thread Shantur Rathore
Hi, On Fri, Dec 22, 2023 at 12:09 PM Shantur Rathore wrote: > > On Fri, Dec 22, 2023 at 12:07 PM Tom Rini wrote: > > > > On Fri, Dec 22, 2023 at 12:05:39PM +0000, Shantur Rathore wrote: > > > Hi all, > > > > > > On Mon, Dec 11, 2023 at 6:27 PM To

[PATCH v4] arch: arm: Kconfig: Enable BOOTSTD_FULL for Rockchip SoCs

2023-12-22 Thread Shantur Rathore
Rockchip SoCs can support wide range of bootflows. Without full bootflow commands, it can be difficult to figure out issues if any, hence enable by default. Reviewed-by: Simon Glass Signed-off-by: Shantur Rathore --- Changes in v4: - Replace BOOTSTD_DEFAULT with BOOTSTD_FULL as previous

[PATCH v4] dts: rockpro64: Disable usb regulators-always-on

2023-12-22 Thread Shantur Rathore
USB port regulators should be controlled by PHYs so we remove always-on property and let phy manage the regulator. phy-supply isn't configured for TypeC port in upstream and now that we are removing always-on, we need to add the phy-supply until its fixed upstream. Signed-off-by: Shantur Ra

Re: [PATCH v3] arch: arm: Kconfig: Enable BOOTSTD_FULL for Rockchip SoCs

2023-12-22 Thread Shantur Rathore
On Fri, Dec 22, 2023 at 12:07 PM Tom Rini wrote: > > On Fri, Dec 22, 2023 at 12:05:39PM +, Shantur Rathore wrote: > > Hi all, > > > > On Mon, Dec 11, 2023 at 6:27 PM Tom Rini wrote: > > > > > > On Mon, Dec 11, 2023 at 11:22:45AM -0700, Simo

Re: [PATCH v3] arch: arm: Kconfig: Enable BOOTSTD_FULL for Rockchip SoCs

2023-12-22 Thread Shantur Rathore
Hi all, On Mon, Dec 11, 2023 at 6:27 PM Tom Rini wrote: > > On Mon, Dec 11, 2023 at 11:22:45AM -0700, Simon Glass wrote: > > Hi Tom, > [snip] > > > I think in hind-sight too much stuff is omitted without BOOTSTD_FULL. > > > The option itself then enables other stuff too by default, but some > > >

Re: [tom.r...@gmail.com: Fwd: New Defects reported by Coverity Scan for Das U-Boot]

2023-12-21 Thread Shantur Rathore
Hi Tom, On Mon, Dec 18, 2023 at 4:26 PM Tom Rini wrote: > > Here's the latest report. > > -- Forwarded message - > From: > Date: Mon, Dec 18, 2023 at 8:42 AM > Subject: New Defects reported by Coverity Scan for Das U-Boot > To: > > > Hi, > > Please find the latest report on new

Re: Adding EFI runtime support to the Arm's FF-A bus

2023-12-21 Thread Shantur Rathore
Hi Ilias, On Thu, Dec 21, 2023 at 6:30 AM Ilias Apalodimas wrote: > > Hi Shantur > > On Thu, 21 Dec 2023 at 00:57, Shantur Rathore wrote: > > > > Hi Illias, > > > > On Wed, Dec 20, 2023 at 3:43 PM Peter Robinson wrote: > > > > > > On Wed,

Re: Adding EFI runtime support to the Arm's FF-A bus

2023-12-20 Thread Shantur Rathore
Hi Illias, On Wed, Dec 20, 2023 at 3:43 PM Peter Robinson wrote: > > On Wed, Dec 20, 2023 at 6:37 AM Ilias Apalodimas > wrote: > > > > Hi Michael > > > > On Tue, 19 Dec 2023 at 14:47, Michael Walle wrote: > > > > > > Hi Mark, > > > > > > >> > Any runtime device drivers for variable storage shou

Re: [PATCH v4] arm: dts: rockpro64: Add RockPro64 smbios

2023-12-14 Thread Shantur Rathore
m Rini wrote: > > > > > > > > On Mon, Dec 11, 2023 at 08:42:19PM +, Shantur Rathore wrote: > > > > > Hi, > > > > > > > > > > On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore > > > > > wrote: > > > >

Re: [PATCH] maintainers: rk3399: remove maintainer

2023-12-14 Thread Shantur Rathore
On Wed, Dec 13, 2023 at 11:06 PM Tom Rini wrote: > > On Fri, Nov 24, 2023 at 12:04:31PM +, Shantur Rathore wrote: > > > Remove Akash Gajjar from > > MAINTAINERS as email is bouncing. > > > > Signed-off-by: Shantur Rathore > > Reviewed-by: Kever Yan

Re: [PATCH v4] arm: dts: rockpro64: Add RockPro64 smbios

2023-12-11 Thread Shantur Rathore
Hi, On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore wrote: > > Add smbios information for Pine64 RockPro64 board and enable in > config > > Signed-off-by: Shantur Rathore > --- > Changes > v4: Change PINE64 to Pine64 > v3: Enable SYSINFO and SYSINFO_SMBIOS in

Re: [PATCH v2 2/2] dts: rockpro64: Disable usb regulators-always-on

2023-12-09 Thread Shantur Rathore
On Sat, Dec 9, 2023 at 10:20 PM Shantur Rathore wrote: > > On Sat, Dec 9, 2023 at 10:05 PM Marek Vasut wrote: > > > > On 12/9/23 18:57, Shantur Rathore wrote: > > > Hi Marek, > > > > > > On Sat, Dec 9, 2023 at 5:31 PM Marek Vasut wrote: > >

Re: bootstd: Support for distro specific EFI folders

2023-12-09 Thread Shantur Rathore
On Sat, Dec 9, 2023 at 4:26 PM Shantur Rathore wrote: > > Hi Peter, > > On Wed, Dec 6, 2023 at 12:16 PM Peter Robinson wrote: > > > > On Sun, Nov 19, 2023 at 6:55 PM Mark Kettenis > > wrote: > > > > > > > Date: Sat, 18 Nov 2023 23:52:11 +010

Re: [PATCH v2 2/2] dts: rockpro64: Disable usb regulators-always-on

2023-12-09 Thread Shantur Rathore
On Sat, Dec 9, 2023 at 10:05 PM Marek Vasut wrote: > > On 12/9/23 18:57, Shantur Rathore wrote: > > Hi Marek, > > > > On Sat, Dec 9, 2023 at 5:31 PM Marek Vasut wrote: > >> > >> On 12/8/23 01:09, Shantur Rathore wrote: > >>> USB port

Re: [PATCH v3] arch: arm: Kconfig: Enable BOOTSTD_FULL for Rockchip SoCs

2023-12-09 Thread Shantur Rathore
On Sat, Dec 9, 2023 at 8:56 PM Tom Rini wrote: > > On Fri, Dec 08, 2023 at 01:59:26PM +, Shantur Rathore wrote: > > Hi Peter, > > > > On Fri, Dec 8, 2023 at 12:59 PM Peter Robinson wrote: > > > > > > On Fri, Dec 8, 2023 at 12:52 PM Shantu

Re: [PATCH v3] arch: arm: Kconfig: Enable BOOTSTD_FULL for Rockchip SoCs

2023-12-09 Thread Shantur Rathore
On Sat, Dec 9, 2023 at 7:18 PM Tom Rini wrote: > > On Fri, Dec 08, 2023 at 10:52:02AM +, Shantur Rathore wrote: > > > Hi Tom / Kever > > > > On Sun, Nov 19, 2023 at 5:24 PM Shantur Rathore wrote: > > > > > > Rockchip SoCs can support wide ra

Re: [PATCH v2 2/2] dts: rockpro64: Disable usb regulators-always-on

2023-12-09 Thread Shantur Rathore
Hi Marek, On Sat, Dec 9, 2023 at 5:57 PM Shantur Rathore wrote: > > Hi Marek, > > On Sat, Dec 9, 2023 at 5:31 PM Marek Vasut wrote: > > > > On 12/8/23 01:09, Shantur Rathore wrote: > > > USB port regulators should be controlled by phys > > > > PHYs

[PATCH v3] common: usb-hub: Reset hub port before scanning

2023-12-09 Thread Shantur Rathore
ff-by: Shantur Rathore --- Changes in v3: - Split up patches as seperate series Changes in v2: - As requested, added fix for regulator-always-on in RockPro64 common/usb_hub.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/common/usb_hub.c b/common/usb_hub.c index 70279

[PATCH v3] dts: rockpro64: Disable usb regulators-always-on

2023-12-09 Thread Shantur Rathore
USB port regulators should be controlled by PHYs so we remove always-on property and let PHY manage the regulator. Typec port has misconfigured phy-supply in upstream and now that we are removing always-on, we need to fix the phy-supply until its fixed upstream. Signed-off-by: Shantur Rathore

Re: [PATCH v2 2/2] dts: rockpro64: Disable usb regulators-always-on

2023-12-09 Thread Shantur Rathore
Hi Marek, On Sat, Dec 9, 2023 at 5:31 PM Marek Vasut wrote: > > On 12/8/23 01:09, Shantur Rathore wrote: > > USB port regulators should be controlled by phys > > PHYs > > > so we remove always-on property and let phy manage the > > regulator. > > > >

Re: bootstd: Support for distro specific EFI folders

2023-12-09 Thread Shantur Rathore
Hi Peter, On Wed, Dec 6, 2023 at 12:16 PM Peter Robinson wrote: > > On Sun, Nov 19, 2023 at 6:55 PM Mark Kettenis wrote: > > > > > Date: Sat, 18 Nov 2023 23:52:11 +0100 > > > From: Heinrich Schuchardt > > > > Hi Heinrich, > > > > > On 1

Re: [PATCH v3] arch: arm: Kconfig: Enable BOOTSTD_FULL for Rockchip SoCs

2023-12-08 Thread Shantur Rathore
Hi Peter, On Fri, Dec 8, 2023 at 12:59 PM Peter Robinson wrote: > > On Fri, Dec 8, 2023 at 12:52 PM Shantur Rathore wrote: > > > > Hi Jagan, > > > > On Fri, Dec 8, 2023 at 11:13 AM Jagan Teki > > wrote: > > > > > > O

Re: [PATCH v3] arch: arm: Kconfig: Enable BOOTSTD_FULL for Rockchip SoCs

2023-12-08 Thread Shantur Rathore
Hi Jagan, On Fri, Dec 8, 2023 at 11:13 AM Jagan Teki wrote: > > On Sun, Nov 19, 2023 at 10:54 PM Shantur Rathore wrote: > > > > Rockchip SoCs can support wide range of bootflows. > > Without full bootflow commands, it can be difficult to > > figure out issues i

Re: [PATCH v3] arch: arm: Kconfig: Enable BOOTSTD_FULL for Rockchip SoCs

2023-12-08 Thread Shantur Rathore
Hi Tom / Kever On Sun, Nov 19, 2023 at 5:24 PM Shantur Rathore wrote: > > Rockchip SoCs can support wide range of bootflows. > Without full bootflow commands, it can be difficult to > figure out issues if any, hence enable by default. > > Reviewed-by: Simon Glass > >

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-12-07 Thread Shantur Rathore
Hi Marek, On Tue, Dec 5, 2023 at 5:40 AM Marek Vasut wrote: > > On 12/4/23 13:10, Shantur Rathore wrote: > > On Mon, Dec 4, 2023 at 11:05 AM Marek Vasut wrote: > >> > >> On 12/4/23 11:59, Shantur Rathore wrote: > >>> Hi Marek, > >>> &g

[PATCH v2 0/2] usb: Fix USB3 detection

2023-12-07 Thread Shantur Rathore
This patch series implements USB 3.0 port reset requirement before scanning port. Changes in v2: - As requested, added fix for regulator-always-on in RockPro64 Shantur Rathore (2): common: usb-hub: Reset hub port before scanning dts: rockpro64: Disable usb regulators-always-on arch/arm

[PATCH v2 2/2] dts: rockpro64: Disable usb regulators-always-on

2023-12-07 Thread Shantur Rathore
USB port regulators should be controlled by phys so we remove always-on property and let phy manage the regulator. Typec port has misconfugred phy-supply in upstream and now that we are removing always-on, we need to fix the phy-supply until its fixed upstream. Signed-off-by: Shantur Rathore

[PATCH v2 1/2] common: usb-hub: Reset hub port before scanning

2023-12-07 Thread Shantur Rathore
ff-by: Shantur Rathore --- (no changes since v1) common/usb_hub.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/common/usb_hub.c b/common/usb_hub.c index 85c0822d8b..06fe436add 100644 --- a/common/usb_hub.c +++ b/common/usb_hub.c @@ -174,8 +174,10 @@ static void usb_hub_pow

Re: bootstd: Support for distro specific EFI folders

2023-12-05 Thread Shantur Rathore
> > >>>> > > >>>> On 12/3/23 18:44, Simon Glass wrote: > > >>>>> Hi Heinrich, > > >>>>> > > >>>>> On Sun, 3 Dec 2023 at 03:55, Heinrich Schuchardt > > >>>>> wrote: > >

Re: [PATCH v4 0/4] bootflow: bootmeth_efi: Fix network efi boot.

2023-12-05 Thread Shantur Rathore
Hi Simon, On Tue, Dec 5, 2023 at 12:52 AM Simon Glass wrote: > > Hi Shantur, > > On Mon, 4 Dec 2023 at 05:38, Shantur Rathore wrote: > > > > Hi Simon, > > > > On Sun, Nov 19, 2023 at 4:56 PM Shantur Rathore wrote: > > > > > > > >

Re: [PATCH v4 0/4] bootflow: bootmeth_efi: Fix network efi boot.

2023-12-04 Thread Shantur Rathore
Hi Simon, On Sun, Nov 19, 2023 at 4:56 PM Shantur Rathore wrote: > > > Currently bootmeth_efi crashes while doing a network (dhcp) boot. > This patch series fixes issues and both network and disk boot works. > How can I help to get this patch series merged in? Kind Regards Shantur

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-12-04 Thread Shantur Rathore
On Mon, Dec 4, 2023 at 11:05 AM Marek Vasut wrote: > > On 12/4/23 11:59, Shantur Rathore wrote: > > Hi Marek, > > > > On Sun, Dec 3, 2023 at 10:37 PM Marek Vasut wrote: > >> > >> On 12/3/23 22:42, Shantur Rathore wrote: > >>> Hi Marek,

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-12-04 Thread Shantur Rathore
Hi Marek, On Sun, Dec 3, 2023 at 10:37 PM Marek Vasut wrote: > > On 12/3/23 22:42, Shantur Rathore wrote: > > Hi Marek, > > > > On Sun, Dec 3, 2023 at 8:42 PM Marek Vasut wrote: > >> > >> On 11/24/23 01:37, Shantur Rathore wrote: > >>> Hi M

Re: efi: Set Variable Runtime implementation

2023-12-03 Thread Shantur Rathore
Hi Simon, On Sun, Dec 3, 2023 at 5:44 PM Simon Glass wrote: > > Hi Shantur, > > On Sat, 2 Dec 2023 at 16:03, Shantur Rathore wrote: > > > > Hi Simon, > > > > On Fri, Dec 1, 2023 at 6:44 PM Simon Glass wrote: > > > > > > Hi Shantur, >

Re: [PATCH v3 3/3] defconfig: rockpro64: Enable SF EFI var store

2023-12-03 Thread Shantur Rathore
Hi Simon, On Sun, Dec 3, 2023 at 5:44 PM Simon Glass wrote: > > Hi Shantur, > > On Sat, 2 Dec 2023 at 16:12, Shantur Rathore wrote: > > > > Hi Simon, > > > > On Fri, Dec 1, 2023 at 6:44 PM Simon Glass wrote: > > > > > > Hi Shantur, >

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-12-03 Thread Shantur Rathore
Hi Marek, On Sun, Dec 3, 2023 at 8:42 PM Marek Vasut wrote: > > On 11/24/23 01:37, Shantur Rathore wrote: > > Hi Marek, > > Hi, > > sorry for the late reply. > > >>>>> In my case RockPro64, the power to usb ports onboard is controlled by > >>

Re: bootstd: Support for distro specific EFI folders

2023-12-02 Thread Shantur Rathore
18 Nov 2023 23:52:11 +0100 > > > > From: Heinrich Schuchardt > > > > > > Hi Heinrich, > > > > > > > On 11/18/23 22:28, Shantur Rathore wrote: > > > > > Hi Heinrich, > > > > > > > > > > On Fri, Nov 17, 2023

Re: [PATCH v3 3/3] defconfig: rockpro64: Enable SF EFI var store

2023-12-02 Thread Shantur Rathore
Hi Simon, On Fri, Dec 1, 2023 at 6:44 PM Simon Glass wrote: > > Hi Shantur, > > On Sun, 26 Nov 2023 at 15:09, Shantur Rathore wrote: > > > > RockPro64 uses SPI Flash for storing env, also use it store > > EFI variables. > > > > Signed-off-by: Shantur R

Re: efi: Set Variable Runtime implementation

2023-12-02 Thread Shantur Rathore
Hi Simon, On Fri, Dec 1, 2023 at 6:44 PM Simon Glass wrote: > > Hi Shantur, > > On Mon, 27 Nov 2023 at 10:27, Shantur Rathore wrote: > > > > + Simon as he seems to have done a lot of work in the driver model. > > > > On Mon, Nov 27, 2023 at 10:12 AM Shantur

Re: [PATCH v3 2/3] efi_vars: Implement SPI Flash store

2023-12-02 Thread Shantur Rathore
Hi Ilias, On Thu, Nov 30, 2023 at 10:10 PM Ilias Apalodimas wrote: > > Hi Shantur > > I have a few remarks on the architecture. > Up to now, we are supporting > 1. Variables on a file > 2. Variables on an RPMB > > The reason those two are in different files is that we generally > expect to use di

Re: [PATCH v2 1/3] efi_var_file: refactor to move buffer functions

2023-11-29 Thread Shantur Rathore
Hi Heinrich, On Wed, Nov 29, 2023 at 5:41 PM Heinrich Schuchardt wrote: > > On 24.11.23 12:35, Shantur Rathore wrote: > > Currently efi_var_file.c has functions to store/read > > EFI variables to/from memory buffer. These functions > > can be used with other EFI variable

Re: efi: Set Variable Runtime implementation

2023-11-27 Thread Shantur Rathore
+ Simon as he seems to have done a lot of work in the driver model. On Mon, Nov 27, 2023 at 10:12 AM Shantur Rathore wrote: > > Hi Ilias, > > On Mon, Nov 27, 2023 at 7:16 AM Ilias Apalodimas > wrote: > > > > Hi Shantur > > > > On Sun, 26 Nov 2023 at 12:33,

Re: efi: Set Variable Runtime implementation

2023-11-27 Thread Shantur Rathore
Hi Ilias, On Mon, Nov 27, 2023 at 7:16 AM Ilias Apalodimas wrote: > > Hi Shantur > > On Sun, 26 Nov 2023 at 12:33, Shantur Rathore wrote: > > > > Hi Peter, > > > > On Sat, Nov 25, 2023 at 6:19 AM Peter Robinson wrote: > > > > > > Hi Shantur

Re: [PATCH v1 2/3] efi_vars: Implement SPI Flash store

2023-11-27 Thread Shantur Rathore
Hi Ilias, On Mon, Nov 27, 2023 at 7:09 AM Ilias Apalodimas wrote: > > Hi Shantur > > Please don't send a v2 unless the v1 discussion has settled. It just > makes life harder. I'll ignore v2 for now and respond here. > Sure, I'm still learning the ways around here. > [...] > > > > > > > > > > +

[PATCH v3 3/3] defconfig: rockpro64: Enable SF EFI var store

2023-11-26 Thread Shantur Rathore
RockPro64 uses SPI Flash for storing env, also use it store EFI variables. Signed-off-by: Shantur Rathore --- configs/rockpro64-rk3399_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig index 4cd6b76665

[PATCH v3 1/3] efi_var_file: refactor to move buffer functions

2023-11-26 Thread Shantur Rathore
Currently efi_var_file.c has functions to store/read EFI variables to/from memory buffer. These functions can be used with other EFI variable stores so move them out to efi_var_common.c Signed-off-by: Shantur Rathore --- (no changes since v1) include/efi_variable.h | 5 ++ lib

[PATCH v3 2/3] efi_vars: Implement SPI Flash store

2023-11-26 Thread Shantur Rathore
Currently U-boot uses ESP as storage for EFI variables. Devices with SPI Flash are used for storing environment with this commit we allow EFI variables to be stored on SPI Flash. Signed-off-by: Shantur Rathore --- (no changes since v1) include/efi_variable.h| 21 lib

[PATCH v3 0/3] With this patch series we implement SPI Flash storage for EFI

2023-11-26 Thread Shantur Rathore
variables. Changes in v3: - Fixed compiler warnings. Changes in v2: - Refactored efi_var_file to move common parts out as requested - Changed ifdefs to use CONFIG_IS_DEFINED - Fixed typos Shantur Rathore (3): efi_var_file: refactor to move buffer functions efi_vars: Implement SPI Flash

Re: efi: Set Variable Runtime implementation

2023-11-26 Thread Shantur Rathore
Hi Peter, On Sat, Nov 25, 2023 at 6:19 AM Peter Robinson wrote: > > Hi Shantur, > > On Fri, Nov 24, 2023 at 11:55 PM Shantur Rathore wrote: > > > > Hi Ilias, > > > > On Fri, Nov 24, 2023 at 10:50 PM Ilias Apalodimas > > wrote: > > > > &

Re: efi: Set Variable Runtime implementation

2023-11-24 Thread Shantur Rathore
Hi Ilias, On Fri, Nov 24, 2023 at 10:50 PM Ilias Apalodimas wrote: > > Hi Shantur > > On Fri, 24 Nov 2023 at 18:51, Shantur Rathore wrote: > > > > Hi Heinrich, > > > > I am trying to work out how to enable the SetVariableRT service in > > U-Boot and

efi: Set Variable Runtime implementation

2023-11-24 Thread Shantur Rathore
Hi Heinrich, I am trying to work out how to enable the SetVariableRT service in U-Boot and came across your patch [1] which initially had the SetVariable RT service enabled in EFI but in the final patch this was removed. I am hoping to implement it on top of the SPI Flash EFI store [2] to be able

[PATCH] maintainers: rk3399: remove maintainer

2023-11-24 Thread Shantur Rathore
Remove Akash Gajjar from MAINTAINERS as email is bouncing. Signed-off-by: Shantur Rathore --- board/pine64/rockpro64_rk3399/MAINTAINERS | 1 - board/rockchip/evb_rk3399/MAINTAINERS | 1 - 2 files changed, 2 deletions(-) diff --git a/board/pine64/rockpro64_rk3399/MAINTAINERS b/board

Re: [PATCH v1 2/3] efi_vars: Implement SPI Flash store

2023-11-24 Thread Shantur Rathore
Hi Ilias and Akashi, On Wed, Nov 22, 2023 at 6:58 AM Ilias Apalodimas wrote: > > Hi Shahtur > > On Wed, 22 Nov 2023 at 01:58, Shantur Rathore wrote: > > > > Currently U-boot uses ESP as storage for EFI variables. > > Devices with SPI Flash are used for storing en

[PATCH v2 3/3] defconfig: rockpro64: Enable SF EFI var store

2023-11-24 Thread Shantur Rathore
RockPro64 uses SPI Flash for storing env, also use it store EFI variables. Signed-off-by: Shantur Rathore --- Changes in v2: - Refactored efi_var_file to move common parts out as requested - Changed ifdefs to use CONFIG_IS_DEFINED - Fixed typos configs/rockpro64-rk3399_defconfig | 2 ++ 1

[PATCH v2 2/3] efi_vars: Implement SPI Flash store

2023-11-24 Thread Shantur Rathore
Currently U-boot uses ESP as storage for EFI variables. Devices with SPI Flash are used for storing environment with this commit we allow EFI variables to be stored on SPI Flash. Signed-off-by: Shantur Rathore --- (no changes since v1) include/efi_variable.h| 21 lib

[PATCH v2 1/3] efi_var_file: refactor to move buffer functions

2023-11-24 Thread Shantur Rathore
Currently efi_var_file.c has functions to store/read EFI variables to/from memory buffer. These functions can be used with other EFI variable stores so move them out to efi_var_common.c Signed-off-by: Shantur Rathore --- (no changes since v1) include/efi_variable.h | 5 ++ lib

[PATCH v2 0/3] efi: vars: Implement SPI Flash storage

2023-11-24 Thread Shantur Rathore
With this patch series we implement SPI Flash storage for EFI variables. Changes in v2: - Refactored efi_var_file to move common parts out as requested - Changed ifdefs to use CONFIG_IS_DEFINED - Fixed typos Shantur Rathore (3): efi_var_file: refactor to move buffer functions efi_vars

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-11-23 Thread Shantur Rathore
Hi Marek, On Thu, Nov 23, 2023 at 9:07 PM Marek Vasut wrote: > > On 11/23/23 12:24, Shantur Rathore wrote: > > Hi Marek, > > > > On Thu, Nov 23, 2023 at 12:06 AM Marek Vasut wrote: > >> > >> On 11/20/23 00:03, Shantur Rathore wrote: > >>> H

Re: [PATCH v5 05/12] usb: Avoid unbinding devices in use by bootflows

2023-11-23 Thread Shantur Rathore
Hi Simon, On Tue, Nov 21, 2023 at 2:17 AM Simon Glass wrote: > > Hi Shantur, > > On Sun, 19 Nov 2023 at 15:47, Shantur Rathore wrote: > > > > Hi Simon, > > > > On Sun, Nov 19, 2023 at 7:12 PM Simon Glass wrote: > > > > > > When a USB device

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-11-23 Thread Shantur Rathore
Hi Marek, On Thu, Nov 23, 2023 at 12:06 AM Marek Vasut wrote: > > On 11/20/23 00:03, Shantur Rathore wrote: > > Hi Marek, > > Hi, > > > On Sun, Nov 19, 2023 at 8:53 PM Marek Vasut wrote: > >> > >> On 11/10/23 15:13, Shantur Rathore wrote: > >

[PATCH v1 3/3] defconfig: rockpro64: Enable SF EFI var store

2023-11-21 Thread Shantur Rathore
RockPro64 uses SPI Flash for storing env, also use it store EFI variables. Signed-off-by: Shantur Rathore --- configs/rockpro64-rk3399_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig index affb6137e0

[PATCH v1 2/3] efi_vars: Implement SPI Flash store

2023-11-21 Thread Shantur Rathore
Currently U-boot uses ESP as storage for EFI variables. Devices with SPI Flash are used for storing environment with this commit we allow EFI variables to be stored on SPI Flash. Signed-off-by: Shantur Rathore --- include/efi_variable.h| 25 ++ lib/efi_loader/Kconfig

[PATCH v1 1/3] efi: filestore: don't compile when config disabled

2023-11-21 Thread Shantur Rathore
Compile out filestore functions when config isn't enabled. Signed-off-by: Shantur Rathore --- include/efi_variable.h| 21 - lib/efi_loader/efi_var_file.c | 13 +++-- lib/efi_loader/efi_variable.c | 10 +- 3 files changed, 28 insertions(+

[PATCH v1 0/3] efi_vars: SPI Flash store

2023-11-21 Thread Shantur Rathore
With this patch series we implement SPI Flash storage for EFI variables. Shantur Rathore (3): efi: filestore: don't compile when config disabled efi_vars: Implement SPI Flash store defconfig: rockpro64: Enable SF EFI var store configs/rockpro64-rk3399_defconfig | 2 + in

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-11-19 Thread Shantur Rathore
On Sun, Nov 19, 2023 at 11:03 PM Shantur Rathore wrote: > > Hi Marek, > > On Sun, Nov 19, 2023 at 8:53 PM Marek Vasut wrote: > > > > On 11/10/23 15:13, Shantur Rathore wrote: > > > Currently when a hub is turned on, all the ports are powered on. > >

Re: [PATCH 0/8] USB fixes: xHCI error handling

2023-11-19 Thread Shantur Rathore
On Sun, Nov 19, 2023 at 8:08 PM Marek Vasut wrote: > > On 10/27/23 01:16, Hector Martin wrote: > > This series is the first of a few bundles of USB fixes we have been > > carrying downstream on the Asahi U-Boot branch for a few months. > > > > Most importantly, this related set of patches makes xH

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-11-19 Thread Shantur Rathore
Hi Marek, On Sun, Nov 19, 2023 at 8:53 PM Marek Vasut wrote: > > On 11/10/23 15:13, Shantur Rathore wrote: > > Currently when a hub is turned on, all the ports are powered on. > > This works well for hubs which have individual power control. > > > > For the hubs wi

Re: [PATCH v5 05/12] usb: Avoid unbinding devices in use by bootflows

2023-11-19 Thread Shantur Rathore
Hi Simon, On Sun, Nov 19, 2023 at 7:12 PM Simon Glass wrote: > > When a USB device is unbound, it causes any bootflows attached to it to > be removed, via a call to bootdev_clear_bootflows() from > bootdev_pre_unbind(). This obviously makes it impossible to boot the > bootflow. > > However, when

[PATCH v3] arch: arm: Kconfig: Enable BOOTSTD_FULL for Rockchip SoCs

2023-11-19 Thread Shantur Rathore
Rockchip SoCs can support wide range of bootflows. Without full bootflow commands, it can be difficult to figure out issues if any, hence enable by default. Reviewed-by: Simon Glass Signed-off-by: Shantur Rathore --- (no changes since v1) arch/arm/Kconfig | 1 + 1 file changed, 1 insertion

Re: [PATCH v2 2/4] bootflow: bootmeth_efi: Don't set bootdev again

2023-11-19 Thread Shantur Rathore
Hi Simon, On Sun, Nov 19, 2023 at 12:44 AM Simon Glass wrote: > > Hi Shantur, > > On Sat, 18 Nov 2023 at 14:17, Shantur Rathore wrote: > > > > Hi Simon, > > > > On Sat, Nov 18, 2023 at 5:11 PM Simon Glass wrote: > > > > > > +Ilias too as

Re: [PATCH v2 2/4] bootflow: bootmeth_efi: Don't set bootdev again

2023-11-19 Thread Shantur Rathore
Hi Ilias, On Sun, Nov 19, 2023 at 7:50 AM Ilias Apalodimas wrote: > > Hi Simon, > > Thanks for looping me in > > On Sat, 18 Nov 2023 at 19:11, Simon Glass wrote: > > > > +Ilias too as this involves a design decision > > > > Hi Shantur, > > &

[PATCH v4 3/4] bootflow: bootmeth_efi: Handle fdt not available.

2023-11-19 Thread Shantur Rathore
While booting with efi, if fdt isn't available externally, just use the built-in one. Reviewed-by: Simon Glass Signed-off-by: Shantur Rathore --- Changes in v4: - Update code to use BUILT_IN_FDT flag as suggested boot/bootmeth_efi.c | 19 +-- include/bootflow.h | 2

[PATCH v4 4/4] bootflow: bootmeth_efi: don't free buffer

2023-11-19 Thread Shantur Rathore
bootmeth_efi doesn't allocate any buffer to load efi in any case. enable static buffer flag for all cases. Reviewed-by: Simon Glass Signed-off-by: Shantur Rathore --- (no changes since v1) boot/bootmeth_efi.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a

[PATCH v4 2/4] bootflow: bootmeth_efi: set bflow->fname from bootfile name

2023-11-19 Thread Shantur Rathore
We need to set boot->fname before calling efi_set_bootdev otherwise this crashes as bflow->fname is null. Reviewed-by: Simon Glass Signed-off-by: Shantur Rathore --- (no changes since v1) boot/bootmeth_efi.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH v4 0/4] bootflow: bootmeth_efi: Fix network efi boot.

2023-11-19 Thread Shantur Rathore
Currently bootmeth_efi crashes while doing a network (dhcp) boot. This patch series fixes issues and both network and disk boot works. Shantur Rathore (4): bootflow: bootmeth_efi: Set bootp_arch as hex bootflow: bootmeth_efi: set bflow->fname from bootfile name bootflow: bootmeth_

  1   2   >