commit adds support for handling drive-strength of 12ma, when it's
defined in the DT.
Signed-off-by: Romain Perier
---
drivers/pinctrl/rockchip/pinctrl_rk3288.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/rockchip/pinctrl_rk3288.c
b/drivers/pi
L).
Fixes: 2454b719fb87 ("rockchip: rk3288: Add pinctrl support for the...")
Signed-off-by: Romain Perier
---
drivers/pinctrl/rockchip/pinctrl_rk3288.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/pinctrl/rockchip/pinctrl_rk3288.c
b/drivers/pinctrl/rockchip/pinctrl_rk328
We should not handle this pin explicitly from pinctrl. GMAC driver takes
care of it by using a "reset-gpio" in the DT.
This commit removes pull up for GPIO4B0.
Fixes: 2454b719fb87 ("rockchip: rk3288: Add pinctrl support for the...")
Signed-off-by: Romain Perier
---
driv
n that
was accidentaly removed while re-working commit 2454b719fb87
("rockchip: rk3288: Add pinctrl support for the...").
Romain Perier (2):
rockchip: rk3288: Remove phy reset GPIO pull up
rockchip: rk3288: Revert MAC_TXCLK in pinctrl for GMAC
drivers/pinctrl/rockchip/pinctrl_rk3288.c
Hello,
Le 11/07/2017 à 15:43, Dr. Philipp Tomsich a écrit :
>> On 10 Jul 2017, at 08:43, Romain Perier wrote:
>>
>> Le 07/07/2017 à 05:58, Simon Glass a écrit :
>>> +Philipp
>>>
>>> Hi Romain,
>>>
>>> On 3 July 2017 at 01:13, Romai
Le 07/07/2017 à 05:58, Simon Glass a écrit :
> +Philipp
>
> Hi Romain,
>
> On 3 July 2017 at 01:13, Romain Perier wrote:
>> Currently, selecting state simple is done by the device driver model,
>> prior probing the driver. The problem is that it's done and ca
und,
and then gmac_config is never called.
This commits toggles the pinctrl on the right node from the probe
function of the driver.
Signed-off-by: Romain Perier
---
drivers/net/gmac_rockchip.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/gmac_rockchip.c b/drivers/
From: Sjoerd Simons
Add support for the gmac ethernet interface to pinctrl. This hardcodes
the setup to match that of the firefly and Radxa Rock2 boards, using the
RGMII phy mode for gmac interface and GPIO4B0 as the phy reset GPIO.
Signed-off-by: Sjoerd Simons
Signed-off-by: Romain Perier
: Romain Perier
---
arch/arm/include/asm/arch-rockchip/grf_rk3288.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/arch-rockchip/grf_rk3288.h
b/arch/arm/include/asm/arch-rockchip/grf_rk3288.h
index 7d56b8ced0..fbc4a0d80f 100644
--- a/arch/arm/include/asm/arch
Hi,
That's what I already tried, but I can re-try differently (the delays
were added at specific points, as suggested by Kever, if I remember
correctly. I could try different approach)
Thanks,
Romain
Le 26/01/2017 à 15:24, Simon Glass a écrit :
> Hi,
>
> On 19 January 2017 at
Hi,
Le 21/01/2017 à 04:51, Simon Glass a écrit :
> On 17 January 2017 at 02:32, Romain Perier
> wrote:
>> Like the rock2, this board has been tested with back to brom feature.
>> This commits adjusts environment offset regarding if back_to_brom is
>> enabled or not
Hi,
no ideas ?
I can try another solution if you want.
Regards,
Romain
Le 09/01/2017 à 09:23, Romain Perier a écrit :
Hi,
Le 09/01/2017 à 08:20, Kever Yang a écrit :
On 01/06/2017 06:52 PM, Romain Perier wrote:
Add Rockchip Engineers to Cc:
Le 06/01/2017 à 11:28, Romain Perier a
This commit enables ethernet MAC address randomization on the
firefly-rk3288. It removes the error at startup 'ethernet@ff29
address not set'.
Signed-off-by: Romain Perier
---
configs/firefly-rk3288_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/confi
This set of patches enables SPL_BACK_TO_BROM feature that has been
tested on this board. That is preferable if all rk3288-based boards use
the same configuration and boot in the same way. Then, it enables
ethernet address randomization.
Romain Perier (2):
Enable ROCKCHIP_SPL_BACK_TO_BROM for
Like the rock2, this board has been tested with back to brom feature.
This commits adjusts environment offset regarding if back_to_brom is
enabled or not and uses this feature by default.
Signed-off-by: Romain Perier
---
configs/firefly-rk3288_defconfig | 2 ++
include/configs/firefly-rk3288.h
From: Sjoerd Simons
Now that ethernet support works, it can be dropped from the rockchip
TODO
Signed-off-by: Sjoerd Simons
Acked-by: Simon Glass
Acked-by: Joe Hershberger
Signed-off-by: Simon Glass
---
Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes i
From: Simon Glass
Export all functions so that drivers can use them, or not, as the need
arises.
Signed-off-by: Simon Glass
Signed-off-by: Romain Perier
Acked-by: Joe Hershberger
---
Changes in v7: None
Changes in v6:
- Changed Acked-by to Signed-off-by for Romain
Changes in v5:
- Add Acked
net: designware: Add a fix_mac_speed hook' patch
- Sort includes
- Use debug() instead of printf() for error
- Use function calls instead of fix_mac_speed() hook
- Use new clk interface
Changes in v2:
- Adjust to new hook name
- Fix various coding style nits
Romain Perier (2):
Enable DIS
From: Simon Glass
With rockchip we need to make adjustments after the link speed is set but
before enabling received/transmit. In preparation for this, split these
two pieces into separate functions.
Signed-off-by: Simon Glass
Signed-off-by: Romain Perier
Acked-by: Joe Hershberger
From: Simon Glass
This is the only RK3399 device without DHCP. Enable it so that we
can use a common BOOT_TARGET_DEVICES setting. It is likely useful to be
able to use USB networking, at least. Full networking can be enabled when
a suitable platform needs it.
Signed-off-by: Simon Glass
---
Chan
This commit enables ethernet MAC address randomization on the rock2. It
removes the error at startup 'ethernet@ff29 address not set'.
Signed-off-by: Romain Perier
---
Changes in v7:
- Added this commit to the series
configs/rock2_defconfig | 1 +
1 file changed, 1 insertion(+)
From: Sjoerd Simons
Enable the various configuration option required to get the ethernet
interface up and running on Radxa Rock2 and Firefly.
Signed-off-by: Sjoerd Simons
Signed-off-by: Romain Perier
Reviewed-by: Simon Glass
Acked-by: Joe Hershberger
---
Changes in v7: None
Changes in v6
This enables suitable commands needed for booting general purpose
Linux distribution. This is required for example if we want to use PXE
or DHCP as default boot targets, symbols no longer enabled by
config_distro_defaults.h .
Signed-off-by: Romain Perier
---
Changes in v7:
- Added this commit
From: Simon Glass
This function can fail, so return the error if there is one.
Signed-off-by: Simon Glass
Signed-off-by: Romain Perier
Acked-by: Joe Hershberger
---
Changes in v7: None
Changes in v6:
- Changed Acked-by to Signed-off-by for Romain
Changes in v5:
- Add Acked-by for Romain
From: Sjoerd Simons
Now that at least on the firefly board we have network support, enable
PXE and DHCP boot targets by default.
Signed-off-by: Sjoerd Simons
Acked-by: Simon Glass
Acked-by: Joe Hershberger
---
Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4: None
Ch
From: Sjoerd Simons
Add a new driver for the GMAC ethernet interface present in Rockchip
RK3288 SOCs. This driver subclasses the generic design-ware driver to
add the glue needed specifically for Rockchip.
Signed-off-by: Sjoerd Simons
Signed-off-by: Simon Glass
Signed-off-by: Romain Perier
From: Sjoerd Simons
To allow other DM drivers to subclass the designware driver various
functions and structures need to be exported. Export these.
Signed-off-by: Sjoerd Simons
Signed-off-by: Romain Perier
Reviewed-by: Bin Meng
Acked-by: Simon Glass
Acked-by: Joe Hershberger
---
Changes
Hi,
Le 09/01/2017 à 08:20, Kever Yang a écrit :
On 01/06/2017 06:52 PM, Romain Perier wrote:
Add Rockchip Engineers to Cc:
Le 06/01/2017 à 11:28, Romain Perier a écrit :
Hello,
I have a strange behaviour with the SPL on rk3288.
When I build u-boot-rockchip master for the rock2
Add Rockchip Engineers to Cc:
Le 06/01/2017 à 11:28, Romain Perier a écrit :
Hello,
I have a strange behaviour with the SPL on rk3288.
When I build u-boot-rockchip master for the rock2 (rock2_defconfig), I
can easily start u-boot SPL and u-boot from an sdcard (the emmc boot
partition is
Hello,
I have a strange behaviour with the SPL on rk3288.
When I build u-boot-rockchip master for the rock2 (rock2_defconfig), I
can easily start u-boot SPL and u-boot from an sdcard (the emmc boot
partition is erased so my board starts in maskrom mode by default)
without any issues.
Now,
From: Sjoerd Simons
Enable the various configuration option required to get the ethernet
interface up and running on Radxa Rock2 and Firefly.
Signed-off-by: Sjoerd Simons
Signed-off-by: Romain Perier
Reviewed-by: Simon Glass
Acked-by: Joe Hershberger
---
Changes in v6:
- Changed Acked-by
From: Sjoerd Simons
Now that at least on the firefly board we have network support, enable
PXE and DHCP boot targets by default.
Signed-off-by: Sjoerd Simons
Acked-by: Simon Glass
Acked-by: Joe Hershberger
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
Ch
From: Sjoerd Simons
Now that ethernet support works, it can be dropped from the rockchip
TODO
Signed-off-by: Sjoerd Simons
Acked-by: Simon Glass
Acked-by: Joe Hershberger
Signed-off-by: Simon Glass
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3:
- Add a few ne
From: Simon Glass
Export all functions so that drivers can use them, or not, as the need
arises.
Signed-off-by: Simon Glass
Signed-off-by: Romain Perier
Acked-by: Joe Hershberger
---
Changes in v6:
- Changed Acked-by to Signed-off-by for Romain
Changes in v5:
- Add Acked-by for Romain
From: Sjoerd Simons
Add a new driver for the GMAC ethernet interface present in Rockchip
RK3288 SOCs. This driver subclasses the generic design-ware driver to
add the glue needed specifically for Rockchip.
Signed-off-by: Sjoerd Simons
Signed-off-by: Simon Glass
Signed-off-by: Romain Perier
From: Simon Glass
With rockchip we need to make adjustments after the link speed is set but
before enabling received/transmit. In preparation for this, split these
two pieces into separate functions.
Signed-off-by: Simon Glass
Signed-off-by: Romain Perier
Acked-by: Joe Hershberger
From: Simon Glass
This function can fail, so return the error if there is one.
Signed-off-by: Simon Glass
Signed-off-by: Romain Perier
Acked-by: Joe Hershberger
---
Changes in v6:
- Changed Acked-by to Signed-off-by for Romain
Changes in v5:
- Add Acked-by for Romain
Changes in v4: None
>From Romain:
This is a resent of Simon's v4 series. I have changed what was suggested
by David Wu about the driver name (rename gmac_rk3288 to gmac_rockchip).
I have also tested the whole series on a rock2 square board, updated the
configuration files for rock2 and firefly boards and added some
Si
From: Simon Glass
This is the only RK3399 device without DHCP. Enable it so that we
can use a common BOOT_TARGET_DEVICES setting. It is likely useful to be
able to use USB networking, at least. Full networking can be enabled when
a suitable platform needs it.
Signed-off-by: Simon Glass
---
Cha
>From Simon:
This v3 patch is an update on Sjoerd's original v2 series from Feburary.
I have dealt with the changes requested at the time, and adjusted the way
that the speed change is handled.
Tested on firefly-rk3288, rock2.
Original cover letter:
To add support I've taken a slightly different
From: Sjoerd Simons
To allow other DM drivers to subclass the designware driver various
functions and structures need to be exported. Export these.
Signed-off-by: Sjoerd Simons
Signed-off-by: Romain Perier
Reviewed-by: Bin Meng
Acked-by: Simon Glass
Acked-by: Joe Hershberger
---
Changes
From: Sjoerd Simons
Enable the various configuration option required to get the ethernet
interface up and running on Radxa Rock2 and Firefly.
Signed-off-by: Sjoerd Simons
Reviewed-by: Simon Glass
Acked-by: Joe Hershberger
Acked-by: Romain Perier
---
Changes in v5:
- Added Acked-by for
From: Simon Glass
Export all functions so that drivers can use them, or not, as the need
arises.
Signed-off-by: Simon Glass
Acked-by: Joe Hershberger
Acked-by: Romain Perier
---
Changes in v5:
- Add Acked-by for Romain
Changes in v4: None
Changes in v3:
- Add new patch to export the
From: Sjoerd Simons
Now that ethernet support works, it can be dropped from the rockchip
TODO
Signed-off-by: Sjoerd Simons
Acked-by: Simon Glass
Acked-by: Joe Hershberger
Signed-off-by: Simon Glass
---
Changes in v5: None
Changes in v4: None
Changes in v3:
- Add a few new patches
- Drop the
44 matches
Mail list logo
