Re: [U-Boot] [PATCH] efi_loader: initialise partition_signature memory

2017-11-30 Thread Rob Clark
s a problem where the loaded image protocol would not return a > device path with MEDIA_DEVICE causing the OpenBSD bootloader to fail > on rpi_3 and other targets. > > Signed-off-by: Jonathan Gray Reviewed-by: Rob Clark > --- > lib/efi_loader/efi_device_path.c | 3 +++ > 1 fi

[U-Boot] [PATCH] efi_loader: add missing breaks

2017-11-30 Thread Rob Clark
Otherwise with GUID partition types you would end up with things like: .../HD(Part0,Sig6252c819-4624-4995-8d16-abc9cd5d4130)/HD(Part0,MBRType=02,SigType=02) Signed-off-by: Rob Clark --- Reported by 'ykaukab' on IRC. Not sure if someone already sent a similar patch. lib/

Re: [U-Boot] [PATCH v2 01/18] efi_loader: efi_bootmgr: do not make hidden assignments

2017-11-17 Thread Rob Clark
On Fri, Nov 17, 2017 at 12:46 PM, Heinrich Schuchardt wrote: > On 11/17/2017 03:04 PM, Rob Clark wrote: >> >> On Sun, Nov 12, 2017 at 9:02 AM, Heinrich Schuchardt >> wrote: >>> >>> Assignments should not be made in the middle of nowhere. >>> >&g

Re: [U-Boot] [PATCH v2 01/18] efi_loader: efi_bootmgr: do not make hidden assignments

2017-11-17 Thread Rob Clark
On Sun, Nov 12, 2017 at 9:02 AM, Heinrich Schuchardt wrote: > Assignments should not be made in the middle of nowhere. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > Call efi_dp_str in debug mode only. > --- > lib/efi_loader/efi_bootmgr.c | 6 -- > 1 file changed, 4 insertions(+

Re: [U-Boot] [RFC] efi_loader: frame buffers in EFI GOP and DM_VIDEO

2017-11-06 Thread Rob Clark
On Wed, Oct 25, 2017 at 3:45 PM, Heinrich Schuchardt wrote: > Hello Alex, hello Simon, > > I have just been reading through efi_gop and video_uclass.c and there seems > to be something missing in the support of video modes. > > U-Boot configuration knows the following color models: > > 16-color >

Re: [U-Boot] [PATCH] efi_loader: Disable env_save() call on boot

2017-10-19 Thread Rob Clark
instead > implement it properly for the next one. > Acked-by: Rob Clark > Reported-by: Heinrich Schuchardt > Fixes: ad644e7c182 ("efi_loader: efi variable support") > Signed-off-by: Alexander Graf > --- > lib/efi_loader/efi_boottime.c | 5 + > 1 file chang

Re: [U-Boot] [PATCH 3/3] efi_loader: Do not enable it by default for sunxi

2017-10-19 Thread Rob Clark
On Thu, Oct 19, 2017 at 7:43 AM, Maxime Ripard wrote: > On Thu, Oct 19, 2017 at 10:12:36AM +0100, Peter Robinson wrote: >> On Thu, Oct 19, 2017 at 10:06 AM, Peter Robinson >> wrote: >> > On Thu, Oct 19, 2017 at 10:01 AM, Maxime Ripard >> > wrote: >> >> On Thu, Oct 19, 2017 at 09:43:20AM +0100,

Re: [U-Boot] Unexpected saving of all environment variables during EFI boot

2017-10-19 Thread Rob Clark
On Thu, Oct 19, 2017 at 5:05 PM, Alexander Graf wrote: > > > On 19.10.17 22:40, Heinrich Schuchardt wrote: >> This was merged as >> ad644e7c18238026fecc647f62584d87d2c5b0a3 >> efi_loader: efi variable support >> >>> diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c >>> ind

Re: [U-Boot] [PATCH 1/1] efi_loader: use named constant for memory type

2017-10-17 Thread Rob Clark
On Tue, Oct 17, 2017 at 12:53 PM, Heinrich Schuchardt wrote: > When we call an EFI image from memory a memory device path > is created. The memory type should use a named constant. > > Fixes: bf19273e81e efi_loader: Add mem-mapped for fallback > Signed-off-by: Heinrich Schuchardt > --- > cmd/boo

Re: [U-Boot] [PATCH 07/11] efi_loader: fix events

2017-10-13 Thread Rob Clark
On Fri, Oct 13, 2017 at 1:24 AM, Heinrich Schuchardt wrote: > > > On 10/10/2017 02:23 PM, Rob Clark wrote: >> >> An event can be created with type==0, Shell.efi does this for an event >> that is set when Ctrl-C is typed. So our current approach of having a >&

Re: [U-Boot] [PATCH 06/11] efi_loader: Decouple EFI input/output from stdin/stdout

2017-10-12 Thread Rob Clark
On Thu, Oct 12, 2017 at 7:48 PM, Heinrich Schuchardt wrote: > On 10/12/2017 11:26 PM, Rob Clark wrote: >> On Thu, Oct 12, 2017 at 6:38 PM, Heinrich Schuchardt >> wrote: >>> On 10/12/2017 04:28 PM, Rob Clark wrote: >>>> On Thu, Oct 12, 2017 at 9:50 AM, Alexan

Re: [U-Boot] [PATCH 06/11] efi_loader: Decouple EFI input/output from stdin/stdout

2017-10-12 Thread Rob Clark
On Thu, Oct 12, 2017 at 6:38 PM, Heinrich Schuchardt wrote: > On 10/12/2017 04:28 PM, Rob Clark wrote: >> On Thu, Oct 12, 2017 at 9:50 AM, Alexander Graf wrote: >>> On 10/12/2017 03:40 PM, Rob Clark wrote: >>>> >>>> On Thu, Oct 12, 2017 a

Re: [U-Boot] [PATCH 06/11] efi_loader: Decouple EFI input/output from stdin/stdout

2017-10-12 Thread Rob Clark
On Thu, Oct 12, 2017 at 9:50 AM, Alexander Graf wrote: > On 10/12/2017 03:40 PM, Rob Clark wrote: >> >> On Thu, Oct 12, 2017 at 9:05 AM, Heinrich Schuchardt >> wrote: >>> >>> >>> On 10/12/2017 02:48 PM, Rob Clark wrote: >>>>

Re: [U-Boot] [PATCH 06/11] efi_loader: Decouple EFI input/output from stdin/stdout

2017-10-12 Thread Rob Clark
On Thu, Oct 12, 2017 at 9:44 AM, Mark Kettenis wrote: >> From: Rob Clark >> Date: Thu, 12 Oct 2017 08:48:39 -0400 >> >> On Thu, Oct 12, 2017 at 3:15 AM, Alexander Graf wrote: >> > >> > >> > On 12.10.17 00:07, Rob Clark wrote: >> &

Re: [U-Boot] [PATCH 06/11] efi_loader: Decouple EFI input/output from stdin/stdout

2017-10-12 Thread Rob Clark
On Thu, Oct 12, 2017 at 9:11 AM, Alexander Graf wrote: > On 10/12/2017 02:48 PM, Rob Clark wrote: >> >> On Thu, Oct 12, 2017 at 3:15 AM, Alexander Graf wrote: >>> >>> >>> On 12.10.17 00:07, Rob Clark wrote: >>>> >>>> On Wed, Oct

Re: [U-Boot] [PATCH 06/11] efi_loader: Decouple EFI input/output from stdin/stdout

2017-10-12 Thread Rob Clark
On Thu, Oct 12, 2017 at 9:05 AM, Heinrich Schuchardt wrote: > > > On 10/12/2017 02:48 PM, Rob Clark wrote: >> >> On Thu, Oct 12, 2017 at 3:15 AM, Alexander Graf wrote: >>> >>> >>> >>> On 12.10.17 00:07, Rob Clark wrote: >>

Re: [U-Boot] [PATCH 06/11] efi_loader: Decouple EFI input/output from stdin/stdout

2017-10-12 Thread Rob Clark
On Thu, Oct 12, 2017 at 3:15 AM, Alexander Graf wrote: > > > On 12.10.17 00:07, Rob Clark wrote: >> On Wed, Oct 11, 2017 at 10:45 AM, Alexander Graf wrote: >>> >>> >>> On 10.10.17 14:23, Rob Clark wrote: >>>> In some cases, it is quite usef

Re: [U-Boot] [PATCH 02/11] efi_loader: Initial HII protocols

2017-10-12 Thread Rob Clark
On Thu, Oct 12, 2017 at 3:13 AM, Alexander Graf wrote: > > > On 12.10.17 00:02, Rob Clark wrote: >> On Wed, Oct 11, 2017 at 10:30 AM, Alexander Graf wrote: >>> >>> >>> On 10.10.17 14:22, Rob Clark wrote: >>>> From: Leif Lindholm >>>

Re: [U-Boot] efi_loader query

2017-10-11 Thread Rob Clark
On Wed, Oct 11, 2017 at 12:13 PM, Suneel Garapati wrote: > Hi Rob, > > I am enlisted on u-boot mailing list and currently trying to use efi > loader to launch ubuntu distro. > > Appreciate your great efforts on this, would definitely help a lot. > > I tried to boot grub from u-boot using efi_loade

Re: [U-Boot] [PATCH 10/11] efi_loader: Add mem-mapped for fallback

2017-10-11 Thread Rob Clark
On Wed, Oct 11, 2017 at 10:59 AM, Alexander Graf wrote: > > > On 10.10.17 14:23, Rob Clark wrote: >> When we don't have a real device/image path, such as 'bootefi hello', >> construct a mem-mapped device-path. >> >> This fixes 'bootefi hello&#

Re: [U-Boot] [PATCH 07/11] efi_loader: fix events

2017-10-11 Thread Rob Clark
On Wed, Oct 11, 2017 at 10:49 AM, Alexander Graf wrote: > > > On 10.10.17 14:23, Rob Clark wrote: >> An event can be created with type==0, Shell.efi does this for an event >> that is set when Ctrl-C is typed. So our current approach of having a >> fixed set of timer s

Re: [U-Boot] [PATCH 06/11] efi_loader: Decouple EFI input/output from stdin/stdout

2017-10-11 Thread Rob Clark
On Wed, Oct 11, 2017 at 10:45 AM, Alexander Graf wrote: > > > On 10.10.17 14:23, Rob Clark wrote: >> In some cases, it is quite useful to have (for example) EFI on screen >> but u-boot on serial port. >> >> This adds two new optional environment variables, &quo

Re: [U-Boot] [PATCH 02/11] efi_loader: Initial HII protocols

2017-10-11 Thread Rob Clark
On Wed, Oct 11, 2017 at 10:30 AM, Alexander Graf wrote: > > > On 10.10.17 14:22, Rob Clark wrote: >> From: Leif Lindholm >> >> Enough implementation of the following protocols to run Shell.efi and >> SCT.efi: >> >> EfiHiiConfigRo

Re: [U-Boot] [PATCH 01/11] efi_loader: Initial EFI_DEVICE_PATH_UTILITIES_PROTOCOL

2017-10-11 Thread Rob Clark
On Wed, Oct 11, 2017 at 10:07 AM, Alexander Graf wrote: > > > On 10.10.17 14:22, Rob Clark wrote: >> From: Leif Lindholm >> >> Not complete, but enough for Shell.efi and SCT.efi. We'll implement the >> rest as needed or once we have SCT running properl

Re: [U-Boot] [PATCH 03/11] efi_loader: Initial EFI_UNICODE_COLLATION_PROTOCOL

2017-10-11 Thread Rob Clark
On Wed, Oct 11, 2017 at 10:36 AM, Alexander Graf wrote: > > > On 10.10.17 14:22, Rob Clark wrote: >> From: Leif Lindholm >> >> Not complete, but enough for Shell.efi and SCT.efi. >> >> Initial skeleton written by Leif, and then implementation by myself. &g

Re: [U-Boot] [PATCH 11/11] efi_loader: exclude openrd devices

2017-10-10 Thread Rob Clark
On Tue, Oct 10, 2017 at 6:28 PM, Heinrich Schuchardt wrote: > On 10/10/2017 02:23 PM, Rob Clark wrote: >> >> These devices have small image size limits, so exclude EFI_LOADER to >> help avoid exceeding limits. >> >> Signed-off-by: Rob Clark >> --- >>

[U-Boot] [PATCH 09/11] efi_loader: Fix disk dp's for pre-DM/legacy devices

2017-10-10 Thread Rob Clark
This fixes an issue with OpenBSD's bootloader, and I think should also fix a similar issue with grub2 on legacy devices. In the legacy case we were creating disk objects for the partitions, but not also the parent device. Reported-by: Jonathan Gray Signed-off-by: Rob Clark --- lib/efi_l

[U-Boot] [PATCH 05/11] efi_loader: console support for color attributes

2017-10-10 Thread Rob Clark
o the best of the device’s capabilities". Signed-off-by: Rob Clark --- include/efi_api.h| 33 + lib/efi_loader/efi_console.c | 27 +-- 2 files changed, 58 insertions(+), 2 deletions(-) diff --git a/include/efi_api.h

[U-Boot] [PATCH 04/11] efi_loader: SIMPLE_TEXT_INPUT_EX plus wire up objects properly

2017-10-10 Thread Rob Clark
We need the _EX version for SCT.. and we need to wire up the corresponding objects in the systab properly, as well as dealing with the console_in object advertising multiple protocols. Signed-off-by: Rob Clark --- include/efi_api.h | 61 +- include/efi_loader.h

[U-Boot] [PATCH 07/11] efi_loader: fix events

2017-10-10 Thread Rob Clark
ese fixes (plus implementation of SIMPLE_TEXT_INPUT_EX protocol), Ctrl-C works in Shell.efi. Signed-off-by: Rob Clark --- include/efi_loader.h | 1 + lib/efi_loader/efi_boottime.c | 217 +- 2 files changed, 111 insertions(+), 107 deletions(-) diff

[U-Boot] [PATCH 11/11] efi_loader: exclude openrd devices

2017-10-10 Thread Rob Clark
These devices have small image size limits, so exclude EFI_LOADER to help avoid exceeding limits. Signed-off-by: Rob Clark --- lib/efi_loader/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig index d2b6327119..6e22940da5

[U-Boot] [PATCH 08/11] efi_loader: implement SetWatchdogTimer

2017-10-10 Thread Rob Clark
From: Heinrich Schuchardt The watchdog is initialized with a 5 minute timeout period. It can be reset by SetWatchdogTimer. It is stopped by ExitBoottimeServices. Signed-off-by: Heinrich Schuchardt --- cmd/bootefi.c | 1 + include/efi_loader.h | 4 ++ lib/efi_loader/M

[U-Boot] [PATCH 06/11] efi_loader: Decouple EFI input/output from stdin/stdout

2017-10-10 Thread Rob Clark
I console will default to stdin/ stdout as before. Signed-off-by: Rob Clark --- As mentioned yesterday, this triggers some problems w/ qemu + 'bootefi hello' since puts() != fputs(stdout). So you can hold off applying this one for now if you want until we figure out a solution. It is

[U-Boot] [PATCH 10/11] efi_loader: Add mem-mapped for fallback

2017-10-10 Thread Rob Clark
When we don't have a real device/image path, such as 'bootefi hello', construct a mem-mapped device-path. This fixes 'bootefi hello' after devicepath refactoring. Fixes: 95c5553ea2 ("efi_loader: refactor boot device and loaded_image handling") Signed-of

[U-Boot] [PATCH 02/11] efi_loader: Initial HII protocols

2017-10-10 Thread Rob Clark
mance test suite. Initial skeleton written by Leif, and then implementation by myself. Cc: Leif Lindholm Signed-off-by: Rob Clark --- include/efi_api.h | 261 ++ include/efi_loader.h | 6 + lib/efi_loader/Makefile | 2 +- lib/efi_l

[U-Boot] [PATCH 03/11] efi_loader: Initial EFI_UNICODE_COLLATION_PROTOCOL

2017-10-10 Thread Rob Clark
From: Leif Lindholm Not complete, but enough for Shell.efi and SCT.efi. Initial skeleton written by Leif, and then implementation by myself. Cc: Leif Lindholm Signed-off-by: Rob Clark --- include/efi_api.h | 41 ++ include/efi_loader.h | 3 + lib/efi_loader

[U-Boot] [PATCH 01/11] efi_loader: Initial EFI_DEVICE_PATH_UTILITIES_PROTOCOL

2017-10-10 Thread Rob Clark
yself. Cc: Leif Lindholm Signed-off-by: Rob Clark --- include/efi_api.h | 34 +++- include/efi_loader.h | 2 + lib/efi_loader/Makefile| 1 + lib/efi_loader/efi_boottime.c | 4 ++ lib/efi_l

[U-Boot] [PATCH 00/11] efi_loader: patches for Shell.efi

2017-10-10 Thread Rob Clark
LITIES_PROTOCOL efi_loader: Initial HII protocols efi_loader: Initial EFI_UNICODE_COLLATION_PROTOCOL Rob Clark (7): efi_loader: SIMPLE_TEXT_INPUT_EX plus wire up objects properly efi_loader: console support for color attributes efi_loader: Decouple EFI input/output from stdin/stdout efi_loa

Re: [U-Boot] [PATCH] efi_loader: Decouple EFI input/output from stdin/stdout

2017-10-09 Thread Rob Clark
On Mon, Sep 11, 2017 at 10:04 AM, Rob Clark wrote: > In some cases, it is quite useful to have (for example) EFI on screen > but u-boot on serial port. > > Signed-off-by: Rob Clark > --- > Applies on top of my previous efi_loader patchset. > > lib/efi_lo

Re: [U-Boot] [PATCH] efi_loader: Fix disk dp's for pre-DM/legacy devices

2017-10-09 Thread Rob Clark
On Mon, Oct 9, 2017 at 1:48 PM, Jonathan Gray wrote: > On Mon, Oct 09, 2017 at 01:06:26PM -0400, Rob Clark wrote: >> On Mon, Oct 9, 2017 at 12:41 PM, Jonathan Gray wrote: >> > On Mon, Oct 09, 2017 at 12:06:24PM -0400, Rob Clark wrote: >> >> On Mon, Oct 9, 2017 at

Re: [U-Boot] [PATCH] efi_loader: Fix disk dp's for pre-DM/legacy devices

2017-10-09 Thread Rob Clark
On Mon, Oct 9, 2017 at 12:41 PM, Jonathan Gray wrote: > On Mon, Oct 09, 2017 at 12:06:24PM -0400, Rob Clark wrote: >> On Mon, Oct 9, 2017 at 11:35 AM, Jonathan Gray wrote: >> > On Mon, Oct 09, 2017 at 10:17:18AM -0400, Rob Clark wrote: >> >> On Mon, Oct 9, 2017 at

Re: [U-Boot] [PATCH] efi_loader: Fix disk dp's for pre-DM/legacy devices

2017-10-09 Thread Rob Clark
On Mon, Oct 9, 2017 at 12:22 PM, Heinrich Schuchardt wrote: > On 10/09/2017 06:06 PM, Rob Clark wrote: >> On Mon, Oct 9, 2017 at 11:35 AM, Jonathan Gray wrote: >>> On Mon, Oct 09, 2017 at 10:17:18AM -0400, Rob Clark wrote: >>>> On Mon, Oct 9, 2017 at 8:25 AM, Jona

Re: [U-Boot] [PATCH] efi_loader: Fix disk dp's for pre-DM/legacy devices

2017-10-09 Thread Rob Clark
On Mon, Oct 9, 2017 at 11:35 AM, Jonathan Gray wrote: > On Mon, Oct 09, 2017 at 10:17:18AM -0400, Rob Clark wrote: >> On Mon, Oct 9, 2017 at 8:25 AM, Jonathan Gray wrote: >> > On Mon, Oct 09, 2017 at 06:52:18AM -0400, Rob Clark wrote: >> >> On Sun, Oct 8, 2017 at

Re: [U-Boot] [PATCH] efi_loader: Fix disk dp's for pre-DM/legacy devices

2017-10-09 Thread Rob Clark
On Mon, Oct 9, 2017 at 8:25 AM, Jonathan Gray wrote: > On Mon, Oct 09, 2017 at 06:52:18AM -0400, Rob Clark wrote: >> On Sun, Oct 8, 2017 at 11:33 PM, Jonathan Gray wrote: >> > On Sun, Oct 08, 2017 at 11:33:08AM -0400, Rob Clark wrote: >> >> This fixes an issue wi

Re: [U-Boot] efi_loader: enough-uefi-for-shell: [PATCH 06/11] efi_loader: implement SetWatchdogTimer

2017-10-09 Thread Rob Clark
On Sun, Oct 8, 2017 at 6:14 PM, Heinrich Schuchardt wrote: > On 10/08/2017 06:57 AM, Heinrich Schuchardt wrote: >> The watchdog is initialized with a 5 minute timeout period. >> It can be reset by SetWatchdogTimer. >> It is stopped by ExitBoottimeServices. >> >> Signed-off-by: Heinrich Schuchardt

Re: [U-Boot] [PATCH] efi_loader: Fix disk dp's for pre-DM/legacy devices

2017-10-09 Thread Rob Clark
On Sun, Oct 8, 2017 at 11:33 PM, Jonathan Gray wrote: > On Sun, Oct 08, 2017 at 11:33:08AM -0400, Rob Clark wrote: >> This fixes an issue with OpenBSD's bootloader, and I think should also >> fix a similar issue with grub2 on legacy devices. In the legacy case >> we

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

2017-10-08 Thread Rob Clark
On Sun, Oct 8, 2017 at 12:41 PM, Alexander Graf wrote: > > >> Am 08.10.2017 um 17:54 schrieb Rob Clark : >> >>> On Wed, Oct 4, 2017 at 12:02 PM, Heinrich Schuchardt >>> wrote: >>> Patch efi_loader: add stub HII protocols uses UINTN heavily. In a

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

2017-10-08 Thread Rob Clark
On Wed, Oct 4, 2017 at 12:02 PM, Heinrich Schuchardt wrote: > Patch efi_loader: add stub HII protocols uses UINTN heavily. In a recent > comment Simon remarked that types should not be uppercase. So I was > planning to replace all occurences of UINTN by size_t in an upcoming patch. btw, how would

[U-Boot] [PATCH] efi_loader: Fix disk dp's for pre-DM/legacy devices

2017-10-08 Thread Rob Clark
This fixes an issue with OpenBSD's bootloader, and I think should also fix a similar issue with grub2 on legacy devices. In the legacy case we were creating disk objects for the partitions, but not also the parent device. Reported-by: Jonathan Gray Signed-off-by: Rob Clark --- lib/efi_l

Re: [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case

2017-10-07 Thread Rob Clark
On Fri, Oct 6, 2017 at 10:08 PM, Jonathan Gray wrote: > On Fri, Oct 06, 2017 at 08:21:26AM -0400, Rob Clark wrote: >> On Fri, Oct 6, 2017 at 12:35 AM, Jonathan Gray wrote: >> > On Thu, Oct 05, 2017 at 05:05:49AM -0400, Rob Clark wrote: >> >> On Thu, Oct 5, 2017 at

Re: [U-Boot] [PATCH] dm: video: make ANSI escape sequence support optional

2017-10-06 Thread Rob Clark
On Fri, Oct 6, 2017 at 12:15 PM, Anatolij Gustschin wrote: > On Sat, 30 Sep 2017 10:19:17 +0200 > Anatolij Gustschin ag...@denx.de wrote: > >> As mentioned in review comments for ANSI escape sequence >> support patches, this should be optional to reduce code >> size. Disable escape sequence suppor

Re: [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case

2017-10-06 Thread Rob Clark
On Fri, Oct 6, 2017 at 8:21 AM, Rob Clark wrote: > On Fri, Oct 6, 2017 at 12:35 AM, Jonathan Gray wrote: >> On Thu, Oct 05, 2017 at 05:05:49AM -0400, Rob Clark wrote: >>> On Thu, Oct 5, 2017 at 12:36 AM, Jonathan Gray wrote: >>> > On Wed, Oct 04, 2017 at 01:

Re: [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case

2017-10-06 Thread Rob Clark
On Fri, Oct 6, 2017 at 12:35 AM, Jonathan Gray wrote: > On Thu, Oct 05, 2017 at 05:05:49AM -0400, Rob Clark wrote: >> On Thu, Oct 5, 2017 at 12:36 AM, Jonathan Gray wrote: >> > On Wed, Oct 04, 2017 at 01:12:48PM -0400, Rob Clark wrote: >> >> On Wed, Oct 4, 2

Re: [U-Boot] [PATCH] usb: kbd: Fix dangling pointers on probe fail

2017-10-05 Thread Rob Clark
On Thu, Oct 5, 2017 at 7:48 PM, Bin Meng wrote: > Hi Rob, > > On Wed, Oct 4, 2017 at 1:31 AM, Rob Clark wrote: >> If probe fails, we should unregister the stdio device, else we leave >> dangling pointers to the parent 'struct usb_device'. >> >> Signed

Re: [U-Boot] [PATCH] distro: load FDT from any partition on boot device

2017-10-05 Thread Rob Clark
On Thu, Oct 5, 2017 at 8:39 AM, Alexander Graf wrote: > > > On 04.10.17 22:16, Rob Clark wrote: >> >> In the EFI_LOADER boot path, we were only checking the FAT partition >> containing the EFI payload for dtb files. But this is somewhat of a >> fiction. In reali

Re: [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case

2017-10-05 Thread Rob Clark
On Thu, Oct 5, 2017 at 12:36 AM, Jonathan Gray wrote: > On Wed, Oct 04, 2017 at 01:12:48PM -0400, Rob Clark wrote: >> On Wed, Oct 4, 2017 at 12:29 PM, Fabio Estevam wrote: >> > Since commit ff98cb90514d ("part: extract MBR signature from partitions") >>

Re: [U-Boot] [PATCH v1 08/12] efi_loader: console support for color attributes

2017-10-04 Thread Rob Clark
On Wed, Oct 4, 2017 at 8:00 PM, Rob Clark wrote: > On Wed, Oct 4, 2017 at 7:53 PM, Heinrich Schuchardt > wrote: >> On 10/05/2017 01:19 AM, Rob Clark wrote: >>> On Wed, Oct 4, 2017 at 6:01 PM, Heinrich Schuchardt >>> wrote: >>>> On 10/04/2017 10:5

Re: [U-Boot] [PATCH v1 08/12] efi_loader: console support for color attributes

2017-10-04 Thread Rob Clark
On Wed, Oct 4, 2017 at 7:53 PM, Heinrich Schuchardt wrote: > On 10/05/2017 01:19 AM, Rob Clark wrote: >> On Wed, Oct 4, 2017 at 6:01 PM, Heinrich Schuchardt >> wrote: >>> On 10/04/2017 10:54 PM, Rob Clark wrote: >>>> On Wed, Oct 4, 2017 at 2:53 PM, Heinrich

Re: [U-Boot] [PATCH v1 08/12] efi_loader: console support for color attributes

2017-10-04 Thread Rob Clark
On Wed, Oct 4, 2017 at 6:01 PM, Heinrich Schuchardt wrote: > On 10/04/2017 10:54 PM, Rob Clark wrote: >> On Wed, Oct 4, 2017 at 2:53 PM, Heinrich Schuchardt >> wrote: >>> On 09/10/2017 03:22 PM, Rob Clark wrote: >>>> Shell.efi uses this, and supportin

Re: [U-Boot] [PATCH v1 08/12] efi_loader: console support for color attributes

2017-10-04 Thread Rob Clark
On Wed, Oct 4, 2017 at 2:53 PM, Heinrich Schuchardt wrote: > On 09/10/2017 03:22 PM, Rob Clark wrote: >> Shell.efi uses this, and supporting color attributes makes things look >> nicer. Map the EFI fg/bg color attributes to ANSI escape sequences. >> Not all colors have a pe

[U-Boot] [PATCH] distro: load FDT from any partition on boot device

2017-10-04 Thread Rob Clark
x27;s 'devicetree' command to load the correct FDT). The other option is somehow passing the ${fdtfile} to grub so that it can load the FDT based on selected kernel version location (which grub knows) and SoC/board specific ${fdtfile} (which grub does not know). Signed-off-by: Rob Clar

Re: [U-Boot] [PATCH v1 03/12] efi_loader: add EFI_UNICODE_COLLATION_PROTOCOL stub

2017-10-04 Thread Rob Clark
On Wed, Oct 4, 2017 at 1:57 PM, Heinrich Schuchardt wrote: > On 09/10/2017 03:22 PM, Rob Clark wrote: >> From: Leif Lindholm > > The commit message is missing. > > Fix all issues reported by checkpatch. > >> >> Signed-off-by: Leif Lindholm >>

Re: [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case

2017-10-04 Thread Rob Clark
and narrow down > this problem. > > Using the old allocation scheme fixes the mx6 SPL boot problem. > Hi Tom, if you are ok with this as a temporary fix, then this is: Acked-by: Rob Clark I'm getting some help from some of the fedora-arm folks so hopefully I can get some i

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

2017-10-04 Thread Rob Clark
On Wed, Oct 4, 2017 at 12:29 PM, Heinrich Schuchardt wrote: > On 10/04/2017 05:25 PM, Alexander Graf wrote: >> >> >> On 04.10.17 16:57, Rob Clark wrote: >>> On Wed, Oct 4, 2017 at 10:46 AM, Heinrich Schuchardt >>> wrote: >>>> On 10/04/2017 04:1

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

2017-10-04 Thread Rob Clark
On Wed, Oct 4, 2017 at 12:02 PM, Heinrich Schuchardt wrote: > On 10/04/2017 04:57 PM, Rob Clark wrote: >> On Wed, Oct 4, 2017 at 10:46 AM, Heinrich Schuchardt >> wrote: >>> On 10/04/2017 04:14 PM, Rob Clark wrote: >>>> On Wed, Oct 4, 2017 at 9:03

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

2017-10-04 Thread Rob Clark
On Wed, Oct 4, 2017 at 11:25 AM, Alexander Graf wrote: > > > On 04.10.17 16:57, Rob Clark wrote: >> >> On Wed, Oct 4, 2017 at 10:46 AM, Heinrich Schuchardt >> wrote: >>> >>> On 10/04/2017 04:14 PM, Rob Clark wrote: >>>> >>>

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

2017-10-04 Thread Rob Clark
On Wed, Oct 4, 2017 at 10:46 AM, Heinrich Schuchardt wrote: > On 10/04/2017 04:14 PM, Rob Clark wrote: >> On Wed, Oct 4, 2017 at 9:03 AM, Heinrich Schuchardt >> wrote: >>> Queued and signaled describe boolean states of events. >>> So let's use type bo

Re: [U-Boot] [PATCH] disk: Don't assume blksz > legacy_mbr

2017-10-04 Thread Rob Clark
On Wed, Oct 4, 2017 at 10:27 AM, Fabio Estevam wrote: > Hi Rob, > > On Wed, Oct 4, 2017 at 11:11 AM, Rob Clark wrote: > >> btw, I'm still hoping someone can get me some logs so I can see what >> blksz is, etc, on these boards.. > > Sorry, I haven't been

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

2017-10-04 Thread Rob Clark
On Wed, Oct 4, 2017 at 9:03 AM, Heinrich Schuchardt wrote: > Queued and signaled describe boolean states of events. > So let's use type bool and rename the structure members to is_queued > and is_signaled. > > Update the comments for is_queued and is_signaled. Reviewed-by:

Re: [U-Boot] [PATCH] disk: Don't assume blksz > legacy_mbr

2017-10-04 Thread Rob Clark
On Tue, Oct 3, 2017 at 12:32 PM, Rob Clark wrote: > On Tue, Oct 3, 2017 at 12:04 PM, Fabio Estevam wrote: >> On Tue, Oct 3, 2017 at 12:30 PM, Rob Clark wrote: >>> On some devices, this does not appear to be a valid assumption. So >>> figure out the number of bloc

[U-Boot] [PATCH] usb: kbd: Fix dangling pointers on probe fail

2017-10-03 Thread Rob Clark
If probe fails, we should unregister the stdio device, else we leave dangling pointers to the parent 'struct usb_device'. Signed-off-by: Rob Clark --- I finally got around to debugging why things explode so badly without fixing usb_kbd vs. iomux[1] (which this patch applies on to

Re: [U-Boot] [PATCH] disk: Don't assume blksz > legacy_mbr

2017-10-03 Thread Rob Clark
On Tue, Oct 3, 2017 at 12:04 PM, Fabio Estevam wrote: > On Tue, Oct 3, 2017 at 12:30 PM, Rob Clark wrote: >> On some devices, this does not appear to be a valid assumption. So >> figure out the number of blocks we actually need to read. >> >> Signed-off-by: Rob Clark

[U-Boot] [PATCH] disk: Don't assume blksz > legacy_mbr

2017-10-03 Thread Rob Clark
On some devices, this does not appear to be a valid assumption. So figure out the number of blocks we actually need to read. Signed-off-by: Rob Clark --- Sorry, took a bit longer to get to a point of testing this.. somehow himport_r() of the default_environment is clobbering my usb keyboard&#

Re: [U-Boot] [RFC] disk: part_dos: Fix part_test_dos() regression

2017-10-03 Thread Rob Clark
On Tue, Oct 3, 2017 at 7:04 AM, Fabio Estevam wrote: > On Tue, Oct 3, 2017 at 7:57 AM, Rob Clark wrote: > >> btw, if I had to take a guess, I'd say that perhaps blksz is smaller >> than 'legacy_mbr', so maybe rather than allocating blksize, it should >

Re: [U-Boot] [RFC] disk: part_dos: Fix part_test_dos() regression

2017-10-03 Thread Rob Clark
On Tue, Oct 3, 2017 at 6:47 AM, Rob Clark wrote: > personally I think we should try to figure out what is wrong on imx6 > rather than blindly reverting.. without this change MBR partitioned > disks might not generate unique device-paths for EFI boot. > > If you can't get any

Re: [U-Boot] [RFC] disk: part_dos: Fix part_test_dos() regression

2017-10-03 Thread Rob Clark
personally I think we should try to figure out what is wrong on imx6 rather than blindly reverting.. without this change MBR partitioned disks might not generate unique device-paths for EFI boot. If you can't get any debug logs from SPL build, perhaps you can try an old SPL image but main u-boot i

Re: [U-Boot] [PATCH v3 02/21] part: extract MBR signature from partitions

2017-10-02 Thread Rob Clark
On Mon, Oct 2, 2017 at 2:17 PM, Fabio Estevam wrote: > On Wed, Sep 13, 2017 at 7:05 PM, Rob Clark wrote: >> From: Peter Jones >> >> EFI client programs need the signature information from the partition >> table to determine the disk a partition is on, so we n

Re: [U-Boot] [PATCH] dm: video: make ANSI escape sequence support optional

2017-09-30 Thread Rob Clark
On Sat, Sep 30, 2017 at 4:19 AM, Anatolij Gustschin wrote: > As mentioned in review comments for ANSI escape sequence > support patches, this should be optional to reduce code > size. Disable escape sequence support when CONFIG_VIDEO_ANSI > is not enabled. Assuming the later version of the patch

Re: [U-Boot] [PATCH 0/3] dm: video: enhancements for Shell.efi

2017-09-28 Thread Rob Clark
On Thu, Sep 28, 2017 at 8:17 AM, Simon Glass wrote: > Hi Rob, > > On 13 September 2017 at 16:12, Rob Clark wrote: >> >> Split out of earlier efi_loader patchset, and updated with some >> comments, use of simple_strtol[1], and added kconfig option to >> en

[U-Boot] [PATCH] usb: kbd: Don't fail with iomux

2017-09-26 Thread Rob Clark
on dragonboard410c with distro- bootcmd, where stdin is not set (so stdinname is null). Signed-off-by: Rob Clark --- Somehow this patch was dropped on the floor. I don't remember which version # this is up to, search the list if you care. But this is the latest. I only noticed it was mi

[U-Boot] [PATCH 2/2] video: test: Add ANSI escape sequence tests

2017-09-25 Thread Rob Clark
Signed-off-by: Rob Clark --- Not sure if there is a way to inject a -l arg when test.py runs sanbox somehow, to visually confirm the results? It is not really possible to do manually since 'echo' command doesn't handle escape sequences properly. At any rate, efi_console uses all

[U-Boot] [PATCH 1/2] video: test: Helper for writing strings

2017-09-25 Thread Rob Clark
I'll need some more of this, let's not just copy-pasta the vidconsole_put_char() loop. Named to match vidconsole_put_char() in case that is ever useful outside of the tests. Signed-off-by: Rob Clark --- test/dm/video.c | 24 1 file changed, 12 inserti

Re: [U-Boot] [PATCH 3/3] fs-test: Add test for a filename using '..' to go back to the root

2017-09-24 Thread Rob Clark
On Sun, Sep 24, 2017 at 5:38 PM, Tom Rini wrote: > On Mon, Sep 25, 2017 at 12:07:36AM +0300, Tuomas Tynkkynen wrote: > >> The previous commit fixed a problem in FAT code where going back to the >> root directory using '..' wouldn't work correctly on FAT12 or FAT16. >> Add a test to exercise this c

Re: [U-Boot] [PATCH 1/3] fs-test: Add FAT16 support

2017-09-24 Thread Rob Clark
On Sun, Sep 24, 2017 at 5:07 PM, Tuomas Tynkkynen wrote: > Currently we can only test FAT32 which is the default FAT version that > mkfs.vfat creates by default. Instead make it explicitly create either a > FAT16 or a FAT32 volume. This allows us to exercise more code, for > instance the root dire

Re: [U-Boot] FAT filesystems and mtools-created filesystems

2017-09-24 Thread Rob Clark
On Sat, Sep 23, 2017 at 6:51 AM, Tuomas Tynkkynen wrote: > On 09/23/2017 01:26 PM, Tuomas Tynkkynen wrote: >> >> Hi, >> >> FAT file systems created by GNU mtools have a problem that mtools doesn't >> initialize the first cluster field of the '.' and '..' directory entries. >> That is, with the fol

Re: [U-Boot] [PATCH v3 15/21] efi_loader: add bootmgr

2017-09-21 Thread Rob Clark
On Thu, Sep 21, 2017 at 12:58 AM, Simon Glass wrote: > Hi, > > On 20 September 2017 at 08:09, Rob Clark wrote: >> On Wed, Sep 20, 2017 at 5:08 AM, Alexander Graf wrote: >>> >>> >>> On 14.09.17 00:05, Rob Clark wrote: >>>> >>>>

[U-Boot] [PATCH] efi_loader: fix efi_exit

2017-09-20 Thread Rob Clark
efi_exit() already restores gd, so we shouldn't EFI_EXIT() on the otherside of the longjmp(). Signed-off-by: Rob Clark --- cmd/bootefi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/cmd/bootefi.c b/cmd/bootefi.c index fdfed1be05..a049e5f64d 100644 --- a/cmd/bootefi.c +++ b/cmd/boot

Re: [U-Boot] [PATCH v2 1/1] efi_loader: reenable selftest

2017-09-20 Thread Rob Clark
boot device and loaded_image handling > Signed-off-by: Heinrich Schuchardt > --- > v2 > completely initialize loaded_image_info lgtm, thanks Reviewed-by: Rob Clark > --- > cmd/bootefi.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --g

Re: [U-Boot] [PATCH 1/1] efi_loader: reenable selftest

2017-09-20 Thread Rob Clark
On Wed, Sep 20, 2017 at 3:46 PM, Heinrich Schuchardt wrote: > ad503ffe9c6 efi_loader: refactor boot device and loaded_image handling > leads to an error when building with CONFIG_CMD_BOOTEFI_SELFTEST=y > This patch fixes the problem. > > Fixes: ad503ffe9c6 efi_loader: refactor boot device and load

Re: [U-Boot] cmd/bootefi.c:285:3: error: ‘loaded_image_info’ undeclared

2017-09-20 Thread Rob Clark
On Wed, Sep 20, 2017 at 2:42 PM, Heinrich Schuchardt wrote: > Hello Rob, hello Alex, > > when I try to compile efi-next I get > > CC cmd/bootefi.o > cmd/bootefi.c: In function ‘do_bootefi’: > cmd/bootefi.c:285:3: error: ‘loaded_image_info’ undeclared (first use in > this function) >load

Re: [U-Boot] [PATCH 16/23] efi_loader: implement DisconnectController

2017-09-20 Thread Rob Clark
On Wed, Sep 20, 2017 at 9:49 AM, Simon Glass wrote: > Hi Heinrich, > > On 15 September 2017 at 00:35, Heinrich Schuchardt wrote: >> On 08/31/2017 02:52 PM, Simon Glass wrote: >>> On 27 August 2017 at 06:53, Heinrich Schuchardt wrote: Signed-off-by: Heinrich Schuchardt --- lib/ef

Re: [U-Boot] [PATCH v3 05/21] efi_loader: add device-path utils

2017-09-20 Thread Rob Clark
On Wed, Sep 20, 2017 at 4:31 AM, Alexander Graf wrote: > > > On 14.09.17 00:05, Rob Clark wrote: >> >> Helpers to construct device-paths from devices, partitions, files, and >> for parsing and manipulating device-paths. >> >> For non-legacy devices,

Re: [U-Boot] [PATCH v3 15/21] efi_loader: add bootmgr

2017-09-20 Thread Rob Clark
On Wed, Sep 20, 2017 at 5:08 AM, Alexander Graf wrote: > > > On 14.09.17 00:05, Rob Clark wrote: >> >> Similar to a "real" UEFI implementation, the bootmgr looks at the >> BootOrder and Boot variables to try to find an EFI payload to load >> a

Re: [U-Boot] [PATCH 08/16] sandbox: Add a setjmp() implementation

2017-09-18 Thread Rob Clark
On Mon, Sep 18, 2017 at 2:01 AM, Heinrich Schuchardt wrote: > On 09/18/2017 12:59 AM, Simon Glass wrote: >> Add an implementation of setjmp() and longjmp() which rely on the >> underlying host C library. Since we cannot know how large the jump buffer >> needs to be, pick something that should be s

Re: [U-Boot] [PATCH] efi_loader: EFI entry point should be EFIAPI

2017-09-18 Thread Rob Clark
On Mon, Sep 18, 2017 at 1:47 PM, Rob Clark wrote: > This is needed to run 'bootefi' from sandbox. I suspect StartImage() > must have been broken too on x86. > > Signed-off-by: Rob Clark > --- > cmd/bootefi.c | 2 +- > include/efi.h

[U-Boot] [PATCH] efi_loader: EFI entry point should be EFIAPI

2017-09-18 Thread Rob Clark
This is needed to run 'bootefi' from sandbox. I suspect StartImage() must have been broken too on x86. Signed-off-by: Rob Clark --- cmd/bootefi.c | 2 +- include/efi.h | 2 +- lib/efi_loader/efi_boottime.c | 2 +- 3 files changed, 3 insertions(+), 3

Re: [U-Boot] [PATCH 00/16] efi: Enable basic sandbox support for EFI loader

2017-09-18 Thread Rob Clark
On Mon, Sep 18, 2017 at 11:07 AM, Rob Clark wrote: > On Mon, Sep 18, 2017 at 10:30 AM, Rob Clark wrote: >> On Mon, Sep 18, 2017 at 9:31 AM, Rob Clark wrote: >>> On Mon, Sep 18, 2017 at 9:18 AM, Rob Clark wrote: >>>> On Sun, Sep 17, 2017 at 11:48 PM, Heinrich Schuc

Re: [U-Boot] [PATCH 00/16] efi: Enable basic sandbox support for EFI loader

2017-09-18 Thread Rob Clark
On Mon, Sep 18, 2017 at 10:30 AM, Rob Clark wrote: > On Mon, Sep 18, 2017 at 9:31 AM, Rob Clark wrote: >> On Mon, Sep 18, 2017 at 9:18 AM, Rob Clark wrote: >>> On Sun, Sep 17, 2017 at 11:48 PM, Heinrich Schuchardt >>> wrote: >>>> On 09/18/2017 12:59 AM, S

Re: [U-Boot] [PATCH 00/16] efi: Enable basic sandbox support for EFI loader

2017-09-18 Thread Rob Clark
On Mon, Sep 18, 2017 at 9:31 AM, Rob Clark wrote: > On Mon, Sep 18, 2017 at 9:18 AM, Rob Clark wrote: >> On Sun, Sep 17, 2017 at 11:48 PM, Heinrich Schuchardt >> wrote: >>> On 09/18/2017 12:59 AM, Simon Glass wrote: >>>> A limitation of the EFI loader at pr

Re: [U-Boot] [PATCH 00/16] efi: Enable basic sandbox support for EFI loader

2017-09-18 Thread Rob Clark
On Mon, Sep 18, 2017 at 9:18 AM, Rob Clark wrote: > On Sun, Sep 17, 2017 at 11:48 PM, Heinrich Schuchardt > wrote: >> On 09/18/2017 12:59 AM, Simon Glass wrote: >>> A limitation of the EFI loader at present is that it does not build with >>> sandbox. This makes

  1   2   3   4   5   6   >