[PATCH v2] cmd: mtd: Enable speed benchmarking

2025-08-04 Thread Miquel Raynal
: MA35D1> mtd read nor0 0x8100 0 0x1 Reading 65536 byte(s) at offset 0x MA35D1> mtd read.benchmark nor0 0x8100 0 0x1 Reading 65536 byte(s) at offset 0x Read speed: 3752kiB/s Signed-off-by: Miquel Raynal --- Changes in v2: * Use an unsigned long as advised by Micha

Re: [PATCH] cmd: mtd: Enable speed benchmarking

2025-08-04 Thread Miquel Raynal
sing time and reading but this looked much nicer. I will give it a try > and review. Thanks! It turned out very useful for development purposes :-) >> Signed-off-by: Miquel Raynal >> --- [...] >> - bool dump, read, raw, woob, write_empty_pages, has_pages = false

Re: [PATCH] imx: power-domain: Fix crash due to uninitialized 'id' field

2025-07-22 Thread Miquel Raynal
struct ofnode_phandle_args *args) > { > + power_domain->id = 0; > + > return 0; > } Looks like a correct fix. I wonder how many drivers do not properly set an id though. Thanks a lot! Reviewed-by: Miquel Raynal Thanks, Miquèl

[PATCH] mtd: spinor: winbond: Describe several chips

2025-07-03 Thread Miquel Raynal
Signed-off-by: Miquel Raynal --- drivers/mtd/spi/spi-nor-ids.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c index 91ae49c94841..892bfd2db6f1 100644 --- a/drivers/mtd/spi/spi-nor-ids.c +++ b/drivers/mtd/spi/spi-nor-ids.c

[PATCH] cmd: mtd: Enable speed benchmarking

2025-07-03 Thread Miquel Raynal
: MA35D1> mtd read nor0 0x8100 0 0x1 Reading 65536 byte(s) at offset 0x MA35D1> mtd read.benchmark nor0 0x8100 0 0x1 Reading 65536 byte(s) at offset 0x Read speed: 3752kiB/s Signed-off-by: Miquel Raynal --- cmd/mtd.c | 15 ++- 1 file changed, 14 inse

[PATCH] mtd: spi-nor: winbond: Make sure w25q{01, 02}jv behave correctly

2025-07-02 Thread Miquel Raynal
. Link: https://lore.kernel.org/all/20250110-winbond-6-12-rc1-nor-volatile-bit-v3-1-735363f8c...@bootlin.com/ Signed-off-by: Miquel Raynal --- drivers/mtd/spi/spi-nor-core.c | 101 + 1 file changed, 101 insertions(+) diff --git a/drivers/mtd/spi/spi-nor-core.c b

[PATCH 2/2] imx: power-domain: Enable refcounting on imx8mp

2025-04-25 Thread Miquel Raynal
Prevent enabling/disabling multiple times the same power domain to avoid breakages due to the same power domains being referenced several times by different device nodes. Signed-off-by: Miquel Raynal --- drivers/power/domain/imx8m-power-domain.c | 4 drivers/power/domain/imx8mp-hsiomix.c

[PATCH 1/2] power-domain: Add support for refcounting (again)

2025-04-25 Thread Miquel Raynal
/off calls is even and the results match what we *now* expect. They are also extended to test the low-level functions. Signed-off-by: Miquel Raynal --- arch/sandbox/include/asm/power-domain.h | 2 + drivers/firmware/scmi/sandbox-scmi_devices.c | 1 + drivers/power/domain/power-do

[PATCH 0/2] power-domain: Enable uclass refcounting

2025-04-25 Thread Miquel Raynal
uld you please confirm it works on your side? For once, CI is green :-) https://github.com/u-boot/u-boot/pull/753 --- Miquel Raynal (2): power-domain: Add support for refcounting (again) imx: power-domain: Enable refcounting on imx8mp arch/sandbox/include/asm/power-domain.h

Re: [PATCH] Revert "power-domain: Add refcounting"

2025-04-22 Thread Miquel Raynal
Hi Simon, >> This sadly needs to get in, there have been 3 or 4 reports already, as >> many boards are broken. We need to find another way to add refcounting >> (otherwise some imx8* features will stay broken), but it requires more >> thinking time. >> >> Acke

Re: [PATCH] clk: Fix clk_set_parent() regression

2025-04-22 Thread Miquel Raynal
o > fix this regression and restore the old behavior of set_parent() ops > being called regardless of if enable() ops is implemented or not. > > Fixes: ac30d90f3367 ("clk: Ensure the parent clocks are enabled while > reparenting") > Signed-off-by: Jonas Karlman Thanks for the fix, Acked-by: Miquel Raynal Miquèl

Re: [PATCH] Revert "power-domain: Add refcounting"

2025-04-18 Thread Miquel Raynal
dy, as many boards are broken. We need to find another way to add refcounting (otherwise some imx8* features will stay broken), but it requires more thinking time. Acked-by: Miquel Raynal Thanks, Miquèl

Re: imx8mp: pci enumeration fails with current HEAD

2025-04-17 Thread Miquel Raynal
with: >> u-boot=> pci enum >> nxp_imx8_pcie_phy pcie-phy@32f0: PHY: Failed to power on >> pcie-phy@32f0: -110. >> pcie_dw_imx pcie@3380: failed to power on PHY >> u-boot=> >> git bisect dropped your patch: >> 197376fbf300e92afa0a1583815d9c9eb

Re: imx8mp: pci enumeration fails with current HEAD

2025-04-17 Thread Miquel Raynal
hy pcie-phy@32f0: PHY: Failed to power on > pcie-phy@32f0: -110. > pcie_dw_imx pcie@3380: failed to power on PHY > u-boot=> > > git bisect dropped your patch: > > 197376fbf300e92afa0a1583815d9c9eb52d613a is the first bad commit > commit 197376fbf300e92afa0a1583815d9c9e

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-16 Thread Miquel Raynal
On 16/04/2025 at 16:20:06 +03, Wadim Egorov wrote: > Am 16.04.25 um 12:50 schrieb Neha Malcom Francis: >> Hi Miquel >> On 16/04/25 14:36, Miquel Raynal wrote: >>> Hello, >>> >>>>>> -int power_domain_on(struct power_domain *power_domain) >&

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-16 Thread Miquel Raynal
Hello, >>> -int power_domain_on(struct power_domain *power_domain) >>> +int power_domain_on_lowlevel(struct power_domain *power_domain) >>> { >>> + struct power_domain_priv *priv = dev_get_uclass_priv(power_domain->dev); >>> struct power_domain_ops *ops = power_domain_dev_ops(power_domain->

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-15 Thread Miquel Raynal
On 15/04/2025 at 15:29:09 +0530, Neha Malcom Francis wrote: > Hi Miquel > > On 15/04/25 15:20, Miquel Raynal wrote: >>>> Francesco, are you also testing on K3 platforms? >>>> >>> >>> Yes he would be, since the firmware print is K3 firmware

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-15 Thread Miquel Raynal
>> Francesco, are you also testing on K3 platforms? >> > > Yes he would be, since the firmware print is K3 firmware. > >> Can one of you boot with the patch below applied? It should partially >> revert the commit to the ancient behaviour, while adding more debug >> traces (please enable the debug

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-15 Thread Miquel Raynal
to enable/disable its own power domain. I will need to know what board/SoC was used for the test, so I can look the relevant driver up. Thanks for your help, Miquèl --- >From 4b128872b2dbcdfb626b8683fbb6c75d17a5089c Mon Sep 17 00:00:00 2001 From: Miquel Raynal Date: Tue, 15 Apr 2025 10:07:05 +0200 Sub

Re: [PATCH v6 03/12] dm: core: Add a helper to retrieve devices through graph endpoints

2025-04-05 Thread Miquel Raynal
> +int uclass_get_device_by_endpoint(enum uclass_id class_id, struct udevice > *dev, > + int port_idx, int ep_idx, struct udevice > **devp) > +{ > + ofnode node_source = dev_ofnode(dev); > + ofnode node_dest = ofnode_graph_get_remote_node(node_source, port_

[PATCH v5 06/12] clk: Ensure the parent clocks are enabled while reparenting

2025-04-05 Thread Miquel Raynal
applied in other parts of the CCM. Signed-off-by: Miquel Raynal --- drivers/clk/clk-uclass.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c index 90b70529a478d11d907cbd6b64d680d0c1db4d5c

[PATCH v6 07/12] clk: imx8mp: Add media related clocks

2025-04-05 Thread Miquel Raynal
These are all the clocks needed to get an LCD panel working, going through one of the LCDIF and the LDB. The media AXI and APB clocks are also described. Signed-off-by: Miquel Raynal --- drivers/clk/imx/clk-imx8mp.c | 69 1 file changed, 69

[PATCH v6 12/12] video: imx: Add LCDIF driver

2025-04-05 Thread Miquel Raynal
. This is normal though, it was contributed more than ten years ago. Signed-off-by: Miquel Raynal --- drivers/video/imx/Kconfig | 3 + drivers/video/imx/Makefile | 1 + drivers/video/imx/lcdif.c | 314 + 3 files changed, 318 insertions(+) diff

[PATCH v6 09/12] imx: power-domain: Add support for the MEDIAMIX control block

2025-04-05 Thread Miquel Raynal
This block delivers power and clocks to the whole display and rendering pipeline. Signed-off-by: Miquel Raynal --- drivers/power/domain/Kconfig | 7 ++ drivers/power/domain/Makefile | 1 + drivers/power/domain/imx8mp-mediamix.c | 208 + 3

Re: [PATCH v6 09/12] imx: power-domain: Add support for the MEDIAMIX control block

2025-04-04 Thread Miquel Raynal
Hi Adam, >> + /* Enable upstream clocks */ >> + ret = clk_enable(&priv->clk_apb); >> + if (ret) >> + goto dis_bus_pd; >> + >> + ret = clk_enable(&priv->clk_axi); >> + if (ret) >> + goto dis_apb_clk; >> + >> + /* Enable blk-ctrl clock

[PATCH v6 01/12] core: ofnode_graph: Fix a comment

2025-04-04 Thread Miquel Raynal
Naming between the parameter list, the prototype and the main comment do not match. Fix the comment which seems the be the one that is incorrect. Fixes: 9057077cf4e1 ("core: ofnode: add of_graph parsing helpers") Signed-off-by: Miquel Raynal Reviewed-by: Svyatoslav Ryhel --- dr

[PATCH v6 00/12] Add imx8mp video support

2025-04-04 Thread Miquel Raynal
mix block driver. - Fix many typos. - Fix checkpatch warnings. - Rebase on next. - Collect tags - Link to v1: https://lore.kernel.org/r/20240910101344.110633-1-miquel.ray...@bootlin.com --- Miquel Raynal (12): core: ofnode_graph: Fix a comment dm: doc: Fix example dm: core: Ad

Re: [PATCH v6 12/12] video: imx: Add LCDIF driver

2025-04-04 Thread Miquel Raynal
Hi Adam, > since there are three instances of this LCDIF, when most other boards > have just one, do you know what happens if someone's device tree has > all three enabled? Is the video mirrored, or does it just go to one of > the instances? IIRC they are not connected to the same outputs, there

[PATCH v6 10/12] video: imx: Fix Makefile in order to be able to add other imx drivers

2025-04-03 Thread Miquel Raynal
The IPUv3 is one IP part of the imx world, there are others, and selecting the whole imx/ folder based on such a specific Kconfig symbol is sub-optimal. Let's always enter the imx/ folder, and then selectively compile parts of the folder based on the configuration. Signed-off-by: Miquel R

[PATCH v6 11/12] video: imx: Add LDB driver

2025-04-03 Thread Miquel Raynal
configuration. This driver was tested on i.MX8MP using a single panel connected to the LVDS2 interface. Signed-off-by: Miquel Raynal --- drivers/video/imx/Kconfig | 6 ++ drivers/video/imx/Makefile | 1 + drivers/video/imx/ldb.c| 251 + 3 files

[PATCH v6 08/12] imx: power-domain: Describe the i.MX8 MEDIAMIX domain

2025-04-03 Thread Miquel Raynal
Add support for the i.MX8 MEDIAMIX domain which is driving the power over the whole display/rendering pipeline. Signed-off-by: Miquel Raynal Reviewed-by: Fabio Estevam --- drivers/power/domain/imx8m-power-domain.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers

[PATCH v6 05/12] power-domain: Add refcounting

2025-04-03 Thread Miquel Raynal
implementation is split between: - a low-level helper reporting error codes if the requested transition could not be operated, - a higher-level helper ignoring the "non error" codes, like EALREADY and EBUSY. Signed-off-by: Miquel Raynal --- drivers/firmware/scmi/sandbox-scmi_devices.

Re: [PATCH v4 00/12] Add imx8mp video support

2025-04-03 Thread Miquel Raynal
Hi Tom, >> I need the tests to run on the test.dts and not the default sandbox.dts. >> The documentation states to use -T for that when doing the checks >> locally. Unfortunately, the Azure pipelines do use the default sandbox >> DT. I can add few mostly useless nodes to the default DTS for the te

Re: [PATCH v5 03/12] dm: core: Add a helper to retrieve devices through graph endpoints

2025-04-03 Thread Miquel Raynal
>> +int uclass_get_device_by_endpoint(enum uclass_id class_id, struct udevice >> *dev, >> + int port_idx, int ep_idx, struct udevice >> **devp) >> +{ >> + ofnode node_source = dev_ofnode(dev); >> + ofnode node_dest = ofnode_graph_get_remote_node(node_

[PATCH v6 06/12] clk: Ensure the parent clocks are enabled while reparenting

2025-04-03 Thread Miquel Raynal
applied in other parts of the CCM. Signed-off-by: Miquel Raynal --- drivers/clk/clk-uclass.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c index 90b70529a478d11d907cbd6b64d680d0c1db4d5c

[PATCH v6 04/12] test: dm: test-fdt: Add checks for uclass_get_device_by_endpoint()

2025-04-03 Thread Miquel Raynal
This is a new DM core helper. There is now a graph endpoint representation in the sandbox test DTS, so we can just use it to verify the helper proper behavior. Suggested-by: Simon Glass Reviewed-by: Simon Glass Signed-off-by: Miquel Raynal --- configs/sandbox64_defconfig| 2

[PATCH v6 03/12] dm: core: Add a helper to retrieve devices through graph endpoints

2025-04-03 Thread Miquel Raynal
enters the child graph reprensentation, looks for a specific port, then follows the remote endpoint, and finally retrieves the first parent of the given uclass_id. This is a very handy and straightforward way to get a bridge or a panel handle. Reviewed-by: Simon Glass Signed-off-by: Miquel Raynal

[PATCH v6 02/12] dm: doc: Fix example

2025-04-03 Thread Miquel Raynal
`.priv_data_size` does not exist. I believe the actual structure member was supposed to be `.priv_auto`. Reviewed-by: Simon Glass Signed-off-by: Miquel Raynal --- doc/develop/driver-model/design.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/develop/driver-model

Re: [PATCH v4 00/12] Add imx8mp video support

2025-03-28 Thread Miquel Raynal
>> > I see that the Azure failure is: >> > https://dev.azure.com/u-boot/u-boot/_build/results?buildId=10824&view=results >> > which was the unfortunate "next is broken because master has a fix and >> > next has a test that needed updating now" that happened this week with >> > -rc5 being merged. So

Re: [PATCH v4 00/12] Add imx8mp video support

2025-03-28 Thread Miquel Raynal
On 27/03/2025 at 08:14:42 -06, Tom Rini wrote: > On Thu, Mar 27, 2025 at 10:31:18AM -0300, Fabio Estevam wrote: >> Hi Miquel, >> >> On Wed, Mar 26, 2025 at 12:01 PM Miquel Raynal >> wrote: >> >> > I rebased this work on the latest next, fixed the

[PATCH v5 03/12] dm: core: Add a helper to retrieve devices through graph endpoints

2025-03-28 Thread Miquel Raynal
enters the child graph reprensentation, looks for a specific port, then follows the remote endpoint, and finally retrieves the first parent of the given uclass_id. This is a very handy and straightforward way to get a bridge or a panel handle. Reviewed-by: Simon Glass Signed-off-by: Miquel Raynal

Re: [PATCH v5 07/12] clk: imx8mp: Add media related clocks

2025-03-26 Thread Miquel Raynal
Hello Adam, On 26/03/2025 at 10:39:44 -05, Adam Ford wrote: > On Wed, Mar 26, 2025 at 10:01 AM Miquel Raynal > wrote: >> >> These are all the clocks needed to get an LCD panel working, going >> through one of the LCDIF and the LDB. The media AXI and APB clocks are >&

Re: [PATCH v5 00/12] Add imx8mp video support

2025-03-26 Thread Miquel Raynal
> - Fixed the tests, again. I observe that the doc explicitly says that we should run tests (specifically the DM tests) using -T to use the test.dts DT instead of the default -D sandbox.dts. However Azure pipelines do not use the test device tree and obviously fail sometimes: https://dev.azure.

[PATCH v5 08/12] imx: power-domain: Describe the i.MX8 MEDIAMIX domain

2025-03-26 Thread Miquel Raynal
Add support for the i.MX8 MEDIAMIX domain which is driving the power over the whole display/rendering pipeline. Signed-off-by: Miquel Raynal Reviewed-by: Fabio Estevam --- drivers/power/domain/imx8m-power-domain.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers

[PATCH v5 07/12] clk: imx8mp: Add media related clocks

2025-03-26 Thread Miquel Raynal
These are all the clocks needed to get an LCD panel working, going through one of the LCDIF and the LDB. The media AXI and APB clocks are also described. Signed-off-by: Miquel Raynal --- drivers/clk/imx/clk-imx8mp.c | 69 1 file changed, 69

[PATCH v5 05/12] power-domain: Add refcounting

2025-03-26 Thread Miquel Raynal
implementation is split between: - a low-level helper reporting error codes if the requested transition could not be operated, - a higher-level helper ignoring the "non error" codes, like EALREADY and EBUSY. Signed-off-by: Miquel Raynal --- drivers/firmware/scmi/sandbox-scmi_devices.

Re: [PATCH v5 01/12] core: ofnode: Fix a comment

2025-03-26 Thread Miquel Raynal
Hello, On 26/03/2025 at 18:31:02 +02, Svyatoslav Ryhel wrote: > ср, 26 бер. 2025 р. о 17:01 Miquel Raynal пише: >> >> Naming between the parameter list, the prototype and the main comment do >> not match. Fix the comment which seems the be the one that is incorrect. >

[PATCH v5 12/12] video: imx: Add LCDIF driver

2025-03-26 Thread Miquel Raynal
. This is normal though, it was contributed more than ten years ago. Signed-off-by: Miquel Raynal --- drivers/video/imx/Kconfig | 3 + drivers/video/imx/Makefile | 1 + drivers/video/imx/lcdif.c | 314 + 3 files changed, 318 insertions(+) diff

[PATCH v5 11/12] video: imx: Add LDB driver

2025-03-26 Thread Miquel Raynal
configuration. This driver was tested on i.MX8MP using a single panel connected to the LVDS2 interface. Signed-off-by: Miquel Raynal --- drivers/video/imx/Kconfig | 6 ++ drivers/video/imx/Makefile | 1 + drivers/video/imx/ldb.c| 251 + 3 files

[PATCH v5 10/12] video: imx: Fix Makefile in order to be able to add other imx drivers

2025-03-26 Thread Miquel Raynal
The IPUv3 is one IP part of the imx world, there are others, and selecting the whole imx/ folder based on such a specific Kconfig symbol is sub-optimal. Let's always enter the imx/ folder, and then selectively compile parts of the folder based on the configuration. Signed-off-by: Miquel R

[PATCH v5 09/12] imx: power-domain: Add support for the MEDIAMIX control block

2025-03-26 Thread Miquel Raynal
This block delivers power and clocks to the whole display and rendering pipeline. Signed-off-by: Miquel Raynal --- drivers/power/domain/Kconfig | 7 ++ drivers/power/domain/Makefile | 1 + drivers/power/domain/imx8mp-mediamix.c | 208 + 3

[PATCH v5 02/12] dm: doc: Fix example

2025-03-26 Thread Miquel Raynal
`.priv_data_size` does not exist. I believe the actual structure member was supposed to be `.priv_auto`. Reviewed-by: Simon Glass Signed-off-by: Miquel Raynal --- doc/develop/driver-model/design.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/develop/driver-model

[PATCH v5 04/12] test: dm: test-fdt: Add checks for uclass_get_device_by_endpoint()

2025-03-26 Thread Miquel Raynal
This is a new DM core helper. There is now a graph endpoint representation in the sandbox test DTS, so we can just use it to verify the helper proper behavior. Suggested-by: Simon Glass Reviewed-by: Simon Glass Signed-off-by: Miquel Raynal --- test/dm/test-fdt.c | 20 +++- 1

[PATCH v5 01/12] core: ofnode: Fix a comment

2025-03-26 Thread Miquel Raynal
Naming between the parameter list, the prototype and the main comment do not match. Fix the comment which seems the be the one that is incorrect. Fixes: 9057077cf4e1 ("core: ofnode: add of_graph parsing helpers") Signed-off-by: Miquel Raynal --- drivers/core/ofnode_graph.c | 2

[PATCH v5 00/12] Add imx8mp video support

2025-03-26 Thread Miquel Raynal
h warnings. - Rebase on next. - Collect tags - Link to v1: https://lore.kernel.org/r/20240910101344.110633-1-miquel.ray...@bootlin.com --- Miquel Raynal (12): core: ofnode: Fix a comment dm: doc: Fix example dm: core: Add a helper to retrieve devices through gr

Re: [PATCH v4 00/12] Add imx8mp video support

2025-03-26 Thread Miquel Raynal
Hi Fabio, On 13/03/2025 at 15:26:30 -03, Fabio Estevam wrote: > Hi Miquel, > > On Mon, Mar 3, 2025 at 2:15 PM Svyatoslav Ryhel wrote: > >> If seems that we are working on the same OF graph stuff > > Yes, there is a conflict in next when I try to apply your series due > to recent commits from Sv

Re: [PATCH v4 00/12] Add imx8mp video support

2025-03-06 Thread Miquel Raynal
Hi Fabio, On 06/03/2025 at 09:38:29 -03, Fabio Estevam wrote: > On Wed, Mar 5, 2025 at 3:17 PM Tom Rini wrote: > >> The series is delayed until someone has a chance to look harder at >> what's causing the handoff test to now fail. > > Ok, I marked this series as "Changes Requested" in patchwork

Re: [PATCH v4 05/12] power-domain: Add refcounting

2025-03-04 Thread Miquel Raynal
>> >> It is very surprising that such an uclass, specifically designed to >> >> handle resources that may be shared by different devices, is not keeping >> >> the count of the number of times a power domain has been >> >> enabled/disabled to avoid shutting it down unexpectedly or disabling it >>

Re: [PATCH v4 05/12] power-domain: Add refcounting

2025-03-03 Thread Miquel Raynal
Hello Simon, On 08/02/2025 at 08:09:30 -03, Fabio Estevam wrote: > Hi Simon, > > On Wed, Jan 29, 2025 at 7:22 AM Miquel Raynal > wrote: >> >> It is very surprising that such an uclass, specifically designed to >> handle resources that may be shared by different

Re: [PATCH] fs/squashfs: Fix memory leak in sqfs_size_nest()

2025-03-03 Thread Miquel Raynal
; > Set the ret value and just break out of the switch to fix this. > > Signed-off-by: Andrea della Porta Reviewed-by: Miquel Raynal Thanks, Miquèl

Re: Security vulnerabilities report to Das-U-Boot

2025-02-12 Thread Miquel Raynal
Hello Tom, On 11/02/2025 at 15:29:09 -06, Tom Rini wrote: > On Tue, Feb 11, 2025 at 08:26:37AM -0800, Jonathan Bar Or wrote: >> Hi Tom and the rest of the team, >> >> Please let me know about fix time, whether this is acknowledged and >> whether you're going to request CVE IDs for those or if I

[PATCH v4 11/12] video: imx: Add LDB driver

2025-01-29 Thread Miquel Raynal
configuration. This driver was tested on i.MX8MP using a single panel connected to the LVDS2 interface. Signed-off-by: Miquel Raynal --- drivers/video/imx/Kconfig | 6 ++ drivers/video/imx/Makefile | 1 + drivers/video/imx/ldb.c| 251 + 3 files

[PATCH v4 10/12] video: imx: Fix Makefile in order to be able to add other imx drivers

2025-01-29 Thread Miquel Raynal
The IPUv3 is one IP part of the imx world, there are others, and selecting the whole imx/ folder based on such a specific Kconfig symbol is sub-optimal. Let's always enter the imx/ folder, and then selectively compile parts of the folder based on the configuration. Signed-off-by: Miquel R

[PATCH v4 12/12] video: imx: Add LCDIF driver

2025-01-29 Thread Miquel Raynal
. This is normal though, it was contributed more than ten years ago. Signed-off-by: Miquel Raynal --- drivers/video/imx/Kconfig | 3 + drivers/video/imx/Makefile | 1 + drivers/video/imx/lcdif.c | 314 + 3 files changed, 318 insertions(+) diff

[PATCH v4 08/12] imx: power-domain: Describe the i.MX8 MEDIAMIX domain

2025-01-29 Thread Miquel Raynal
Add support for the i.MX8 MEDIAMIX domain which is driving the power over the whole display/rendering pipeline. Signed-off-by: Miquel Raynal Reviewed-by: Fabio Estevam --- drivers/power/domain/imx8m-power-domain.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers

[PATCH v4 09/12] imx: power-domain: Add support for the MEDIAMIX control block

2025-01-29 Thread Miquel Raynal
This block delivers power and clocks to the whole display and rendering pipeline. Signed-off-by: Miquel Raynal --- drivers/power/domain/Kconfig | 7 ++ drivers/power/domain/Makefile | 1 + drivers/power/domain/imx8mp-mediamix.c | 208 + 3

[PATCH v4 06/12] clk: Ensure the parent clocks are enabled while reparenting

2025-01-29 Thread Miquel Raynal
applied in other parts of the CCM. Signed-off-by: Miquel Raynal --- drivers/clk/clk-uclass.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c index a9937c22dcb6bcc90b14f748a0758810a7435d61

[PATCH v4 07/12] clk: imx8mp: Add media related clocks

2025-01-29 Thread Miquel Raynal
These are all the clocks needed to get an LCD panel working, going through one of the LCDIF and the LDB. The media AXI and APB clocks are also described. Signed-off-by: Miquel Raynal --- drivers/clk/imx/clk-imx8mp.c | 69 1 file changed, 69

[PATCH v4 02/12] dm: core: Add a helper to retrieve devices through graph endpoints

2025-01-29 Thread Miquel Raynal
enters the child graph reprensentation, looks for a specific port, then follows the remote endpoint, and finally retrieves the first parent of the given uclass_id. This is a very handy and straightforward way to get a bridge or a panel handle. Reviewed-by: Simon Glass Signed-off-by: Miquel Raynal

[PATCH v4 05/12] power-domain: Add refcounting

2025-01-29 Thread Miquel Raynal
implementation is split between: - a low-level helper reporting error codes if the requested transition could not be operated, - a higher-level helper ignoring the "non error" codes, like EALREADY and EBUSY. Signed-off-by: Miquel Raynal --- drivers/firmware/scmi/sandbox-scmi_devices.

[PATCH v4 03/12] sandbox: Add a fake DSI controller and link it to the panel

2025-01-29 Thread Miquel Raynal
Use a graph endpoint representation for that in order to test a new core DM helper going through these properties. Display pipelines typically include graph endpoints, but the helper is generic and would work with any device type. Reviewed-by: Simon Glass Signed-off-by: Miquel Raynal --- arch

[PATCH v4 01/12] dm: doc: Fix example

2025-01-29 Thread Miquel Raynal
`.priv_data_size` does not exist. I believe the actual structure member was supposed to be `.priv_auto`. Reviewed-by: Simon Glass Signed-off-by: Miquel Raynal --- doc/develop/driver-model/design.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/develop/driver-model

[PATCH v4 04/12] test: dm: test-fdt: Add checks for uclass_get_device_by_endpoint()

2025-01-29 Thread Miquel Raynal
This is a new DM core helper. There is now a graph endpoint representation in the sandbox test DTS, so we can just use it to verify the helper proper behavior. Suggested-by: Simon Glass Reviewed-by: Simon Glass Signed-off-by: Miquel Raynal --- configs/sandbox64_defconfig| 1

[PATCH v4 00/12] Add imx8mp video support

2025-01-29 Thread Miquel Raynal
upport, as Adam and Fabio advised. - Disable the enabled clocks in the remove path of the mediamix block driver. - Fix many typos. - Fix checkpatch warnings. - Rebase on next. - Collect tags - Link to v1: https://lore.kernel.org/r/20240910101344.110633-1-miquel.ray...@bootlin.com --- Miquel Rayn

Re: [PATCH v3 05/13] power-domain: Add refcounting

2025-01-28 Thread Miquel Raynal
Hi Simon, Cheers, Miquèl

Re: [PATCH v3 05/13] power-domain: Add refcounting

2025-01-27 Thread Miquel Raynal
Hi Simon, On 25/01/2025 at 10:11:22 -07, Simon Glass wrote: > Hi Miquel, > > On Fri, 24 Jan 2025 at 08:20, Miquel Raynal wrote: >> >> Hi Simon, >> >> >> > If we >> >> > want a power domain to actually turn off, how many times do we need

Re: [PATCH v3 05/13] power-domain: Add refcounting

2025-01-24 Thread Miquel Raynal
Hi Simon, >> > If we >> > want a power domain to actually turn off, how many times do we need to >> > call power_domain_off()? >> >> We do not? It is why I add refcounting, if a power domain has 2 >> consumers, each consumer says whether it needs the power domain to be on >> or off and the core wi

Re: [PATCH v3 05/13] power-domain: Add refcounting

2025-01-21 Thread Miquel Raynal
Hi Simon, On 20/01/2025 at 12:21:04 -07, Simon Glass wrote: > Hi Miquel, > > On Mon, 20 Jan 2025 at 03:34, Miquel Raynal wrote: >> >> Hello Simon, >> >> >> int power_domain_on(struct power_domain *power_domain) >> >> {

Re: [PATCH v3 05/13] power-domain: Add refcounting

2025-01-20 Thread Miquel Raynal
Hello Simon, >> int power_domain_on(struct power_domain *power_domain) >> { ... >> + if (priv->on_count++ > 0) >> + return 0; > > -EALREADY ... >> int power_domain_off(struct power_domain *power_domain) >> { ... >> + if (priv->on_count-- > 1) >> +

Re: [PATCH v3 13/13] imx8mp_evk: Enable display support

2025-01-16 Thread Miquel Raynal
On 16/01/2025 at 13:13:53 -03, Fabio Estevam wrote: > Hi Miquel, > > On Sat, Jan 11, 2025 at 6:51 AM Miquel Raynal > wrote: > >> I only worked on a custom design based on a i.MX8MP. We do have an EVK, >> but it has no display. I was asked to add a user, but in practi

Re: [PATCH v3 13/13] imx8mp_evk: Enable display support

2025-01-11 Thread Miquel Raynal
Hello Fabio, On 10/01/2025 at 15:53:35 -03, Fabio Estevam wrote: > Hi Peng, > > On Fri, Jan 10, 2025 at 3:43 PM Miquel Raynal > wrote: >> >> There is now support for the display pipeline using one LCD interface, >> the LDB bridge and of course the relat

[PATCH v3 08/13] imx: power-domain: Describe the i.MX8 MEDIAMIX domain

2025-01-10 Thread Miquel Raynal
Add support for the i.MX8 MEDIAMIX domain which is driving the power over the whole display/rendering pipeline. Signed-off-by: Miquel Raynal Reviewed-by: Fabio Estevam --- drivers/power/domain/imx8m-power-domain.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers

[PATCH v3 13/13] imx8mp_evk: Enable display support

2025-01-10 Thread Miquel Raynal
needed to enable the VIDEO_CONSOLE explicitly using: setenv stdout serial,vidconsole0 Signed-off-by: Miquel Raynal --- configs/imx8mp_evk_defconfig | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configs/imx8mp_evk_defconfig b/configs/imx8mp_evk_defconfig index

[PATCH v3 12/13] video: imx: Add LCDIF driver

2025-01-10 Thread Miquel Raynal
. This is normal though, it was contributed more than ten years ago. Signed-off-by: Miquel Raynal --- drivers/video/imx/Kconfig | 3 + drivers/video/imx/Makefile | 1 + drivers/video/imx/lcdif.c | 314 + 3 files changed, 318 insertions(+) diff

[PATCH v3 09/13] imx: power-domain: Add support for the MEDIAMIX control block

2025-01-10 Thread Miquel Raynal
This block delivers power and clocks to the whole display and rendering pipeline. Signed-off-by: Miquel Raynal --- drivers/power/domain/Kconfig | 7 ++ drivers/power/domain/Makefile | 1 + drivers/power/domain/imx8mp-mediamix.c | 208 + 3

[PATCH v3 10/13] video: imx: Fix Makefile in order to be able to add other imx drivers

2025-01-10 Thread Miquel Raynal
The IPUv3 is one IP part of the imx world, there are others, and selecting the whole imx/ folder based on such a specific Kconfig symbol is sub-optimal. Let's always enter the imx/ folder, and then selectively compile parts of the folder based on the configuration. Signed-off-by: Miquel R

[PATCH v3 11/13] video: imx: Add LDB driver

2025-01-10 Thread Miquel Raynal
configuration. This driver was tested on i.MX8MP using a single panel connected to the LVDS2 interface. Signed-off-by: Miquel Raynal --- drivers/video/imx/Kconfig | 6 ++ drivers/video/imx/Makefile | 1 + drivers/video/imx/ldb.c| 251 + 3 files

[PATCH v3 07/13] clk: imx8mp: Add media related clocks

2025-01-10 Thread Miquel Raynal
These are all the clocks needed to get an LCD panel working, going through one of the LCDIF and the LDB. The media AXI and APB clocks are also described. Signed-off-by: Miquel Raynal --- drivers/clk/imx/clk-imx8mp.c | 69 1 file changed, 69

[PATCH v3 06/13] clk: Ensure the parent clocks are enabled while reparenting

2025-01-10 Thread Miquel Raynal
applied in other parts of the CCM. Signed-off-by: Miquel Raynal --- drivers/clk/clk-uclass.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c index a9937c22dcb6bcc90b14f748a0758810a7435d61

[PATCH v3 04/13] test: dm: test-fdt: Add checks for uclass_get_device_by_endpoint()

2025-01-10 Thread Miquel Raynal
This is a new DM core helper. There is now a graph endpoint representation in the sandbox test DTS, so we can just use it to verify the helper proper behavior. Suggested-by: Simon Glass Reviewed-by: Simon Glass Signed-off-by: Miquel Raynal --- configs/sandbox64_defconfig| 1

[PATCH v3 05/13] power-domain: Add refcounting

2025-01-10 Thread Miquel Raynal
, leading to ADB400 errors and later crashes in Linux. CI tests using power domains are slightly updated to make sure the count of on/off calls is even and the results match what we *now* expect. Signed-off-by: Miquel Raynal --- drivers/firmware/scmi/sandbox-scmi_devices.c | 1 + drivers

[PATCH v3 02/13] dm: core: Add a helper to retrieve devices through graph endpoints

2025-01-10 Thread Miquel Raynal
enters the child graph reprensentation, looks for a specific port, then follows the remote endpoint, and finally retrieves the first parent of the given uclass_id. This is a very handy and straightforward way to get a bridge or a panel handle. Reviewed-by: Simon Glass Signed-off-by: Miquel Raynal

[PATCH v3 03/13] sandbox: Add a fake DSI controller and link it to the panel

2025-01-10 Thread Miquel Raynal
Use a graph endpoint representation for that in order to test a new core DM helper going through these properties. Display pipelines typically include graph endpoints, but the helper is generic and would work with any device type. Reviewed-by: Simon Glass Signed-off-by: Miquel Raynal --- arch

[PATCH v3 00/13] Add imx8mp video support

2025-01-10 Thread Miquel Raynal
d configurations without video support, as Adam and Fabio advised. - Disable the enabled clocks in the remove path of the mediamix block driver. - Fix many typos. - Fix checkpatch warnings. - Rebase on next. - Collect tags - Link to v1: https://lore.kernel.org/r/20240910101344.110633-1-miqu

[PATCH v3 01/13] dm: doc: Fix example

2025-01-10 Thread Miquel Raynal
`.priv_data_size` does not exist. I believe the actual structure member was supposed to be `.priv_auto`. Reviewed-by: Simon Glass Signed-off-by: Miquel Raynal --- doc/develop/driver-model/design.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/develop/driver-model

Re: [PATCH 1/1] tpm: update descriptions in tpm-v2.h header

2024-12-30 Thread Miquel Raynal
cification 1.0, rev 10 What about including this in the comment rather than dropping the comment entirely? > * Describe some of the structures in Sphinx style. > > Signed-off-by: Heinrich Schuchardt Fine otherwise, Reviewed-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH v2 00/13] Add imx8mp video support

2024-12-20 Thread Miquel Raynal
Hi Fabio, > There are errors in CI when this series is applied. > > Please take a look at the sandbox test failures: I observed errors while locally testing which looked unrelated. I'll do another test round and see what I can fix. > https://source.denx.de/u-boot/custodians/u-boot-imx/-/pipeline

Re: [PATCH v2 05/13] power-domain: Add refcounting

2024-12-06 Thread Miquel Raynal
Hello Simon, On 05/12/2024 at 10:56:44 -07, Simon Glass wrote: > Hi Miquel, > > On Thu, 5 Dec 2024 at 06:54, Miquel Raynal wrote: >> >> It is very surprising that such an uclass, specifically designed to >> handle resources that may be shared by different devices,

[PATCH v2 12/13] video: imx: Add LCDIF driver

2024-12-05 Thread Miquel Raynal
. This is normal though, it was contributed more than ten years ago. Signed-off-by: Miquel Raynal --- drivers/video/imx/Kconfig | 3 + drivers/video/imx/Makefile | 1 + drivers/video/imx/lcdif.c | 314 + 3 files changed, 318 insertions(+) diff

[PATCH v2 11/13] video: imx: Add LDB driver

2024-12-05 Thread Miquel Raynal
configuration. This driver was tested on i.MX8MP using a single panel connected to the LVDS2 interface. Signed-off-by: Miquel Raynal --- drivers/video/imx/Kconfig | 6 ++ drivers/video/imx/Makefile | 1 + drivers/video/imx/ldb.c| 251 + 3 files

  1   2   3   4   5   6   7   8   9   10   >