Re: [PATCH] mailbox: zynqmp: Fix off by 1 errors

2025-08-01 Thread Michal Simek
return -EINVAL; --- base-commit: 4c3b5fcd810081bd7f3c51859fe1b5f0c159803c change-id: 20250728-zynqmp-ipi-0b1791238085 Best regards, Applied. M -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microbla

Re: [PATCH 1/2] serial: uartlite: Use private data instead of platform

2025-08-01 Thread Michal Simek
On 7/23/25 11:06, Michal Simek wrote: plat data should be used only in probe or of_to_plat to fill it information from DT. Then in probe platform data should be stored in private structure which should be used by the other driver functions. Signed-off-by: Michal Simek --- drivers/serial

Re: [PATCH 0/4] xilinx: mbv: Prepare MBV for CI

2025-08-01 Thread Michal Simek
On 7/22/25 13:03, Michal Simek wrote: Hi, this patch series is fixing issues reported by dt-schema and all 4 combinations are tested on Qemu to be able to wire them in CI. U-Boot hooks changes are sent here https://lore.kernel.org/r/82725079ee90362468fe8096db24ef2959725af9.1753181505

Re: [PATCH] xilinx: Make XILINX_OF_BOARD_DTB_ADDR depending on OF_BOARD only

2025-08-01 Thread Michal Simek
On 7/22/25 10:15, Michal Simek wrote: board_fdt_blob_setup() is guarded by OF_BOARD already that's why make no sense to depend also on OF_SEPARATE. Signed-off-by: Michal Simek --- board/xilinx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/x

Re: [PATCH] CI: Wire mbv32 combinations

2025-07-31 Thread Michal Simek
On 7/30/25 19:23, Tom Rini wrote: On Wed, Jul 30, 2025 at 01:25:09PM +0200, Michal Simek wrote: After upgrading to QEMU 10 by commit 1d782a3f229c ("Docker, CI: Update to latest Ubuntu and Dockerfile") let's wire mbv32 which is the part of QEMU to have it under regression.

[PATCH v2] CI: Wire mbv32 combinations

2025-07-31 Thread Michal Simek
After upgrading to QEMU 10 by commit 1d782a3f229c ("Docker, CI: Update to latest Ubuntu and Dockerfile") let's wire mbv32 which is the part of QEMU to have it under regression. Signed-off-by: Michal Simek --- Changes in v2: - Add missing backslash to azure pipeline gitlab I hav

[PATCH] arm64: versal2: Define BOOTENV_DEV_SHARED_XSPI when distro is disabled

2025-07-30 Thread Michal Simek
When DISTRO_DEFAULT is disabled there is missing empty BOOTENV_DEV_SHARED_XSPI macro defined. Signed-off-by: Michal Simek --- include/configs/amd_versal2.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/configs/amd_versal2.h b/include/configs/amd_versal2.h index 1ade6adfa0bc

[PATCH] CI: Wire mbv32 combinations

2025-07-30 Thread Michal Simek
After upgrading to QEMU 10 by commit 1d782a3f229c ("Docker, CI: Update to latest Ubuntu and Dockerfile") let's wire mbv32 which is the part of QEMU to have it under regression. Signed-off-by: Michal Simek --- gitlab I have tested. azure I didn't test it but did blindly all

[PATCH] arm64: zynqmp: Add missing ethernet alias for kr260-revB

2025-07-29 Thread Michal Simek
Ethernet aliases are used in fdt_fixup_ethernet() to inject local-mac-address in every boot for OS. Similar change has been done for other carrier cards by commit c4a711253613 ("arm64: zynqmp: Describe ethernet controllers via aliases on SOM"). Signed-off-by: Michal Simek --- ar

[PATCH] cmd: bdinfo: Fix showing correct IP address based on current device

2025-07-29 Thread Michal Simek
Use the same logic as is used for MAC address where bdi shows mac address for current device where index (idx) is used to point to correct IP address which is read and show. Signed-off-by: Michal Simek --- cmd/bdinfo.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a

Re: [u-boot-test-hooks PATCH] travis-ci: Wire MB-V targets for CI

2025-07-28 Thread Michal Simek
On 7/22/25 22:08, Tom Rini wrote: On Tue, Jul 22, 2025 at 12:51:45PM +0200, Michal Simek wrote: When QEMU v10 upgrade happens MB-V targets should be wired to add them to CI that's why add configuration for it. Signed-off-by: Michal Simek Reviewed-by: Tom Rini Thanks. Can you p

[PATCH v2 3/3] fpga: lattice: Remove unused support

2025-07-28 Thread Michal Simek
There is no single platform which is using this driver that's why remove it completely. Some issues regarding this code are also reported by Coverity (CID 583143, 583144, 583145, 583146). Signed-off-by: Michal Simek --- (no changes since v1) configs/sandbox_defconfig |1 - drivers

[PATCH v2 2/3] fpga: Remove ancient ACEX1K support

2025-07-28 Thread Michal Simek
Coverity (CID 583149) reports issue on code which is not enabled by any real platform that's why remove it completely. Signed-off-by: Michal Simek --- Changes in v2: - Get EP2/EP3/EP4 sizes back even they are not used by any code today configs/sandbox_defconfig | 1 - drivers/fpga/ACE

[PATCH v2 1/3] fpga: xilinx: Check valid desc structure

2025-07-28 Thread Michal Simek
FPGA validation can fail and return value needs to be checked. Addresses-Coverity-ID: CID 583150: Null pointer dereferences (NULL_RETURNS) Signed-off-by: Michal Simek --- (no changes since v1) drivers/fpga/xilinx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/fpga/xilinx.c

[PATCH v2 0/3] fpga: Remove lattice and ACEX1 support

2025-07-28 Thread Michal Simek
trick: Is this board still maintained? Thanks, Michal Changes in v2: - Get EP2/EP3/EP4 sizes back even they are not used by any code today Michal Simek (3): fpga: xilinx: Check valid desc structure fpga: Remove ancient ACEX1K support fpga: lattice: Remove unused support co

Re: Fwd: New Defects reported by Coverity Scan for Das U-Boot

2025-07-25 Thread Michal Simek
Hi Tom, On 7/25/25 15:26, Tom Rini wrote: Here's the latest report. These aren't new issues as much as they are Coverity now looking at FPGA code issues. I have sent https://lore.kernel.org/all/cover.1753442748.git.michal.si...@amd.com/ to address some of them. Thanks, Michal

Re: [PATCH] exception: Add missing string.h

2025-07-25 Thread Michal Simek
On 7/25/25 14:46, Heinrich Schuchardt wrote: On 25.07.25 14:41, Michal Simek wrote: The commit 1e50f7457fca ("include/command.h: Drop ") removed env.h which also included string.h which generate compilation error. But because none is enabling CMD_EXCEPTION it by default it hasn&#

[PATCH] exception: Add missing string.h

2025-07-25 Thread Michal Simek
The commit 1e50f7457fca ("include/command.h: Drop ") removed env.h which also included string.h which generate compilation error. But because none is enabling CMD_EXCEPTION it by default it hasn't been spot. Signed-off-by: Michal Simek --- CC drivers/mtd/mtd-uclass.o I

Re: [PATCH 2/3] fpga: Remove ancient ACEX1K support

2025-07-25 Thread Michal Simek
On 7/25/25 14:10, Alexander Dahl wrote: Hello Michal, Am Fri, Jul 25, 2025 at 01:25:53PM +0200 schrieb Michal Simek: Coverity (CID 583149) reports issue on code which is not enabled by any real platform that's why remove it completely. Signed-off-by: Michal Simek --- co

Re: [PATCH 0/3] fpga: Remove lattice and ACEX1 support

2025-07-25 Thread Michal Simek
On 7/25/25 14:00, Alexander Dahl wrote: Hello Michal, Am Fri, Jul 25, 2025 at 01:25:51PM +0200 schrieb Michal Simek: Hi, when fpga drivers were enabled via sandbox some coverity issues came and make no sense to fix them when there is no user of these drivers that's why it is easier

[PATCH 2/3] mailbox: zynqmp-ipi: Mark zynqmp_ipi_dest_mbox_ops as const

2025-07-25 Thread Michal Simek
Operations are not changing that's why mark them as const which ensure that structure will be moved from .data section to .rodata section. Also mark them as static because they are not used out of this file. Signed-off-by: Michal Simek --- drivers/mailbox/zynqmp-ipi.c | 2 +- 1 file chang

[PATCH 3/3] dm: core: Mark root_info as const

2025-07-25 Thread Michal Simek
root_info driver structure is not changing that's why mark them as const which ensure that structure will be moved from .data section to .rodata section. Signed-off-by: Michal Simek --- drivers/core/root.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/core/r

[PATCH 1/3] clk: zynqmp: Mark zynqmp_clk_ops as const

2025-07-25 Thread Michal Simek
Operations are not changing that's why mark them as const which ensure that structure will be moved from .data section to .rodata section. Signed-off-by: Michal Simek --- drivers/clk/clk_zynqmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk_zynqm

[PATCH 2/3] fpga: Remove ancient ACEX1K support

2025-07-25 Thread Michal Simek
Coverity (CID 583149) reports issue on code which is not enabled by any real platform that's why remove it completely. Signed-off-by: Michal Simek --- configs/sandbox_defconfig | 1 - drivers/fpga/ACEX1K.c | 245 -- drivers/fpga/Kconfig

[PATCH 3/3] fpga: lattice: Remove unused support

2025-07-25 Thread Michal Simek
There is no single platform which is using this driver that's why remove it completely. Some issues regarding this code are also reported by Coverity (CID 583143, 583144, 583145, 583146). Signed-off-by: Michal Simek --- configs/sandbox_defconfig |1 - drivers/fpga/Kconfig |

[PATCH 1/3] fpga: xilinx: Check valid desc structure

2025-07-25 Thread Michal Simek
FPGA validation can fail and return value needs to be checked. Addresses-Coverity-ID: CID 583150: Null pointer dereferences (NULL_RETURNS) Signed-off-by: Michal Simek --- drivers/fpga/xilinx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/fpga/xilinx.c b/drivers/fpga/xilinx.c

[PATCH 0/3] fpga: Remove lattice and ACEX1 support

2025-07-25 Thread Michal Simek
trick: Is this board still maintained? Thanks, Michal Michal Simek (3): fpga: xilinx: Check valid desc structure fpga: Remove ancient ACEX1K support fpga: lattice: Remove unused support configs/sandbox_defconfig |2 - drivers/fpga/ACEX1K.c | 245 --- drivers/fpga/Kconfig |

[GIT PULL] AMD/Xilinx/FPGA changes for 2025-10-rc1-v

2025-07-24 Thread Michal Simek
mode Michal Simek (3): xilinx: zynqmp: Remove PSCI_RESET from mini configurations arm64: zynqmp: Let fit-dtb.blob generated all the time firmware: zynqmp: Simplify power-domain driver bind Pieter Van Trappen (6): cmd: fpga: improve user feedback in case of bits

Re: [PATCH] firmware: zynqmp: Simplify power-domain driver bind

2025-07-24 Thread Michal Simek
On 7/18/25 10:12, Michal Simek wrote: CONFIG_IS_ENABLED macro is covering CONFIG_POWER_DOMAIN or CONFIG_SPL_POWER_DOMAIN Kconfig symbols based on build target which simplify logic around binding power domain driver. Signed-off-by: Michal Simek --- drivers/firmware/firmware-zynqmp.c | 7

Re: [PATCH] arm64: zynqmp: Let fit-dtb.blob generated all the time

2025-07-24 Thread Michal Simek
On 7/18/25 09:04, Michal Simek wrote: There is a value to generate fit-dtb.blob even for cases without SPL because flows with FSBL also require it. Signed-off-by: Michal Simek --- arch/arm/dts/zynqmp-binman-som.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch

Re: [PATCH] Revert "spi: cadence_qspi: Fix odd byte write issue in STIG mode"

2025-07-24 Thread Michal Simek
On 7/16/25 09:04, Prasanth Babu Mantena wrote: The buffer that is being used to write into the flash needs to be handled properly with padding of 0xFF. The place that this is done can be at a more generic place like spi-nor core. This reverts commit cd9123507003e07b13e61d72e14e493bb338e827.

[PATCH 2/2] serial: uartlite: Add support for OF_PLATDATA

2025-07-23 Thread Michal Simek
The first change is to list DM_DRIVER_ALIAS for compatible string to be able to match the driver. Only xps one is listed because opb one is likely unused for quite a long time. The second change is to add dtplat structure to plat data and fill register base in probe. Signed-off-by: Michal Simek

[PATCH 1/2] serial: uartlite: Use private data instead of platform

2025-07-23 Thread Michal Simek
plat data should be used only in probe or of_to_plat to fill it information from DT. Then in probe platform data should be stored in private structure which should be used by the other driver functions. Signed-off-by: Michal Simek --- drivers/serial/serial_xuartlite.c | 20

[PATCH 4/4] xilinx: mbv: Use separate DTB for binman nodes

2025-07-22 Thread Michal Simek
Signed-off-by: Michal Simek --- arch/riscv/dts/Makefile | 1 + arch/riscv/dts/xilinx-binman.dts | 12 arch/riscv/dts/xilinx-mbv32.dts | 2 -- arch/riscv/dts/xilinx-mbv64.dts | 2 -- configs/xilinx_mbv32_defconfig | 1 + configs/xilinx_mbv32_smode

[PATCH 3/4] xilinx: mbv: Fix dt properties in interrupt controller node

2025-07-22 Thread Michal Simek
Properties didn't match dt binding that's why should be fixed. Signed-off-by: Michal Simek --- Binding has been sent here: https://lore.kernel.org/r/6ddaf6f1e3748cdeda2e2e32ee69343a06c60dcb.1753166980.git.michal.si...@amd.com but it is used for more then 15 years unchanged. --- arch

[PATCH 2/4] xilinx: mbv: Add missing mmu-type cpu property

2025-07-22 Thread Michal Simek
OpenSBI expects mmu-type to be present in DT that's why add it. Without it OpenSBI disable CPU node which ends up in not working boot. Signed-off-by: Michal Simek --- arch/riscv/dts/xilinx-mbv32.dts | 3 ++- arch/riscv/dts/xilinx-mbv64.dts | 3 ++- 2 files changed, 4 insertions(+), 2 dele

[PATCH 1/4] xilinx: mbv: Disable OF_HAS_PRIOR_STAGE

2025-07-22 Thread Michal Simek
There is no reason to use OF_BOARD for MBV because reduced DT is used by SPL and full DT is passed via u-boot.img or u-boot.itb. There is no reason to pick up DTB from certain address. Signed-off-by: Michal Simek --- board/xilinx/mbv/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a

[PATCH 0/4] xilinx: mbv: Prepare MBV for CI

2025-07-22 Thread Michal Simek
Hi, this patch series is fixing issues reported by dt-schema and all 4 combinations are tested on Qemu to be able to wire them in CI. U-Boot hooks changes are sent here https://lore.kernel.org/r/82725079ee90362468fe8096db24ef2959725af9.1753181505.git.michal.si...@amd.com Thanks, Michal Michal

[u-boot-test-hooks PATCH] travis-ci: Wire MB-V targets for CI

2025-07-22 Thread Michal Simek
When QEMU v10 upgrade happens MB-V targets should be wired to add them to CI that's why add configuration for it. Signed-off-by: Michal Simek --- bin/travis-ci/conf.xilinx_mbv32_qemu | 40 ++ bin/travis-ci/conf.xilinx_mbv32_smode_qemu | 1 + bin/trav

[PATCH] xilinx: Make XILINX_OF_BOARD_DTB_ADDR depending on OF_BOARD only

2025-07-22 Thread Michal Simek
board_fdt_blob_setup() is guarded by OF_BOARD already that's why make no sense to depend also on OF_SEPARATE. Signed-off-by: Michal Simek --- board/xilinx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/xilinx/Kconfig b/board/xilinx/Kconfig index f7152d6

Re: [PATCH v3 17/24] fwu_arm_psa: Add ESRT support

2025-07-21 Thread Michal Simek
: Simon Glass Cc: Michal Simek Cc: Marek Vasut Cc: Casey Connolly --- Changelog of changes: === v2: * As suggested by Michal: Add /** for marking kernel-doc format v1: * Read ESRT data from Secure world in GetImageInfo() include/fwu_arm_psa.h | 13 lib

[PATCH] firmware: zynqmp: Simplify power-domain driver bind

2025-07-18 Thread Michal Simek
CONFIG_IS_ENABLED macro is covering CONFIG_POWER_DOMAIN or CONFIG_SPL_POWER_DOMAIN Kconfig symbols based on build target which simplify logic around binding power domain driver. Signed-off-by: Michal Simek --- drivers/firmware/firmware-zynqmp.c | 7 ++- 1 file changed, 2 insertions(+), 5

Re: [PATCH] net: xilinx: Fix kernel-doc for axi_mrmac function parameters

2025-07-18 Thread Michal Simek
On 7/17/25 06:48, Venkatesh Yadav Abbarapu wrote: The kernel-doc comment for the axi_mrmac_recv function was missing the colon (':') after the '@packetp' parameter tag. The kernel-doc comment for the axi_mrmac_free_pkt function was missing the colon (':') after the 'length' parameter tag. Th

Re: [PATCH] gpio: zynq: Fix the documentation warning in zynq_gpio_get_bank_pin

2025-07-18 Thread Michal Simek
On 7/17/25 06:46, Venkatesh Yadav Abbarapu wrote: The 'dev' parameter in the zynq_gpio_get_bank_pin function was not described in its kernel-doc comment block, leading to a Sparse warning. drivers/gpio/zynq_gpio.c:194: warning: Function parameter or member 'dev' not described in 'zynq_gpio_ge

[PATCH] arm64: zynqmp: Let fit-dtb.blob generated all the time

2025-07-18 Thread Michal Simek
There is a value to generate fit-dtb.blob even for cases without SPL because flows with FSBL also require it. Signed-off-by: Michal Simek --- arch/arm/dts/zynqmp-binman-som.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/zynqmp-binman-som.dts b/arch/arm

[PATCH] sysreset: psci: Fix SPL dependency

2025-07-17 Thread Michal Simek
SYSRESET_PSCI should select SPL_ARM_PSCI_FW only when SPL_SYSRESET is enabled/required. This change saves 1.6kB on Xilinx ZynqMP Kria platform. Signed-off-by: Michal Simek --- drivers/sysreset/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/sysreset/Kconfig

[PATCH] riscv: cpu: Use CONFIG_IS_ENABLED(CPU) instead of plain ifdef

2025-07-16 Thread Michal Simek
ifdef CONFIG_CPU only works in U-Boot proper but macro is not working when XPL phases are used. In this case CONFIG_SPL_CPU is also defined and can be disabled which is causing compilation error. Signed-off-by: Michal Simek --- arch/riscv/cpu/cpu.c | 14 +++--- 1 file changed, 7

Re: [PATCH 0/3] Update riscv's SYS_BOOTM_LEN to the most commonly used value.

2025-07-15 Thread Michal Simek
onfig | 1 + configs/xilinx_mbv64_smode_defconfig| 1 + 34 files changed, 9 insertions(+), 26 deletions(-) I don't mind with these changes. It is just value which can be changed. Acked-by; Michal Simek # xilinx_mbv Thanks Michal

Re: [PATCH v2] spi: cadence_qspi: Fix odd byte write issue in STIG mode

2025-07-15 Thread Michal Simek
this be handled at the spi-nor core level. 2> You are just increasing the number of bytes here, aren't we writing an unwanted extra data ? Where did we pad the buffer ? NACK. Considering the issues that this can cause, referring the above comments. Michal Simek, my request is to

Re: [PATCH v2 01/25] arm_ffa: Remove NULL pointer check for ops

2025-07-14 Thread Michal Simek
or its affiliates > > + * Copyright 2022-2023, 2025 Arm Limited and/or its affiliates > > * > * Authors: > * Abdellatif El Khlifi > -- > 2.25.1 > That commit message is not matching what you do here. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP

Re: [PATCH 1/3] riscv: Set SYS_BOOTM_LEN explicitly to 0x800000

2025-07-13 Thread Michal Simek
On 7/12/25 10:27, Martin Herren wrote: For all riscv defconfigs that use the current default value. This is done in provision of changing the default value to the most common used value of 0x400. Signed-off-by: Martin Herren --- configs/k230_canmv_defconfig| 1 + configs

Re: [PATCH v2] kbuild: Avoid including architecture-specific Makefile twice

2025-07-13 Thread Michal Simek
autoconf_is_old. ifeq ($(dot-config),1) ifeq ($(may-sync-config),1) Since Fabio confirmed this fixes his issue, I'd like one or two more tested-by's if I can before the end of the day when I'll apply this. Thanks! Tested-by: Michal Simek Thanks, Michal

Re: [PATCH v2 2/2] kbuild: Bump the build system to 5.1

2025-07-10 Thread Michal Simek
On 7/10/25 17:01, Tom Rini wrote: On Thu, Jul 10, 2025 at 04:58:00PM +0200, Michal Simek wrote: Hi, On 7/10/25 16:34, Fabio Estevam wrote: Hi Ilias, On Thu, Jul 10, 2025 at 11:28 AM Ilias Apalodimas wrote: Thanks I'll try to reproduce it later today and let you know. Do you know

Re: [PATCH v2 2/2] kbuild: Bump the build system to 5.1

2025-07-10 Thread Michal Simek
Hi, On 7/10/25 16:34, Fabio Estevam wrote: Hi Ilias, On Thu, Jul 10, 2025 at 11:28 AM Ilias Apalodimas wrote: Thanks I'll try to reproduce it later today and let you know. Do you know if we build this defonconfig in the CI? Yes, mx6sabresd_defconfig is built in CI, but no CI error was seen

Re: [PATCH v5 0/6] Improve user feedback in case of FPGA bitstream load failure

2025-07-09 Thread Michal Simek
On 7/8/25 17:24, vtpie...@gmail.com wrote: From: Pieter Van Trappen The main motivation for this patch series is to make the `fpga *` commands' return message more explicit because simply returning the command usage without indicating the root cause is not helpful. In addition, the sandbox_

[GIT PULL] AMD/Xilinx changes for 2025-10-rc1

2025-07-08 Thread Michal Simek
updates - Enable rng-seed generation versal: - Fix clock dependency versal2: - defconfig updates - Enable sysreset Michal Simek (6): clk: versal: Fix clock driver dependency firmware: xilinx: Prepare code for new SMC

Re: [PATCH] spi: cadence_qspi: Set tshsl_ns to at least one sclk_ns

2025-07-08 Thread Michal Simek
On 7/2/25 08:57, Venkatesh Yadav Abbarapu wrote: tshsl_ns is the clock delay for chip select deassert. This is the delay in master reference clocks for the length that the master mode chip select outputs are de-asserted between transactions. The minimum delay is always SCLK period to ensure t

Re: [PATCH v2] spi: cadence_qspi: Fix odd byte write issue in STIG mode

2025-07-08 Thread Michal Simek
On 7/4/25 06:04, Venkatesh Yadav Abbarapu wrote: Starting from 'commit <8077d296adff> ("spi: cadence-quadspi: Use STIG mode for all ops with small payload") the utilization of STIG mode has been implemented for read and write operations involving less than 8 bytes of data. However, following

Re: [PATCH] cadence_qspi: fix odd byte read issue in STIG mode

2025-07-08 Thread Michal Simek
On 7/2/25 07:39, Venkatesh Yadav Abbarapu wrote: In DDR mode, even bytes are read using DMA, while the remaining odd bytes are read using STIG mode. However, the data is not correctly transferred into the flash read data lower register because the supplementary byte of the STIG opcode is not b

Re: [PATCH v2] arm64: versal2: Remove the ZynqMP Firmware from mini ospi

2025-07-08 Thread Michal Simek
On 7/7/25 11:21, Venkatesh Yadav Abbarapu wrote: Remove the config ZYNQMP_FIRMWARE and also update the initial stack address. Signed-off-by: Venkatesh Yadav Abbarapu --- Changes in v2: - Remove the config FIRMWARE as well. --- configs/amd_versal2_mini_ospi_defconfig | 3 ++- 1 file change

Re: [PATCH] config: amd: Enable the SPI_STACKED_PARALLEL config option

2025-07-08 Thread Michal Simek
On 7/7/25 06:30, Venkatesh Yadav Abbarapu wrote: Enable the SPI_STACKED_PARALLEL config option for AMD versal2 platform, as this is required for parallel and stacked memories. Signed-off-by: Venkatesh Yadav Abbarapu --- configs/amd_versal2_virt_defconfig | 1 + 1 file changed, 1 insertion

Re: [PATCH] xilinx: zynqmp: disable CONFIG_SPI_FLASH_BAR

2025-07-08 Thread Michal Simek
On 7/7/25 06:37, Venkatesh Yadav Abbarapu wrote: Legacy SPI flash devices used a 24-bit (3-byte) addressing scheme, limiting the addressable memory to 16 MB. To support larger densities (256 Mbit and higher), extended addressing schemes, such as 32-bit (4-byte) addressing, were introduced. If

Re: [PATCH 0/2] versal2: Enable reset and poweroff

2025-07-08 Thread Michal Simek
On 7/7/25 06:06, Venkatesh Yadav Abbarapu wrote: Enable reset and poweroff via sysreset framework. Venkatesh Yadav Abbarapu (2): arm64: versal2: Enable reset and poweroff via sysreset framework arm64: versal2: Do not define do_reset() if sysreset is enabled board/amd/versal2/board.c

Re: [PATCH v2 1/2] cmd: Introduce CMD_HELP

2025-07-08 Thread Michal Simek
On 7/2/25 12:17, Mattijs Korpershoek wrote: Hi Michal, Thank you for the patch. On Mon, Jun 30, 2025 at 14:21, Michal Simek wrote: Add option to disable help command in size constrained systems to save some space. There is also no need to have ifdefs around CMDLINE because all commands

Re: [PATCH] config: versal2: Update timer clock to 100Mhz

2025-07-08 Thread Michal Simek
On 7/4/25 11:09, Venkatesh Yadav Abbarapu wrote: U-Boot timer clock is not updated when it is migrated from emulator to silicon. Update CONFIG_COUNTER_FREQUENCY to 100Mhz. Signed-off-by: Venkatesh Yadav Abbarapu --- configs/amd_versal2_virt_defconfig | 2 +- 1 file changed, 1 insertion(+)

Re: [PATCH v4 1/5] cmd: fpga: improve user feedback in case of bitstream load failure

2025-07-07 Thread Michal Simek
On 7/5/25 22:57, vtpie...@gmail.com wrote: From: Pieter Van Trappen In cmd/fpga.c, change some `debug` calls to `log_err` for important user feedback and use CMD_RET_FAILURE in favor of CMD_RET_USAGE due to its long output which hides the actual, useful return message. Change the remaining `

Re: [PATCH v4 5/5] configs: enable FPGA commands and drivers at sandbox_defconfig

2025-07-07 Thread Michal Simek
On 7/5/25 22:57, vtpie...@gmail.com wrote: From: Pieter Van Trappen Enable to facilitate compiler checks on most FPGA-related sources. Signed-off-by: Pieter Van Trappen --- configs/sandbox_defconfig | 20 1 file changed, 20 insertions(+) diff --git a/configs/sandbo

Re: [PATCH v4 2/5] drivers: fpga/firmware: add Kconfig dependencies

2025-07-07 Thread Michal Simek
On 7/5/25 22:57, vtpie...@gmail.com wrote: From: Pieter Van Trappen FPGA_SOCFPGA requires ARCH_SOCFPGA cause socfpga.c contains arch/arm/mach-socfpga/* include macros. ZYNQMP_FIRMWARE requires ARCH_ZYNQMP cause firmware-zynqmp.c contains arch/arm/mach-zynqmp/* include macros. Signed-off-by

Re: [PATCH v3] arm64: zynqmp: Enable rng-seed generation

2025-07-07 Thread Michal Simek
On 7/2/25 09:44, Michal Simek wrote: SOM has TPM with RNG in it that's why enable rng-seed generation. Signed-off-by: Michal Simek --- Changes in v3: - Move malloc allocation before rng_read Changes in v2: - Free alloc area in case of error board/xilinx/common/board.c

Re: [PATCH] arm64: versal2: Remove the ZynqMP Firmware from mini ospi

2025-07-07 Thread Michal Simek
On 7/7/25 06:13, Venkatesh Yadav Abbarapu wrote: Remove the config ZYNQMP_FIRMWARE and also update the initial stack address. Signed-off-by: Venkatesh Yadav Abbarapu --- configs/amd_versal2_mini_ospi_defconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configs/

Re: [PATCH v3 1/4] Improve user feedback in case of FPGA bitstream load failure

2025-07-04 Thread Michal Simek
On 7/4/25 14:38, Pieter Van Trappen wrote: On 02/07/2025 10:51, Michal Simek wrote: On 6/26/25 11:35, vtpie...@gmail.com wrote: From: Pieter Van Trappen In cmd/fpga.c, change some `debug` calls to `log_err` for important user feedback and use CMD_RET_FAILURE in favor of CMD_RET_USAGE due

Re: [PATCH 25/25] fwu_arm_psa: Document FWU support for Arm PSA

2025-07-04 Thread Michal Simek
On 7/2/25 17:25, abdellatif.elkhl...@arm.com wrote: From: Abdellatif El Khlifi Add a README Signed-off-by: Abdellatif El Khlifi Signed-off-by: Davidson kumaresan Cc: Heinrich Schuchardt Cc: Sughosh Ganu Cc: Tom Rini Cc: Ilias Apalodimas Cc: Simon Glass Cc: Michal Simek Cc: Marek

Re: [PATCH 17/25] fwu_arm_psa: Add FWU acceptance mechanism

2025-07-04 Thread Michal Simek
images in trial state. Also, add FWU_ARM_PSA_ACCEPT_IMAGES config to allow platforms to switch off image acceptance in ExitBootServices(). Signed-off-by: Abdellatif El Khlifi Cc: Sughosh Ganu Cc: Tom Rini Cc: Ilias Apalodimas Cc: Simon Glass Cc: Michal Simek Cc: Marek Vasut Cc: Casey

Re: [PATCH] drivers: fpga: intel_sdm_mb: Check SIP SMC status in send_bitstream()

2025-07-02 Thread Michal Simek
On 7/1/25 06:43, Naresh Kumar Ravulapalli wrote: While sending bitstream via SIP SMC, busy status received does not correspond to error, instead it means transfer is accepted but SDM doesn't have any more free buffer space. Hence, data transmission is continued when busy status is received. S

Re: [PATCH v3 1/4] Improve user feedback in case of FPGA bitstream load failure

2025-07-02 Thread Michal Simek
On 6/26/25 11:35, vtpie...@gmail.com wrote: From: Pieter Van Trappen In cmd/fpga.c, change some `debug` calls to `log_err` for important user feedback and use CMD_RET_FAILURE in favor of CMD_RET_USAGE due to its long output which hides the actual, useful return message. Change the remaining

[PATCH v3] arm64: zynqmp: Enable rng-seed generation

2025-07-02 Thread Michal Simek
SOM has TPM with RNG in it that's why enable rng-seed generation. Signed-off-by: Michal Simek --- Changes in v3: - Move malloc allocation before rng_read Changes in v2: - Free alloc area in case of error board/xilinx/common/board.c | 33 +++- co

Re: [PATCH v2] arm64: zynqmp: Enable rng-seed generation

2025-07-02 Thread Michal Simek
On 7/2/25 08:38, Ilias Apalodimas wrote: Hi Michal On Wed, 2 Jul 2025 at 09:34, Michal Simek wrote: SOM has TPM with RNG in it that's why enable rng-seed generation. Signed-off-by: Michal Simek --- Changes in v2: - Free alloc area in case of error board/xilinx/common/bo

Re: [PATCH] mmc: zynq_sdhci: Add emmc hardware reset

2025-07-02 Thread Michal Simek
On 7/1/25 06:09, Venkatesh Yadav Abbarapu wrote: Add support for emmc hardware reset for the emmc card, trigger this hardware reset at the end of arasan_sdhci_probe() function. Signed-off-by: Venkatesh Yadav Abbarapu --- drivers/mmc/zynq_sdhci.c | 25 - 1 file chan

Re: [PATCH] xilinx: Remove simple-bus description from mini configurations

2025-07-02 Thread Michal Simek
On 6/27/25 11:20, Michal Simek wrote: simple bus node and drivers not bringing up any value for mini configuration that's why remove it and disable drivers for it to save some space. Signed-off-by: Michal Simek --- arch/arm/dts/versal-mini-emmc0.dts| 36 +---

Re: [PATCH] xilinx: zynqmp: Remove PSCI_RESET from mini configurations

2025-07-02 Thread Michal Simek
On 6/27/25 11:02, Michal Simek wrote: There is no reason to call reset in these size constrained configurations that's why remove it to get some space. Signed-off-by: Michal Simek --- configs/xilinx_zynqmp_mini_defconfig | 1 + configs/xilinx_zynqmp_mini_emmc0_defc

Re: [PATCH v2] mmc: zynq_sdhci: Reset the host controller

2025-07-02 Thread Michal Simek
On 6/26/25 08:24, Venkatesh Yadav Abbarapu wrote: Reset the host controller at the early stage of probe so that the configuration will be done properly for reboot cases. Signed-off-by: Venkatesh Yadav Abbarapu --- Changes in v2: - Reset is optional, so don't return if reset property is not f

Re: [PATCH] firmware: xilinx: Prepare code for new SMC firmware format

2025-07-01 Thread Michal Simek
On 6/25/25 15:29, Michal Simek wrote: Separate code to own function to be able to add new enhancement format. Signed-off-by: Michal Simek --- drivers/firmware/firmware-zynqmp.c | 60 +- include/zynqmp_firmware.h | 9 + 2 files changed, 44

[PATCH v2] arm64: zynqmp: Enable rng-seed generation

2025-07-01 Thread Michal Simek
SOM has TPM with RNG in it that's why enable rng-seed generation. Signed-off-by: Michal Simek --- Changes in v2: - Free alloc area in case of error board/xilinx/common/board.c | 34 +++- configs/xilinx_zynqmp_kria_defconfig | 1 + 2 files change

Re: [PATCH] firmware: xilinx: Tighten dependencies for ZYNQMP_FIRMWARE

2025-07-01 Thread Michal Simek
On 7/2/25 03:04, Tom Rini wrote: The ZYNQMP_FIRMWARE code cannot build without platform specific headers being available. Express that requirement in Kconfig as well. Signed-off-by: Tom Rini --- Cc: Michal Simek --- drivers/firmware/Kconfig | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH v2 0/5] Create FPGA Partial Reconfiguration (fpga pr) command

2025-07-01 Thread Michal Simek
On 5/24/25 22:37, Naresh Kumar Ravulapalli wrote: Partial Reconfiguration (pr) FPGA command is added to U-Boot console. The "fpga pr" command supports multiple regions for partial reconfiguration by specifying the region number. The implementation of the command is specific to the underlying F

[PATCH v2 1/2] cmd: Introduce CMD_HELP

2025-06-30 Thread Michal Simek
Add option to disable help command in size constrained systems to save some space. There is also no need to have ifdefs around CMDLINE because all commands bepends on it. And also mark cmd_help dependency in test_help.py. Signed-off-by: Michal Simek Reviewed-by: Peter Robinson --- Changes in

[PATCH v2 2/2] xilinx: Disable help command for all mini configurations

2025-06-30 Thread Michal Simek
There is no reason to have help command available because none is calling it and only make binary bigger that's why disable it. Signed-off-by: Michal Simek --- (no changes since v1) configs/amd_versal2_mini_defconfig | 1 + configs/amd_versal2_mini_emmc_defconfig

Re: [PATCH] xilinx: zynqmp: Enable xilinx ethernet phy

2025-06-27 Thread Michal Simek
On 6/24/25 10:46, Padmarao Begari wrote: Enable xilinx ethernet phy on ZynqMP by default. Signed-off-by: Padmarao Begari --- configs/xilinx_zynqmp_virt_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/xilinx_zynqmp_virt_defconfig b/configs/xilinx_zynqmp_virt_defconfi

Re: [PATCH] clk: zynqmp: Add support for dpll clock source

2025-06-27 Thread Michal Simek
On 6/18/25 11:43, Padmarao Begari wrote: The clock driver fails to correctly calculate the PLL clock rate for peripherals when using the DPLL as the clock source. The DPLL operates within the full power domain, while peripheral clocks reside in the low power domain. To ensure accurate PLL cloc

[PATCH] xilinx: Remove simple-bus description from mini configurations

2025-06-27 Thread Michal Simek
simple bus node and drivers not bringing up any value for mini configuration that's why remove it and disable drivers for it to save some space. Signed-off-by: Michal Simek --- arch/arm/dts/versal-mini-emmc0.dts| 36 +--- arch/arm/dts/versal-mini-emmc1.dts

[PATCH] xilinx: zynqmp: Remove PSCI_RESET from mini configurations

2025-06-27 Thread Michal Simek
There is no reason to call reset in these size constrained configurations that's why remove it to get some space. Signed-off-by: Michal Simek --- configs/xilinx_zynqmp_mini_defconfig | 1 + configs/xilinx_zynqmp_mini_emmc0_defconfig | 1 + co

[PATCH 2/2] xilinx: Disable help command for all mini configurations

2025-06-27 Thread Michal Simek
There is no reason to have help command available because none is calling it and only make binary bigger that's why disable it. Signed-off-by: Michal Simek --- configs/amd_versal2_mini_defconfig | 1 + configs/amd_versal2_mini_emmc_defconfig | 1 + co

[PATCH 1/2] cmd: Introduce CMD_HELP

2025-06-27 Thread Michal Simek
Add option to disable help command in size constrained systems to save some space. Signed-off-by: Michal Simek --- cmd/Kconfig | 6 ++ cmd/Makefile | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/cmd/Kconfig b/cmd/Kconfig index f21d27cb27f2..3f4221cb4d02 100644 --- a

[PATCH] firmware: xilinx: Prepare code for new SMC firmware format

2025-06-25 Thread Michal Simek
Separate code to own function to be able to add new enhancement format. Signed-off-by: Michal Simek --- drivers/firmware/firmware-zynqmp.c | 60 +- include/zynqmp_firmware.h | 9 + 2 files changed, 44 insertions(+), 25 deletions(-) diff --git a

Re: [BUG] [PATCH v5 1/3] common/spl: fix potential out of buffer access in spl_fit_get_image_name function

2025-06-25 Thread Michal Simek
boot from MMC2 > spl_fit_get_image_name(): index = 0, name = 'opensbi' len = 8 > spl_fit_get_image_name(): outname = 'opensbi' > spl_fit_get_image_name(): index = 0, name = 'uboot' len = 6 > spl_fit_get_image_name(): outname = 'uboot' >

Re: [PATCH] mmc: zynq_sdhci: Reset the host controller

2025-06-25 Thread Michal Simek
On 6/25/25 07:26, Venkatesh Yadav Abbarapu wrote: Reset the host controller at the early stage of probe so that the configuration will be done properly for reboot cases. Signed-off-by: Venkatesh Yadav Abbarapu --- drivers/mmc/zynq_sdhci.c | 21 + 1 file changed, 21 ins

[PATCH] arm64: zynqmp: Enable rng-seed generation

2025-06-24 Thread Michal Simek
SOM has TPM with RNG in it that's why enable rng-seed generation. Signed-off-by: Michal Simek --- board/xilinx/common/board.c | 32 +++- configs/xilinx_zynqmp_kria_defconfig | 1 + 2 files changed, 32 insertions(+), 1 deletion(-) diff --git a/board/x

Re: [PATCH v2] i2c: mux: Fix the crash when the i2c-arbitrator node is present

2025-06-23 Thread Michal Simek
On 6/24/25 05:43, Heiko Schocher wrote: Hello Venkatesh Yadav Abbarapu, On 23.06.25 10:06, Venkatesh Yadav Abbarapu wrote: Observing the crash when we add the i2c-arbitrator node in the device tree as per the DT bindings. The issue is with the child node of i2c-arbitrator@72 i.e., i2c@f19500

Re: [PATCH 6/6] fdtdec: apply DT overlays from bloblist

2025-06-23 Thread Michal Simek
Hi Raymond, Isn't it also worth to check if existing CONTROL_FDT has enough space inside that new overlay can fit there before resizing it? By default each entry only contains the actual size since bloblist (aka transfer list) is designed as a compact data structure and there should not be a wa

Re: [PATCH 6/6] fdtdec: apply DT overlays from bloblist

2025-06-19 Thread Michal Simek
Hi, On 6/19/25 18:22, Raymond Mao wrote: Hi Michal, On Thu, 19 Jun 2025 at 07:39, Michal Simek wrote: On 6/18/25 16:59, Raymond Mao wrote: During FDT setup, apply all existing DT overlays from the bloblist to the base FDT if bloblist is being used for handoff from previous boot stage

  1   2   3   4   5   6   7   8   9   10   >