Re: [PATCH v3] clk: set initial best mux parent to current parent with CLK_MUX_ROUND_CLOSEST

2024-03-12 Thread Maxime Ripard
On Tue, Mar 12, 2024 at 04:52:29PM +0800, Yang Xiwen wrote: > On 3/11/2024 5:34 PM, Maxime Ripard wrote: > > On Thu, Mar 07, 2024 at 07:18:05PM +0800, Yang Xiwen wrote: > > > On 3/7/2024 4:48 PM, Maxime Ripard wrote: > > > > Hi, > > > > > > > >

Re: [PATCH v4 00/16] Introduce initial TI's J784S4 and AM69 support

2023-11-15 Thread Maxime Ripard
Hi, On Sun, Oct 01, 2023 at 10:25:29PM +0530, Apurva Nandan wrote: > This series will introduce basic support (SD and UART) support for Texas > Instruments J784S4 EVM. > > The J784S4 SoC device tree patches are taken from kernel patch submissions > and will be updated as they are accepted and mer

Re: eMMC broken on SK-AM62

2023-11-09 Thread Maxime Ripard
Hi Nishanth, On Thu, Nov 09, 2023 at 06:23:03AM -0600, Nishanth Menon wrote: > On 11:29-20231109, Mattijs Korpershoek wrote: > > Hi Maxime, Nishanth, > > > > On mer., nov. 08, 2023 at 16:05, Maxime Ripard wrote: > > > > > Hi Nishanth, > > > > &

eMMC broken on SK-AM62

2023-11-08 Thread Maxime Ripard
Hi Nishanth, I've been trying for the last few days to get an SK-AM62 to boot from the eMMC user data area. I finally got the jumper configuration to make the CPU boot from there thanks to Mattijs, but it looks like the 2024.01-rc2 release doesn't support booting from there: U-Boot SPL 2024.01-r

Re: [PATCH V3 3/3] arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1

2023-07-28 Thread Maxime Ripard
ecure proxies are defined in SoC dtsi > - Drop duplicate nodes - u-boot.dtsi is includes in r5-sk, no need for > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH V3 0/3] arm: dts: Sync k3-am62 with upstream kernel

2023-07-28 Thread Maxime Ripard
On Thu, 27 Jul 2023 04:03:28 -0500, Nishanth Menon wrote: > Hopefully, third time is a charm.. ;) > > I have picked up part of Sjoerd's series[1] to keep it constrained just > to dts sync at this point rather than adding newer functionality on top. > > > [ ... ]

Re: [PATCH 0/4] net: ti: am65-cpsw-nuss: Fix DT binding handling of pinctrl

2023-07-26 Thread Maxime Ripard
Hi Ravi, On Wed, Jul 26, 2023 at 02:44:00PM +0530, Ravi Gunasekaran wrote: > On 7/20/23 7:42 PM, Maxime Ripard wrote: > > Hi > > > > Sorry, I didn't receive Roger mail so I'll reply here > > > > On Thu, Jul 20, 2023 at 09:00:19AM -0500, Nishanth

Re: [PATCH 3/3] arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1

2023-07-26 Thread Maxime Ripard
On Wed, Jul 26, 2023 at 11:26:05AM +0530, Ravi Gunasekaran wrote: > On 7/25/23 11:47 PM, Tom Rini wrote: > > On Tue, Jul 25, 2023 at 09:09:34AM -0500, Nishanth Menon wrote: > >> On 15:56-20230725, Maxime Ripard wrote: > >>> Hi, > >>> > >>> On

Re: [PATCH 3/3] arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1

2023-07-25 Thread Maxime Ripard
Hi, On Tue, Jul 25, 2023 at 07:58:56AM -0500, Nishanth Menon wrote: > Update the am62 and am625 device-trees from linux v6.3-rc5 This needed the > followin > tweaks to the u-boot specific dtsi as well: > - Switch tick-timer to the main_timer as it's now defined in the main dtsi > - Secure proxies

[PATCH v4 2/2] fixup! arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1

2023-07-24 Thread Maxime Ripard
The MDIO pinctrl nodes can't be duplicated between the child and device, because if we ever boot Linux with our DT it will try to attach that pinctrl configuration to both the MAC and MDIO devices, which will result in failure to probe. Signed-off-by: Maxime Ripard --- arch/arm/dts/k3-am6

[PATCH v4 0/2] net: ti: am65-cpsw-nuss: Fix DT binding handling of pinctrl

2023-07-24 Thread Maxime Ripard
s was solved by duplicating the pinctrl configuration onto the MAC device node. Unfortunately, this doesn't work for Linux since now it has two devices competing for the same pins. Let me know what you think, Maxime Signed-off-by: Maxime Ripard --- Changes in v4: - Squashed fixup patches -

[PATCH v4 1/2] net: ti: am65-cpsw-nuss: Enforce pinctrl state on the MDIO child node

2023-07-24 Thread Maxime Ripard
core to select the right muxing. Signed-off-by: Maxime Ripard --- drivers/net/ti/Kconfig | 1 + drivers/net/ti/am65-cpsw-nuss.c | 60 + 2 files changed, 61 insertions(+) diff --git a/drivers/net/ti/Kconfig b/drivers/net/ti/Kconfig index d9f1c01

[PATCH v3 1/3] net: ti: am65-cpsw-nuss: Enforce pinctrl state on the MDIO child node

2023-07-24 Thread Maxime Ripard
core to select the right muxing. Signed-off-by: Maxime Ripard --- drivers/net/ti/Kconfig | 1 + drivers/net/ti/am65-cpsw-nuss.c | 67 + 2 files changed, 68 insertions(+) diff --git a/drivers/net/ti/Kconfig b/drivers/net/ti/Kconfig index d9f1c01

[PATCH v3 2/3] fixup! arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1

2023-07-24 Thread Maxime Ripard
The MDIO pinctrl nodes can't be duplicated between the child and device, because if we ever boot Linux with our DT it will try to attach that pinctrl configuration to both the MAC and MDIO devices, which will result in failure to probe. Signed-off-by: Maxime Ripard --- arch/arm/dts/k3-am6

[PATCH v3 3/3] fixup! net: ti: am65-cpsw-nuss: Enforce pinctrl state on the MDIO child node

2023-07-24 Thread Maxime Ripard
--- drivers/net/ti/am65-cpsw-nuss.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/net/ti/am65-cpsw-nuss.c b/drivers/net/ti/am65-cpsw-nuss.c index 29a4284a9b70..51a8167d14a9 100644 --- a/drivers/net/ti/am65-cpsw-nuss.c +++ b/drivers/net/ti/am65-cpsw-nuss

[PATCH v3 0/3] net: ti: am65-cpsw-nuss: Fix DT binding handling of pinctrl

2023-07-24 Thread Maxime Ripard
s was solved by duplicating the pinctrl configuration onto the MAC device node. Unfortunately, this doesn't work for Linux since now it has two devices competing for the same pins. Let me know what you think, Maxime Signed-off-by: Maxime Ripard --- Changes in v3: - Rebase on top of latest Ro

Re: [PATCH v3 3/3] fixup! net: ti: am65-cpsw-nuss: Enforce pinctrl state on the MDIO child node

2023-07-24 Thread Maxime Ripard
Hi, On Mon, Jul 24, 2023 at 03:52:54PM +0200, Maxime Ripard wrote: > --- > drivers/net/ti/am65-cpsw-nuss.c | 13 +++-- > 1 file changed, 3 insertions(+), 10 deletions(-) Sorry, it should have been squashed. I'll send a v4 shortly. Maxime signature.asc Description: PGP signature

Re: [PATCH v2 1/3] net: ti: am65-cpsw-nuss: Enforce pinctrl state on the MDIO child node

2023-07-24 Thread Maxime Ripard
On Sat, Jul 22, 2023 at 11:25:50AM +0300, Roger Quadros wrote: > On 21/07/2023 16:07, Maxime Ripard wrote: > > The binding represents the MDIO controller as a child device tree > > node of the MAC device tree node. > > > > The U-Boot driver mostly ignores that chil

Re: [PATCH v2 0/4] net: ti: am65-cpsw-nuss: Drop custom properties

2023-07-24 Thread Maxime Ripard
es are RFC so they can come separately. i.e. squashed with > DT cleanup series from Nishanth. Thanks for cleaning this up, hopefully it will solve our ranges conversation :) Tested-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH v2 3/3] fixup! arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1

2023-07-24 Thread Maxime Ripard
Hi, Thanks for your review On Sat, Jul 22, 2023 at 11:32:37AM +0300, Roger Quadros wrote: > On 21/07/2023 16:07, Maxime Ripard wrote: > > Dropping ranges entirely doesn't work since the register offset on the > > MDIO device node will now be completely off, so we need to

[PATCH v2 3/3] fixup! arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1

2023-07-21 Thread Maxime Ripard
ff-by: Maxime Ripard --- arch/arm/dts/k3-am625-sk-u-boot.dtsi | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm/dts/k3-am625-sk-u-boot.dtsi b/arch/arm/dts/k3-am625-sk-u-boot.dtsi index db814ed02a7e..77c9e4cb87f7 100644 --- a/arch/arm/dts/k3-am625-sk-u-boot.dtsi +++ b/arc

[PATCH v2 2/3] fixup! arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1

2023-07-21 Thread Maxime Ripard
The MDIO pinctrl nodes can't be duplicated between the child and device, because if we ever boot Linux with our DT it will try to attach that pinctrl configuration to both the MAC and MDIO devices, which will result in failure to probe. Signed-off-by: Maxime Ripard --- arch/arm/dts/k3-am6

[PATCH v2 1/3] net: ti: am65-cpsw-nuss: Enforce pinctrl state on the MDIO child node

2023-07-21 Thread Maxime Ripard
core to select the right muxing. Signed-off-by: Maxime Ripard --- drivers/net/ti/Kconfig | 1 + drivers/net/ti/am65-cpsw-nuss.c | 67 + 2 files changed, 68 insertions(+) diff --git a/drivers/net/ti/Kconfig b/drivers/net/ti/Kconfig index e13dbc9

[PATCH v2 0/3] net: ti: am65-cpsw-nuss: Fix DT binding handling of pinctrl

2023-07-21 Thread Maxime Ripard
node. Unfortunately, this doesn't work for Linux since now it has two devices competing for the same pins. Let me know what you think, Maxime Signed-off-by: Maxime Ripard --- Changes in v2: - Drop the pinctrl API change in favour of a dummy driver - Link to v1: https://lore.kernel.org/r/202307

Re: [PATCH 0/2] net: ti: am65-cpsw-nuss: Drop custom property "mac_efuse"

2023-07-21 Thread Maxime Ripard
Hi, On Fri, Jul 21, 2023 at 12:59:33AM +0300, Roger Quadros wrote: > Hi, > > We need to track the Device tree in Linux. > The approved property for MAC address EFUSE is "ti,syscon-efuse". > > Use that and drop custom property "mac_efuse". On a SK-AM62:

Re: [PATCH 2/4] net: ti: am65-cpsw-nuss: Enforce pinctrl state on the MDIO child node

2023-07-21 Thread Maxime Ripard
On Thu, Jul 20, 2023 at 06:47:43PM +0300, Roger Quadros wrote: > On 20/07/2023 12:55, Maxime Ripard wrote: > > The binding represents the MDIO controller as a child device tree > > node of the MAC device tree node. > > > > The U-Boot driver mostly ignores that chil

Re: [PATCH 4/4] fixup! arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1

2023-07-21 Thread Maxime Ripard
On Fri, Jul 21, 2023 at 12:14:35PM +0300, Roger Quadros wrote: > > > On 21/07/2023 10:46, Maxime Ripard wrote: > > On Thu, Jul 20, 2023 at 06:27:56PM +0300, Roger Quadros wrote: > >> > >> > >> On 20/07/2023 12:55, Maxime Ripard wrote: > >&g

Re: [PATCH 4/4] fixup! arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1

2023-07-21 Thread Maxime Ripard
On Thu, Jul 20, 2023 at 06:27:56PM +0300, Roger Quadros wrote: > > > On 20/07/2023 12:55, Maxime Ripard wrote: > > Dropping ranges entirely doesn't work since the register offset on the > > MDIO device node will now be completely off, so we need to adjust it to >

Re: [PATCH 0/4] net: ti: am65-cpsw-nuss: Fix DT binding handling of pinctrl

2023-07-20 Thread Maxime Ripard
Hi Sorry, I didn't receive Roger mail so I'll reply here On Thu, Jul 20, 2023 at 09:00:19AM -0500, Nishanth Menon wrote: > On 16:56-20230720, Roger Quadros wrote: > > Hi, > > > > On 20/07/2023 16:33, Ravi Gunasekaran wrote: > > > > > >

[PATCH 4/4] fixup! arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1

2023-07-20 Thread Maxime Ripard
ff-by: Maxime Ripard --- arch/arm/dts/k3-am625-sk-u-boot.dtsi | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm/dts/k3-am625-sk-u-boot.dtsi b/arch/arm/dts/k3-am625-sk-u-boot.dtsi index fe1c7408a89d..2ec3fff99f32 100644 --- a/arch/arm/dts/k3-am625-sk-u-boot.dtsi +++ b/arc

[PATCH 2/4] net: ti: am65-cpsw-nuss: Enforce pinctrl state on the MDIO child node

2023-07-20 Thread Maxime Ripard
muxing states are thus ignored. This has been a problem with device trees since Linux 6.5-rc1 which will put some pinctrl states on the MDIO device tree node. Let's rework the driver a bit to fetch the pinctrl state from the MDIO node and apply it. Signed-off-by: Maxime Ripard --- drivers/n

[PATCH 3/4] fixup! arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1

2023-07-20 Thread Maxime Ripard
The MDIO pinctrl nodes can't be duplicated between the child and device, because if we ever boot Linux with our DT it will try to attach that pinctrl configuration to both the MAC and MDIO devices, which will result in failure to probe. Signed-off-by: Maxime Ripard --- arch/arm/dts/k3-am6

[PATCH 1/4] pinctrl: Create a select_state variant with the ofnode

2023-07-20 Thread Maxime Ripard
) but supported by a single driver tied to the MAC device in U-Boot. In order to get the proper pinctrl state, we would need to get the state from the MDIO device tree node, but tie it to the MAC device since it's the only thing we have access to. Signed-off-by: Maxime Ripard --- drivers/pi

[PATCH 0/4] net: ti: am65-cpsw-nuss: Fix DT binding handling of pinctrl

2023-07-20 Thread Maxime Ripard
wo devices competing for the same pins. Let me know what you think, Maxime Signed-off-by: Maxime Ripard --- Maxime Ripard (4): pinctrl: Create a select_state variant with the ofnode net: ti: am65-cpsw-nuss: Enforce pinctrl state on the MDIO child node fixup! arm: dts: k3-am62: Bump

Re: [RFC PATCH 4/4] arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1

2023-07-19 Thread Maxime Ripard
On Wed, Jul 19, 2023 at 09:05:55AM -0500, Nishanth Menon wrote: > On 10:27-20230719, Maxime Ripard wrote: > > Hi Nishanth, > > > > On Thu, Jul 13, 2023 at 02:20:19AM -0500, Nishanth Menon wrote: > [...] > > > > - Add mdio pins to the cpsw3g pinctrl in u-boot d

Re: [RFC PATCH 4/4] arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1

2023-07-19 Thread Maxime Ripard
Hi Nishanth, On Thu, Jul 13, 2023 at 02:20:19AM -0500, Nishanth Menon wrote: > Update the am62 and am625 device-trees from linux v6.3-rc5 This needed the > followin > tweaks to the u-boot specific dtsi as well: > - Switch tick-timer to the main_timer as it's now defined in the main dtsi > - Secur

Re: [PATCH v7 00/23] Migration to using binman for bootloader

2023-07-17 Thread Maxime Ripard
On Mon, Jul 17, 2023 at 06:38:22PM +0530, Neha Malcom Francis wrote: > Hi Maxime > > On 17/07/23 18:19, Maxime Ripard wrote: > > Hi, > > > > On Fri, Jul 14, 2023 at 07:20:47PM +0530, Neha Malcom Francis wrote: > > > This series aims to eliminate the u

Re: [PATCH v7 00/23] Migration to using binman for bootloader

2023-07-17 Thread Maxime Ripard
S devices > > Series intends to use binman to take over the packaging and signing for > the R5 bootloader images tiboot3.bin (and sysfw.itb, for non-combined > boot flow) instead of k3-image-gen. > > Series also packages the A72/A53 bootloader images (tispl.bin and > u-boot.img) using

Re: [RFC PATCH 0/4] arm: dts: Sync k3-am62 with upstream

2023-07-17 Thread Maxime Ripard
> to dts sync at this point rather than adding newer functionality on top. > > You can find the full series in [3]. > > Attempting am625 as a start of a series of clean ups for device tree for > u-boot, but will love to get any review comments to improve this series > up. Te

Re: [PATCH] sunxi-nand: fix the PIO instead of DMA implementation

2022-06-30 Thread Maxime Ripard
On Thu, Jun 30, 2022 at 10:04:31AM +0200, Markus Hoffrogge wrote: > Hi Miquel, hi Maxime, > > could you probably run a test on a newer Allwinner SOC - like e.g. > SUNI8, SUNI9, SUNI50 or newer, since I can test it on a SUNI7 (A20) > board only? > > The only aspect that makes me wonder is, that it

Re: [PATCH] sunxi-nand: fix the PIO instead of DMA implementation

2022-06-30 Thread Maxime Ripard
On Thu, Jun 30, 2022 at 09:13:22AM +0200, Miquel Raynal wrote: > Hi Markus, > > + Maxime, for the record :) > > mhoffro...@gmail.com wrote on Thu, 30 Jun 2022 01:26:39 +0200: > > > The sunxi nand SPL loader was broken at least for SUN4I, > > SUN5I and SUN7I SOCs since the implementation change >

Re: using device-tree fragments/overlays

2021-10-14 Thread Maxime Ripard
Hi, On Thu, Oct 14, 2021 at 08:13:55AM -0700, Tim Harvey wrote: > On Wed, Oct 13, 2021 at 1:38 AM Peter Robinson wrote: > > > > Hi Tim, > > > > > I'm working on some features for the imx8mm-venice boards I support > > > which depend on making small changes to the dt before booting Linux. > > > >

Re: [U-Boot] [PATCH v3 13/20] spl: nand: sunxi: use PIO instead of DMA

2021-07-07 Thread Maxime Ripard
Hi, On Tue, Jul 06, 2021 at 06:00:33PM +0200, Miquel Raynal wrote: > Hi Maxime, > > Maxime Ripard wrote on Thu, 24 Jun 2021 14:05:40 > +0200: > > > Hi Miquel, > > > > On Wed, Feb 28, 2018 at 08:51:55PM +0100, Miquel Raynal wrote: > > > SPL support was

Re: [PATCH] cmd: ums: Enable by default for sunxi

2021-07-06 Thread Maxime Ripard
On Tue, Jul 06, 2021 at 04:57:32PM +0100, Andre Przywara wrote: > On Tue, 6 Jul 2021 19:56:24 +0530 > Jagan Teki wrote: > > Hi Jagan, > > thanks for the response! > > > On Tue, Jul 6, 2021 at 4:53 AM Andre Przywara > > wrote: > > > > > > The ums command (presenting a U-Boot block device as a

Re: [PATCH 03/12] Revert "usb: gadget: fastboot: use correct max packet size"

2021-07-03 Thread Maxime Ripard
Hi Peng, On Tue, Jun 29, 2021 at 10:27:27AM +0800, Peng Fan (OSS) wrote: > Maxime > > On 2021/6/25 21:05, Maxime Ripard wrote: > > This reverts commit 27c9141b1114fd5721437abbb1c694e45e765f19. > > --- > > drivers/usb/gadget/f_fastboot.c | 2 +- > > 1 file ch

Re: [PATCH 03/12] Revert "usb: gadget: fastboot: use correct max packet size"

2021-06-25 Thread Maxime Ripard
Hi Sean, On Fri, Jun 25, 2021 at 09:47:11AM -0400, Sean Anderson wrote: > On 6/25/21 9:05 AM, Maxime Ripard wrote: > > This reverts commit 27c9141b1114fd5721437abbb1c694e45e765f19. > > Why does this need to be reverted? As I stated in the cover letter, I don't really know

[PATCH 12/12] configs: chip pro: Fix NAND Controller name

2021-06-25 Thread Maxime Ripard
The controller name in Linux isn't sunxi_nand.0 but 1c03000.nand-controller, preventing us from passing the mtdparts variable directly on the kernel command line. Let's adjust our value to match what Linux expects. Signed-off-by: Maxime Ripard --- configs/CHIP_pro_defconfig | 4 ++

[PATCH 11/12] configs: chip pro: fix the offsets

2021-06-25 Thread Maxime Ripard
The CHIP Pro MTD partition table sets the U-Boot offset at 512kB (0x8), and its backup at 2.5MB (0x28). However, the default value for both of these on sunxi is 8MB (0x80), which doesn't work in our case. Fix this. Signed-off-by: Maxime Ripard --- configs/CHIP_pro_defconfi

[PATCH 09/12] fastboot: nand: Fix return error code

2021-06-25 Thread Maxime Ripard
er we support fastboot slots or not by calling fb_nand_lookup and assuming that anything >= 0 means the partition is there. Signed-off-by: Maxime Ripard --- drivers/fastboot/fb_nand.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/fastboot/fb_nand.c b/drivers/

[PATCH 10/12] configs: chip pro: Disable UMS

2021-06-25 Thread Maxime Ripard
The CHIP Pro doesn't have any block storage device, so enabling UMS makes little sense. Signed-off-by: Maxime Ripard --- configs/CHIP_pro_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/configs/CHIP_pro_defconfig b/configs/CHIP_pro_defconfig index d2eddc7e9ff0..c8e2e2ae2ca3 1

[PATCH 08/12] clk: sunxi: Add missing clock compatible

2021-06-25 Thread Maxime Ripard
The NextThingCo GR8 is a derivative of the sun5i family, and thus should be considered similar to the A10s and A13 as far as clocks go. The compatible was missing from the clock driver so far, leading to all the drivers depending on it being non-functional. Signed-off-by: Maxime Ripard

[PATCH 07/12] configs: chip pro: Disable video output

2021-06-25 Thread Maxime Ripard
't have an HDMI controller to begin with. Signed-off-by: Maxime Ripard --- configs/CHIP_pro_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/CHIP_pro_defconfig b/configs/CHIP_pro_defconfig index 7f10fd2b886e..d2eddc7e9ff0 100644 --- a/configs/CHIP_pro_defconfig +++ b/config

[PATCH 06/12] fastboot: Add missing newlines

2021-06-25 Thread Maxime Ripard
Most of the error messages in the NAND fastboot support are missing a \n at the end, add it where relevant. Signed-off-by: Maxime Ripard --- drivers/fastboot/fb_nand.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/fastboot/fb_nand.c b/drivers/fastboot

[PATCH 05/12] mtd: Allow for a longer mtdparts table

2021-06-25 Thread Maxime Ripard
20 characters is fairly short for a partition table, let's increase it a bit. Signed-off-by: Maxime Ripard --- drivers/mtd/mtd_uboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/mtd_uboot.c b/drivers/mtd/mtd_uboot.c index c53ec657a34d..3b54d0ba6e95 1

[PATCH 04/12] Kconfig: Migrate SPL_PANIC_ON_RAW_IMAGE

2021-06-25 Thread Maxime Ripard
The SPL_PANIC_ON_RAW_IMAGE can be fairly useful to avoid the SPL getting stuck without a message when the image retrieved isn't a valid image. Let's convert it to Kconfig. Signed-off-by: Maxime Ripard --- README | 10 -- common/spl/Kconfig

[PATCH 03/12] Revert "usb: gadget: fastboot: use correct max packet size"

2021-06-25 Thread Maxime Ripard
This reverts commit 27c9141b1114fd5721437abbb1c694e45e765f19. --- drivers/usb/gadget/f_fastboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c index 8ba55aab9f8f..1fcffaf9dd26 100644 --- a/drivers/usb/gadget/f

[PATCH 01/12] Revert "sunxi: spl: remove DMA related settings of the NAND controller"

2021-06-25 Thread Maxime Ripard
This reverts commit 136e32593335e031558a573158b6180fc80b551f. --- board/sunxi/board.c | 5 + 1 file changed, 5 insertions(+) diff --git a/board/sunxi/board.c b/board/sunxi/board.c index 21651a1bfca4..80c222114f9a 100644 --- a/board/sunxi/board.c +++ b/board/sunxi/board.c @@ -395,6 +395,11 @@

[PATCH 02/12] Revert "spl: nand: sunxi: use PIO instead of DMA"

2021-06-25 Thread Maxime Ripard
This reverts commit 6ddbb1e936c78cdef1e7395039fa7020c5c75326. --- drivers/mtd/nand/raw/sunxi_nand_spl.c | 141 -- 1 file changed, 85 insertions(+), 56 deletions(-) diff --git a/drivers/mtd/nand/raw/sunxi_nand_spl.c b/drivers/mtd/nand/raw/sunxi_nand_spl.c index 85d8013b1a6

[PATCH 00/12] Random Fixes for the CHIP Pro

2021-06-25 Thread Maxime Ripard
about the side effects. The following patches fixes a couple of things around the GR8, CHIP Pro, and fastboot support in general. Let me know what you think, Maxime Maxime Ripard (12): Revert "sunxi: spl: remove DMA related settings of the NAND controller" Revert "spl: nand:

Re: [U-Boot] [PATCH v3 13/20] spl: nand: sunxi: use PIO instead of DMA

2021-06-24 Thread Maxime Ripard
Hi Miquel, On Wed, Feb 28, 2018 at 08:51:55PM +0100, Miquel Raynal wrote: > SPL support was first written to support only the earlier generations of > Allwinner SoCs, and was only really enabled on the A13 / GR8. However, > those old SoCs had a DMA engine that has been replaced since the A31 by >

Re: [PATCH V2 16/17] usb: gadget: fastboot: use correct max packet size

2021-06-23 Thread Maxime Ripard
Hi, Adding Andre, Lukasz and Marek in Cc On Mon, Jan 25, 2021 at 09:43:59PM +0800, peng.fan at nxp.com wrote: > From: Li Jun > > Change to use wMaxPacketSize of current speed EP desc for request > length wrap up. > > Reviewed-by: Peter Chen > Signed-off-by: Li Jun > Signed-off-by: Peng Fan

Re: [RFC PATCH 0/3] fastboot: sunxi: Determine MMC device at runtime

2021-06-07 Thread Maxime Ripard
On Mon, May 24, 2021 at 11:43:43AM -0400, Sean Anderson wrote: > > > On 5/24/21 11:28 AM, Maxime Ripard wrote: > > On Mon, May 24, 2021 at 10:37:31AM -0400, Sean Anderson wrote: > >> > >> > >> On 5/23/21 8:36 PM, Andre Przywara wrote: > >>>

Re: [RFC PATCH 0/3] fastboot: sunxi: Determine MMC device at runtime

2021-05-24 Thread Maxime Ripard
On Mon, May 24, 2021 at 10:37:31AM -0400, Sean Anderson wrote: > > > On 5/23/21 8:36 PM, Andre Przywara wrote: > > At the moment the fastboot code relies on the Kconfig variable > > CONFIG_FASTBOOT_FLASH_MMC_DEV to point to the MMC device to use for the > > flash command. This value needs to be t

Re: [PATCH] sunxi: Select environment MMC based on boot device

2021-04-26 Thread Maxime Ripard
Hi, On Mon, Apr 19, 2021 at 04:35:04PM +0100, Andre Przywara wrote: > On Sun, 18 Apr 2021 22:16:21 -0500 > Samuel Holland wrote: > > (CC:ing Maxime) > > Hi, > > > Currently, the environment is always stored in eMMC if eMMC is enabled > > in the config. This means images written to SD and eMMC

Re: [PATCH v3 07/10] arm: sunxi: add support for DIP detection to CHIP board

2021-04-15 Thread Maxime Ripard
> > obj-$(CONFIG_MACH_SUN5I) += dram_sun5i_auto.o > > > obj-$(CONFIG_MACH_SUN7I) += dram_sun5i_auto.o > > > +obj-$(CONFIG_CHIP_DIP_SCAN) += chip.o > > > diff --git a/board/sunxi/chip.c b/board/sunxi/chip.c > > > new file mode 100644 > > >

Re: Getting rid of falcon mode

2021-04-13 Thread Maxime Ripard
On Tue, Apr 13, 2021 at 10:13:50AM -0400, Tom Rini wrote: > On Tue, Apr 13, 2021 at 09:08:01AM -0500, Alex G. wrote: > > Hi Maxime, > > > > On 4/13/21 3:56 AM, Maxime Ripard wrote: > > > Hi, > > > > > > On Mon, Apr 12, 2021 at 04:32:49

Re: Getting rid of falcon mode

2021-04-13 Thread Maxime Ripard
On Tue, Apr 13, 2021 at 09:08:01AM -0500, Alex G. wrote: > On 4/13/21 3:56 AM, Maxime Ripard wrote: > > On Mon, Apr 12, 2021 at 04:32:49PM -0500, Alex G. wrote: > > > ## Introduction > > > > > > Today we use "falcon mode" to mean "boot linux str

Re: Getting rid of falcon mode

2021-04-13 Thread Maxime Ripard
Hi, On Mon, Apr 12, 2021 at 04:32:49PM -0500, Alex G. wrote: > ## Introduction > > Today we use "falcon mode" to mean "boot linux straight from SPL". This > designation makes sense, since falcons "fly at high speed and change > direction rapidly" according to Wikipedia. > > The way we implement

Re: [PATCH v3 08/10] configs: CHIP: add support for DIP detect functionality

2021-03-24 Thread Maxime Ripard
On Wed, Mar 24, 2021 at 11:04:18AM +0100, Kory Maincent wrote: > This commit enables using the extension board detection mechanism on > CHIP boards > > Signed-off-by: Kory Maincent Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH v3 07/10] arm: sunxi: add support for DIP detection to CHIP board

2021-03-24 Thread Maxime Ripard
+ b/board/sunxi/chip.c > @@ -0,0 +1,104 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * (C) Copyright 2021 > + * Köry Maincent, Bootlin, > + * Based on initial code from Maxime Ripard > + */ > + > +#include > +#include > +#include > +#include > +#inc

Re: [PATCH v3 06/10] w1: replace dt detection by automatic detection

2021-03-24 Thread Maxime Ripard
t; id of the w1 detected. > > The patch is inspired from Maxime Ripart code. It's Ripard, but otherwise Reviewed-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH v3 02/10] cmd: add support for a new "extension" command

2021-03-24 Thread Maxime Ripard
2021, Kory Maincent > + > +U-Boot extension board usage (CONFIG_EXTENSION) > +=== > + > +Synopsis > + > + > +:: > + > +extension scan > +extension list > +extension apply > + > +Description > +--- > + > +The "extension" command proposes a generic U-Boot mechanism to detect > +extension boards connected to the HW platform, and apply the appropriate > +Device Tree overlays depending on the detected extension boards. > + > +The "extension" command comes with three sub-commands: > + > + - "extension scan" makes the generic code call the board-specific > + extension_board_scan() function to retrieve the list of detected > + extension boards. > + > + - "extension list" allows to list the detected extension boards. > + > + - "extension apply |all" allows to apply the Device Tree > + overlay(s) corresponding to one, or all, extension boards > + > +The latter requires two environment variables to exist: > + > + - extension_overlay_addr: the RAM address where to load the Device > + Tree overlays > + > + - extension_overlay_cmd: the U-Boot command to load one overlay. > + Indeed, the location and mechanism to load DT overlays is very setup > + specific. I guess we should make it explicit that the extension_overlay_name variable will be set and usable by that command With that fixed, Reviewed-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH v3 01/10] fdt_support: move fdt_valid from cmd_fdt.c to fdt_support.c

2021-03-24 Thread Maxime Ripard
: Tom Rini Reviewed-by: Maxime Ripard Thanks! Maxime signature.asc Description: PGP signature

Re: Help needed with uboot for CHIP

2021-03-23 Thread Maxime Ripard
On Tue, Mar 23, 2021 at 12:01:36AM +0530, Gunjan Gupta wrote: > Ok... > > What about supporting SLC. I dont have a Chip pro, but are you sure that > the current logic works for that too? The CHIP Pro has support for the NAND enabled, and if there's an issue then it should be fixed indeed. Maxime

Re: Help needed with uboot for CHIP

2021-03-22 Thread Maxime Ripard
Hi, On Sun, Mar 21, 2021 at 08:04:08PM +0530, Gunjan Gupta wrote: > I figured out the why SPL was not loading U-Boot from NAND. > > Apparently the logic to use PIO instead of DMA that was introduced in > 6ddbb1e936c78cdef1e7395039fa7020c5c75326 >

Re: [PATCH v2 07/12] w1-eeprom: remove sandbox eeprom driver

2021-03-02 Thread Maxime Ripard
Hi, On Tue, Mar 02, 2021 at 10:58:08AM +0100, Kory Maincent wrote: > Remove the sandbox w1 eeprom driver. The detection of w1 is > now automatic and does not depend on the devicetree, therefore this driver > can not be loaded anymore. > > Signed-off-by: Kory Maincent It's not really great to re

Re: [PATCH v2 10/12] sun5i: add support for DIP detection to CHIP board

2021-03-02 Thread Maxime Ripard
On Tue, Mar 02, 2021 at 05:14:44PM +0100, Köry Maincent wrote: > Hello Maxime, > > Thanks for your review. > > On Tue, 2 Mar 2021 17:05:38 +0100 > Maxime Ripard wrote: > > > The split of that patch and the previous one is weird: you're adding a > > Kc

Re: [PATCH v2 10/12] sun5i: add support for DIP detection to CHIP board

2021-03-02 Thread Maxime Ripard
x 00..fc3d14e497 > --- /dev/null > +++ b/board/sunxi/chip.c > @@ -0,0 +1,104 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * (C) Copyright 2021 > + * Köry Maincent, Bootlin, > + * Based on initial code from Maxime Ripard > + */ > + > +#include > +#inc

Re: [PATCH 2/4] pinephone_defconfig: reduce boot delay

2021-02-25 Thread Maxime Ripard
On Thu, Feb 25, 2021 at 05:02:40PM +, André Przywara wrote: > On 20/02/2021 12:14, Nicolas Boulenguez wrote: > > From: Arnaud Ferraris > > > > On a cellular phone, the vast majority of users can be expected to > > have no serial console connected and prefer a short boot. > > It's a bit trick

Re: [PATCH] sunxi: board: Splitting CHIP defconfig for nand.

2021-02-22 Thread Maxime Ripard
On Fri, Feb 19, 2021 at 06:00:13PM +, André Przywara wrote: > On 24/01/2021 16:19, Alexandre GRIVEAUX wrote: > > Hi Alexandre, > > (CCing: Kory, plus using Maxime's and Boris' newer emails) > > > This patch split CHIP defconfig to add nand 4G and 8G support. > > > > Some CONFIG was put at t

Re: [PATCH v3] video: sunxi_display: Convert to DM_VIDEO

2021-02-22 Thread Maxime Ripard
On Sun, Feb 21, 2021 at 09:24:18AM -0700, Simon Glass wrote: > > > > +static int sunxi_de_bind(struct udevice *dev) > > > > +{ > > > > + struct video_uc_plat *plat = dev_get_uclass_plat(dev); > > > > + > > > > + plat->size = LCD_MAX_WIDTH * LCD_MAX_HEIGHT * > > > > +

Re: [PATCH v3] video: sunxi_display: Convert to DM_VIDEO

2021-02-22 Thread Maxime Ripard
Hi Andre, On Sun, Feb 21, 2021 at 12:07:35AM +, Andre Przywara wrote: > > > enum sunxi_monitor { > > > sunxi_monitor_none, > > > sunxi_monitor_dvi, > > > @@ -59,12 +68,11 @@ enum sunxi_monitor { > > > #define SUNXI_MONITOR_LAST sunxi_monitor_composite_pal_nc > > > > > > stru

Re: [PATCH v3] video: sunxi_display: Convert to DM_VIDEO

2021-02-05 Thread Maxime Ripard
(Jagan) > > Signed-off-by: Jagan Teki > [Andre: rebase and smaller fixes] > Signed-off-by: Andre Przywara Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH] sunxi: display: introduce "sunxi-video" environment variable

2021-01-11 Thread Maxime Ripard
Hi, On Mon, Jan 11, 2021 at 10:13:32AM +0100, Giulio Benetti wrote: > From: Giulio Benetti > > At the moment you can specify lcd_mode only through hardcoded > CONFIG_VIDEO_LCD_MODE but this way, if you have a board with multiple lcds > compatible, you have to rebuild u-boot for every single lcd,

Re: [PATCH] MAINTAINERS, git-mailrc: Update sunxi maintainers

2020-10-29 Thread Maxime Ripard
hnical question to you in the future. > > Cc: Maxime Ripard > Signed-off-by: Andre Przywara Thanks for taking over, and I'll keep working on the linux-side, so I'm not going anywhere if you need help :) Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH] arm: sunxi: disable obsolete VIDEO config

2020-10-27 Thread Maxime Ripard
On Mon, Oct 19, 2020 at 10:50:49AM -0400, Tom Rini wrote: > On Mon, Oct 19, 2020 at 11:17:54AM +0200, Maxime Ripard wrote: > > On Sun, Oct 18, 2020 at 09:18:15PM +0200, Anatolij Gustschin wrote: > > > DM_VIDEO conversion deadline has passed, disable VIDEO config > > >

Re: [PATCH v2 5/5] sunxi: add drivers and configs needed for LCD display

2020-10-26 Thread Maxime Ripard
On Sun, Oct 25, 2020 at 10:56:32AM +0100, Martin Cerveny wrote: > > > On Mon, 19 Oct 2020, Maxime Ripard wrote: > > On Fri, Oct 16, 2020 at 07:17:05PM +0200, Martin Cerveny wrote: > > > Add PWM and dummy power regulator support. > > > Modify pha

Re: [PATCH v2 4/5] sunxi: video: v3s: Enable LCD support

2020-10-26 Thread Maxime Ripard
On Sun, Oct 25, 2020 at 10:46:04AM +0100, Martin Cerveny wrote: > > On Mon, 19 Oct 2020, Maxime Ripard wrote: > > On Fri, Oct 16, 2020 at 07:17:04PM +0200, Martin Cerveny wrote: > > > Enable support for V3s LCD display with following changes: > > > > > > V

Re: [PATCH 6/6] sunxi: add PineCube board

2020-10-26 Thread Maxime Ripard
DCDC3_VOLT=3300 > +CONFIG_AXP_ALDO3_VOLT_SLOPE_08=y > +CONFIG_AXP_ALDO3_INRUSH_QUIRK=y It would be worth mentioning in the commit log why you need those options. With that fixed, the whole series is Acked-by: Maxime Ripard Thanks! Maxime signature.asc Description: PGP signature

Re: [PATCH 4/8] sunxi: board: Add PinePhone DT selection logic

2020-10-22 Thread Maxime Ripard
On Wed, Oct 21, 2020 at 08:38:21PM -0500, Samuel Holland wrote: > On 10/21/20 1:56 PM, Jagan Teki wrote: > > On Thu, Sep 3, 2020 at 10:37 AM Samuel Holland wrote: > >> > >> There are two different publicly-released revisions of the PinePhone > >> hardware, versions 1.1 and 1.2; and they need diffe

Re: [PATCH v5 0/9] sunxi: binman fixes and SCP firmware support

2020-10-22 Thread Maxime Ripard
versions > of this series, but using binman instead of a shell script. > Acked-by: Maxime Ripard Thanks! Maxime signature.asc Description: PGP signature

Re: [PATCH v2 5/5] sunxi: add drivers and configs needed for LCD display

2020-10-19 Thread Maxime Ripard
On Fri, Oct 16, 2020 at 07:17:05PM +0200, Martin Cerveny wrote: > Add PWM and dummy power regulator support. > Modify phase of data signal for LCD display. > > Signed-off-by: Martin Cerveny > --- > configs/LicheePi_Zero_defconfig | 4 > 1 file changed, 4 insertions(+) > > diff --git a/conf

Re: [PATCH v2 4/5] sunxi: video: v3s: Enable LCD support

2020-10-19 Thread Maxime Ripard
On Fri, Oct 16, 2020 at 07:17:04PM +0200, Martin Cerveny wrote: > Enable support for V3s LCD display with following changes: > > V3s has 2x VI and 1x UI channels (use UI channel). > V3s uses PLL3 (PLL_VIDEO) for both DE2 and TCON0 pixelclock. > V3s does not support doubleclock for PLL3. > V3s supp

Re: [PATCH] arm: sunxi: disable obsolete VIDEO config

2020-10-19 Thread Maxime Ripard
On Sun, Oct 18, 2020 at 09:18:15PM +0200, Anatolij Gustschin wrote: > DM_VIDEO conversion deadline has passed, disable VIDEO config > option by default. Boards should convert to DM_VIDEO if they > need video console support. > > Signed-off-by: Anatolij Gustschin > Cc: Jagan

Re: [PATCH v2 2/5] ARM: dts: sun8i: v3s: Add simple-framebuffer

2020-10-19 Thread Maxime Ripard
On Fri, Oct 16, 2020 at 07:17:02PM +0200, Martin Cerveny wrote: > Add support for "allwinner,simple-framebuffer" with "mixer0-lcd0" pipeline. > > Signed-off-by: Martin Cerveny Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH 4/5] arm: dts: v3s: Add support for simple-framebuffer with DE2/TCON

2020-09-21 Thread Maxime Ripard
On Wed, Sep 16, 2020 at 05:53:35PM +0200, Martin Cerveny wrote: > On Wed, 16 Sep 2020, Maxime Ripard wrote: > > On Wed, Sep 16, 2020 at 04:10:51PM +0200, Martin Cerveny wrote: > > > Add support for DE2 and TCON connected LCD display. > > > Add support for export as &q

Re: [PATCH 5/5] sunxi: add drivers and configs needed for LCD display

2020-09-21 Thread Maxime Ripard
On Wed, Sep 16, 2020 at 05:44:58PM +0200, Martin Cerveny wrote: > > > On Wed, 16 Sep 2020, Maxime Ripard wrote: > > On Wed, Sep 16, 2020 at 04:10:52PM +0200, Martin Cerveny wrote: > > > Add PWM and dummy power regulator support. > > > Modify data timings for LCD

Re: [PATCH 5/5] sunxi: add drivers and configs needed for LCD display

2020-09-16 Thread Maxime Ripard
On Wed, Sep 16, 2020 at 04:10:52PM +0200, Martin Cerveny wrote: > Add PWM and dummy power regulator support. > Modify data timings for LCD displays. > > Signed-off-by: Martin Cerveny > --- > configs/LicheePi_Zero_defconfig | 4 > 1 file changed, 4 insertions(+) > > diff --git a/configs/Lic

Re: [PATCH 4/5] arm: dts: v3s: Add support for simple-framebuffer with DE2/TCON

2020-09-16 Thread Maxime Ripard
On Wed, Sep 16, 2020 at 04:10:51PM +0200, Martin Cerveny wrote: > Add support for DE2 and TCON connected LCD display. > Add support for export as "allwinner,simple-framebuffer" > with "mixer0-lcd0" pipeline. > > Signed-off-by: Martin Cerveny You shouldn't do multiple things at once. If you need

Re: [PATCH 1/5] sunxi: video: No double clock on DE2

2020-09-16 Thread Maxime Ripard
On Wed, Sep 16, 2020 at 04:10:48PM +0200, Martin Cerveny wrote: > Weird code or comment. This is variant is tested on V3s. > > Signed-off-by: Martin Cerveny Generally speaking your commit logs are fairly concise, but it really becomes an issue when you're allegedly fixing a bug. There's a bunch

  1   2   3   4   5   6   7   8   9   10   >