Re: [PATCH 1/9] phy: samsung: Add Exynos USB DRD PHY driver

2025-07-21 Thread Mattijs Korpershoek
On Sun, Jul 20, 2025 at 14:57, Sam Protsenko wrote: > On Thu, Jul 17, 2025 at 1:58 AM Mattijs Korpershoek > wrote: >> >> Hi Sam, >> >> Thank you for the patch. >> > > [snip] > >> > + >> > +#define EXYNOS850_DRD_UTMI

Re: [PATCH 2/4] riscv: Set SYS_BOOTM_LEN default to 0x4000000

2025-07-21 Thread Mattijs Korpershoek
rren """ I don't think you need to resend for this, usually the maintainer who picks up your patch will fix this. Also: Reviewed-by: Mattijs Korpershoek > --- > > (no changes since v1) > > boot/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [PATCH v4 3/6] bootm: Append bootargs value when bootmeth_android provide cmdline

2025-07-18 Thread Mattijs Korpershoek
Hi George, On Wed, Jul 16, 2025 at 19:55, george chan wrote: > Hi Mattijs, > > Thx for reply. > > 在 2025年7月16日週三 17:05,Mattijs Korpershoek 寫道: > >> Hi George, >> >> Thank you for the patch. >> > ... > >> >>

Re: [PATCH v3] drivers: fastboot: Add support for SPI flash memory

2025-07-18 Thread Mattijs Korpershoek
tition_boot=0x0 0x100 > ``` > > Signed-off-by: Ariel D'Alessandro Thanks for the doc updates. This looks great! Reviewed-by: Mattijs Korpershoek > --- > doc/android/fastboot.rst| 16 +- > drivers/fastboot/Kconfig| 6 +- > drivers/fastboot/Mak

Re: [PATCH] fastboot: Fix off by 1 error

2025-07-18 Thread Mattijs Korpershoek
issue found by Smatch. This issue was* > > Signed-off-by: Andrew Goodbody Good catch! Reviewed-by: Mattijs Korpershoek > --- > drivers/fastboot/fb_command.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fastboot/fb_command.c b/d

Re: [PATCH 2/9] usb: dwc3-generic: Add Exynos850 support

2025-07-16 Thread Mattijs Korpershoek
this chip. > > Signed-off-by: Sam Protsenko Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/dwc3/dwc3-generic.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c > index 21452ad15693..3cda2b74b7e

Re: [PATCH 1/9] phy: samsung: Add Exynos USB DRD PHY driver

2025-07-16 Thread Mattijs Korpershoek
e UTMI_DM_PULLDOWN BIT(2) > +#define UTMI_DP_PULLDOWN BIT(3) > +#define UTMI_FORCE_BVALIDBIT(4) > +#define UTMI_FORCE_VBUSVALID BIT(5) Comparing with the linux driver using commit cc52a697f87e ("ph

Re: [PATCH v2] drivers: fastboot: Add support for SPI flash memory

2025-07-16 Thread Mattijs Korpershoek
Hi Ariel, Thank you for the patch. On Tue, Jul 15, 2025 at 16:11, Ariel D'Alessandro wrote: > Fastboot currently supports MMC and NAND flash devices. Similarly, > extend the support to SPI flash memories. > > Note that in this initial implementation, partitions on the device are > not supporte

Re: [PATCH] docs: Update FIT signature testing instructions

2025-07-16 Thread Mattijs Korpershoek
Hi Enric, Thank you for the patch. On Wed, Jul 16, 2025 at 15:12, Enric Balletbo i Serra wrote: > Update the FIT signature testing instructions to use the pytest suite instead > of > the old vboot_test.sh script. > > Signed-off-by: Enric Balletbo i Serra Reviewed-by: Matt

Re: [GIT PULL] Please pull u-boot-dfu-20250716 into master

2025-07-16 Thread Mattijs Korpershoek
And, apparently I forgot to update my subject line again. It should be "u-boot-dfu-20250716", not "u-boot-dfu-next-20250716". Sorry about that ! On Wed, Jul 16, 2025 at 12:08, Mattijs Korpershoek wrote: > Hi Tom, > > Please find the following fixes for master:

[GIT PULL] Please pull u-boot-dfu-next-20250716 into master

2025-07-16 Thread Mattijs Korpershoek
Hi Tom, Please find the following fixes for master: Android: - Fix printing lbaint_t format in AVB and android_ab messages DFU: - Fix dfu_config_interfaces() for single interface DFU syntax CI Job: - https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/27074 Please note that this is

Re: [PATCH v4 3/6] bootm: Append bootargs value when bootmeth_android provide cmdline

2025-07-16 Thread Mattijs Korpershoek
Hi George, Thank you for the patch. On Mon, Jun 30, 2025 at 15:56, George Chan via B4 Relay wrote: > From: George Chan > > Old logic wipe bootargs env with cmdline, new logic cater the value > by prepending cmdline value to bootargs. > > Signed-off-by: George Chan > --- > boot/bootm.c | 2 +

Re: [PATCH] dfu: Fix dfu_config_interfaces() for single interface DFU syntax

2025-07-15 Thread Mattijs Korpershoek
Hi, On Tue, 08 Jul 2025 23:23:42 -0500, Sam Protsenko wrote: > As stated in DFU documentation [1], the device interface part might be > missing in dfu_alt_info: > > dfu_alt_info > The DFU setting for the USB download gadget with a semicolon > separated string of information on

Re: [PATCH] dfu: Fix dfu_config_interfaces() for single interface DFU syntax

2025-07-15 Thread Mattijs Korpershoek
On Fri, Jul 11, 2025 at 15:14, Sam Protsenko wrote: > On Fri, Jul 11, 2025 at 3:02 AM Mattijs Korpershoek > wrote: >> >> Hi Sam, >> >> Thank you for the patch. [...] >> >> Good catch! I can indeed reproduce this on sandbox afte

Re: [PATCH v2 3/6] rockchip: Add default USB_GADGET_PRODUCT_NUM for RK3576

2025-07-15 Thread Mattijs Korpershoek
Hi Jonas, Thank you for the patch. On Fri, Jul 11, 2025 at 22:21, Jonas Karlman wrote: > Use 0x350e as the default USB Product ID for Rockchip RK3576, same PID > being used by the BootROM when the device is in MASKROM mode. > > Signed-off-by: Jonas Karlman Reviewed-by: Mattijs

Re: [PATCH] dfu: Fix dfu_config_interfaces() for single interface DFU syntax

2025-07-11 Thread Mattijs Korpershoek
case. > > [1] doc/usage/dfu.rst > > Fixes: commit febabe3ed4f4 ("dfu: allow to manage DFU on several devices") > Signed-off-by: Sam Protsenko Good catch! I can indeed reproduce this on sandbox after enabling CMD_DFU: $ ./u-boot -T [...] => setenv dfu_alt_info "

Re: [PATCH] fastboot: fb_mmc: Fix write/erase logic when buffer address is zero

2025-07-11 Thread Mattijs Korpershoek
-by: Chance Yang Reviewed-by: Mattijs Korpershoek Unfortunately, this patch is not publicly available on the mailing list: http://lore.kernel.org/all/20250708-master-v1-1-f97e40dd3...@kneron.us Neither on patchwork: https://patchwork.ozlabs.org/project/uboot/list/?submitter=91223&state=%2A

Re: [PATCH] fastboot: Fix has-slot command always returning yes for fb_nand

2025-07-11 Thread Mattijs Korpershoek
Hi Chance, Thank you for the patch. On Tue, Jul 08, 2025 at 09:16, Chance Yang wrote: > The issue was a mismatch in return value conventions between functions: > - getvar_get_part_info() expects >= 0 for success > - fb_nand_lookup() returns 0 on success, 1 on failure (from > find_dev_and_part

Re: [PATCH RFT v6 1/3] fastboot: blk: introduce fastboot block flashing support

2025-07-09 Thread Mattijs Korpershoek
e extended. >> >> For the erase logic, allmost no block drivers exposes the >> erase operation, except mmc & virtio, so in order to allow >> erasiong any partition a soft-erase logic has been added >> to write zero-ed buffers in a loop. >> >> Signed-off-b

Re: [PATCH 1/2] boot/android_ab.c: Make use of LBAF for printing lbaint_t

2025-07-09 Thread Mattijs Korpershoek
Hi, On Tue, 01 Jul 2025 19:06:02 -0600, Tom Rini wrote: > When printing the contents of an lbaint_t variable we need to use LBAF > to print it in order to get the correct format type depending on 32 or > 64bit-ness. Furthermore, printed message should not be split as that > makes finding them hard

[GIT PULL] Please pull u-boot-dfu-next-20250703 into next

2025-07-03 Thread Mattijs Korpershoek
: abootimg: Prevent use of unintialised variable boot: android: Prevent use of unintialised variable Mattijs Korpershoek (1): MAINTAINERS: Add common/spl/spl_dfu to DFU entry MAINTAINERS | 1 + boot/image-android.c | 2 +- cmd/abootimg.c | 2 +- 3 files changed, 3 insert

Re: [PATCH RFT v6 3/3] fastboot: integrate block flashing back-end

2025-07-02 Thread Mattijs Korpershoek
tforms since they > default to y already. > > Make it only default on SUNXI when MMC or NAND is enabled, > so it doesn't break the CHIP & Ninendo boards, and for ROCKCHIP s/Ninendo/Nintendo/ ? I can fix when applying if needed. Mattijs > when MMC is enabled. > > Signe

Re: [PATCH 2/2] common/avb_verify.c: Make use of LBAF for printing lbaint_t

2025-07-02 Thread Mattijs Korpershoek
wed-by: Mattijs Korpershoek > --- > Cc: Mattijs Korpershoek > Cc: Igor Opaniuk > Cc: Sam Protsenko > --- > common/avb_verify.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/common/avb_verify.c b/common/avb_verify.c > index cff

Re: [PATCH 1/2] boot/android_ab.c: Make use of LBAF for printing lbaint_t

2025-07-02 Thread Mattijs Korpershoek
split as that > makes finding them harder, so bring this back to a single line. > > Signed-off-by: Tom Rini Reviewed-by: Mattijs Korpershoek > --- > Cc: Mattijs Korpershoek > Cc: Igor Opaniuk > Cc: Sam Protsenko > --- > boot/android_ab.c | 3 +-- > 1 fi

Re: [PATCH v2 1/2] cmd: Introduce CMD_HELP

2025-07-02 Thread Mattijs Korpershoek
s/ > And also mark cmd_help dependency in test_help.py. > > Signed-off-by: Michal Simek > Reviewed-by: Peter Robinson Reviewed-by: Mattijs Korpershoek > --- > > Changes in v2: > - Remove CONFIG_CMDLINE ifdefs from code. > - Update test_help. > > cmd/Kconfig

Re: [PATCH v4 0/2] Prevent use of unitialised variable vhdr

2025-07-02 Thread Mattijs Korpershoek
Hi, On Thu, 26 Jun 2025 17:38:53 +0100, Andrew Goodbody wrote: > Ensure that vhdr is initialised so that its value is never > accessed when not initialised. > > Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-dfu (u-boot-dfu-next) [1/2] cmd: abootimg: Prevent use of unintia

Re: [PATCH] MAINTAINERS: Add common/spl/spl_dfu to DFU entry

2025-07-02 Thread Mattijs Korpershoek
Hi, On Wed, 18 Jun 2025 15:43:44 +0200, Mattijs Korpershoek wrote: > This was not listed as part of the DFU entry. > > Add it to make sure that the DFU maintainers get CC'ed on > patches for spl_dfu. > > Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boo

Re: [PATCH v2] usb: dwc3: qcom: Add delays in UTMI clock selection for Qscratch

2025-06-27 Thread Mattijs Korpershoek
e is taken from this Linux kernel implementation: > https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/usb/dwc3/dwc3-qcom.c?id=a4333c3a6ba9ca9cff50a3c1d1bf193dc5489e1c Thank you for mentioning this link, it's very helpful for the review. > > Signed-of

Re: [PATCH v4 2/2] boot: android: Prevent use of unintialised variable

2025-06-26 Thread Mattijs Korpershoek
port) > Signed-off-by: Andrew Goodbody Reviewed-by: Mattijs Korpershoek > --- > boot/image-android.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/boot/image-android.c b/boot/image-android.c > index 459cdb8456c..12bcf7e4fbd 100644 > ---

Re: [PATCH v4 1/2] cmd: abootimg: Prevent use of unintialised variable

2025-06-26 Thread Mattijs Korpershoek
Hi Andrew, Thank you for the patch. On Thu, Jun 26, 2025 at 17:38, Andrew Goodbody wrote: > Initiaise vhdr to prevent its use when uninitialised. s/Initiaise/Initialise/: will fix when applying. > > This issue was found with Smatch. > > Fixes: 636da2039aea (android: boot: support boot image

Re: [PATCH v3] cmd: abootimg: Prevent use of unintialised variable

2025-06-26 Thread Mattijs Korpershoek
port boot image header version 3 and 4) > Signed-off-by: Andrew Goodbody Reviewed-by: Mattijs Korpershoek > --- > Changes in v3: > - Just initialise the variable rather than exit early > - Link to v2: > https://lore.kernel.org/r/20250625-abootimg_fix-v2-1-0d295dc1f...@lina

Re: [PATCH v2] cmd: abootimg: Prevent use of unintialised variable

2025-06-26 Thread Mattijs Korpershoek
On Wed, Jun 25, 2025 at 17:31, Andrew Goodbody wrote: > On 25/06/2025 17:10, Mattijs Korpershoek wrote: [...] > >> android_image_get_data() handles the case where vendor_boot_hdr is NULL: >> """ >> if (((struct andr_boot_img_hdr_v0 *)boot_hdr)-&g

[PATCH] doc: board: ti: Add defconfigs for AM69-SK

2025-06-25 Thread Mattijs Korpershoek
The J784S4 and AM69 Platforms page only details the defconfigs for J784S4. Mention the ones needed for AM69-SK as well, to guide users on how to build for that board. Signed-off-by: Mattijs Korpershoek --- doc/board/ti/j784s4_evm.rst | 9 + 1 file changed, 9 insertions(+) diff --git a

Re: [PATCH v2] cmd: abootimg: Prevent use of unintialised variable

2025-06-25 Thread Mattijs Korpershoek
Hi Andrew, Thank you for the patch. On Wed, Jun 25, 2025 at 16:52, Andrew Goodbody wrote: > vhdr can be used when not initialised so detect this condition > and exit early to prevent the problem. > > This issue was found with Smatch. > > Fixes: 636da2039aea (android: boot: support boot image h

Re: [PATCH v3] spl: Add support for Device Firmware Upgrade (DFU) over PCIe

2025-06-24 Thread Mattijs Korpershoek
Hi Hrushikesh, Thank you for the patch. On Thu, Jun 19, 2025 at 12:48, Hrushikesh Salunke wrote: > Introduces support for Device Firmware Upgrade (DFU) over PCIe in > U-Boot. Traditionally, the DFU protocol is used over USB, where a > device enters DFU mode and allows a host to upload firmware

[PATCH] MAINTAINERS: Add common/spl/spl_dfu to DFU entry

2025-06-18 Thread Mattijs Korpershoek
This was not listed as part of the DFU entry. Add it to make sure that the DFU maintainers get CC'ed on patches for spl_dfu. Signed-off-by: Mattijs Korpershoek --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS

Re: [RFH] Future direction of the U-Boot project

2025-06-18 Thread Mattijs Korpershoek
Hi Tom, On Mon, Jun 02, 2025 at 16:27, Tom Rini wrote: > Hey all, > > Something I've talked about in release emails earlier this year, and > promised a follow-up on but hadn't gotten to yet, was how to manage the > project moving forward. The email I made last week about Simon also I > believe h

Re: [GIT PULL] Please pull u-boot-dfu-next-20250616 into next

2025-06-16 Thread Mattijs Korpershoek
On Mon, Jun 16, 2025 at 16:32, Mattijs Korpershoek wrote: The PR description is correct, but not the title: u-boot-dfu-20250616 -> u-boot-dfu-next-20250616 Sorry about the confusion. > Hi Tom, > > Please find the following fixes/developments for next: > > Usb gadget:

[GIT PULL] Please pull u-boot-dfu-20250616 into next

2025-06-16 Thread Mattijs Korpershoek
Hi Tom, Please find the following fixes/developments for next: Usb gadget: - Atmel: Improve gadget disconnect stability by power cycling CI Job: - https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/26704 Thanks, Mattijs The following changes since commit 9de873b4c3098c0662d4adaeb1

[GIT PULL] Please pull u-boot-dfu-20250616 into master

2025-06-16 Thread Mattijs Korpershoek
Hi Tom, Please find the following fixes for master: Usb gadget: - Fix ti_musb driver in gadget mode (with DM_USB_GADGET) DFU: - mmc/scsi backends when using 10 or more partitions CI job: - https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/26696 Thanks, Mattijs The following chan

Re: [PATCH] usb: gadget: atmel: reliably generate disconnect by disabling controller instead of toggling PULLD_DIS

2025-06-16 Thread Mattijs Korpershoek
On Mon, Jun 16, 2025 at 10:45, Zixun LI wrote: > On Mon, Jun 16, 2025 at 9:28 AM Mattijs Korpershoek > wrote: >> >> On Mon, Jun 16, 2025 at 09:24, Mattijs Korpershoek >> wrote: >> >> > On Fri, Jun 13, 2025 at 16:45, Zixun LI wrote: >> >

Re: [PATCH] usb: gadget: atmel: reliably generate disconnect by disabling controller instead of toggling PULLD_DIS

2025-06-16 Thread Mattijs Korpershoek
Hi, On Mon, 02 Jun 2025 17:45:08 +0200, Zixun LI wrote: > Contrary to the datasheet, setting both DETACH and PULLD_DIS bits to 1 > does not always drive the DP and DM lines to high-impedance. This > prevents the host from reliably detecting a USB disconnect and subsequent > reconnect. > > The sym

Re: [PATCH] usb: gadget: atmel: reliably generate disconnect by disabling controller instead of toggling PULLD_DIS

2025-06-16 Thread Mattijs Korpershoek
On Mon, Jun 16, 2025 at 09:24, Mattijs Korpershoek wrote: > On Fri, Jun 13, 2025 at 16:45, Zixun LI wrote: > >> On Fri, Jun 13, 2025 at 11:22 AM Mattijs Korpershoek >> wrote: >>> >>> >>> Mihai, Zixun, do you have any update on case No.01589331 ? &g

Re: [PATCH] usb: gadget: atmel: reliably generate disconnect by disabling controller instead of toggling PULLD_DIS

2025-06-16 Thread Mattijs Korpershoek
On Fri, Jun 13, 2025 at 16:45, Zixun LI wrote: > On Fri, Jun 13, 2025 at 11:22 AM Mattijs Korpershoek > wrote: >> >> >> Mihai, Zixun, do you have any update on case No.01589331 ? >> >> I'd like to pick this up and some point so please keep me infor

Re: [PATCH] usb: gadget: musb: Fix duplicate ops assignment in ti_musb_peripheral

2025-06-16 Thread Mattijs Korpershoek
Hi, On Wed, 11 Jun 2025 19:10:30 +0200, Kory Maincent wrote: > Remove duplicate .ops assignment that was overriding the correct > ti_musb_gadget_ops with musb_usb_ops (host ops) in the ti_musb_peripheral > driver. This was causing U-Boot crashes when trying to call the > handle_interrupts operatio

Re: [PATCH v1] dfu: fix dev_part_str for file operations

2025-06-16 Thread Mattijs Korpershoek
Hi, On Wed, 11 Jun 2025 05:00:38 +, Ivan Pang wrote: > The third_arg for a dfu alt is read as an integer and is overloaded for > different supported backends. For ext4 and fat, this third_arg > represents the partition and forms the dev part string, which should > have its partition in hex. Th

Re: [PATCH v1] dfu: fix dev_part_str for file operations

2025-06-13 Thread Mattijs Korpershoek
rt string, which should > have its partition in hex. This commit fixes dfu ext4/fat usage for > devices with ten or more partitions. > > Signed-off-by: Ivan Pang Reviewed-by: Mattijs Korpershoek > --- > > drivers/dfu/dfu_mmc.c | 2 +- > drivers/dfu/dfu_scsi.c | 2 +- >

Re: [PATCH] usb: gadget: atmel: reliably generate disconnect by disabling controller instead of toggling PULLD_DIS

2025-06-13 Thread Mattijs Korpershoek
Host used: > 1. AMD Ryzen 5800H native port, Linux 6.14 > 2. Intel i7-8750H native port, Windows 10 > 3. Genesys GL3523 hub attached to [1] > > Zixun LI > > On Jun 4, 2025, at 11:51, Eugen Hristev wrote: >> >> >> >> On 6/4/25 11:20, Mattijs Korpershoek

Re: [PATCH] usb: gadget: musb: Fix duplicate ops assignment in ti_musb_peripheral

2025-06-13 Thread Mattijs Korpershoek
dget_generic_ops") I can do that while applying. Reviewed-by: Mattijs Korpershoek > Signed-off-by: Kory Maincent > --- > drivers/usb/musb-new/ti-musb.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/musb-new/ti-musb.c b/drivers/usb/musb-new/ti-musb.c >

Re: [PATCH v2 3/5] boot: bootmeth_android: Conditionally dependent on abootimg

2025-06-12 Thread Mattijs Korpershoek
> aarch64-linux-gnu-ld.bfd: > /home/user/sources/u-boot-next/boot/bootmeth_android.c:543:(.text.boot_android_normal+0xd8): > undefined reference to `set_abootimg_addr' > Segmentation fault (core dumped) > > Signed-off-by: George Chan Reviewed-by: Mattijs Korpershoek Acke

Re: [PATCH v2 5/5] usb: gadget: Introduce usb gadget vendor/product default id for ARCH_QCOM

2025-06-12 Thread Mattijs Korpershoek
> Signed-off-by: George Chan > Reviewed-by: Neil Armstrong Reviewed-by: Mattijs Korpershoek Acked-by: Mattijs Korpershoek Casey, even if this is usb gadget, feel free to pick this up in your tree. Thanks, Mattijs > --- > drivers/usb/gadget/Kconfig | 2 ++ > 1 file changed, 2

Re: [PATCH v2 1/5] image-android: Prepend/postpend default bootargs value with given bootcmd

2025-06-12 Thread Mattijs Korpershoek
g tool [1]) [1] https://android.googlesource.com/platform/system/tools/mkbootimg/+/refs/heads/main/mkbootimg.py#511 With the wording fixed, please add Reviewed-by: Mattijs Korpershoek Also, Casey, feel free to pick of the reworded version through your tree ! > + env bootargs. By enable

Re: [PATCH RFT v4 3/3] fastboot: integrate block flashing back-end

2025-06-06 Thread Mattijs Korpershoek
rote: >>>> >>>>> From: Dmitrii Merkurev >>>>> >>>>> 1. Get partition info/size >>>>> 2. Erase partition >>>>> 3. Flash partition >>>>> 4. BCB >>>>> >>>>> Signed-off-b

Re: [PATCH RFT v5 0/3] fastboot: add support for generic block flashing

2025-06-06 Thread Mattijs Korpershoek
Hi Neil, On ven., juin 06, 2025 at 11:33, Neil Armstrong wrote: > This serie permits using any block device as target > for fastboot by moving the generic block logic into > a common set of helpers and also use them as generic > backend. > > The erase logic has been extended to support software

Re: [PATCH v3 2/2] renesas: Renesas R-Car Gen4 watchdog driver

2025-06-05 Thread Mattijs Korpershoek
Hi Shmuel, On jeu., juin 05, 2025 at 06:33, Shmuel Melamud wrote: > On Wed, Jun 4, 2025 at 12:02 PM Mattijs Korpershoek > wrote: >> >> Hi Shmuel, >> >> Thank you for the patch. >> >> On Tue, Jun 03, 2025 at 06:06, Shmuel Leib Melamud via B4 Relay &g

Re: [PATCH] usb: gadget: atmel: reliably generate disconnect by disabling controller instead of toggling PULLD_DIS

2025-06-04 Thread Mattijs Korpershoek
Hi Zixun, Thank you for the patch. On Mon, Jun 02, 2025 at 17:45, Zixun LI wrote: I'm surprised that checkpatch.pl does not catch this, but the subject (title) is too long (it should be less than 70 chars): https://docs.u-boot.org/en/latest/develop/sending_patches.html#commit-message-convention

Re: [PATCH v3 2/2] renesas: Renesas R-Car Gen4 watchdog driver

2025-06-04 Thread Mattijs Korpershoek
Hi Shmuel, Thank you for the patch. On Tue, Jun 03, 2025 at 06:06, Shmuel Leib Melamud via B4 Relay wrote: > From: Shmuel Leib Melamud > > Add support of Renesas R-Car Gen4 watchdog timer. Timeouts up to > 8184.0s are supported (CKS1 register is not involved). The watchdog > uses the clock of

Re: [PATCH v3 1/2] renesas: Handle CLK_TYPE_GEN4_MDSEL in gen3_clk_get_rate64()

2025-06-04 Thread Mattijs Korpershoek
R-Car > Gen4 watchdog. It operates similarly to CLK_TYPE_GEN3_MDSEL clock. > > Signed-off-by: Shmuel Leib Melamud Reviewed-by: Mattijs Korpershoek nitpick: for a future submission, consider looking at the commit title for a particular file to have the same subject. $ git log --oneline -- dr

[GIT PULL] Please pull u-boot-dfu-next-20250602 into next

2025-06-02 Thread Mattijs Korpershoek
Hi Tom, Please find the following developments for next: Usb gadget: - dwc2: Fix incorrect ULPI_UTMI_SEL bit setting - dwc2: Fix HBstLen setting for external DMA mode - dwc2: Various refactors to get the code closer to Linux - dwc2: Support reset logic for v4.20a CI Job: - https://source.denx.de

Re: [PATCH] usb: dwc2: Refactor register operations with clrsetbits macros

2025-06-02 Thread Mattijs Korpershoek
Hi, On Sun, 26 Jan 2025 00:29:59 -0800, Junhui Liu wrote: > Refactor DWC2 USB gadget driver to replace manual read-modify-write > operations with `clrsetbits_le32`, `setbits_le32`, and `clrbits_le32` > macros, which simplify the code and improve readability. > > Thanks, Applied to https://sourc

Re: [PATCH v4 0/8] usb: dwc2: Refactor and update USB DWC2 driver

2025-06-02 Thread Mattijs Korpershoek
Hi, On Fri, 10 Jan 2025 21:55:19 +0800, Junhui Liu wrote: > This series improves the USB DWC2 driver by extracting register > definitions into a common file for better readability and updating the > reset method to reflect changes in version 4.20a, including the new > GRSTCTL_CSFTRST_DONE bit for

Re: [PATCH] image: android: fix ramdisk default address

2025-05-30 Thread Mattijs Korpershoek
a kernel on > the Renesas R-Car S4 board. > > Add an additional check to the if clause so that the ramdisk address is > assigned when the kernel address and the ramdisk address are the same, > restoring the previous default behavior. > > Fixes: 21e7fa0e3ac5 ("image: android:

Re: [PATCH v2] renesas: Renesas R-Car Gen4 watchdog driver

2025-05-30 Thread Mattijs Korpershoek
Hi Shmuel, Thank you for the patch. On ven., mai 30, 2025 at 01:58, Shmuel Melamud via B4 Relay wrote: > From: Shmuel Melamud > > Add support of Renesas R-Car Gen4 watchdog timer. Timeouts up to > 8184.0s are supported (CKS1 register is not involved). The watchdog > uses the clock type CLK_TY

Re: [PATCH 2/2] test/py: Correct handling of exceptions

2025-05-30 Thread Mattijs Korpershoek
tions") Reviewed-by: Mattijs Korpershoek > --- > > test/py/conftest.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/py/conftest.py b/test/py/conftest.py > index eec0b5488e4..8ce680a92a0 100644 > --- a/test/py/conftest.py > +++ b/test/py

Re: [PATCH 1/2] test/py: Use the correct fixture name in exception handler

2025-05-30 Thread Mattijs Korpershoek
ed4b75add ("test/py: Drop u_boot_ prefix on test files") Reviewed-by: Mattijs Korpershoek > --- > > test/py/conftest.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/py/conftest.py b/test/py/conftest.py > index 6c3ac67979a..eec0b5

Re: [PATCH] renesas: Renesas R-Car Gen4 watchdog driver

2025-05-26 Thread Mattijs Korpershoek
l --check camfvly31c0yptgpkx3ze1kmjn_hpqcjh-ghbc+jamplmdcs...@mail.gmail.com ✓ [PATCH] renesas: Renesas R-Car Gen4 watchdog driver + Link: https://lore.kernel.org/r/camfvly31c0yptgpkx3ze1kmjn_hpqcjh-ghbc+jamplmdcs...@mail.gmail.com + Signed-off-by: Mattijs Korpershoek ● checkpat

Re: [PATCH 09/17] include/dfu.h: Audit include list

2025-05-22 Thread Mattijs Korpershoek
Hi Tom, Thank you for the patch. On mer., mai 21, 2025 at 16:51, Tom Rini wrote: > This file does not need a forward declaration of 'struct list_head' as > it includes so remove it. > > Signed-off-by: Tom Rini Reviewed-by: Mattijs Korpershoek > ---

Re: [PATCH RFT v3 0/3] fastboot: add support for generic block flashing

2025-05-21 Thread Mattijs Korpershoek
Hi Tom, On mer., mai 21, 2025 at 13:03, Tom Rini wrote: > On Wed, May 21, 2025 at 08:52:41PM +0200, Mattijs Korpershoek wrote: >> Hi Tom, >> >> On mer., mai 21, 2025 at 09:12, Tom Rini wrote: >> >> > On Wed, May 21, 2025 at 04:49:35PM +0200, Matt

Re: [PATCH RFT v3 0/3] fastboot: add support for generic block flashing

2025-05-21 Thread Mattijs Korpershoek
Hi Tom, On mer., mai 21, 2025 at 09:12, Tom Rini wrote: > On Wed, May 21, 2025 at 04:49:35PM +0200, Mattijs Korpershoek wrote: >> Hi Neil, >> >> On mar., mai 20, 2025 at 13:35, Mattijs Korpershoek >> wrote: >> >> > Hi, >> > >> > O

Re: [PATCH RFT v3 0/3] fastboot: add support for generic block flashing

2025-05-21 Thread Mattijs Korpershoek
Hi Neil, On mar., mai 20, 2025 at 13:35, Mattijs Korpershoek wrote: > Hi, > > On Tue, 06 May 2025 18:10:06 +0200, neil.armstr...@linaro.org wrote: >> This serie permits using any block device as target >> for fastboot by moving the generic block logic into >> a com

Re: [PATCH RFT v3 0/3] fastboot: add support for generic block flashing

2025-05-20 Thread Mattijs Korpershoek
Hi, On Tue, 06 May 2025 18:10:06 +0200, neil.armstr...@linaro.org wrote: > This serie permits using any block device as target > for fastboot by moving the generic block logic into > a common set of helpers and also use them as generic > backend. > > The erase logic has been extended to support s

Re: [PATCH 4/5] global: Avoid indirect inclusion of from

2025-05-15 Thread Mattijs Korpershoek
f the places which had relied on this indirect > inclusion to instead include directly. > > Signed-off-by: Tom Rini Reviewed-by: Mattijs Korpershoek # android, bcb > ---

Re: [PATCH v2 1/5] boot/image-android: Workaround kernel/ramdisk invalid addr

2025-05-09 Thread Mattijs Korpershoek
Hi George, On jeu., mai 08, 2025 at 12:22, george chan wrote: > Hi Mattijs, > > Thx for feedback. > > 在 2025年5月7日週三 15:47,Mattijs Korpershoek 寫道: > >> Hi George, >> >> Thank you for the patch. >> I really prefer this solution to the one proposed in v

Re: [PATCH v2 1/5] boot/image-android: Workaround kernel/ramdisk invalid addr

2025-05-07 Thread Mattijs Korpershoek
ramdisk_ptr; >> } else { >> ramdisk_ptr = img_data.ramdisk_addr; >> > > I like this and should be the default except rare cases, exposing the whole > memory > to image loading sound really dangerous.. > > Reviewed-by: Neil A

Re: [PATCH RFT v3 0/3] fastboot: add support for generic block flashing

2025-05-07 Thread Mattijs Korpershoek
ng the generic block layer: => fastboot usb 0 Warning: the fastboot block backend features are limited, consider using the MMC backend $ fastboot flash super super.img Both work great! Tested-by: Mattijs Korpershoek I've also opened a issue on gitlab to harmonize the fastboot

Re: [PATCH RFT v3 1/3] fastboot: blk: introduce fastboot block flashing support

2025-05-07 Thread Mattijs Korpershoek
can fixup when applying. > to write zero-ed buffers in a loop. > > Signed-off-by: Dmitrii Merkurev > Signed-off-by: Neil Armstrong Reviewed-by: Mattijs Korpershoek > ---

Re: [PATCH RFT v3 2/3] fastboot: blk: switch emmc to use the block helpers

2025-05-07 Thread Mattijs Korpershoek
urev > Signed-off-by: Neil Armstrong Reviewed-by: Mattijs Korpershoek > --- > drivers/fastboot/Kconfig | 4 +- > drivers/fastboot/Makefile | 3 +- > drivers/fastboot/fb_mmc.c | 210 > +++--- > 3 files changed, 16 insertions(+), 201 deletions(-) >

Re: [PATCH v2 1/5] boot/image-android: Workaround kernel/ramdisk invalid addr

2025-05-07 Thread Mattijs Korpershoek
Hi George, Thank you for the patch. I really prefer this solution to the one proposed in v1. I have tested this on Khadas VIM3 board (using khadas-vim3_android_defconfig) I have a couple of small remarks below. On lun., mai 05, 2025 at 17:17, George Chan via B4 Relay wrote: > From: George Ch

Re: [PATCH 1/1] doc: describe u-boot-test-release

2025-05-05 Thread Mattijs Korpershoek
Hi Heinrich, Thank you for the patch. On sam., mai 03, 2025 at 12:14, Heinrich Schuchardt wrote: > The scripts u-boot-test-release is called at the end of testing. > Describe it. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Mattijs Korpershoek > --- > doc/deve

Re: [PATCH 1/1] doc: u-boot-test-reset: mention power cycling

2025-05-05 Thread Mattijs Korpershoek
Hi Heinrich, Thank you for the patch. On sam., mai 03, 2025 at 12:12, Heinrich Schuchardt wrote: > Using power cycling is a valid option to implement u-boot-test-reset. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Mattijs Korpershoek > --- > doc/develop/py_testing.r

Re: [PATCH v2 1/1] bootm: improve error message when gzip decompression buffer is too small

2025-04-30 Thread Mattijs Korpershoek
return code from zunzip() instead of overwriting > it with -1 > > By providing clearer hints when decompression fails due to insufficient > buffer size, this change helps users diagnose and fix boot failures more > easily. > > Signed-off-by: Aristo Chen Reviewed-by: M

Re: [PATCH 0/3] u-boot chain-loading LineageOS bootimg

2025-04-30 Thread Mattijs Korpershoek
Hi George, On mer., avril 30, 2025 at 11:58, george chan wrote: > Hi Mattijs, > CC: Casey, > > Thx for your reply. > > > 在 2025年4月29日週二 16:30,Mattijs Korpershoek 寫道: > >> Hi George, >> >> Thank you for contributing. >> >> On lun., av

Re: [PATCH 1/1] boot: let BOOTSTAGE_RECORD_COUNT default to 50

2025-04-30 Thread Mattijs Korpershoek
the default for BOOTSTAGE_RECORD_COUNT to 50. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Mattijs Korpershoek > --- > boot/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/boot/Kconfig b/boot/Kconfig > index fb37d912bc9..2456856a572 100644 &g

Re: [PATCH RFT v2 1/3] fastboot: blk: introduce fastboot block flashing support

2025-04-29 Thread Mattijs Korpershoek
On mar., avril 29, 2025 at 11:45, Dmitrii Merkurev wrote: >> >> Dmitrii, are you okay to re-licence this code under GPL v2 (which is >> common licence for this project) >> > > Yes, I'm ok with that. Fantastic, thanks a lot for answering so quickly!

Re: [PATCH] configs: phycore_am62x_a53_defconfig: Remove CONFIG_SYS_BOOTM_LEN

2025-04-29 Thread Mattijs Korpershoek
e A53 defconfig and use the correct > default config. > > Signed-off-by: Daniel Schultz Reviewed-by: Mattijs Korpershoek > --- > configs/phycore_am62x_a53_defconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/configs/phycore_am62x_a53_defconfig > b/c

Re: [PATCH 0/3] u-boot chain-loading LineageOS bootimg

2025-04-29 Thread Mattijs Korpershoek
Hi George, Thank you for contributing. On lun., avril 28, 2025 at 15:53, Casey Connolly wrote: > Hi George, > > Thanks a lot for the series, it's super exciting to see support for > booting Android on top of U-Boot :D > > On 4/27/25 13:25, George Chan via B4 Relay wrote: >> This is a series o

Re: [PATCH RFT v2 1/3] fastboot: blk: introduce fastboot block flashing support

2025-04-29 Thread Mattijs Korpershoek
On mer., avril 23, 2025 at 09:38, Neil Armstrong wrote: > Hi, > > On 22/04/2025 15:17, Mattijs Korpershoek wrote: >> Hi Neil, >> >> Thank you for the patch. > > Thx for the review > >> >> On mer., avril 09, 2025 at 09:58, neil.armstr...@

[GIT PULL] Please pull u-boot-dfu-20250424 into master

2025-04-24 Thread Mattijs Korpershoek
Hi Tom, Please find the following fixes/developments for master: Usb gadget: - Fix ACM gadget release - Allow ACM gadget restart after releasing it - Add 'enabled' flag to usb_ep structure DFU: - Fix alt buffer clearing for DeveloperBox board CI Job: - https://source.denx.de/u-boot/custodians/u

Re: Maintenance of Python tools

2025-04-23 Thread Mattijs Korpershoek
Hi Simon, On mer., avril 23, 2025 at 06:28, Simon Glass wrote: > Hi Mattijs, > > On Wed, 23 Apr 2025 at 01:07, Mattijs Korpershoek > wrote: >> >> Hi Simon, >> >> On mar., avril 22, 2025 at 17:39, Simon Glass wrote: >> >> > Hi, >> >

Re: (subset) [PATCH 0/5] fix dfu alt buffer clearing

2025-04-23 Thread Mattijs Korpershoek
Hi, On Mon, 07 Apr 2025 19:05:24 +0200, Vincent Stehlé wrote: > This patch series applies the same fix in five different locations (the > detailed description of the fix is in the patches). > > I did validate statically by looking at the assembly before/after for all > five cases, using the follo

Re: [PATCH 0/3] usb: gadget: Fix issues when using f_acm with ci_udc

2025-04-23 Thread Mattijs Korpershoek
Hi, On Mon, 07 Apr 2025 16:59:34 +0200, Stephan Gerhold wrote: > The ACM console does not work properly with ci_udc, it crashes immediately > when setting it up, because usb_ep_disable() is called on an USB endpoint > that was never enabled before. There are also some other issues in f_acm > where

Re: Maintenance of Python tools

2025-04-23 Thread Mattijs Korpershoek
Hi Simon, On mar., avril 22, 2025 at 17:39, Simon Glass wrote: > Hi, > > Tom has indicated that he would like Patman to move out of his tree. I > suggested on another thread[1] that I maintain it in my 'sjg' tree, so > here is a new thread to discuss this. > > I have already done this for the qe

Re: [PATCH RFT v2 1/3] fastboot: blk: introduce fastboot block flashing support

2025-04-22 Thread Mattijs Korpershoek
Hi Neil, Thank you for the patch. On mer., avril 09, 2025 at 09:58, neil.armstr...@linaro.org wrote: > From: Dmitrii Merkurev > > Introduce fastboot block flashing functions and helpers > to be shared with the MMC implementation. > > The write logic comes from the mmc implementation, while > th

Re: [PATCH] cmd: Kconfig: Fix typos

2025-04-22 Thread Mattijs Korpershoek
Hi Aristo, Thank you for the patch. On dim., avril 20, 2025 at 16:12, Aristo Chen wrote: > fix the following typos > - from "categorys" to "categories" > - from "indivdually" to "individually" > > Signed-off-by: Aristo Chen Reviewed-by:

Re: [PATCH RFT v2 0/3] fastboot: add support for generic block flashing

2025-04-17 Thread Mattijs Korpershoek
B:0; And after rebooting the board, we are on the newly flashed bootloader. So, to me: Tested-by: Mattijs Korpershoek I do need some more time to review, though. Thank you for your patience! > --- > Changes in v2: > - Dropped applied virtio erase patch > - Reorganize patches, intro

Re: [PATCH v2] tools/make_pip: Use venv when invoking pip

2025-04-16 Thread Mattijs Korpershoek
On mer., avril 16, 2025 at 16:26, Quentin Schulz wrote: > Hi Mattijs, > > On 4/16/25 4:21 PM, Mattijs Korpershoek wrote: >> Hi Quentin, >> >> Thank you for the review. >> >> On mer., avril 16, 2025 at 14:47, Quentin Schulz >> wrote: >>

Re: [PATCH v2] tools/make_pip: Use venv when invoking pip

2025-04-16 Thread Mattijs Korpershoek
Hi Quentin, Thank you for the review. On mer., avril 16, 2025 at 14:47, Quentin Schulz wrote: > Hi Mattijs, > > On 4/16/25 2:36 PM, Mattijs Korpershoek wrote: >> Recent Ubuntu versions (24.04+) disallow pip by default when >> installing packages. The recommended approac

Re: [PATCH] tools/make_pip: Use virtualenv when invoking pip

2025-04-16 Thread Mattijs Korpershoek
On mer., avril 16, 2025 at 10:25, Mattijs Korpershoek wrote: > Hi Tom, > > On mar., avril 15, 2025 at 11:59, Tom Rini wrote: > >> On Wed, Apr 09, 2025 at 09:46:34AM +0200, Mattijs Korpershoek wrote: >> >>> Recent Ubuntu versions (24.04+) disallow pip by def

[PATCH v2] tools/make_pip: Use venv when invoking pip

2025-04-16 Thread Mattijs Korpershoek
pip script. Note: This has been reported on [1] [1] https://source.denx.de/u-boot/custodians/u-boot-dm/-/issues/37 Signed-off-by: Mattijs Korpershoek --- This has been tested in docker on ubuntu:24.04 after running: $ apt install python3 python3-venv with: $ ./scripts/make_pip.sh u_boot_pylib

Re: [PATCH] tools/make_pip: Use virtualenv when invoking pip

2025-04-16 Thread Mattijs Korpershoek
Hi Tom, On mar., avril 15, 2025 at 11:59, Tom Rini wrote: > On Wed, Apr 09, 2025 at 09:46:34AM +0200, Mattijs Korpershoek wrote: > >> Recent Ubuntu versions (24.04+) disallow pip by default when >> installing packages. The recommended approach is to use a virtualenv >>

  1   2   3   4   5   6   7   8   9   10   >