Re: [PATCH RESEND v2 2/2] usb: udc: Try to clarify an error message

2023-10-02 Thread Massimo Pegorer
Hi Miquel, Il giorno lun 2 ott 2023 alle ore 15:46 Miquel Raynal ha scritto: > > At some point when trying to use USB gadgets, two situations may arise [...cut...] > Signed-off-by: Miquel Raynal > --- > While doing this I really wanted to add "much more" error comments but I > faced another re

[PATCH v2] configs: rockchip: add DOS_PARTITION to RK3308 boards defconfig

2023-10-01 Thread Massimo Pegorer
boards missing of DOS_PARTITION. Reported-by: Jayantajit Gogoi Signed-off-by: Massimo Pegorer --- configs/evb-rk3308_defconfig | 2 +- configs/roc-cc-rk3308_defconfig| 2 +- configs/rock-pi-s-rk3308_defconfig | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configs

Re: [PATCH 2/2] configs: rockchip: add DOS_PARTITION to RK3308 boards defconfig

2023-10-01 Thread Massimo Pegorer
t; so that the mail system know this is a patch set and grab them together. > > > Thanks, > > - Kever > > On 2023/9/3 01:15, Massimo Pegorer wrote: > > Without DOS_PARTITION support U-Boot is not able to boot an OS stored > > into an SD card with MBR partitions tabl

Re: [PATCH v2] dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation : regression

2023-10-01 Thread Massimo Pegorer
Il giorno ven 29 set 2023 alle ore 13:23 Roger Quadros ha scritto: > > > > On 28/09/2023 22:18, Jonas Karlman wrote: > > Hi Roger, > > > > On 2023-09-28 14:59, Roger Quadros wrote: > >> Hi, > >> > >> On 21/08/2023 01:03, Jonas Karlman wrote: > >>> Nodes with bootph-pre-sram/ram props are bound in

Re: [PATCH] pinctrl: Check pinconfig nodes pre-reloc status recursively

2023-09-30 Thread Massimo Pegorer
Hi Simon, Il giorno ven 11 ago 2023 alle ore 02:29 Simon Glass ha scritto: > > Hi Jonas, > > On Sat, 5 Aug 2023 at 08:29, Jonas Karlman wrote: > > > > Hi Massimo, > > > > On 2023-08-05 16:06, Massimo Pegorer wrote: > > > Hi Jonas, > > &g

Re: [PATCH 1/1] binman: doc: Remove incomplete sentence

2023-09-20 Thread Massimo Pegorer
d22 ("binman: add documentation for binman sign option") > > Signed-off-by: Massimo Pegorer > > Signed-off-by: Heinrich Schuchardt > > --- > > tools/binman/binman.rst | 2 -- > > 1 file changed, 2 deletions(-) > > Reviewed-by: Simon Glass Acked-b

Re: Pull request doc-2023-10-rc5-2

2023-09-18 Thread Massimo Pegorer
Hi Heinrich, Il giorno lun 18 set 2023 alle ore 16:12 Tom Rini ha scritto: > > On Sun, Sep 17, 2023 at 02:14:03AM +0200, Heinrich Schuchardt wrote: > > > Dear Tom, > > > > The following changes since commit 252592214f79d8206c3cf0056a8827a0010214e0: > > > > Merge tag 'doc-2023-10-rc5' of > > htt

Re: [PATCH v2 2/2] riscv: dts: starfive: generate u-boot-spl.bin.normal.out

2023-09-17 Thread Massimo Pegorer
Il giorno dom 17 set 2023 alle ore 09:14 Massimo Pegorer ha scritto: > > Il giorno dom 17 set 2023 alle ore 02:01 Heinrich Schuchardt > ha scritto: > > > > > > > > On 9/17/23 00:19, Jonas Karlman wrote: > > > On 2023-09-06 14:00, Heinrich Schuchardt wro

Re: [PATCH v2 2/2] riscv: dts: starfive: generate u-boot-spl.bin.normal.out

2023-09-17 Thread Massimo Pegorer
Il giorno dom 17 set 2023 alle ore 02:01 Heinrich Schuchardt ha scritto: > > > > On 9/17/23 00:19, Jonas Karlman wrote: > > On 2023-09-06 14:00, Heinrich Schuchardt wrote: > >> The StarFive VisionFive 2 board cannot load spl/u-boot-spl.bin but needs a > >> prefixed header. We have referring to a v

Re: Binman how to build using Rockchip BL32 binary as OP-TEE

2023-09-16 Thread Massimo Pegorer
Hi Jonas, Il giorno mer 6 set 2023 alle ore 09:11 Jonas Karlman ha scritto: > > Hi Massimo, > > On 2023-09-06 07:15, Massimo Pegorer wrote: > > Hi Jonas, > > > > Il giorno lun 4 set 2023 alle ore 18:52 Jonas Karlman > > ha scritto: > >> > >&

[PATCH 4/4] spl: atf: Reduce SPL code size

2023-09-16 Thread Massimo Pegorer
Previous fix commit increases code size of a few bytes. This minor rework finally reduces SPL size of about 64-72 bytes (tested with buildman on several aarch64 boards). Signed-off-by: Massimo Pegorer --- common/spl/spl_atf.c | 42 +++--- 1 file changed, 19

[PATCH 3/4] spl: atf: Fix potential but not occurring bug

2023-09-16 Thread Massimo Pegorer
fit_image_get_load() will make current SPL flow to break on loading images, see spl_load_fit_image(), before entering spl_invoke_atf(). Signed-off-by: Massimo Pegorer --- common/spl/spl_atf.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/common/spl/spl_atf.c b

[PATCH 2/4] image: fit: Improve functions description comments

2023-09-16 Thread Massimo Pegorer
Load and entry addresses are returned in ulong variables, which are 32 or 64 bit depending on architecture. Specify that on failure these functions do not set memory pointed by load / entry argument: this detail is relavant for correct functions usage. Signed-off-by: Massimo Pegorer --- boot

[PATCH 1/4] spl: atf: Improve comments and code readability

2023-09-16 Thread Massimo Pegorer
Rename bl31_entry static function to avoid name clash with its first argument. Fix spaces misuse. Describe code accurately: load address is used if getting entry point address fails, and not if addresses differ. Remove not up-to-date comment about BL3-2 usage. Signed-off-by: Massimo Pegorer

[PATCH 0/4] spl: atf: Fix potential bug on getting FIT data

2023-09-16 Thread Massimo Pegorer
bl3x_entry reference to fit_image_get_xxx would be fine. Massimo Pegorer (4): spl: atf: Improve comments and code readability image: fit: Improve functions description comments spl: atf: Fix potential but not occurring bug spl: atf: Reduce SPL code size boot/image-fit.c | 12

[PATCH v2] binman: doc: fix reference tag placement for Logging section

2023-09-13 Thread Massimo Pegorer
Move BinmanLogging reference tag after section "Signing FIT container with private key in an image" and just before section "Logging". Remove meaningless line with incomplete sentence. Fixes: 0f40e23fd22 ("binman: add documentation for binman sign option") Signed-off

Re: [PATCH] binman: doc: fix reference tag placement for Logging section

2023-09-10 Thread Massimo Pegorer
Hi Simon, Heinrich, Il giorno sab 9 set 2023 alle ore 15:52 Massimo Pegorer ha scritto: > > Move BinmanLogging reference tag after section "Signing FIT container > with private key in an image" and just before section "Logging". > > Fixes: 0f40e23fd22 ("b

[PATCH] binman: doc: fix reference tag placement for Logging section

2023-09-09 Thread Massimo Pegorer
Move BinmanLogging reference tag after section "Signing FIT container with private key in an image" and just before section "Logging". Fixes: 0f40e23fd22 ("binman: add documentation for binman sign option") Signed-off-by: Massimo Pegorer --- Note that at the end

[PATCH] expo: Fix documentation reference

2023-09-09 Thread Massimo Pegorer
Fix typo: doc/develop/expo.rst instead of doc/developer/expo.rst Signed-off-by: Massimo Pegorer --- boot/expo_build.c | 6 +++--- include/expo.h| 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/boot/expo_build.c b/boot/expo_build.c index 22f62eb54b..702bf49890 100644

[PATCH v2 2/2] doc: rockchip: Update and improve info on rk3308, TPL and TF-A

2023-09-09 Thread Massimo Pegorer
Update and improve documentation about build steps for SoCs that require using TF-A and TPL binaries provided by Rockchip, such as rk3308. Add rk3308 boards case to rST document. Add ROCK Pi S in the list of supported boards. Minor page format improvements. Signed-off-by: Massimo Pegorer

[PATCH v2 1/2] rockchip: Kconfig: Enable external TPL binary for rk3308

2023-09-09 Thread Massimo Pegorer
There is no support to initialize DRAM on rk3308 SoC using U-Boot TPL or SPL, and therefore an external TPL binary must be used to package a bootable u-boot-rockchip.bin image. Default ROCKCHIP_EXTERNAL_TPL to yes if ROCKCHIP_RK3308. Remove useless TPL_SERIAL. Signed-off-by: Massimo Pegorer

[PATCH v2 0/2] rockchip: Use an external TPL binary on RK3308

2023-09-09 Thread Massimo Pegorer
of TF-A and TPL binaries Massimo Pegorer (2): rockchip: Kconfig: Enable external TPL binary for rk3308 doc: rockchip: Update and improve info on rk3308, TPL and TF-A arch/arm/mach-rockchip/Kconfig | 3 +-- doc/README.rockchip | 10 +--- doc/board/rockchip/rockchip.rst | 43

Re: Binman how to build using Rockchip BL32 binary as OP-TEE

2023-09-05 Thread Massimo Pegorer
Il giorno mar 5 set 2023 alle ore 20:16 Simon Glass ha scritto: > > Hi Jonas, > > On Mon, 4 Sept 2023 at 10:52, Jonas Karlman wrote: > > > > Hi Massimo, > > > > On 2023-09-04 17:05, Massimo Pegorer wrote: > > > Hi, > > > > > >

Re: Binman how to build using Rockchip BL32 binary as OP-TEE

2023-09-05 Thread Massimo Pegorer
Hi Jonas, Il giorno lun 4 set 2023 alle ore 18:52 Jonas Karlman ha scritto: > > Hi Massimo, > > On 2023-09-04 17:05, Massimo Pegorer wrote: > > Hi, > > > > Is there any way for binman to package FIT with U-Boot TF-A and > > OP-TEE, using bl32 binary provi

Re: Binman how to build using Rockchip BL32 binary as OP-TEE

2023-09-05 Thread Massimo Pegorer
Il giorno lun 4 set 2023 alle ore 18:49 Simon Glass ha scritto: > > Hi Massimo, > > On Mon, 4 Sept 2023 at 09:05, Massimo Pegorer > wrote: > > > > Hi, > > > > Is there any way for binman to package FIT with U-Boot TF-A and > > OP-TEE, using bl32 bin

Binman how to build using Rockchip BL32 binary as OP-TEE

2023-09-04 Thread Massimo Pegorer
Hi, Is there any way for binman to package FIT with U-Boot TF-A and OP-TEE, using bl32 binary provided by Rockchip as TEE? I've tried with TEE=/path/to/rkbin/bin/rk33/xxx_bl32_vX.YZ.bin, but binman failed. In my poor understanding of Python code, it seems binman accepts only ELF format or a bina

Re: [PATCH 1/2] rockchip: Use an external TPL binary on RK3308

2023-09-03 Thread Massimo Pegorer
Il giorno sab 2 set 2023 alle ore 18:32 Massimo Pegorer ha scritto: > > There is no support to initialize DRAM on RK3308 SoC using U-Boot > TPL and therefore an external TPL binary must be used to generate > a bootable u-boot-rockchip.bin image. > > Imply ROCKCHIP_EXTERNAL_

Re: [PATCH 2/2] doc: rockchip: Update and complete info about RK3308

2023-09-03 Thread Massimo Pegorer
Hi Johan, Il giorno dom 3 set 2023 alle ore 10:36 Johan Jonker ha scritto: > > > > On 9/2/23 18:32, Massimo Pegorer wrote: > > Update documentation about build steps for RK3308, using an external > > TPL. Add RK3308 case to rST document. Add ROCK Pi S in the list

[PATCH 2/2] configs: rockchip: add DOS_PARTITION to RK3308 boards defconfig

2023-09-02 Thread Massimo Pegorer
DOS_PARTITION. Signed-off-by: Massimo Pegorer --- configs/evb-rk3308_defconfig| 2 +- configs/roc-cc-rk3308_defconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configs/evb-rk3308_defconfig b/configs/evb-rk3308_defconfig index a13a809c1e..c6472a2c9c 100644 --- a

[PATCH 1/2] configs: rockchip: add DOS_PARTITION to rock-pi-s defconfig

2023-09-02 Thread Massimo Pegorer
Without DOS_PARTITION support U-Boot is not able to boot an OS stored into an SD card with MBR partitions table. This is still a quite common case so add DOS_PARTITION (only for U-Boot proper build) to ROCK Pi S defconfig. Reported-by: Jayantajit Gogoi Signed-off-by: Massimo Pegorer

[PATCH 2/2] doc: rockchip: Update and complete info about RK3308

2023-09-02 Thread Massimo Pegorer
Update documentation about build steps for RK3308, using an external TPL. Add RK3308 case to rST document. Add ROCK Pi S in the list of supported boards. Signed-off-by: Massimo Pegorer --- doc/README.rockchip | 4 ++-- doc/board/rockchip/rockchip.rst | 10 ++ 2 files

[PATCH 1/2] rockchip: Use an external TPL binary on RK3308

2023-09-02 Thread Massimo Pegorer
There is no support to initialize DRAM on RK3308 SoC using U-Boot TPL and therefore an external TPL binary must be used to generate a bootable u-boot-rockchip.bin image. Imply ROCKCHIP_EXTERNAL_TPL by default for RK3308 builds. Remove useless TPL_SERIAL. Signed-off-by: Massimo Pegorer --- arch

[PATCH 0/2] rockchip: Use an external TPL binary on RK3308

2023-09-02 Thread Massimo Pegorer
for RK3308. Add ROCK Pi S in the list of supported boards. Massimo Pegorer (2): rockchip: Use an external TPL binary on RK3308 doc: rockchip: Update and complete info about RK3308 arch/arm/mach-rockchip/Kconfig | 2 +- doc/README.rockchip | 4 ++-- doc/board/rockchip

U-Boot logging

2023-08-15 Thread Massimo Pegorer
Hi I had a trip into U-Boot logging and I am quite confused. I read the documentation at doc/develop/logging.rst and had a look at source code in log.h log.c printk.h Kconfig and other files, but the picture is still quite foggy and, let's say, 'complicated'. The documentation does not mention at

Re: Problem upon startup with halted USB device on RaspberryPi 4

2023-08-15 Thread Massimo Pegorer
Il giorno lun 14 ago 2023 alle ore 11:11 Harry Waschkeit < harry.waschk...@conplement.de> ha scritto: > Am 13.08.23 um 19:37 schrieb Michal Suchánek: > > Hello, > > Hi again, > > thanks for your answers! > > > On Sat, Aug 12, 2023 at 08:31:56PM +0200,

Re: Problem upon startup with halted USB device on RaspberryPi 4

2023-08-12 Thread Massimo Pegorer
Hi Harry, Il giorno lun 7 ago 2023 alle ore 11:02 Harry Waschkeit < harry.waschk...@conplement.de> ha scritto: > Hi, > > I have a RaspberryPi 4 where on one USB port a Sierra Wireless LTE > module (EM7455) is attached via an PCIe-to-USB adapter. > The boot image I use gets built by Yocto with the

Re: [PATCH 1/1] lmb: description lmb_is_reserved, lmb_is_reserved_flags

2023-08-12 Thread Massimo Pegorer
Hi, Il giorno sab 12 ago 2023 alle ore 19:49 Heinrich Schuchardt < heinrich.schucha...@canonical.com> ha scritto: > * provide a description for function lmb_is_reserved() > * improve the description of funciton lmb_is_reserved_flags() > > Signed-off-by: Heinrich Schuchardt > --- > include/lmb.h

Re: [PATCH] pinctrl: Check pinconfig nodes pre-reloc status recursively

2023-08-05 Thread Massimo Pegorer
Hi Jonas, Il giorno sab 5 ago 2023 alle ore 13:11 Jonas Karlman ha scritto: > Pinconfig nodes normally bind recursively with PINCTRL_FULL and > PINCONF_RECURSIVE enabled. However, during U-Boot proper pre-relocation > any node marked with e.g. bootph-all will not bind unless its parent is > also

[PATCH 3/3] dts: rockchip: rk3308: Avoid warning for serial probe on prereloc

2023-08-03 Thread Massimo Pegorer
issues). Add to *-u-boot.dtsi all required nodes with the 'bootph-some-ram' attribute. Signed-off-by: Massimo Pegorer --- arch/arm/dts/rk3308-rock-pi-s-u-boot.dtsi | 27 +++ 1 file changed, 27 insertions(+) diff --git a/arch/arm/dts/rk3308-rock-pi-s-u-boot.dtsi b/ar

[PATCH 2/3] clk: rockchip: rk3308: Support reading UART rate and clock registers

2023-08-03 Thread Massimo Pegorer
all cases where UART is not inited by U-Boot proper or by SPL o by TPL code but by a preliminary external boot phase (for Rock PI S, UART is inited by external TPL). Signed-off-by: Massimo Pegorer --- arch/arm/dts/rk3308-rock-pi-s-u-boot.dtsi | 2 - arch/arm/include/asm/arch-rk3308/cru_rk3

[PATCH 1/3] clk: rockchip: rk3308: Fix ordering between masking and shifting

2023-08-03 Thread Massimo Pegorer
As per definitions of masks and shift offsets in cru_rk3308.h, values read from registers must be first masked and then shifted. By the way, this fix is binary invariant, because in all of fixed cases the shift offset is zero. Signed-off-by: Massimo Pegorer --- drivers/clk/rockchip/clk_rk3308.c

[PATCH 0/3] rockchip: rk3308: Fix two minor UART warnings

2023-08-03 Thread Massimo Pegorer
ve 510 MiB) clk_get_rate() returning err=-2 Core: 287 devices, 23 uclasses, devicetree: separate MMC: mmc@ff48: 1, mmc@ff49: 0, mmc@ff4a: 2 Massimo Pegorer (3): clk: rockchip: rk3308: Fix ordering between masking and shifting clk: rockchip: rk3308: Support reading UART rate

[PATCH 2/2] rockchip: spl: Drop out of scope debug message related to uart init

2023-08-02 Thread Massimo Pegorer
Debug uart is no more inited in board_init_f function: remove this debug message from board_init_f. If an earliest-as-possible message after debug uart initialization is needed, enable DEBUG_UART_ANNOUNCE Kconfig option, instead. Signed-off-by: Massimo Pegorer --- arch/arm/mach-rockchip/spl.c

[PATCH 1/2] rockchip: spl: Drop useless call to debug_uart_init

2023-08-02 Thread Massimo Pegorer
Since commit 0dba45864b2a ("arm: Init the debug UART") function debug_uart_init is called in crt files _main before calling board_init_f. Therefore, there is no need to call it again inside board_init_f implementation in arm/mach-rockchip/spl.c. Signed-off-by: Massimo Pegorer --- arc

[PATCH 0/2] Drop useless call to debug_uart_init

2023-08-02 Thread Massimo Pegorer
ge related to debug uart initializazion in board_init_f. If an earliest-as-possible message after debug uart initialization is needed, enable DEBUG_UART_ANNOUNCE Kconfig option, instead. Massimo Pegorer (2): rockchip: spl: Drop useless call to debug_uart_init rockchip: spl: Drop out of s

[PATCH] mkimage: fit: Support signed configurations in 'auto' FITs

2023-01-05 Thread Massimo Pegorer
a useless FIT named unused.itb. mkimage -f auto-conf -d /dev/null -k /folder/with/key-files \ -g keyname -o sha256,rsa4096 -K u-boot.dtb -r unused.itb Signed-off-by: Massimo Pegorer --- The commit includes: patch for adding the new feature to mkimage tool; updated man page, with descri