RE: [PATCH v3] Provide more details of exactly how configuration signatures are calculated

2022-08-03 Thread Martin Bonner
> Signed-off-by: Martin Bonner Does it matter that v3 is signed off by martingreybe...@gmail.com but emailed by martin.bon...@entrust.com? *I* know that they are the same person, but you only have my word for that. (OTOH, you can compare this patch to v2 and see they are the s

Re: Submitting patches

2022-08-03 Thread Martin Bonner
On Wed, 3 Aug 2022 at 19:14, Simon Glass wrote: > Hi Martin, > > On Wed, 3 Aug 2022 at 04:05, Martin Bonner > wrote: > > > > I and my colleagues have a number of patches we would like to > > contribute back to the community, however for various reasons >

[PATCH v3] Provide more details of exactly how configuration signatures are calculated

2022-08-03 Thread Martin Bonner
corporate IT. Please apply with: git am --scissors file.eml -- >8 -- Describe exactly which bytes are hashed and in what order so that external tools can calculate a valid signature. Signed-off-by: Martin Bonner --- doc/uImage.FIT/signature.txt | 26 ++ 1 f

Submitting patches

2022-08-03 Thread Martin Bonner
I and my colleagues have a number of patches we would like to contribute back to the community, however for various reasons (principally operating inside corporate firewalls), it isn't possible to use `git send-email`, and I haven't been able to create a plain text email which is acceptable to `git

Building documentation on Windows

2022-08-03 Thread Martin Bonner
I am trying to build documentation on Windows with `make htmldocs`. In additions to the modules I have installed for building tools (such as fit-check-sign), I have installed pacman -S mingw-w64-x86_64-python-sphinx pacman -S mingw-w64-x86_64-fontconfig pacman -S mingw-w64-x86_64-pytho

Re: [PATCH v4] Improve Windows build documentation

2022-07-27 Thread Martin Bonner
Martin On Wed, 27 Jul 2022 at 15:15, Tom Rini wrote: > On Wed, Jul 27, 2022 at 03:56:07PM +0200, Heinrich Schuchardt wrote: > > On 7/27/22 15:51, Heinrich Schuchardt wrote: > > > On 7/27/22 15:29, Heinrich Schuchardt wrote: > > > > On 7/25/22 09:42, Martin Bonne

Re: [PATCH v4] Improve Windows build documentation

2022-07-27 Thread Martin Bonner
Martin On Wed, 27 Jul 2022 at 14:29, Heinrich Schuchardt wrote: > On 7/25/22 09:42, Martin Bonner wrote: > > * Add three more modules that are required. > > * Remove the version numbers (because they are hard to keep in sync > >with the latest MSYS2 versions) >

[PATCH v2] Provide more details of exactly how configuration signatures are calculated

2022-07-25 Thread Martin Bonner
Describe exactly which bytes are hashed and in what order when signing a configuration. Signed-off-by: Martin Bonner --- doc/uImage.FIT/signature.txt | 26 ++ 1 file changed, 26 insertions(+) diff --git a/doc/uImage.FIT/signature.txt b/doc/uImage.FIT/signature.txt index

[PATCH v4] Improve Windows build documentation

2022-07-25 Thread Martin Bonner
* Add three more modules that are required. * Remove the version numbers (because they are hard to keep in sync with the latest MSYS2 versions) * Add a pacman command line to install everything. Signed-off-by: Martin Bonner --- doc/build/tools.rst | 22 ++ 1 file changed

[PATCH v3] Improve Windows build documentation

2022-07-25 Thread Martin Bonner
* Add three more modules that are required. * Remove the version numbers (because they are hard to keep in sync with the latest MSYS2 versions) * Add a pacman command line to install everything. Signed off by: Martin Bonner --- doc/build/tools.rst | 22 ++ 1 file changed

[PATCH v2] Improve Windows build documentation

2022-07-20 Thread Martin Bonner
x27;d be grateful if @Bin Meng could review this, because `git blame` says the file I am changing is all his. No actual changes, but hopefully closer to the required formalities: Signed-off-by: Martin Bonner commit e3615603d919ab19fddbee4a68e8a37b91a75f3e (HEAD -> better-windows-build-doc) Author:

Re: [PATCH] Provide more details of exactly how configuration signatures are calculated

2022-07-20 Thread Martin Bonner
;[Patch v2] ..."? I will hold off submitting that in case there are other comments that need to be addressed. Martin On Wed, 20 Jul 2022 at 08:23, Martin Bonner wrote: > > There are a couple of uncertainties still remaining: > - The "hashed-nodes" property is created by mkimage

Re: [PATCH] Provide more details of exactly how configuration signatures are calculated

2022-07-20 Thread Martin Bonner
.) Martin On Wed, 20 Jul 2022 at 08:14, Martin Bonner wrote: > > I have just spent a week reverse-engineering this, so I thought I'd > contribute the work back to the community > > diff --git a/doc/uImage.FIT/signature.txt b/doc/uImage.FIT/signature.txt > index 61a72db3

[PATCH] Provide more details of exactly how configuration signatures are calculated

2022-07-20 Thread Martin Bonner
I have just spent a week reverse-engineering this, so I thought I'd contribute the work back to the community diff --git a/doc/uImage.FIT/signature.txt b/doc/uImage.FIT/signature.txt index 61a72db3c7..61cdd55e40 100644 --- a/doc/uImage.FIT/signature.txt +++ b/doc/uImage.FIT/signature.txt @@ -382,6

[PATCH] Improve Window's build documentation

2022-07-19 Thread Martin Bonner
libuuid-devel git + +The MSYS2 installer tested is http://repo.msys2.org/distrib/x86_64/msys2-x86_64-20190524.exe. There are 3 MSYS subsystems installed: MSYS2, MinGW32 and MinGW64. Each Martin Bonner

Re: [PATCH 1/7] doc: Migrate CodingStyle wiki page to Sphinx

2022-07-11 Thread Martin Bonner
On // comments: a) I thought I had read recently that they are now accepted. b) Can we stop calling them "C++ style"? They have been legal in standard C for all of this millennium! There are university graduates who were born after // comments became legal in standard C. c) If we don't currently

Re: [PATCH 4/4] doc: Migrate Process wiki page to sphinx

2022-07-08 Thread Martin Bonner
Martin On Fri, 8 Jul 2022 at 08:06, Claudius Heine wrote: > Hi Tom, > > On 2022-06-27 19:17, Tom Rini wrote: > > Move the current Process wiki page to doc/develop/process.rst. The > > changes here are for formatting or slight rewording so that it reads > > well when linking to other sphinx doc

Re: fit_check_sig not hashing everything.

2022-07-08 Thread Martin Bonner
On Thu, 7 Jul 2022 at 17:29, Martin Bonner wrote: > I have a 30MB FIT image as input, and I have added some debug to > hash_calculate in rsa-checksum.c to print the amount of data being hashed. > The answer is a rather scary "1106 bytes"! ... > > Can anyone clarify wh

fit_check_sig not hashing everything.

2022-07-07 Thread Martin Bonner
I am running fit_check_sig on windows to understand in more details how it works. What I really want, is a _precise_ description of exactly which bytes of a FIT image are fed into the hash function (and in which order) in order to calculate the hash value. I then want to reproduce that hash funct

Re: [PATCH v6 00/25] Add support for MediaTek MT7621 SoC - v6

2022-07-07 Thread Martin Bonner
FYI, Gmail marked this as Spam - no idea why! Martin On Thu, 7 Jul 2022 at 02:48, Weijie Gao (高惟杰) wrote: > Hi Daniel, > > I've tested these changes and they work fine on both NOR and NAND boards. > > Best Regards, > Weijie > > -邮件原件- > 发件人: Daniel Schwierzeck > 发送时间: 2022年7月7日 6:12 >

Building host tools on Windows

2022-07-04 Thread Martin Bonner
I am trying to build the host tools on Windows, and I have hit a road block. Specifically, I get the output: HOSTCC tools/mkeficapsule tools/mkeficapsule.c:18:10: fatal error: uuid/uuid.h: No such file or directory 18 | #include Steps so far: Download latest msys Double upgrade with "pacma