Re: [U-Boot, v3, 1/1] misc: fs_loader: Add request_firmware_into_buf_via_script() for flexible firmware loading via U-Boot script

2025-07-29 Thread Marek Vasut
On 7/29/25 4:51 PM, Lucien.Jheng wrote: [...] +int request_firmware_into_buf_via_script(void **buf, size_t max_size, + const char *script_name) +{ [...] + *buf = (void *)memdup((void *)addr, size); + if (!*buf) { + log_err("Fail

Re: [PATCH 01/10] ARM: stm32: Add STM32MP13xx SPL Kconfig options

2025-07-28 Thread Marek Vasut
On 6/29/25 9:08 PM, Marek Vasut wrote: Hi, diff --git a/arch/arm/mach-stm32mp/Kconfig.13x b/arch/arm/mach- stm32mp/Kconfig.13x index bc8b3f8cf77..cecf9e3b8c7 100644 --- a/arch/arm/mach-stm32mp/Kconfig.13x +++ b/arch/arm/mach-stm32mp/Kconfig.13x @@ -20,7 +20,8 @@ config TARGET_ST_STM32MP13X

Re: [PATCH] reset: stm32: Fix header misuse

2025-07-28 Thread Marek Vasut
eviewed-by: Patrice Chotard Thanks Patrice I double checked, in fact for AARCH64, i am using aarch64-none-elf-gcc (GNU Toolchain for the A-profile Architecture 10.3-2021.07 (arm-10.29)) 10.3.1 20210621 which is out of date. 2025.10-rc1 is now out, this is still broken. -- Best regards, Marek Vasut

[PATCH] ARM: imx6: dh-imx6: Enable USB OTG ID pin pull up in SPL

2025-07-28 Thread Marek Vasut
Enable SoC pull up for USB OTG ID pin in SPL. There is no dedicated pull up resistor on the SoM itself, and the pull up is mandatory for correct USB OTG ID pin detection. U-Boot proper already configures the USB OTG ID pin pull up via DT pinctrl node entry. Signed-off-by: Marek Vasut --- Cc

Re: [U-Boot, v2, 1/1] misc: fs_loader: Add request_firmware_into_buf_via_script() for flexible firmware loading via U-Boot script

2025-07-28 Thread Marek Vasut
On 7/28/25 8:08 PM, Frank Wunderlich wrote: Am 28. Juli 2025 18:34:01 MESZ schrieb "Lucien.Jheng" : Marek Vasut 於 2025/7/27 下午 10:46 寫道: On 7/27/25 4:16 PM, Lucien.Jheng wrote: This commit introduces a new API, request_firmware_into_buf_via_script(), to the fs_loader framework. Thi

Re: [U-Boot, v2, 1/1] misc: fs_loader: Add request_firmware_into_buf_via_script() for flexible firmware loading via U-Boot script

2025-07-27 Thread Marek Vasut
On 7/27/25 4:16 PM, Lucien.Jheng wrote: This commit introduces a new API, request_firmware_into_buf_via_script(), to the fs_loader framework. This function allows firmware to be loaded into memory using a user-defined U-Boot script, providing greater flexibility for firmware loading scenarios tha

Re: [PATCH] clk: renesas: Do not test unsigned variable to be less than 0

2025-07-24 Thread Marek Vasut
alue as an int so the code can behave as expected. Also remove initial values from 'value' and 'div' as they are not needed. This issue was found by Smatch. Signed-off-by: Andrew Goodbody Reviewed-by: Marek Vasut Thanks !

Re: [PATCH] mtd: spi-nor-ids: Add support for Winbond W77Q51NW

2025-07-22 Thread Marek Vasut
On 7/22/25 11:20 AM, Tudor Ambarus wrote: On 7/20/25 8:58 PM, Marek Vasut wrote: Add IDs for Winbond W77Q51NW, 512M-bit Secure Serial Flash Memory with Post-Quantum Cryptography, Dual/Quad SPI, QPI and DTR . The flash part is similar to W25Q512NWM . Signed-off-by: Marek Vasut --- Cc: Jagan

Re: [PATCH] net: phy: Support overriding Auto Negotiation timeout with env variable

2025-07-22 Thread Marek Vasut
On 7/22/25 8:05 AM, Siddharth Vadapalli wrote: The Auto Negotiation procedure between two Ethernet PHYs consists of determining the best commonly supported parameters among Speed, Duplex Mode and Flow Control. The time taken for this procedure is not only dependent on the local PHY used, but als

Re: [PATCH 2/3] image: Add support for starting TFA BL31 as fitImage loadables

2025-07-21 Thread Marek Vasut
On 1/29/25 6:51 PM, Quentin Schulz wrote: This would need to be added to the ITS spec, c.f. https:// fitspec.osfw.foundation/ Where does one do that ? https://github.com/open-source-firmware/flat-image-tree I guess? Thank you for adding the entry.

Re: Aw: [U-Boot, v3, 1/1]net: phy: Add the Airoha EN8811H PHY driver

2025-07-21 Thread Marek Vasut
On 7/21/25 5:26 PM, fran...@public-files.de wrote: Hi Gesendet: Sonntag, 20. Juli 2025 um 14:28 Von: "Lucien.Jheng" Betreff: [U-Boot, v3, 1/1]net: phy: Add the Airoha EN8811H PHY driver Add the driver for the Airoha EN8811H 2.5 Gigabit PHY. The PHY supports 100/1000/2500 Mbps with auto negoti

Re: [PATCH] mtd: spi-nor-ids: Add support for Winbond W77Q51NW

2025-07-21 Thread Marek Vasut
On 7/21/25 2:03 PM, Prasanth Mantena wrote: Hi, diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c index e7e97780d7c..0383175beb5 100644 --- a/drivers/mtd/spi/spi-nor-ids.c +++ b/drivers/mtd/spi/spi-nor-ids.c @@ -591,6 +591,7 @@ const struct flash_info spi_nor_ids[] = {

Re: [PATCH] RZ/A1 Genmai SDRAM setup prototype

2025-07-20 Thread Marek Vasut
On 7/11/25 9:35 AM, Magnus Damm wrote: Hello Magnus, sorry for the late reply. Here's a hack that adds SDRAM setup code to the r7s72100 Genmai board. Might be useful in case someone wants to boot Linux on the Genmai board. Before merge a few unclear points remain: - How to make best use of

Re: [PATCH] net: sh_eth: Cleanup the driver to remove most

2025-07-20 Thread Marek Vasut
On 7/11/25 2:39 PM, Magnus Damm wrote: Hello Magnus, sorry for the late reply. Would it be possible to split this change into multiple easier-to-review patches ? --- 0004/drivers/net/sh_eth.c +++ work/drivers/net/sh_eth.c 2025-07-11 20:31:22.438699670 +0900 @@ -29,6 +29,8 @@ #include

Re: [PATCH v2] configs: Remove redundant CONFIG_TEXT_BASE assignments for Renesas defconfigs

2025-07-20 Thread Marek Vasut
On 7/17/25 12:52 PM, Prabhakar wrote: From: Lad Prabhakar The Renesas board defconfigs explicitly set CONFIG_TEXT_BASE=0x5000, however U-Boot's POSITION_INDEPENDENT=y build default already places text at 0x0. These hardcoded overrides are therefore unnecessary and will be pruned automatical

Re: [U-Boot, v1, 1/1] misc: fs_loader: Add request_firmware_into_buf_via_env API for environment-based firmware loading

2025-07-20 Thread Marek Vasut
On 7/20/25 5:04 PM, Lucien.Jheng wrote: This commit adds request_firmware_into_buf_via_env() to the fs_loader driver, enabling firmware loading into a buffer using environment variables for path and size. It supports multiple entries via indexed variable names (e.g., "fw_dir0", "fw_size0"). This

Re: [PATCH v3 7/9] net: sh_eth: Adjust RZ/A1, add RZ/A2 support

2025-07-20 Thread Marek Vasut
On 7/7/25 7:03 PM, Magnus Damm wrote: Hello Magnus, I'm sorry for the late reply. +++ work/drivers/net/sh_eth.c 2025-07-05 17:45:07.333754799 +0900 @@ -144,10 +144,10 @@ static int sh_eth_reset(struct sh_eth_in { #if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ) int ret =

[PATCH 1/2] arm64: dts: renesas: r8a779g3: Describe generic SPI NOR support on Retronix R-Car V4H Sparrow Hawk board

2025-07-20 Thread Marek Vasut
Retronix R-Car V4H Sparrow Hawk EVTA1 is populated with Spansion S25FS512S, EVTB1 is populated with Winbond W77Q51NW. Describe the SPI NOR using generic "spi-flash" compatible, because both flashes can be auto-detected based on their built-in IDs. Signed-off-by: Marek Vasut --- Cc

[PATCH 2/2] arm64: renesas: r8a779g3: Enable Winbond SPI NOR support on Retronix R-Car V4H Sparrow Hawk board

2025-07-20 Thread Marek Vasut
Enable support for Winbond SPI NOR on Retronix R-Car V4H Sparrow Hawk board, this is required to support W77Q51NW on new board revision EVTB1 operational. Signed-off-by: Marek Vasut --- Cc: Nobuhiro Iwamatsu Cc: Tom Rini Cc: u-boot@lists.denx.de --- configs/r8a779g3_sparrowhawk_defconfig | 1

[PATCH] mtd: spi-nor-ids: Add support for Winbond W77Q51NW

2025-07-20 Thread Marek Vasut
Add IDs for Winbond W77Q51NW, 512M-bit Secure Serial Flash Memory with Post-Quantum Cryptography, Dual/Quad SPI, QPI and DTR . The flash part is similar to W25Q512NWM . Signed-off-by: Marek Vasut --- Cc: Jagan Teki Cc: Nobuhiro Iwamatsu Cc: Takahiro Kuwano Cc: Tom Rini Cc: Tudor Ambarus Cc

Re: [U-Boot, v1, 1/1] misc: fs_loader: Add request_firmware_into_buf_via_env API for environment-based firmware loading

2025-07-20 Thread Marek Vasut
On 7/20/25 5:31 PM, Heinrich Schuchardt wrote: Am 20. Juli 2025 17:04:04 MESZ schrieb "Lucien.Jheng" : This commit adds request_firmware_into_buf_via_env() to the fs_loader driver, enabling firmware loading into a buffer using environment variables for path and size. It supports multiple entries

Re: [PATCH] configs: renesas: Set CONFIG_TEXT_BASE to 0x0 for R-Car Gen3 PIE builds

2025-07-15 Thread Marek Vasut
On 7/15/25 4:49 PM, Lad, Prabhakar wrote: Hi Tom, On Tue, Jul 15, 2025 at 3:31 PM Tom Rini wrote: On Tue, Jul 15, 2025 at 12:11:03PM +0100, Prabhakar wrote: From: Lad Prabhakar For Renesas R-Car Gen3 platforms with CONFIG_POSITION_INDEPENDENT enabled, override CONFIG_TEXT_BASE to 0x0 in ea

[PULL] u-boot-sh/master

2025-07-10 Thread Marek Vasut
+0200) Magnus Damm (2): ARM: renesas: Put common r7s72100 code in board/renesas/common ARM: renesas: Add support for the r7s72100 Genmai board Marek Vasut (14): arm64: renesas: Convert SCIF SREC from u-boot-spl.bin

Re: [PATCH v3 9/9] ARM: renesas: Add RZ/A2 RZA2MBTC board support

2025-07-07 Thread Marek Vasut
patch please . libs-y += boot/ libs-$(CONFIG_CMDLINE) += cmd/ libs-y += common/ [...] -- Best regards, Marek Vasut

Re: [PATCH v3 8/9] ARM: renesas: Add RZ/A2 GR-Mango board support

2025-07-07 Thread Marek Vasut
Please add symbolic names (introduce macros) for those registers here. + return 0; +} [...] -- Best regards, Marek Vasut

Re: [PATCH v3 7/9] net: sh_eth: Adjust RZ/A1, add RZ/A2 support

2025-07-07 Thread Marek Vasut
On 7/6/25 1:29 PM, Magnus Damm wrote: +++ work/drivers/net/sh_eth.c 2025-07-05 17:45:07.333754799 +0900 @@ -144,10 +144,10 @@ static int sh_eth_reset(struct sh_eth_in { #if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ) int ret = 0, i; - Does something like this ... if (

Re: [PATCH v3 6/9] spi: renesas_rpc_spi: Add RZ/A2 SPI Multi I/O support

2025-07-07 Thread Marek Vasut
On 7/6/25 1:29 PM, Magnus Damm wrote: +++ work/drivers/spi/Kconfig2025-07-05 03:07:38.660458220 +0900 @@ -432,12 +432,12 @@ config SPI_QUP config RENESAS_RPC_SPI bool "Renesas RPC SPI driver" - depends on RCAR_64 || RZA1 + depends on RCAR_64 || RZA1 || RZA2

Re: [PATCH v3 3/9] ARM: renesas: Add RZ/A2 support

2025-07-07 Thread Marek Vasut
Burst ON, Length=2, Flush cache */ + + /* Enable all internal RAM */ + write8 SYSCR1, 0xFF + write8 SYSCR2, 0xFF + write8 SYSCR3, 0x0F + dummy_read8 SYSCR3 Can any of this be converted into s_init() (early init) C code ? -- Best regards, Marek Vasut

Re: [PATCH v2 0/2] Initial r7s72100 Genmai board support

2025-07-07 Thread Marek Vasut
On 7/2/25 7:13 PM, Magnus Damm wrote: Initial r7s72100 Genmai board support (V2) [PATCH v2 1/2] ARM: renesas: Put common r7s72100 code in board/renesas/common [PATCH v2 2/2] ARM: renesas: Add support for the r7s72100 Genmai board These two patches for U-Boot aim at adding initial support for th

Re: [PATCH] pinctrl: renesas: Initial RZ/A2 R7S9210 support

2025-07-07 Thread Marek Vasut
+DECLARE_GLOBAL_DATA_PTR; See comment in r7s9210_pfc_set_state() below. +struct r7s9210_pfc_plat { + void __iomem*base; +}; + +static void r7s9210_pfc_set_function(struct udevice *dev, u8 port, u8 pin, u8 func) +{ + struct r7s9210_pfc_plat *plat = dev_get_plat(dev); + u1

Re: [PATCH] serial: sh: Initial RZ/A2 R7S9210 support

2025-07-07 Thread Marek Vasut
On 7/1/25 8:16 AM, Magnus Damm wrote: From: Magnus Damm Add SCIF support for RZ/A2 r7s9210 including a work around to prevent the driver from hanging on boot due to TEND flag handling. Signed-off-by: Magnus Damm Reviewed-by: Marek Vasut Thank you

Re: [PATCH] ARM: renesas: Split common RZ/A1 and GR-PEACH defconfigs

2025-07-07 Thread Marek Vasut
On 7/2/25 3:11 PM, Magnus Damm wrote: Hi Marek, On Mon, Jun 30, 2025 at 8:52 PM Marek Vasut wrote: Split the RZ/A1 GR-PEACH defconfig into board-specific defconfig and common RZ/A1 SoC defconfig. This is a preparatory patch for new RZ/A1 boards, no functional change. Signed-off-by: Marek

[PATCH v2] ARM: renesas: Split common RZ/A1 and GR-PEACH defconfigs

2025-07-07 Thread Marek Vasut
Split the RZ/A1 GR-PEACH defconfig into board-specific defconfig and common RZ/A1 SoC defconfig. This is a preparatory patch for new RZ/A1 boards, no functional change. Signed-off-by: Marek Vasut --- Cc: Magnus Damm Cc: Marek Vasut Cc: Nobuhiro Iwamatsu Cc: Paul Barker Cc: Tom Rini Cc: u

Re: [PATCH] makefile: Adjust distclean to remove .binman_stamp file

2025-07-07 Thread Marek Vasut
On 7/2/25 3:34 PM, Magnus Damm wrote: From: Magnus Damm Remove the .binman_stamp file during distclean Signed-off-by: Magnus Damm --- On top of cbb5672790d400e9ec6e9fceaf89ece2660c0117 (origin/next) Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- 0001/Makefile ++

Re: [PATCH 1/2] Put common r7s72100 code in board/renesas/common

2025-06-30 Thread Marek Vasut
and patch [2] , so u-boot/next with [1] and [2] applied would be ideal. Thank you [1] https://patchwork.ozlabs.org/project/uboot/list/?series=463012 [2] https://patchwork.ozlabs.org/project/uboot/list/?series=463013 -- Best regards, Marek Vasut

[PATCH] ARM: renesas: Split common RZ/A1 and GR-PEACH defconfigs

2025-06-30 Thread Marek Vasut
Split the RZ/A1 GR-PEACH defconfig into board-specific defconfig and common RZ/A1 SoC defconfig. This is a preparatory patch for new RZ/A1 boards, no functional change. Signed-off-by: Marek Vasut --- Cc: Magnus Damm Cc: Marek Vasut Cc: Nobuhiro Iwamatsu Cc: Paul Barker Cc: Tom Rini Cc: u

[PATCH 8/8] arm: renesas: configs: Drop deprecated comments

2025-06-30 Thread Marek Vasut
Remove various deprecated code comments, no functional change. Signed-off-by: Marek Vasut --- Cc: Heinrich Schuchardt Cc: Joe Hershberger Cc: Masakazu Mochizuki Cc: Nobuhiro Iwamatsu Cc: Ramon Fried Cc: Simon Glass Cc: Tom Rini Cc: u-boot@lists.denx.de --- include/configs/alt.h | 2

[PATCH 7/8] net: sh_eth: arm: renesas: README: Drop CFG_SH_ETHER_PHY_MODE

2025-06-30 Thread Marek Vasut
Drop CFG_SH_ETHER_PHY_MODE from configuration files, this value is never used. No functional change intended. Signed-off-by: Marek Vasut --- Cc: Heinrich Schuchardt Cc: Joe Hershberger Cc: Masakazu Mochizuki Cc: Nobuhiro Iwamatsu Cc: Ramon Fried Cc: Simon Glass Cc: Tom Rini Cc: u-boot

[PATCH 6/8] net: sh_eth: arm: renesas: README: Drop CFG_SH_ETHER_PHY_ADDR

2025-06-30 Thread Marek Vasut
Drop CFG_SH_ETHER_PHY_ADDR from README and configuration files, this value is never used, PHY address is extracted from control DT instead. No functional change intended. Signed-off-by: Marek Vasut --- Cc: Heinrich Schuchardt Cc: Joe Hershberger Cc: Masakazu Mochizuki Cc: Nobuhiro Iwamatsu

[PATCH 4/8] net: sh_eth: arm: renesas: README: Drop CFG_SH_ETHER_CACHE_*

2025-06-30 Thread Marek Vasut
. CFG_SH_ETHER_ALIGNE_SIZE now set as SH_ETHER_ALIGN_SIZE in sh_eth.h based on architecture and no longer configured on board level. Remove CFG_SH_ETHER_CACHE_WRITEBACK configuration option from README. Signed-off-by: Marek Vasut --- Cc: Heinrich Schuchardt Cc: Joe Hershberger Cc: Masakazu Mochizuki Cc

[PATCH 3/8] net: sh_eth: Convert cache operations to static functions

2025-06-30 Thread Marek Vasut
driver is only used on 32bit and 64bit ARM, which both have those operations. The CFG_SH_ETHER_ALIGNE_SIZE is converted to SH_ETHER_ALIGN_SIZE and defined as either 64 on ARM or 16 on SH. Signed-off-by: Marek Vasut --- Cc: Heinrich Schuchardt Cc: Joe Hershberger Cc: Masakazu Mochizuki Cc

[PATCH 5/8] net: sh_eth: Drop phy_addr assignment

2025-06-30 Thread Marek Vasut
Drop unused struct sh_eth_info *port_info .phy_addr member assignment. PHY address is extracted from control DT. No functional change intended. Signed-off-by: Marek Vasut --- Cc: Heinrich Schuchardt Cc: Joe Hershberger Cc: Masakazu Mochizuki Cc: Nobuhiro Iwamatsu Cc: Ramon Fried Cc: Simon

[PATCH 1/8] net: sh_eth: Pass struct port_info around

2025-06-30 Thread Marek Vasut
sh_eth_dev entirely. Handling of multiple ports should be done by U-Boot DM and multiple per-driver-instance private data. No functional change intended. Signed-off-by: Marek Vasut --- Cc: Heinrich Schuchardt Cc: Joe Hershberger Cc: Masakazu Mochizuki Cc: Nobuhiro Iwamatsu Cc: Ramon Fried Cc

[PATCH 2/8] net: sh_eth: arm: renesas: README: Drop CFG_SH_ETHER_USE_PORT

2025-06-30 Thread Marek Vasut
The CFG_SH_ETHER_USE_PORT configuration option is a remnant from before U-Boot DM existed and SH Ethernet made full use of it, and is no longer used, remove it. Signed-off-by: Marek Vasut --- Cc: Heinrich Schuchardt Cc: Joe Hershberger Cc: Masakazu Mochizuki Cc: Nobuhiro Iwamatsu Cc: Ramon

Re: [PATCH v2 2/2] spl: fit: Add ability to jump to Linux via OpTee-OS on ARMv7a

2025-06-30 Thread Marek Vasut
On 6/30/25 4:30 PM, Jerome Forissier wrote: Hi, On 6/30/25 02:08, Marek Vasut wrote: Add support for jumping to Linux kernel through OpTee-OS on ARMv7a to SPL. Nitpicking: OP-TEE OS Is this the official spelling ? I was always under the impression it was OpTee-OS . but maybe I am wrong .

Re: [PATCH] reset: stm32: Fix header misuse

2025-06-30 Thread Marek Vasut
On 6/30/25 8:17 AM, Patrice CHOTARD wrote: diff --git a/drivers/reset/stm32/stm32-reset.c b/drivers/reset/stm32/stm32-reset.c index 975f67f712a..918e81e588f 100644 --- a/drivers/reset/stm32/stm32-reset.c +++ b/drivers/reset/stm32/stm32-reset.c @@ -5,7 +5,7 @@ */ #include -#include +#

[PATCH v2 08/10] ARM: dts: stm32: Add STM32MP13x SPL specific DT additions

2025-06-29 Thread Marek Vasut
having to rely on PSCI call. Reviewed-by: Patrice Chotard Signed-off-by: Marek Vasut --- Cc: Cheick Traore Cc: Fabrice Gasnier Cc: Gatien Chevallier Cc: Lionel Debieve Cc: Pascal Zimmermann Cc: Patrice Chotard Cc: Patrick Delaunay Cc: Simon Glass Cc: Sughosh Ganu Cc: Tom Rini Cc: u-b

[PATCH v2 09/10] ARM: dts: stm32: Add SPL specifics for DH STM32MP13xx DHCOR DHSBC

2025-06-29 Thread Marek Vasut
to prevent interference from TFABOOT specific configuration, and RCC configuration to define clock tree configuration used by this platform. Reviewed-by: Patrice Chotard Signed-off-by: Marek Vasut --- Cc: Cheick Traore Cc: Fabrice Gasnier Cc: Gatien Chevallier Cc: Lionel Debieve Cc: Pascal

[PATCH v2 07/10] ARM: dts: stm32: Add 512 MiB DRAM settings for DH STM32MP13xx DHCOR DHSBC

2025-06-29 Thread Marek Vasut
Add DRAM settings for 512 MiB of DRAM variant of DH STM32MP13xx DHCOR DHSBC. Reviewed-by: Patrice Chotard Signed-off-by: Marek Vasut --- Cc: Cheick Traore Cc: Fabrice Gasnier Cc: Gatien Chevallier Cc: Lionel Debieve Cc: Pascal Zimmermann Cc: Patrice Chotard Cc: Patrick Delaunay Cc: Simon

[PATCH v2 10/10] ARM: dts: stm32: Switch defconfig to SPL for DH STM32MP13xx DHCOR DHSBC

2025-06-29 Thread Marek Vasut
STM32MP15xx DHSOM defconfigs. Changes to STM32MP13xx DHCOR defconfig then enable SPL support, CCF in SPL to configure clock, pin configuration support in SPL, and OpTee OS start support in U-Boot. Reviewed-by: Patrice Chotard Signed-off-by: Marek Vasut --- Cc: Cheick Traore Cc: Fabrice Gasnier

[PATCH v2 06/10] ARM: dts: stm32: Add stm32mp13-ddr.dtsi template

2025-06-29 Thread Marek Vasut
Factor out common parts of STM32MP15xx DRAM controller configuration DT description into stm32mp1-ddr.dtsi and introduce stm32mp13-ddr.dtsi which describes STM32MP13xx DRAM controller configuration in DT. Reviewed-by: Patrice Chotard Signed-off-by: Marek Vasut --- Cc: Cheick Traore Cc: Fabrice

[PATCH v2 05/10] ARM: stm32: Add STM32MP13xx debug UART initialization

2025-06-29 Thread Marek Vasut
Add default STM32MP13xx debug UART initialization. This is similar to STM32MP15xx debug UART initialization, except the RCC registers are at different offsets and the UART pinmux pins are different. Reviewed-by: Patrice Chotard Reviewed-by: Patrick Delaunay Signed-off-by: Marek Vasut --- Cc

[PATCH v2 03/10] ARM: stm32: Limit early cache enablement in SPL to STM32MP15xx

2025-06-29 Thread Marek Vasut
-by: Marek Vasut --- Cc: Cheick Traore Cc: Fabrice Gasnier Cc: Gatien Chevallier Cc: Lionel Debieve Cc: Pascal Zimmermann Cc: Patrice Chotard Cc: Patrick Delaunay Cc: Simon Glass Cc: Sughosh Ganu Cc: Tom Rini Cc: u-b...@dh-electronics.com Cc: u-boot@lists.denx.de Cc: uboot-st...@st-md

[PATCH v2 04/10] ARM: stm32: Add STM32MP13xx PMIC initialization for DDR3 DRAM type

2025-06-29 Thread Marek Vasut
The STM32MP13xx PMIC initialization for DDR3 DRAM type is similar to the STM32MP15xx PMIC initialization, except the VTT rail is not enabled. Fill in the STM32MP13xx support. Reviewed-by: Patrice Chotard Signed-off-by: Marek Vasut --- Cc: Cheick Traore Cc: Fabrice Gasnier Cc: Gatien

[PATCH v2 02/10] ARM: stm32: Add STM32MP13xx SPL hardware initialization

2025-06-29 Thread Marek Vasut
Add hardware initialization for the STM32MP13xx in SPL. This is similar to STM32MP15xx except the code has to enable MCE to bring DRAM controller up later. Reviewed-by: Patrice Chotard Signed-off-by: Marek Vasut --- Cc: Cheick Traore Cc: Fabrice Gasnier Cc: Gatien Chevallier Cc: Lionel

[PATCH v2 01/10] ARM: stm32: Add STM32MP13xx SPL Kconfig options

2025-06-29 Thread Marek Vasut
Introduce Kconfig options used by SPL on STM32MP13xx and isolate the Kconfig options only used in case TFA BL2 is used as a SPL behind CONFIG_TFABOOT dependency. Reviewed-by: Patrice Chotard Signed-off-by: Marek Vasut --- Cc: Cheick Traore Cc: Fabrice Gasnier Cc: Gatien Chevallier Cc: Lionel

[PATCH] reset: stm32: Fix header misuse

2025-06-29 Thread Marek Vasut
The stm32-reset-core.h is located in drivers/reset/stm32/ , it has to be included using "stm32-reset-core.h" and not , otherwise the build fails. Fix it. Fixes: 0994a627c278 ("reset: stm32mp25: add stm32mp25 reset driver") Signed-off-by: Marek Vasut --- Cc: Gabriel Fe

[PATCH v2 2/2] spl: fit: Add ability to jump to Linux via OpTee-OS on ARMv7a

2025-06-29 Thread Marek Vasut
-Boot fitImage jump code to start OpTee-OS first and jump to Linux next. Signed-off-by: Marek Vasut --- Cc: Heinrich Schuchardt Cc: Ilias Apalodimas Cc: Janne Grunau Cc: Mattijs Korpershoek Cc: Patrick Rudolph Cc: Sam Edwards Cc: Simon Glass Cc: Tom Rini Cc: u-boot@lists.denx.de --- V2

[PATCH v2 1/2] ARM: bootm: Add support for starting Linux through OpTee-OS on ARMv7a

2025-06-29 Thread Marek Vasut
(). The boot_jump_linux_via_optee() also includes STM32MP13xx late TZC configuration write, this cannot be moved easily, hence the ifdef. Signed-off-by: Marek Vasut --- Cc: Heinrich Schuchardt Cc: Ilias Apalodimas Cc: Janne Grunau Cc: Mattijs Korpershoek Cc: Patrick Rudolph Cc: Sam Edwards Cc

Re: [U-Boot, v2, 1/1] net: phy: Add the Airoha EN8811H PHY driver

2025-06-29 Thread Marek Vasut
On 6/29/25 6:10 PM, Lucien.Jheng wrote: Hi, I'm sorry for my abysmally slow response. +config PHY_AIROHA_FW_IN_MMC +    bool "Airoha firmware in MMC partition" +    help +  Airoha PHYs use firmware which can be loaded automatically +  from storage directly attached to the PHY, and then

Re: [PATCH 09/10] ARM: dts: stm32: Add SPL specifics for DH STM32MP13xx DHCOR DHSBC

2025-06-29 Thread Marek Vasut
On 6/3/25 4:36 PM, Patrick DELAUNAY wrote: Hi, +&etzpc { +    compatible = "simple-bus"; +}; + change the compatible is not not needed I think if the ETZPC driver was not compiled for SPL today it is compiled  ./arch/arm/mach-stm32mp/stm32mp1/etzpc.c ./arch/arm/mach-stm32mp/stm32mp1/Make

Re: [PATCH 04/10] ARM: stm32: Add STM32MP13xx PMIC initialization for DDR3 DRAM type

2025-06-29 Thread Marek Vasut
On 6/3/25 4:00 PM, Patrick DELAUNAY wrote: Hi, diff --git a/board/st/common/stpmic1.c b/board/st/common/stpmic1.c index 45c2bb5bcea..b46f89dacb9 100644 --- a/board/st/common/stpmic1.c +++ b/board/st/common/stpmic1.c @@ -14,8 +14,19 @@   #include   #include +static bool is_stm32mp13xx(void) +{

Re: [PATCH 06/10] ARM: dts: stm32: Add stm32mp13-ddr.dtsi template

2025-06-29 Thread Marek Vasut
On 6/3/25 4:22 PM, Patrick DELAUNAY wrote: Hi, +++ b/arch/arm/dts/stm32mp13-ddr.dtsi @@ -0,0 +1,49 @@ +// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause For new STM32MP file avoids to use the Deprecated License Identifiers (GPL-2.0+ / GPL-2.0) reference= +https://spdx.dev/learn/handli

Re: [PATCH 03/10] ARM: stm32: Limit early cache enablement in SPL to STM32MP15xx

2025-06-29 Thread Marek Vasut
On 6/3/25 3:37 PM, Patrick DELAUNAY wrote: Hi, diff --git a/arch/arm/mach-stm32mp/stm32mp1/cpu.c b/arch/arm/mach- stm32mp/stm32mp1/cpu.c index 9ab5a3ede52..1ae82489a4b 100644 --- a/arch/arm/mach-stm32mp/stm32mp1/cpu.c +++ b/arch/arm/mach-stm32mp/stm32mp1/cpu.c @@ -28,7 +28,9 @@    * early TLB

Re: [PATCH 01/10] ARM: stm32: Add STM32MP13xx SPL Kconfig options

2025-06-29 Thread Marek Vasut
On 6/3/25 3:26 PM, Patrick DELAUNAY wrote: Hi, diff --git a/arch/arm/mach-stm32mp/Kconfig.13x b/arch/arm/mach- stm32mp/Kconfig.13x index bc8b3f8cf77..cecf9e3b8c7 100644 --- a/arch/arm/mach-stm32mp/Kconfig.13x +++ b/arch/arm/mach-stm32mp/Kconfig.13x @@ -20,7 +20,8 @@ config TARGET_ST_STM32MP13X

Re: [PATCH 1/2] Put common r7s72100 code in board/renesas/common

2025-06-29 Thread Marek Vasut
On 6/28/25 10:36 AM, Magnus Damm wrote: From: Magnus Damm Break out SoC specific code from the GR-Peach board and put it into the board/renesas/common directory so it can be easily shared between the GR-Peach and Genmai boards. I've pushed an SH Ethernet clean up patchset , defconfig split patc

Re: [U-Boot, v2, 1/1] net: phy: Add the Airoha EN8811H PHY driver

2025-06-29 Thread Marek Vasut
On 6/15/25 3:12 PM, Lucien.Jheng wrote: Add the driver for the Airoha EN8811H 2.5 Gigabit PHY. The PHY supports 100/1000/2500 Mbps with auto negotiation only. The driver uses two firmware files, for which updated versions are added to linux-firmware already. Locating the AIROHA FW within the fi

[PULL] u-boot-sh/next

2025-06-18 Thread Marek Vasut
stodians/u-boot-sh.git next for you to fetch changes up to b1d017afda2bf5b88736528ee54d32f6e51b7bf2: renesas: Renesas R-Car Gen4 watchdog driver (2025-06-18 17:18:47 +0200) -------- Marek Vasut (1): ARM: dts: renesas: Drop most

[PULL] u-boot-sh/master

2025-06-18 Thread Marek Vasut
oot-sh.git master for you to fetch changes up to 668b2d791d94d4fd6a4be6d7dfa822b072017378: arm64: renesas: Move early SPL stack into System RAM SRAM on R-Car V4H boards (2025-06-18 17:18:43 +0200) -------- Marek Vasut (1): arm64: ren

[PATCH 1/6] drivers: pci: pcie_dw_common: Add dw_pcie_link_set_max_link_width()

2025-06-17 Thread Marek Vasut
Add dw_pcie_link_set_max_link_width() implementation ported from Linux kernel as of commit 89db0793c9f2 ("PCI: dwc: Add missing PCI_EXP_LNKCAP_MLW handling"). This is common code which is already duplicated in multiple drivers. Signed-off-by: Marek Vasut --- Cc: Casey Connolly Cc:

[PATCH 2/6] pci: pcie_dw_meson: Use dw_pcie_link_set_max_link_width()

2025-06-17 Thread Marek Vasut
kernel behavior. Signed-off-by: Marek Vasut --- Cc: Casey Connolly Cc: Christian Marangi Cc: Daniel Schwierzeck Cc: Jiaxun Yang Cc: John Crispin Cc: Kever Yang Cc: Neil Armstrong Cc: Nobuhiro Iwamatsu Cc: Philipp Tomsich Cc: Siddharth Vadapalli Cc: Simon Glass Cc: Sumit Garg Cc: Tom Rini

[PATCH 6/6] arm64: dts: renesas: r8a779g3: Enable PCIe/NVMe on Retronix R-Car V4H Sparrow Hawk board

2025-06-17 Thread Marek Vasut
Enable support for R-Car Gen4 PCIe controller and NVMe storage on Retronix R-Car V4H Sparrow Hawk board . Signed-off-by: Marek Vasut --- Cc: Casey Connolly Cc: Christian Marangi Cc: Daniel Schwierzeck Cc: Jiaxun Yang Cc: John Crispin Cc: Kever Yang Cc: Neil Armstrong Cc: Nobuhiro Iwamatsu

[PATCH 5/6] pci: pcie-rcar-gen4: Add Renesas R-Car Gen4 DW PCIe controller driver

2025-06-17 Thread Marek Vasut
implemented in an entirely generic manner, by calling a firmware loading script, which the user can configure in a way they require. This provides the user with flexibility of loading the PCIe firmware from whichever storage device they need to load it from. Signed-off-by: Marek Vasut --- Cc: Casey

[PATCH 4/6] pci: pcie_dw_rockchip: Use dw_pcie_link_set_max_link_width()

2025-06-17 Thread Marek Vasut
kernel behavior. Signed-off-by: Marek Vasut --- Cc: Casey Connolly Cc: Christian Marangi Cc: Daniel Schwierzeck Cc: Jiaxun Yang Cc: John Crispin Cc: Kever Yang Cc: Neil Armstrong Cc: Nobuhiro Iwamatsu Cc: Philipp Tomsich Cc: Siddharth Vadapalli Cc: Simon Glass Cc: Sumit Garg Cc: Tom Rini

[PATCH 3/6] pci: pcie_dw_qcom: Use dw_pcie_link_set_max_link_width()

2025-06-17 Thread Marek Vasut
Use dw_pcie_link_set_max_link_width() instead of local implementation of the same functionality. Signed-off-by: Marek Vasut --- Cc: Casey Connolly Cc: Christian Marangi Cc: Daniel Schwierzeck Cc: Jiaxun Yang Cc: John Crispin Cc: Kever Yang Cc: Neil Armstrong Cc: Nobuhiro Iwamatsu Cc

[PATCH v2 2/2] arm64: renesas: Switch R-Car V4H to renesas_rcar4_sa0 binman etype

2025-06-16 Thread Marek Vasut
boot time. Signed-off-by: Marek Vasut --- Cc: Ilias Apalodimas Cc: Nobuhiro Iwamatsu Cc: Simon Glass Cc: Tom Rini Cc: u-boot@lists.denx.de --- V2: No change --- arch/arm/dts/r8a779g0-u-boot.dtsi | 78 ++- 1 file changed, 15 insertions(+), 63 deletions(-) diff

[PATCH v2 1/2] binman: Add renesas_rcar4_sa0 etype

2025-06-16 Thread Marek Vasut
payload(s) into RT-VRAM. Signed-off-by: Marek Vasut --- Cc: Ilias Apalodimas Cc: Nobuhiro Iwamatsu Cc: Simon Glass Cc: Tom Rini Cc: u-boot@lists.denx.de --- V2: Add a test --- .gitignore| 1 + tools/binman/etype/renesas_rcar4_sa0.py | 46

[PATCH 2/2] arm64: renesas: Add Renesas R-Car Gen4 SCIF/HSCIF loader SREC generation

2025-06-15 Thread Marek Vasut
: Marek Vasut --- Cc: Nobuhiro Iwamatsu Cc: Paul Barker Cc: Tom Rini Cc: u-boot@lists.denx.de --- arch/arm/mach-renesas/Makefile | 10 ++ common/spl/Kconfig | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-renesas/Makefile b/arch/arm/mach

[PATCH 1/2] arm64: renesas: Convert SCIF SREC from u-boot-spl.bin

2025-06-15 Thread Marek Vasut
Convert u-boot-spl.bin instead of u-boot-spl ELF into SCIF loader compatible SREC. The u-boot-spl.bin includes SPL DT, while the ELF does not, which leads to failure to start SPL via SCIF loader due to missing SPL DT. Fix this by using u-boot-spl.bin which includes the DT. Signed-off-by: Marek

[PATCH 2/2] arm64: renesas: Switch R-Car V4H to renesas_rcar4_sa0 binman etype

2025-06-15 Thread Marek Vasut
boot time. Signed-off-by: Marek Vasut --- Cc: Ilias Apalodimas Cc: Nobuhiro Iwamatsu Cc: Simon Glass Cc: Tom Rini Cc: u-boot@lists.denx.de --- arch/arm/dts/r8a779g0-u-boot.dtsi | 78 ++- 1 file changed, 15 insertions(+), 63 deletions(-) diff --git a/arch/arm/dts

[PATCH 1/2] binman: Add renesas_rcar4_sa0 etype

2025-06-15 Thread Marek Vasut
payload(s) into RT-VRAM. Signed-off-by: Marek Vasut --- Cc: Ilias Apalodimas Cc: Nobuhiro Iwamatsu Cc: Simon Glass Cc: Tom Rini Cc: u-boot@lists.denx.de --- .gitignore | 1 + tools/binman/etype/renesas_rcar4_sa0.py | 46 + 2 files changed, 47

[PATCH] arm64: renesas: Move early SPL stack into System RAM SRAM on R-Car V4H boards

2025-06-15 Thread Marek Vasut
SPL stack at fixed location at the end of System RAM instead, where it cannot interfere with the payload loaded into RT-VRAM. Signed-off-by: Marek Vasut --- Cc: Nobuhiro Iwamatsu Cc: Paul Barker Cc: Tom Rini Cc: u-boot@lists.denx.de --- configs/r8a779g0_whitehawk_defconfig | 4 +++- configs

Re: [U-Boot, v1, 1/1] net: phy: Add the Airoha EN8811H PHY driver

2025-06-12 Thread Marek Vasut
LARITY, + EN8811H_POLARITY_RX_REVERSE | + EN8811H_POLARITY_TX_NORMAL, pbus_value); + if (ret < 0) + return ret; + + ret = air_leds_init(phydev, EN8811H_LED_COUNT, AIR_PHY_LED_DUR, + AIR_LED_MODE_USER_DEFINE); + if (ret < 0) { + printf("Failed to disable leds: %d\n", ret); + return ret; + } + + return 0; +} [...] -- Best regards, Marek Vasut

Re: Aw: [U-Boot, v1, 1/1] net: phy: Add the Airoha EN8811H PHY driver

2025-06-12 Thread Marek Vasut
On 6/12/25 5:04 PM, Lucien.Jheng wrote: Frank Wunderlich 於 2025/6/12 下午 10:44 寫道: Am 12. Juni 2025 16:36:41 MESZ schrieb Tom Rini: On Thu, Jun 12, 2025 at 10:09:48AM +,fran...@public-files.de wrote: Gesendet: Sonntag, 11. Mai 2025 um 07:14 Von: "Lucien.Jheng" Betreff: [U-Boot, v1, 1/1] n

Re: [PATCH v4 2/2] renesas: Renesas R-Car Gen4 watchdog driver

2025-06-11 Thread Marek Vasut
/upstream/src/arm64/renesas/r8a779f0-spider-cpu.dtsi section &rwdt. This driver is based on upstream linux commit: e70140ba0d2b("Get rid of 'remove_new' relic from platform driver struct") Signed-off-by: Shmuel Leib Melamud Reviewed-by: Mattijs Korpershoek Reviewed-by: Marek Vasut Thanks !

[PULL] u-boot-sh/master

2025-06-10 Thread Marek Vasut
V4H Sparrow Hawk board support (2025-06-10 20:50:50 +0200) Marek Vasut (2): arm64: renesas: Introduce renesas_dram_init_banksize() arm64: dts: renesas: r8a779g3: Add Retronix R-Car V4H Sparrow Hawk board support arch

[PATCH v2 2/8] env: Rename SYS_REDUNDAND_ENVIRONMENT to ENV_REDUNDANT

2025-06-09 Thread Marek Vasut
Rename the variable and add ENV_ prefix, so that all configuration options which are related to environment would have an CONFIG_ENV_ prefix. No functional change. Signed-off-by: Marek Vasut --- Cc: Paul Barker Cc: Quentin Schulz Cc: Simon Glass Cc: Tom Rini --- V2: Replace

[PATCH v2 8/8] env: Drop DELAY_ENVIRONMENT

2025-06-09 Thread Marek Vasut
There are no users of DELAY_ENVIRONMENT and the same effect can be achieved either using DT /config/load-environment property, or by using ENV_IS_NOWHERE . Remove this configuration option and matching functionality. Signed-off-by: Marek Vasut --- Cc: Paul Barker Cc: Quentin Schulz Cc: Simon

[PATCH v2 7/8] env: Rename DEFAULT_ENV_FILE to ENV_DEFAULT_ENV_TEXT_FILE

2025-06-09 Thread Marek Vasut
Rename the variable and add ENV_ prefix, so that all configuration options which are related to environment would have an CONFIG_ENV_ prefix. No functional change. Also rename USE_DEFAULT_ENV_FILE to USE_ENV_DEFAULT_ENV_TEXT_FILE . Signed-off-by: Marek Vasut --- Cc: Paul Barker Cc: Quentin

[PATCH v2 5/8] env: Rename SYS_MMC_ENV_PART to ENV_MMC_EMMC_HW_PARTITION

2025-06-09 Thread Marek Vasut
. Retain the ENV_MMC_ prefix to make it easier to search for all the SD/MMC related ENV options. Update the help text accordingly. Signed-off-by: Marek Vasut --- Cc: Paul Barker Cc: Quentin Schulz Cc: Simon Glass Cc: Tom Rini --- V2: Rename to ENV_MMC_EMMC_HW_PARTITION --- arch/arm/mach-imx

[PATCH v2 6/8] env: Rename ENV_MMC_PARTITION to ENV_MMC_SW_PARTITION

2025-06-09 Thread Marek Vasut
. Signed-off-by: Marek Vasut --- Cc: Paul Barker Cc: Quentin Schulz Cc: Simon Glass Cc: Tom Rini --- V2: Rename to ENV_MMC_SW_PARTITION --- doc/device-tree-bindings/config.txt | 2 +- env/Kconfig | 19 +++ env/mmc.c | 4 ++-- 3

[PATCH v2 4/8] env: Rename SYS_MMC_ENV_DEV to ENV_MMC_DEVICE_INDEX

2025-06-09 Thread Marek Vasut
accordingly. Signed-off-by: Marek Vasut --- Cc: Paul Barker Cc: Quentin Schulz Cc: Simon Glass Cc: Tom Rini --- V2: Rename to ENV_MMC_DEVICE_INDEX --- arch/arm/cpu/armv8/fsl-layerscape/cpu.c| 2 +- arch/arm/mach-imx/imx8/cpu.c | 4 ++-- arch/arm/mach-imx

[PATCH v2 1/8] env: Rename OVERWRITE_ETHADDR_ONCE to ENV_OVERWRITE_ETHADDR_ONCE

2025-06-09 Thread Marek Vasut
Rename the variable and add ENV_ prefix, so that all configuration options which are related to environment would have an CONFIG_ENV_ prefix. No functional change. Reviewed-by: Quentin Schulz Reviewed-by: Tom Rini Signed-off-by: Marek Vasut --- Cc: Paul Barker Cc: Quentin Schulz Cc: Simon

[PATCH v2 0/8] Consistent Kconfig environment options CONFIG_ENV_ prefix

2025-06-09 Thread Marek Vasut
Rename the environment related variables and add ENV_ prefix, so that all configuration options which are related to environment would have an CONFIG_ENV_ prefix. No functional change. Marek Vasut (8): env: Rename OVERWRITE_ETHADDR_ONCE to ENV_OVERWRITE_ETHADDR_ONCE env: Rename

[PATCH] arm64: dts: renesas: Clean up sysinfo EEPROM DT description on R-Car Gen3

2025-06-08 Thread Marek Vasut
Most of the sysinfo EEPROM node eeprom@50 is now part of the core DTs, remove duplicate DT properties from *-u-boot.dtsi . Adjust the phandle reference to i2c-eeprom in sysinfo node using <&{i2c_*/eeprom@50}> to avoid need for DT label. No functional change. Signed-off-by: Marek Vas

[PATCH] ARM: dts: renesas: Drop most of bootph-* tags

2025-06-08 Thread Marek Vasut
al duplicates of the same tags, as well as duplicate property assignments which are part of the core DTs themselves. Signed-off-by: Marek Vasut --- Cc: Nobuhiro Iwamatsu Cc: Tom Rini Cc: u-boot@lists.denx.de --- .../dts/r8a774a1-hihope-rzg2m-ex-u-boot.dtsi | 8 arch/arm/dts/r8a774a

Re: [PATCH v3 2/2] renesas: Renesas R-Car Gen4 watchdog driver

2025-06-08 Thread Marek Vasut
On 6/3/25 5:06 AM, Shmuel Leib Melamud via B4 Relay wrote: [...] +++ b/drivers/watchdog/renesas_wdt.c @@ -0,0 +1,182 @@ +// SPDX-License-Identifier: GPL-2.0+ +// Copyright 2025 Red Hat, Inc., Shmuel Leib Melamud + +#include +#include +#include +#include +#include +#include +#include N

Re: [PATCH v3 1/2] renesas: Handle CLK_TYPE_GEN4_MDSEL in gen3_clk_get_rate64()

2025-06-08 Thread Marek Vasut
. Signed-off-by: Shmuel Leib Melamud Reviewed-by: Marek Vasut Thank you

[PATCH 2/2] arm64: dts: renesas: r8a779g3: Add Retronix R-Car V4H Sparrow Hawk board support

2025-05-30 Thread Marek Vasut
for NVMe SSD, debug UART and JTAG. DT is imported from Linux next commit: a719915e76f2 ("arm64: dts: renesas: r8a779g3: Add Retronix R-Car V4H Sparrow Hawk board support") Signed-off-by: Marek Vasut --- Cc: Nobuhiro Iwamatsu Cc: Tom Rini Cc: u-boot@lists.denx.de --- .../arm/dts/r8a779

[PATCH 1/2] arm64: renesas: Introduce renesas_dram_init_banksize()

2025-05-30 Thread Marek Vasut
boards to ship with single U-Boot binary on all boards. Signed-off-by: Marek Vasut --- Cc: Nobuhiro Iwamatsu Cc: Tom Rini Cc: u-boot@lists.denx.de --- board/renesas/common/rcar64-common.c | 4 1 file changed, 4 insertions(+) diff --git a/board/renesas/common/rcar64-common.c b/board

  1   2   3   4   5   6   7   8   9   10   >