Re: [U-Boot] [PATCH 14/28] drivers/fsl-mc: Changed MC firmware loading for new boot architecture

2015-03-27 Thread Kim Phillips
On Thu, 26 Mar 2015 18:57:02 -0500 Rivera Jose-B46482 wrote: > > From: Kim Phillips [mailto:kim.phill...@freescale.com] > > Sent: Wednesday, March 25, 2015 4:13 PM > > > > On Tue, 24 Mar 2015 21:32:56 -0500 > > Stuart Yoder wrote: > > > > > On a

Re: [U-Boot] [PATCH 14/28] drivers/fsl-mc: Changed MC firmware loading for new boot architecture

2015-03-25 Thread Kim Phillips
nly when necessary, i.e., when users want to use one of the DP net interfaces. Most of the time when we boot today, we don't use DP net interfaces, so MC init - with or without DPL processing - is just a waste of our time! Thanks, Kim > Thanks, > Stuart > > > > O

Re: [U-Boot] [PATCH 14/28] drivers/fsl-mc: Changed MC firmware loading for new boot architecture

2015-03-24 Thread Kim Phillips
On Tue, 24 Mar 2015 10:14:39 -0500 Rivera Jose-B46482 wrote: > > From: Kim Phillips [mailto:kim.phill...@freescale.com] > > Sent: Monday, March 23, 2015 5:06 PM > > > > On Mon, 23 Mar 2015 16:15:56 -0500 > > Rivera Jose-B46482 wrote: > > > >

Re: [U-Boot] [PATCH 14/28] drivers/fsl-mc: Changed MC firmware loading for new boot architecture

2015-03-23 Thread Kim Phillips
On Mon, 23 Mar 2015 16:15:56 -0500 Rivera Jose-B46482 wrote: > > -Original Message- > > From: Kim Phillips [mailto:kim.phill...@freescale.com] > > Sent: Monday, March 23, 2015 3:34 PM > > To: Rivera Jose-B46482 > > Cc: Sun York-R58495; u-boot@lists.de

Re: [U-Boot] [PATCH 14/28] drivers/fsl-mc: Changed MC firmware loading for new boot architecture

2015-03-23 Thread Kim Phillips
On Mon, 23 Mar 2015 15:06:11 -0500 Rivera Jose-B46482 wrote: > > From: Kim Phillips [mailto:kim.phill...@freescale.com] > > Sent: Thursday, March 19, 2015 12:53 PM > > > > On Thu, 19 Mar 2015 09:45:45 -0700 > > York Sun wrote: > > > > > Fro

Re: [U-Boot] [PATCH v5 14/28] drivers/fsl-mc: Changed MC firmware loading for new boot architecture

2015-03-23 Thread Kim Phillips
On Fri, 20 Mar 2015 19:28:18 -0700 York Sun wrote: > From: "J. German Rivera" > > Changed MC firmware loading to comply with the new MC boot architecture. > Flush D-cache hierarchy after loading MC images. Add environment > variables "mcboottimeout" for MC boot timeout in milliseconds, > "mcmem

Re: [U-Boot] [PATCH 14/28] drivers/fsl-mc: Changed MC firmware loading for new boot architecture

2015-03-19 Thread Kim Phillips
On Thu, 19 Mar 2015 09:45:45 -0700 York Sun wrote: > From: "J. German Rivera" > > Changed MC firmware loading to comply with the new MC boot architecture. > Flush D-cache hierarchy after loading MC images. Add environment > variables "mcboottimeout" for MC boot timeout in milliseconds, > "mcmem

[U-Boot] [PATCH] mpc83xx: preempt premature board support removal by setting GENERIC_BOARD (was: [PATCH 7/7] powerpc: mpc83xx: remove non-generic freescale boards)

2015-03-17 Thread Kim Phillips
ard for details.) > > Signed-off-by: Masahiro Yamada > Cc: Ilya Yanok > Cc: Dave Liu > Cc: Michael Barkowski > Cc: Kim Phillips Nacked-by: Kim Phillips >From 39cb4e8eb7f768778ada3aed2e1419c88fe3adda Mon Sep 17 00:00:00 2001 From: Kim Phillips Date: Tue, 17 Mar 2015 11:

Re: [U-Boot] checkstack.pl

2015-01-28 Thread Kim Phillips
>From 42512a3fe6f2434cfc9381328d2a4755ebe6d051 Mon Sep 17 00:00:00 2001 From: Kim Phillips Date: Wed, 28 Jan 2015 13:15:01 -0600 Subject: [PATCH] scripts/checkstack.pl: update to get AArch64 port from Linux Bring checkstack.pl up to date from its upstream Linux development. Effectively,

Re: [U-Boot] [PATCH v2 0/7] Update gdsys board support

2014-11-18 Thread Kim Phillips
On Tue, 18 Nov 2014 13:59:12 +0100 Stefan Roese wrote: > On 18.11.2014 13:55, Dirk Eibach wrote: > > do you see any chance too get this merged soon? "mpc83xx: Add gdsys > > hrcon board" fixes a build failure and it would be nice to get it in > > before rc2. > > > > Kim offered to ack " mpc83xx: A

Re: [U-Boot] [PATCH v1 0/6] Update gdsys board support

2014-11-07 Thread Kim Phillips
On Fri, 7 Nov 2014 13:58:37 +0100 Dirk Eibach wrote: > Hi Kim, > > 2014-11-05 11:43 GMT+01:00 Stefan Roese : > > Hi Dirk, > > > > On 05.11.2014 10:45, Dirk Eibach wrote: > >> > >> will you look after this series? I ask because there is also some > >> mpc83xx stuff involved. > > > > > > Yes, I ju

Re: [U-Boot] [PATCH v1 6/6] mpc83xx: Add gdsys hrcon board

2014-11-06 Thread Kim Phillips
On Wed, 29 Oct 2014 16:03:57 +0100 wrote: > From: Dirk Eibach > > The gdsys hrcon board is based on a Freescale MPC8308 SOC. > It boots from NOR-Flash, kernel and rootfs are stored on > SD-Card. > > On board peripherals include: > - 1x GbE (optional) > - Lattice ECP3 FPGA connected via eLBC an

Re: [U-Boot] [PATCH v1 0/6] Update gdsys board support

2014-11-06 Thread Kim Phillips
On Thu, 6 Nov 2014 10:25:58 -0800 York Sun wrote: > On 11/05/2014 10:29 PM, Dirk Eibach wrote: > > Hi Stefan, > > > >>> Is Kim still active? Last message from him on the list I found was from > >>> may. > >> > >> Not sure. Lets wait and see if Kim responds... > > > > looks not so good. > > I pu

[U-Boot] [PATCH] mpc85xx: configs: remove c=ffe from default environment

2014-05-14 Thread Kim Phillips
AFAICT, c=ffe does nothing and was a typo from the original commit d17123696c6180ac8b74fbd318bf14652623e982 "powerpc/p4080: Add support for the P4080DS board" and just kept on getting duplicated in subsequently added board config files. Signed-off-by: Kim Phillips --- include/configs/

Re: [U-Boot] [PATCH 2/4] mpc8313, signed fit: disable legacy image format on ids8313 board

2014-05-08 Thread Kim Phillips
On Thu, 8 May 2014 13:05:16 +0200 Heiko Schocher wrote: > Disable legacy image format with CONFIG_DISABLE_IMAGE_FORMAT_LEGACY > on the ids8313 board, as it uses signed FIT images for booting > Linux. > > Signed-off-by: Heiko Schocher > Cc: Simon Glass > Cc: Kim Phillips

Re: [U-Boot] [PATCH 4/4] mpc8313: add CONFIG_SYS_GENERIC_BOARD to ids8313 board

2014-05-08 Thread Kim Phillips
On Thu, 8 May 2014 13:05:18 +0200 Heiko Schocher wrote: > - add CONFIG_SYS_GENERIC_BOARD > - remove CONFIG_OF_CONTROL to boot again > > Signed-off-by: Heiko Schocher > Cc: Simon Glass > Cc: Kim Phillips > --- on behalf of mpc83xx: Acked-b

Re: [U-Boot] [PATCH] boards.cfg: fix a configuration error of ep8248 board

2014-05-08 Thread Kim Phillips
y commit e7e90901. > > But it is not the author's fault. He just intended to change > > IDS8247 board. > > > > The commiter added ep8248 entry by mistake when he resolved a conflict. > > > > Signed-off-by: Masahiro Yamada > > Cc: Heiko Schocher > >

[U-Boot] [GIT PULL] u-boot-mpc83xx: add support for the ids8313 board

2014-04-23 Thread Kim Phillips
Hi Tom, Please pull support for the ids8313 board: The following changes since commit adcdeacc3eda1e5949e54062aa99c299e12483be: Merge branch 'master' of git://git.denx.de/u-boot-mips (2014-04-23 11:07:11 -0400) are available in the git repository at: git://git.denx.de/u-boot-mpc83xx.git

Re: [U-Boot] declaring and initializing variables

2013-10-15 Thread Kim Phillips
On Mon, 14 Oct 2013 12:05:52 -0700 York Sun wrote: > On 10/07/2013 03:03 PM, Kim Phillips wrote: > > On Mon, 30 Sep 2013 17:04:33 -0700 > > York Sun wrote: > > > >> Kim, et al., > >> > >> I know I have asked this before. Pardon me as I don'

Re: [U-Boot] declaring and initializing variables

2013-10-07 Thread Kim Phillips
On Mon, 30 Sep 2013 17:04:33 -0700 York Sun wrote: > Kim, et al., > > I know I have asked this before. Pardon me as I don't consider myself a > savy programmer. > > I am cleaning up the DDR driver for mpc83xx, mpc85xx and mpc86xx. The > question is the accetable formats of declaring and initial

Re: [U-Boot] [PATCH v6 1/2] exynos5250: Add arndale board support

2013-08-20 Thread Kim Phillips
On Tue, 6 Aug 2013 20:05:46 +0530 Chander Kashyap wrote: > Arndale board is based on samsung's exynos5250 soc. > > Signed-off-by: Inderpal Singh > Signed-off-by: Chander Kashyap > --- This patchseries gives me: make[1]: Entering directory `/home/kim/git/u-boot-arndale-upstream/board/samsun

Re: [U-Boot] [PATCH 1/2] powerpc/83xx/km: MV88e6122 errata fix for 1.9V

2013-05-21 Thread Kim Phillips
On Mon, 6 May 2013 15:02:39 +0200 Holger Brunck wrote: > Errata Fix: 1.9V Output from Internal 1.8V Regulator, acc. > MV-S300889-00D.pdf , clause 4.5 > > Signed-off-by: Holger Brunck > --- patches 1-2 applied to mpc83xx/next. Thanks, Kim ___ U-Boo

Re: [U-Boot] [PATCH v2 0/45] Verified boot implementation based on FIT

2013-04-22 Thread Kim Phillips
On Sat, 20 Apr 2013 16:03:20 -0700 Simon Glass wrote: > On Mon, Apr 1, 2013 at 5:13 PM, Kim Phillips > wrote: > > On Mon, 18 Mar 2013 16:51:20 -0700 > > Simon Glass wrote: > > > >> I have received a number of off-list comments - please do copy the list

Re: [U-Boot] [PATCH v2 0/45] Verified boot implementation based on FIT

2013-04-01 Thread Kim Phillips
On Mon, 18 Mar 2013 16:51:20 -0700 Simon Glass wrote: > I have received a number of off-list comments - please do copy the list when > replying so that everyone can see your comments. I don't have time to fully review 45 patches, let alone the subject matter (e.g., no support for RSA in h/w, eh?

Re: [U-Boot] [PATCH 0/5] FSL SECURE BOOT: Add support for next level image validation

2013-03-29 Thread Kim Phillips
On Fri, 29 Mar 2013 04:43:23 + Gupta Ruchika-R66431 wrote: > > From: otavio.salva...@gmail.com [mailto:otavio.salva...@gmail.com] On Behalf > > Of Otavio Salvador > > Sent: Thursday, March 28, 2013 8:23 PM > > To: Gupta Ruchika-R66431 > > Cc: U-Boot Mailing List; Fleming Andy-AFLEMING > > Sub

Re: [U-Boot] [PATCH 1/4 v7] Exynos: Add hardware accelerated SHA256 and SHA1

2013-03-21 Thread Kim Phillips
On Thu, 21 Mar 2013 03:12:54 -0400 Akshay Saraswat wrote: > >On Mon, 18 Mar 2013 02:06:15 -0400 > >Akshay Saraswat wrote: > > > >> + while ((readl(&ace_sha_reg->hash_status) & ACE_HASH_MSGDONE_MASK) == > >> + ACE_HASH_MSGDONE_OFF) { > >> + /* > >> + * PRNG error bit

Re: [U-Boot] [PATCH 1/4 v7] Exynos: Add hardware accelerated SHA256 and SHA1

2013-03-19 Thread Kim Phillips
On Mon, 18 Mar 2013 02:06:15 -0400 Akshay Saraswat wrote: > SHA-256 and SHA-1 accelerated using ACE hardware. > > Signed-off-by: ARUN MANKUZHI > Signed-off-by: Akshay Saraswat > Acked-by: Simon Glass > --- > +++ b/arch/arm/include/asm/arch-exynos/ace_sha.h ace_sha.h belongs in drivers/crypto

Re: [U-Boot] [PATCH 4/5 v4] gen: Add ACE acceleration to hash

2013-03-12 Thread Kim Phillips
On Tue, 12 Mar 2013 16:40:38 -0700 Simon Glass wrote: > Hi Kim, > > On Tue, Mar 12, 2013 at 12:32 PM, Kim Phillips > wrote: > > On Mon, 11 Mar 2013 17:53:37 -0700 > > Simon Glass wrote: > > > >> On Mon, Mar 11, 2013 at 5:44 PM, Kim Phillips > &g

Re: [U-Boot] [PATCH 4/5 v4] gen: Add ACE acceleration to hash

2013-03-12 Thread Kim Phillips
On Mon, 11 Mar 2013 17:53:37 -0700 Simon Glass wrote: > On Mon, Mar 11, 2013 at 5:44 PM, Kim Phillips > wrote: > > On Thu, 7 Mar 2013 19:11:16 -0800 > > Simon Glass wrote: > > > OK so let's look at adding the hash_register() idea. But not in this > >

Re: [U-Boot] [PATCH 4/5 v4] gen: Add ACE acceleration to hash

2013-03-11 Thread Kim Phillips
On Thu, 7 Mar 2013 19:11:16 -0800 Simon Glass wrote: > Hi Kim, > > On Thu, Mar 7, 2013 at 6:18 PM, Kim Phillips > wrote: > > On Thu, 7 Mar 2013 17:05:15 -0800 > > Simon Glass wrote: > > > >> On Thu, Mar 7, 2013 at 4:25 PM, Kim Phillips > >>

Re: [U-Boot] [PATCH 4/5 v4] gen: Add ACE acceleration to hash

2013-03-07 Thread Kim Phillips
On Thu, 7 Mar 2013 17:05:15 -0800 Simon Glass wrote: > On Thu, Mar 7, 2013 at 4:25 PM, Kim Phillips > wrote: > > On Wed, 6 Mar 2013 18:08:21 -0800 > > Simon Glass wrote: > > > >> On Wed, Mar 6, 2013 at 5:22 PM, Kim Phillips > >> wrote: > >&g

Re: [U-Boot] [PATCH 4/5 v4] gen: Add ACE acceleration to hash

2013-03-07 Thread Kim Phillips
On Wed, 6 Mar 2013 18:08:21 -0800 Simon Glass wrote: > On Wed, Mar 6, 2013 at 5:22 PM, Kim Phillips > wrote: > > On Tue, 5 Mar 2013 22:22:09 -0800 > > Simon Glass wrote: > > > >> On Tue, Mar 5, 2013 at 9:04 PM, Kim Phillips > >> wrote: > >&g

Re: [U-Boot] [PATCH 4/5 v4] gen: Add ACE acceleration to hash

2013-03-06 Thread Kim Phillips
On Wed, 6 Mar 2013 10:29:46 -0500 Akshay Saraswat wrote: > I have removed "tested with" in the new set of patches. And I tested those > patches with that command > before mailing for review. I have tested them for various sizes this time > which includes 8 MB as well. > I have shared benchmark

Re: [U-Boot] [PATCH 3/4 v5] gen: Add ACE acceleration to hash

2013-03-06 Thread Kim Phillips
On Wed, 6 Mar 2013 09:18:55 -0500 Akshay Saraswat wrote: > ACE H/W acceleration support is added to hash > which can be used to test SHA 256 hash algorithm. > > Signed-off-by: ARUN MANKUZHI > Signed-off-by: Akshay Saraswat > --- this doesn't even apply any more: Applying: gen: Add ACE accele

Re: [U-Boot] [PATCH 4/5 v4] gen: Add ACE acceleration to hash

2013-03-06 Thread Kim Phillips
On Tue, 5 Mar 2013 22:22:09 -0800 Simon Glass wrote: > On Tue, Mar 5, 2013 at 9:04 PM, Kim Phillips > wrote: > > On Tue, 5 Mar 2013 17:51:00 -0800 > > Simon Glass wrote: > > > [snip for Kim] and others too, I hope. > >> >> Changes sice v3: > >

Re: [U-Boot] [PATCH 4/5 v4] gen: Add ACE acceleration to hash

2013-03-05 Thread Kim Phillips
On Tue, 5 Mar 2013 17:51:00 -0800 Simon Glass wrote: > Hi Kim, > > On Tue, Mar 5, 2013 at 2:43 PM, Kim Phillips > wrote: > > On Tue, 5 Mar 2013 08:19:59 -0500 > > Akshay Saraswat wrote: > > > >> Tested with command "hash sha256 0x40008000 0x2B

Re: [U-Boot] [PATCH 4/5 v4] gen: Add ACE acceleration to hash

2013-03-05 Thread Kim Phillips
On Tue, 5 Mar 2013 08:19:59 -0500 Akshay Saraswat wrote: > Tested with command "hash sha256 0x40008000 0x2B 0x40009000". > Used mm and md to write a standard string to memory location > 0x40008000 and ran the above command to verify the output. patches 1,2,4,5 all contain this "tested with" text

Re: [U-Boot] dtb vs. kernel command line arguments

2013-03-04 Thread Kim Phillips
On Mon, 4 Mar 2013 10:30:45 -0800 Curt Brune wrote: > Hello - > > I want to pass a number of arguments from u-boot to the booted kernel. > The arguments are needed by user space applications, not the kernel. > > I can think of two ways: > > 1. append args by setting "bootargs". > 2. add nodes

Re: [U-Boot] [PATCH 3/4 v3] gen: Add ACE acceleration to hash

2013-03-04 Thread Kim Phillips
On Fri, 1 Mar 2013 11:16:24 -0500 Akshay Saraswat wrote: > +#include > > /* > * These are the hash algorithms we support. Chips which support accelerated > * crypto could perhaps add named version of these algorithms here. > */ > static struct hash_algo hash_algo[] = { > +#ifdef CONFIG

Re: [U-Boot] [PATCH 1/4 v3] Exynos: Add hardware accelerated SHA 256

2013-03-04 Thread Kim Phillips
On Fri, 1 Mar 2013 11:16:22 -0500 Akshay Saraswat wrote: > SHA-256 and SHA-1 accelerated using ACE hardware. curious about the rationale: how much faster is this than software? > --- > Changes since v2: > - Added falling back to software sha256 in case length exceeds buffer > limit. >

Re: [U-Boot] [PATCH 1/4] Exynos: Add hardware accelerated SHA 256

2013-03-04 Thread Kim Phillips
On Fri, 1 Mar 2013 16:11:36 + Akshay Saraswat wrote: > Samsung Enterprise Portal mySingle > > > > Hi Kim, > > > > >On Thu, 28 Feb 2013 11:08:21 + > > >Akshay Saraswat wrote: > > > > > >> >On Wed, 27 Feb 2013 10:24:39 -0500 > > >> > > >> >Akshay Saraswat wrote: > > > > > >

[U-Boot] [PATCH 1/2] tools: update checkpatch to latest upstream version

2013-02-28 Thread Kim Phillips
i.e., from the linux kernel's commit be987d9f80354e2e919926349282facd74992f90 Signed-off-by: Kim Phillips --- tools/checkpatch.pl | 752 ++-- 1 file changed, 558 insertions(+), 194 deletions(-) diff --git a/tools/checkpatch.pl b/

[U-Boot] [PATCH 2/2] tools: enable more checkpatch tests by default

2013-02-28 Thread Kim Phillips
without this, patches don't get checked for proper alignment, and e.g., for spaces after a cast and/or before a semicolon. Signed-off-by: Kim Phillips --- .checkpatch.conf | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.checkpatch.conf b/.checkpatch.conf index 977db9e..38386b3 1

Re: [U-Boot] [PATCH 1/4] Exynos: Add hardware accelerated SHA 256

2013-02-28 Thread Kim Phillips
On Thu, 28 Feb 2013 11:08:21 + Akshay Saraswat wrote: > >On Wed, 27 Feb 2013 10:24:39 -0500 > > >Akshay Saraswat wrote: can you fix your mailer to not double space lines? > >> +/* Maximum input data size is 8 MB. Timeout observed for data size above > >> 8MB */ > >> +#define TIMEOUT_MS

Re: [U-Boot] [PATCH 1/3 v2] Exynos: Add hardware accelerated SHA 256

2013-02-28 Thread Kim Phillips
On Thu, 28 Feb 2013 06:00:21 -0500 Akshay Saraswat wrote: > --- > Changes since v1: > - Moved code to drivers/crypto. > - Fixed few other nits. be more specific wrt changes between revisions. > + if (buf_len == 0) { > + /* ACE H/W cannot compute hash value for empty

Re: [U-Boot] [PATCH 4/4] Exynos: Flush memory region before starting SHA DMA operation

2013-02-27 Thread Kim Phillips
On Wed, 27 Feb 2013 10:24:42 -0500 Akshay Saraswat wrote: > SHA256 commands weren't giving desired output since the data we set > in the memory addresses through mw.l commands was not getting updated > in actual memory. Adding this patch resolves the issue. why not use the dcache flush command i

Re: [U-Boot] [PATCH 1/4] Exynos: Add hardware accelerated SHA 256

2013-02-27 Thread Kim Phillips
On Wed, 27 Feb 2013 10:24:39 -0500 Akshay Saraswat wrote: > SHA-256 and SHA-1 accelerated using ACE hardware. > > TEST=sha256 0x40008000 0x2B 0x40009000 > Used mm and md to write a standard string to memory location > 0x40008000 and ran the above command to verify the output. can we get rid of

[U-Boot] [GIT PULL] u-boot-mpc83xx: keymile board updates

2013-02-15 Thread Kim Phillips
Hi Tom, Please pull the latest set of keymile 83xx board updates: The following changes since commit 9a82b10c6657c5744802971036bb564ebc660291: Merge branch 'master' of git://git.denx.de/u-boot (2013-02-15 17:46:50 -0600) are available in the git repository at: git://git.denx.de/u-boot-mpc

Re: [U-Boot] [PATCH v2 01/16] km/common: remove unneeded ifdefs for I2C

2013-02-15 Thread Kim Phillips
On Mon, 21 Jan 2013 14:55:13 +0100 Holger Brunck wrote: > All boards from this serie use i2c. There is no need to #ifdef the > header. > > Signed-off-by: Holger Brunck > --- applied 16 out of 16 patches. Thanks, Kim ___ U-Boot mailing list U-Boot@

Re: [U-Boot] [RFC PATCH v2 1/5] Initial net6.h

2013-01-18 Thread Kim Phillips
On Fri, 18 Jan 2013 14:35:28 +1300 Chris Packham wrote: > From: Chris Packham > > Has the definition of an IPv6 address and IPv6 header. It may make sense > to separate the v4 support from net.h (or to include this in net.h). > > Signed-off-by: Chris Packham > &

Re: [U-Boot] [PATCH 05/15] powerpc/83xx/km: add MV88E6122 switch support for kmvect1

2013-01-18 Thread Kim Phillips
On Fri, 18 Jan 2013 10:14:39 +0100 Holger Brunck wrote: > On 01/18/2013 01:44 AM, Kim Phillips wrote: > > On Thu, 17 Jan 2013 13:47:51 +0100 > > Holger Brunck wrote: > > > >> + if (piggy_present()) { > >> + uchar enetaddr[6]; > >

Re: [U-Boot] [PATCH 04/15] km82xx, km83xx: move ethernet_present() from common to cpu specific

2013-01-18 Thread Kim Phillips
On Fri, 18 Jan 2013 09:07:32 +0100 Holger Brunck wrote: > On 01/18/2013 01:23 AM, Kim Phillips wrote: > > On Thu, 17 Jan 2013 13:47:50 +0100 > > Holger Brunck wrote: > > > >> +int piggy_present(void) > >> +{ > >> + struct km_bec_

Re: [U-Boot] [PATCH V2] MPC8308: Fixup clocks in PCI Host configuration

2013-01-17 Thread Kim Phillips
On Tue, 15 Jan 2013 11:39:51 -0800 "Ira W. Snyder" wrote: > On Mon, Jan 14, 2013 at 06:59:59PM -0600, Kim Phillips wrote: > > On Tue, 8 Jan 2013 18:25:11 -0800 > > Barry Grussling wrote: > > > > > While trying to bring up a custom MPC8308 based board I

Re: [U-Boot] [PATCH 05/15] powerpc/83xx/km: add MV88E6122 switch support for kmvect1

2013-01-17 Thread Kim Phillips
On Thu, 17 Jan 2013 13:47:51 +0100 Holger Brunck wrote: > +#if defined(CONFIG_KMVECT1) > +#include > +/* Marvell MV88E6122 switch configuration */ > +struct mv88e_sw_reg extsw_conf[] = { > + /* port 1, FRONT_MDI, autoneg */ > + { PORT(1), PORT_PHY, NO_SPEED_FOR }, > + { PORT(1), PORT

Re: [U-Boot] [PATCH 04/15] km82xx, km83xx: move ethernet_present() from common to cpu specific

2013-01-17 Thread Kim Phillips
On Thu, 17 Jan 2013 13:47:50 +0100 Holger Brunck wrote: > +int piggy_present(void) > +{ > + struct km_bec_fpga *base = > + (struct km_bec_fpga *)CONFIG_SYS_KMBEC_FPGA_BASE; > + > + return in_8(&base->bprth) & PIGGY_PRESENT; > +} this change produces two new sparse warnings:

Re: [U-Boot] [PATCH 1/5] treewide: include libfdt_env.h before fdt.h

2013-01-17 Thread Kim Phillips
On Wed, 16 Jan 2013 18:36:03 -0600 Scott Wood wrote: > On 01/16/2013 05:59:04 PM, Kim Phillips wrote: > > and, if including libfdt.h which includes libfdt_env.h in > > the correct order, don't include fdt.h before libfdt.h. > > > > this is needed to get the fdt t

[U-Boot] [GIT PULL] u-boot-mpc83xx: support for new SPL

2013-01-16 Thread Kim Phillips
a6187dccd813920524987792e49ef2feffb213e6: Merge remote-tracking branch 'mpc83xx/next' (2013-01-16 18:34:09 -0600) ---- Kim Phillips (1): Merge remote-tracking branch 'mpc83xx/next' Scott Wood (3): spl: Change PAD_TO to CONFIG_SPL_

[U-Boot] [PATCH 5/5 v2] common/fdt_support.c: sparse fixes

2013-01-16 Thread Kim Phillips
get type [enabled by default] See also linux kernel commit 0131d897 "of/address: use proper endianess in get_flags". Signed-off-by: Kim Phillips Cc: Jerry Van Baren --- v1 sent Tue, 16 Oct 2012 14:28:30 - v2: updated to use fdt32 instead of be32 nomenclature, now that fdt spe

[U-Boot] [PATCH 4/5] libfdt: update from upstream dtc commit 142419e

2013-01-16 Thread Kim Phillips
commit 142419e "dtc/libfdt: sparse fixes", for u-boot's libfdt copy. Signed-off-by: Kim Phillips Cc: Jerry Van Baren --- include/libfdt.h | 32 lib/libfdt/fdt.c | 2 +- lib/libfdt/fdt_ro.c | 2 +- lib/libfdt/fdt_rw.c | 4 ++-- lib/

[U-Boot] [PATCH 2/5] libfdt_env.h: add fdt type definitions

2013-01-16 Thread Kim Phillips
fdt types are big endian. Signed-off-by: Kim Phillips Cc: Jerry Van Baren --- include/libfdt_env.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/libfdt_env.h b/include/libfdt_env.h index bf63583..3e3defc 100644 --- a/include/libfdt_env.h +++ b/include/libfdt_env.h @@ -22,9

[U-Boot] [PATCH 1/5] treewide: include libfdt_env.h before fdt.h

2013-01-16 Thread Kim Phillips
and, if including libfdt.h which includes libfdt_env.h in the correct order, don't include fdt.h before libfdt.h. this is needed to get the fdt type definitions set from the project environment before fdt.h uses them. Signed-off-by: Kim Phillips Cc: Jerry Van Baren --- arch/arm/lib/bo

[U-Boot] [PATCH 2/2] net/tftp: sparse fixes

2013-01-16 Thread Kim Phillips
tftp.c:464:17: warning: cast to restricted __be16 tftp.c:552:29: warning: cast to restricted __be16 tftp.c:640:33: warning: cast to restricted __be16 tftp.c:642:25: warning: cast to restricted __be16 Signed-off-by: Kim Phillips Cc: Joe Hershberger --- net/tftp.c | 12 ++-- 1 file

[U-Boot] [PATCH 1/2] net: make IPaddr type big endian

2013-01-16 Thread Kim Phillips
for use with sparse. Signed-off-by: Kim Phillips Cc: Joe Hershberger --- include/net.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net.h b/include/net.h index 970d4d1..4c5a000 100644 --- a/include/net.h +++ b/include/net.h @@ -39,7 +39,7 @@ #define PKTALIGN

[U-Boot] [PATCH 3/5] libfdt: update fdt.h from upstream dtc

2013-01-16 Thread Kim Phillips
upstream dtc commit feafcd972cb744750a65728440c99526e6199a6d "dtc/libfdt: introduce fdt types for annotation by endian checkers". Signed-off-by: Kim Phillips Cc: Jerry Van Baren --- include/fdt.h | 42 +- 1 file changed, 21 insertions(+), 21

Re: [U-Boot] [RFC PATCH 1/2] Initial net6.h

2013-01-16 Thread Kim Phillips
On Wed, 16 Jan 2013 23:01:26 +1300 Chris Packham wrote: > +typedef union ip6addr_t { > + __u8u6_addr8[16]; > + __u16 u6_addr16[8]; __be16, for use with sparse. > + __u32 u6_addr32[4]; __be32 > +} IP6addr_t; Kim ___ U-Boot maili

Re: [U-Boot] [PATCH V2] MPC8308: Fixup clocks in PCI Host configuration

2013-01-14 Thread Kim Phillips
On Tue, 8 Jan 2013 18:25:11 -0800 Barry Grussling wrote: > While trying to bring up a custom MPC8308 based board I found > that the clocking was wrong. The comment in > include/configs/mpc8308_p1m.h led me to believe > setting HRCWH_PCI_HOST and HRCWH_PCI1_ARBITER_ENABLE in the > CONFIG_SYS_HRCW

Re: [U-Boot] [PATCH] MPC8308: Fixup clocks in PCI Host configuration

2013-01-08 Thread Kim Phillips
On Tue, 8 Jan 2013 10:24:05 -0800 Barry Grussling wrote: > While trying to bring up a custom MPC8308 based board I found > that the clocking was wrong. The comment in > include/configs/mpc8308_p1m.h led me to believe > setting HRCWH_PCI_HOST and HRCWH_PCI1_ARBITER_ENABLE in the > CONFIG_SYS_HRCW

Re: [U-Boot] [PATCH v2] env: don't generate callback list entries for SPL

2012-12-20 Thread Kim Phillips
break due to size limitations and/or unresolved symbols. > > A static inline function is used to provide a context in which we > can consume the callback, and thus avoid unused function warnings. > > Signed-off-by: Scott Wood > Acked-by: Joe Hershberger > ---

Re: [U-Boot] [PATCH 1/3] spl: Change PAD_TO to CONFIG_SPL_PAD_TO

2012-12-19 Thread Kim Phillips
On Thu, 6 Dec 2012 17:33:16 -0600 Scott Wood wrote: > This was already used by some SPL targets, and allows the pad amount to > be specified by board config headers rather than only in makefile > fragments. > > Also supply a pad-to of zero if the variable is undefined. It works > without this,

Re: [U-Boot] [PATCH v4 3/4] dtc/libfdt: introduce fdt types for annotation by endian checkers

2012-11-28 Thread Kim Phillips
regular integers. This patch adds these new fdtXX_t types and, ifdef __CHECKER__ (a symbol sparse defines), includes the bitwise annotation. Signed-off-by: Kim Phillips --- v2: adds bitwise awareness: determine host endianness manually, and annotate swabs with __force in fdtXX_to_cpu and

Re: [U-Boot] [PATCH v2] include/linux/byteorder: Always defines __fswab64, __swab64p and __swab64s

2012-11-15 Thread Kim Phillips
EORDER_HAS_U64__. > > Signed-off-by: Nobuhiro Iwamatsu > CC: Kim Phillips > --- > v2: Fix mail address. Reviewed-by: Kim Phillips Kim ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3 3/4] dtc/libfdt: introduce fdt types for annotation by endian checkers

2012-11-14 Thread Kim Phillips
On Thu, 15 Nov 2012 15:43:40 +1100 David Gibson wrote: > On Wed, Nov 14, 2012 at 06:59:58PM -0600, Kim Phillips wrote: > > +#define EXTRACT_BYTE(x, n) ((unsigned long long)((uint8_t *)&x)[n]) > > +#define __SWAB16(x) ((EXTRACT_BYTE(x, 0) << 8) | EXTRACT_BYTE(x, 1)

[U-Boot] [PATCH v3 3/4] dtc/libfdt: introduce fdt types for annotation by endian checkers

2012-11-14 Thread Kim Phillips
regular integers. This patch adds these new fdtXX_t types and, ifdef __CHECKER__ (a symbol sparse defines), includes the bitwise annotation. Signed-off-by: Kim Phillips --- v2: adds bitwise awareness: determine host endianness manually, and annotate swabs with __force in fdtXX_to_cpu and cpu_to_fdtXX

[U-Boot] [PATCH v2 2/4] dtc/fdtdump: include libfdt_env.h prior to fdt.h

2012-11-14 Thread Kim Phillips
in order to get the upcoming fdt type definitions. Signed-off-by: Kim Phillips Acked-by: David Gibson --- v2: added David's Acked-by. fdtdump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fdtdump.c b/fdtdump.c index 207a46d..8a7ae72 100644 --- a/fdtdump.c

[U-Boot] [PATCH v2 1/4] dtc/tests: don't include fdt.h prior to libfdt.h

2012-11-14 Thread Kim Phillips
tests will need fdt type definitions provided in a subsequent patch to libfdt_env.h. Since libfdt.h includes libfdt_env.h in the right order anyway, just remove the fdt.h include. Signed-off-by: Kim Phillips Acked-by: David Gibson --- v2: added David's Acked-by. tests/add_subnode_with_n

[U-Boot] [PATCH v2 4/4] dtc/libfdt: uintXX_t to fdtXX_t conversion

2012-11-14 Thread Kim Phillips
Now that fdt types are defined and annotated, use them to make sparse happy. Signed-off-by: Kim Phillips --- v2: reworded commit text libfdt/fdt.c | 2 +- libfdt/fdt_ro.c | 2 +- libfdt/fdt_rw.c | 4 ++-- libfdt/fdt_sw.c | 4 ++-- libfdt/fdt_wip.c | 2 +- libfdt/libfdt.h | 32

[U-Boot] [PATCH 3/4 v2] dtc/libfdt: introduce fdt types for annotation by endian checkers

2012-11-13 Thread Kim Phillips
regular integers. This patch adds these new fdtXX_t types and, ifdef __CHECKER__ (a symbol sparse defines), includes the bitwise annotation. Signed-off-by: Kim Phillips --- v2: adds bitwise awareness: determine host endianness manually, and annotate swabs with __force in fdtXX_to_cpu and cpu_to_fdtXX

Re: [U-Boot] [PATCH 1/2] libfdt: Add support for appending the values to a existing property

2012-11-13 Thread Kim Phillips
On Mon, 12 Nov 2012 21:41:17 -0500 Jerry Van Baren wrote: > On 11/08/2012 08:41 PM, Kim Phillips wrote: > > On Sat, 15 Sep 2012 10:36:28 -0400 > > Jerry Van Baren wrote: > >> Queued up 2 of 2 patches to the u-boot-fdt "next" branch. I'll issue a > &

Re: [U-Boot] [PATCH 1/2] libfdt: Add support for appending the values to a existing property

2012-11-08 Thread Kim Phillips
On Sat, 15 Sep 2012 10:36:28 -0400 Jerry Van Baren wrote: > On 08/27/2012 08:38 PM, Kim Phillips wrote: > > From: Minghuan Lian > > > > Some properties may contain multiple values, these values may need > > to be added to the property respectively. this patch prov

Re: [U-Boot] [PATCH v2 13/25] lib/zlib: sparse fixes

2012-11-08 Thread Kim Phillips
On Thu, 8 Nov 2012 12:20:51 +0100 Wolfgang Denk wrote: > In message <1351553687-12469-14-git-send-email-kim.phill...@freescale.com> > you wrote: > > define Z_NULL to (void *)0 include/u-boot/zlib.h to get rid of most of > > the NULL pointer warnings. > ... > > -#define Z_NULL 0 /* for initiali

Re: [U-Boot] [PATCH v2 09/25] common/cmd_*.c: sparse fixes

2012-11-08 Thread Kim Phillips
On Thu, 8 Nov 2012 11:48:54 +0100 Wolfgang Denk wrote: > In message <1351553687-12469-10-git-send-email-kim.phill...@freescale.com> > you wrote: > > > ... > > Signed-off-by: Kim Phillips > > Has anybody tested the impact of this change on the memory >

[U-Boot] [PATCH] common: fix help command breakage

2012-11-05 Thread Kim Phillips
code intended to use the maximum number of commands (not arguments to a command). this patch fixes both by making the allocation manually on the heap. Reported-by: Henrik Nordström Signed-off-by: Kim Phillips --- tested on an 8572ds board common/command.c | 21 - 1 file ch

Re: [U-Boot] [PATCH v2] net: Fix endianness bug in link-local

2012-11-05 Thread Kim Phillips
On Mon, 5 Nov 2012 10:13:45 -0600 Joe Hershberger wrote: > The ip is stored in network order, so we can't test it in host order. > > Signed-off-by: Joe Hershberger > --- > Changes in v2: > - Changed htonl() to ntohl() Reviewed

Re: [U-Boot] [PATCH] net: Fix endianness bug in link-local

2012-11-02 Thread Kim Phillips
On Thu, 1 Nov 2012 22:05:54 -0500 Joe Hershberger wrote: > The ip is stored in network order, so we can't test it in host order. > > Signed-off-by: Joe Hershberger > --- > net/link_local.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/link_local.c b/net/link_loc

Re: [U-Boot] [PATCH] 8xxx: Change all 8*xx_DDR addresses to 8xxx

2012-10-31 Thread Kim Phillips
ard (p4080ds), and one 83xx board > (mpc837xerdb). I'll give it a day or so before I apply it, in > case there are objections. It's mostly trivial, but touches > very sensitive code. missed one in fixed_sdram() in board/freescale/mpc8569mds/mpc8569mds.c (not use

[U-Boot] [PATCH] powerpc/mpc8xxx: take fdt_fixup_crypto_node() off the checkstack list

2012-10-31 Thread Kim Phillips
by moving compat_strlist into the .bss section. 0xfe004d80 fdt_fixup_crypto_node [u-boot]: 264 Signed-off-by: Kim Phillips --- arch/powerpc/cpu/mpc8xxx/fdt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/cpu/mpc8xxx/fdt.c b/arch/powerpc/cpu

Re: [U-Boot] [PATCH] libfdt: introduce fdt type annotation for use by endian checkers

2012-10-30 Thread Kim Phillips
On Tue, 30 Oct 2012 16:24:05 -0600 Stephen Warren wrote: > On 10/30/2012 03:57 PM, Kim Phillips wrote: > > Projects such as linux and u-boot run sparse on libfdt. libfdt > > contains the notion of endianness via usage of endian conversion > > functions such as fdt32_to_cp

[U-Boot] [PATCH] libfdt: introduce fdt type annotation for use by endian checkers

2012-10-30 Thread Kim Phillips
(a symbol sparse defines), for two new fdt types: fdt32_t and fdt64_t, and subsequently silences warnings emitted by sparse when parsing libfdt. Signed-off-by: Kim Phillips --- note: wasn't sure whether to introduce the new fdt32 types, or just have libfdt use __be32 directly. libfdt/

[U-Boot] [PATCH v2 01/25] include/linux/byteorder: import latest endian definitions from linux

2012-10-29 Thread Kim Phillips
called from here and: In file included from crc32.c:50:0: crc32table.h:4:1: warning: implicit declaration of function '___constant_swab32' [-Wimplicit-function-declaration] crc32table.h:4:1: error: initializer element is not constant crc32table.h:4:1: error: (near initialization for 

[U-Boot] [PATCH v2 00/32] Initial sparse fix series

2012-10-29 Thread Kim Phillips
utput will only include newly built code. fyi, I've pushed the series onto the u-boot-mpc83xx tree, 'sparsefixes' branch: http://git.denx.de/u-boot.git/?p=u-boot/u-boot-mpc83xx.git;a=shortlog;h=refs/heads/sparsefixes All power, arm, mips boards tested. Thanks, Kim Kim Phillips (

[U-Boot] [PATCH v2 15/25] arch/powerpc/cpu/mpc8xxx/: sparse fixes

2012-10-29 Thread Kim Phillips
imm_params.c:15:1: warning: symbol 'compute_cas_latency_ddr3' was not declared. Should it be static? making it static produces the following compiler warning: lc_common_dimm_params.c:15:1: warning: 'compute_cas_latency_ddr3' defined but not used [-Wunused-function] so

[U-Boot] [PATCH v2 25/25] drivers/serial/serial_ns16550.c: sparse fixes

2012-10-29 Thread Kim Phillips
Signed-off-by: Kim Phillips --- v2: checkpatch fixes. drivers/serial/serial_ns16550.c | 42 ++--- 1 file changed, 27 insertions(+), 15 deletions(-) diff --git a/drivers/serial/serial_ns16550.c b/drivers/serial/serial_ns16550.c index 4176e25..bf280ba 100644

[U-Boot] [PATCH v2 07/25] arch/powerpc/lib/board.c, *traps.c: sparse fixes

2012-10-29 Thread Kim Phillips
static? board.c:348:5: warning: symbol '__fixup_cpu' was not declared. Should it be static? board.c:405:53: warning: Using plain integer as NULL pointer Signed-off-by: Kim Phillips --- v2: added checkpatch fixes, undid making show_regs static, as it's used in cmd_begbug: traps.c:66:6

[U-Boot] [PATCH v2 12/25] drivers/net/: sparse fixes

2012-10-29 Thread Kim Phillips
h.c:48:6: warning: symbol 'dtsec_configure_serdes' was not declared. Should it be static? p4080.c:26:5: warning: symbol 'port_to_devdisr' was not declared. Should it be static? Signed-off-by: Kim Phillips --- v2: no changes drivers/net/fm/eth.c | 2 +- drivers/net/fm/p1023.c

[U-Boot] [PATCH v2 21/25] drivers/mmc/mmc.c: sparse fixes

2012-10-29 Thread Kim Phillips
7; was not declared. Should it be static? mmc.c:953:6: warning: symbol 'mmc_set_bus_width' was not declared. Should it be static? mmc.c:1108:26: warning: dubious: !x & y mmc.c:960:5: warning: symbol 'mmc_startup' was not declared. Should it be static? mmc.c:1

[U-Boot] [PATCH v2 02/25] include/linux/compat.h: fix warning: preprocessor token {__iomem, __user} redefined

2012-10-29 Thread Kim Phillips
definitions in compat.h code appears to be placed there as a cover up from a code import from linux when u-boot didn't yet have a compiler.h, introduced by commit 932394ac43e2e778e664eeb6e456fecd0fae6e59 "Rewrite of NAND code based on what is in 2.6.12 Linux kernel". Signed-off-b

[U-Boot] [PATCH v2 23/25] drivers/mtd/cfi_flash.c: sparse fixes

2012-10-29 Thread Kim Phillips
) cfi_flash.c:1508:61: warning: cast truncates bits from constant value (10001 becomes 1) cfi_flash.c:1738:63: warning: cast truncates bits from constant value (10001 becomes 1) cfi_flash.c:1857:6: warning: symbol '__flash_cmd_reset' was not declared. Should it be static? Signed-off-by: Ki

[U-Boot] [PATCH v2 18/25] drivers/block/: sparse fixes

2012-10-29 Thread Kim Phillips
*addr fsl_sata.c:297:53:got unsigned int * fsl_sata.c:298:53: warning: incorrect type in argument 1 (different address spaces) fsl_sata.c:298:53:expected unsigned int const volatile [noderef] *addr fsl_sata.c:298:53:got unsigned int * Signed-off-by: Kim Phillips --- v2: checkpatch fixes.

[U-Boot] [PATCH v2 22/25] drivers/mmc/fsl_esdhc.c: sparse fixes

2012-10-29 Thread Kim Phillips
fsl_esdhc.c:71:6: warning: symbol 'esdhc_xfertyp' was not declared. Should it be static? fsl_esdhc.c:413:6: warning: symbol 'set_sysctl' was not declared. Should it be st Signed-off-by: Kim Phillips --- v2: no changes drivers/mmc/fsl_esdhc.c | 4 ++-- 1 file changed

[U-Boot] [PATCH v2 20/25] drivers/input/input.c: sparse fix

2012-10-29 Thread Kim Phillips
input.c:97:5: warning: symbol 'input_queue_ascii' was not declared. Should it be Signed-off-by: Kim Phillips --- v2: no changes drivers/input/input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/input.c b/drivers/input/input.c index 9800667..04fa

  1   2   3   4   5   6   7   8   >