Hello Tom,
On Thu, Jan 16, 2025 at 01:11:25PM -0600, Tom Rini wrote:
> On Thu, Jan 16, 2025 at 04:11:40PM +0300, Dmitry Rokosov wrote:
> > Hello Quentin,
> >
> > On Tue, Jan 14, 2025 at 12:16:35PM +0100, Quentin Schulz wrote:
> > > Hi Dmitry,
> > >
>
Hello Simon,
On Tue, Jan 14, 2025 at 06:14:59AM -0700, Simon Glass wrote:
> Hi Dmitry,
>
> On Thu, 19 Dec 2024 at 14:42, Dmitry Rokosov
> wrote:
> >
> > Sometimes, it is necessary to provide an additional bootargs string to
> > the kernel command line.
> >
&
Hello Quentin,
On Tue, Jan 14, 2025 at 12:16:35PM +0100, Quentin Schulz wrote:
> Hi Dmitry,
>
> On 12/19/24 10:42 PM, Dmitry Rokosov wrote:
> > Sometimes, it is necessary to provide an additional bootargs string to
> > the kernel command line.
> >
> > We have
configurability of U-Boot for various kernel
images without relying on outdated configurations like CMDLINE_EXTEND.
CI/CD results: https://github.com/u-boot/u-boot/pull/716/checks
Signed-off-by: Dmitry Rokosov
---
Dmitry Rokosov (3):
include/fdt_support: fix docstyle to comply with kernel-doc
argument to
board_fdt_chosen_bootargs() to share the original 'chosen/bootargs' data
with the board code. Consequently, the board developer can decide how to
handle this information for their board setup: whether to drop it or
merge it with the bootargs environment.
Signed-off-by: Dmitry
/fdt_support.h:500: info: Scanning doc for fdt_kaslrseed
Signed-off-by: Dmitry Rokosov
---
include/fdt_support.h | 169 +-
1 file changed, 100 insertions(+), 69 deletions(-)
diff --git a/include/fdt_support.h b/include/fdt_support.h
index
It should be structured this way to demonstrate to the caller that
freeing the return value is unnecessary and that the caller cannot
modify it.
The function fdt_setprop() includes a parameter with a const char*
prototype, so it is better to use the const qualifier.
Signed-off-by: Dmitry Rokosov
On Thu, Oct 17, 2024 at 05:12:05PM +0300, Dmitry Rokosov wrote:
> The patch series include changes:
> - move ab_select_slot() documentation to @ notation
> - redesign 'bcb' command to U_BOOT_LONGHELP approach
> - move ab_select command to bcb subcommands
>
o useful for testing
slot_suffix problem code paths
Signed-off-by: Dmitry Rokosov
---
Changes in v5:
- rework direct #ifdefs to IS_ENABLED() macro
- redesign 'bcb' command to U_BOOT_LONGHELP approach
- check argc directly in the ab_select and ab_dump subcommands handlers
- Link to v4:
http
commands more succinctly.
Signed-off-by: Dmitry Rokosov
---
cmd/bcb.c | 151 ++
1 file changed, 43 insertions(+), 108 deletions(-)
diff --git a/cmd/bcb.c b/cmd/bcb.c
index
97a96c009641cc094645607ef833575f3c03fe4b
: Dmitry Rokosov
---
cmd/bcb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/bcb.c b/cmd/bcb.c
index
2854408e5669b0d7d2a06073fa81158b21834b99..b33c046af0385a112fd40634ab7f48e05542ca48
100644
--- a/cmd/bcb.c
+++ b/cmd/bcb.c
@@ -391,7 +391,7 @@ __maybe_unused static int
ce [1].
Links:
[1] -
https://source.android.com/docs/core/architecture/bootloader/updating#slots
Based-on:
https://android-review.googlesource.com/c/platform/external/u-boot/+/1446439
Reviewed-by: Mattijs Korpershoek
Reviewed-by: Simon Glass
Tested-by: Guillaume La Roque
Signed-off-by: Dmitry Ro
as the 'ab_select' subcommand, maintaining the same parameter list
for consistency.
Signed-off-by: Dmitry Rokosov
---
MAINTAINERS | 1 -
cmd/Kconfig | 14 ---
cmd/Makefile | 1 -
cmd/ab
Priority: 14
> - Tries Remaining: 7
> - Successful Boot: 0
> - Verity Corrupted: 0
The ab_dump command allows you to display ABC data directly on the
U-Boot console. During an A/B test execution, this test verifies the
accuracy of each
There are new function documentation requirements in U-Boot, so apply
these changes for android_ab.
Reviewed-by: Mattijs Korpershoek
Reviewed-by: Simon Glass
Tested-by: Guillaume La Roque
Signed-off-by: Dmitry Rokosov
---
boot/android_ab.c| 43
Hi Simon,
On Tue, Oct 15, 2024 at 09:27:14AM -0600, Simon Glass wrote:
> Hi Dmitry,
>
> On Tue, 15 Oct 2024 at 08:42, Dmitry Rokosov
> wrote:
> >
> > Hi Mattijs, Simon,
> >
> > On Tue, Oct 15, 2024 at 02:10:10PM +0200, Mattijs Korpershoek wrote:
> > &
On Tue, Oct 15, 2024 at 05:26:37PM +0200, Mattijs Korpershoek wrote:
> Hi Dmitry,
>
> On mar., oct. 15, 2024 at 16:26, Dmitry Rokosov
> wrote:
>
> > Hi Mattijs,
> >
> > On Tue, Oct 15, 2024 at 02:10:10PM +0200, Mattijs Korpershoek wrote:
> >> Hi Simon
Hi Mattijs, Simon,
On Tue, Oct 15, 2024 at 02:10:10PM +0200, Mattijs Korpershoek wrote:
> Hi Simon, Dmitry
>
> On lun., oct. 14, 2024 at 15:06, Simon Glass wrote:
>
> > Hi Dmitry,
> >
> > On Mon, 14 Oct 2024 at 14:38, Dmitry Rokosov
> > wrote:
> >>
Hi Mattijs,
On Tue, Oct 15, 2024 at 02:10:10PM +0200, Mattijs Korpershoek wrote:
> Hi Simon, Dmitry
>
> On lun., oct. 14, 2024 at 15:06, Simon Glass wrote:
>
> > Hi Dmitry,
> >
> > On Mon, 14 Oct 2024 at 14:38, Dmitry Rokosov
> > wrote:
> >>
>
ce [1].
Links:
[1] -
https://source.android.com/docs/core/architecture/bootloader/updating#slots
Based-on:
https://android-review.googlesource.com/c/platform/external/u-boot/+/1446439
Reviewed-by: Mattijs Korpershoek
Reviewed-by: Simon Glass
Tested-by: Guillaume La Roque
Signed-off-by: Dmitry Ro
as the 'ab_select' subcommand, maintaining the same parameter list
for consistency.
Signed-off-by: Dmitry Rokosov
---
MAINTAINERS | 1 -
cmd/Kconfig | 14 --
cmd/Makefile | 1 -
cmd/ab
ABC data.
Reviewed-by: Mattijs Korpershoek
Reviewed-by: Simon Glass
Tested-by: Guillaume La Roque
Signed-off-by: Dmitry Rokosov
---
boot/android_ab.c | 68 +++
cmd/bcb.c | 35 ++
include/andr
There are new function documentation requirements in U-Boot, so apply
these changes for android_ab.
Reviewed-by: Mattijs Korpershoek
Reviewed-by: Simon Glass
Tested-by: Guillaume La Roque
Signed-off-by: Dmitry Rokosov
---
boot/android_ab.c| 43
: Dmitry Rokosov
---
cmd/bcb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/bcb.c b/cmd/bcb.c
index
bf28726da91134fa287ca8aada884ed74ecc8f2b..3935b7f8d535e87593020b91a6b37d7c5ef02a83
100644
--- a/cmd/bcb.c
+++ b/cmd/bcb.c
@@ -439,7 +439,7 @@ static int do_bcb_ab_select
/lore.kernel.org/all/20240725194716.32232-1-ddroko...@salutedevices.com/
[2]
https://lore.kernel.org/all/20240911214945.15873-1-ddroko...@salutedevices.com/
Signed-off-by: Dmitry Rokosov
---
Changes in v4:
- add #ifdefs for CONFIG_ANDROID_AB in cmd/bcb.c to allow the usage of
the bcb command without A
Hello Mattijs,
On Sat, Oct 12, 2024 at 10:49:08AM +0200, Mattijs Korpershoek wrote:
> Hi Dmitry,
>
> On ven., oct. 11, 2024 at 21:00, Dmitry Rokosov
> wrote:
>
> > On Fri, Oct 11, 2024 at 04:20:39PM +0200, Mattijs Korpershoek wrote:
> >> On ven., oct. 11, 2024
On Fri, Oct 11, 2024 at 04:20:39PM +0200, Mattijs Korpershoek wrote:
> On ven., oct. 11, 2024 at 15:30, "Mattijs Korpershoek via groups.io"
> wrote:
>
> > Hi Dmitry,
> >
> > Thank you for the patch.
> >
> > On mar., oct. 08, 2024 at 23:18, Dmi
Hello Mattijs,
On Fri, Oct 11, 2024 at 04:22:43PM +0200, Mattijs Korpershoek wrote:
> Hi Dmitry,
>
> On jeu., oct. 10, 2024 at 14:17, "Mattijs Korpershoek via groups.io"
> wrote:
>
> [...]
>
> >>> > >
> >>> > > Reviewed-by: Simon Glass
> >>> > >
> >>> > > Can you also update the test?
> >>>
On Wed, Oct 09, 2024 at 03:13:57PM -0600, Simon Glass wrote:
> Hi Dmitry,
>
> On Wed, 9 Oct 2024 at 07:26, Dmitry Rokosov
> wrote:
> >
> > Hello Simon,
> >
> > On Tue, Oct 08, 2024 at 07:57:15PM -0600, Simon Glass wrote:
> > > On Tue, 8 Oc
hanks for your patches.
>
> Tested-by: Guillaume La Roque
>
>
> Le 08/10/2024 à 22:18, Dmitry Rokosov a écrit :
> > The patch series include changes:
> > - move ab_select_slot() documentation to @ notation
> > - move ab_select command to bcb subcommands
On Tue, Oct 08, 2024 at 11:18:03PM +0300, Dmitry Rokosov wrote:
> The patch series include changes:
> - move ab_select_slot() documentation to @ notation
> - move ab_select command to bcb subcommands
> - introduce the ab_dump command to print the content of the BCB
>
Hello Simon,
On Tue, Oct 08, 2024 at 07:57:15PM -0600, Simon Glass wrote:
> On Tue, 8 Oct 2024 at 14:18, Dmitry Rokosov
> wrote:
> >
> > It's really helpful to have the ability to dump BCB block for debugging
> > A/B logic on the board supported this partition
as the 'ab_select' subcommand, maintaining the same parameter list
for consistency.
Signed-off-by: Dmitry Rokosov
---
MAINTAINERS | 1 -
cmd/Kconfig | 15 +--
cmd/Makefile | 1 -
cmd/ab
ce [1].
Links:
[1] -
https://source.android.com/docs/core/architecture/bootloader/updating#slots
Based-on:
https://android-review.googlesource.com/c/platform/external/u-boot/+/1446439
Reviewed-by: Mattijs Korpershoek
Reviewed-by: Simon Glass
Signed-off-by: Dmitry Rokosov
---
boot/android_ab.
Priority: 14
> - Tries Remaining: 7
> - Successful Boot: 0
> - Verity Corrupted: 0
Signed-off-by: Dmitry Rokosov
---
boot/android_ab.c| 68
cmd/bcb.c| 35 +++
i
The ab_dump command allows you to display ABC data directly on the
U-Boot console. During an A/B test execution, this test verifies the
accuracy of each field within the ABC data.
Reviewed-by: Simon Glass
Reviewed-by: Mattijs Korpershoek
Signed-off-by: Dmitry Rokosov
---
test/py/tests
In the entire cmd/bcb.c file, the return value of strcmp() is not
directly compared to 0. Therefore, it would be better to maintain this
style in the new do_bcb_ab_select() function as well.
Reviewed-by: Mattijs Korpershoek
Reviewed-by: Simon Glass
Signed-off-by: Dmitry Rokosov
---
cmd/bcb.c
/lore.kernel.org/all/20240725194716.32232-1-ddroko...@salutedevices.com/
[2]
https://lore.kernel.org/all/20240911214945.15873-1-ddroko...@salutedevices.com/
Signed-off-by: Dmitry Rokosov
---
Dmitry Rokosov (6):
include/android_ab: move ab_select_slot() documentation to @ notation
treewide: bcb: mo
There are new function documentation requirements in U-Boot, so apply
these changes for android_ab.
Reviewed-by: Mattijs Korpershoek
Reviewed-by: Simon Glass
Signed-off-by: Dmitry Rokosov
---
boot/android_ab.c| 43 ---
include/android_ab.h | 7
On Mon, Sep 30, 2024 at 01:24:21PM +0200, Mattijs Korpershoek wrote:
> Hi Dmitry,
>
> Thank you for the patch.
>
> On jeu., sept. 12, 2024 at 00:49, Dmitry Rokosov
> wrote:
>
> > To enhance code organization, it is beneficial to consolidate all A/B
> > BCB
On Thu, Sep 12, 2024 at 10:10:53AM +0300, Dmitry Rokosov wrote:
> There are Pipeline results. One test was failed. I suppose it's not
> related to my patch series:
>
> https://github.com/u-boot/u-boot/pull/625/checks?check_run_id=30029925059
>
> =
Hello Tom,
On Thu, Sep 12, 2024 at 11:45:01AM -0600, Tom Rini wrote:
> On Thu, Sep 12, 2024 at 10:10:53AM +0300, Dmitry Rokosov wrote:
> > There are Pipeline results. One test was failed. I suppose it's not
> > related to my patch series:
> >
> > https://github.c
s: 1
=>
=== FAILURES =======
On Thu, Sep 12, 2024 at 12:49:08AM +0300, Dmitry Rokosov wrote:
> The patch series include changes:
> - move ab_select_slot() documentation to @ notation
> - move ab_select command to bcb subcommands
> - introd
necessary.
On Thu, Sep 12, 2024 at 12:49:13AM +0300, Dmitry Rokosov wrote:
> To align with the official Android BCB (Bootloader Control Block)
> specifications, it's important to note that the slot_suffix should start
> with an underscore symbol.
>
> For a comprehensive understan
as the 'ab_select' subcommand, maintaining the same parameter list
for consistency.
Signed-off-by: Dmitry Rokosov
---
MAINTAINERS | 1 -
cmd/Kconfig | 15 +
cmd/Makefile | 1 -
cmd/ab
d RvB tags
Links:
[1]
https://lore.kernel.org/all/20240725194716.32232-1-ddroko...@salutedevices.com/
Signed-off-by: Dmitry Rokosov
Dmitry Rokosov (6):
include/android_ab: move ab_select_slot() documentation to @ notation
treewide: bcb: move ab_select command to bcb subcommands
cmd: b
Priority: 14
> - Tries Remaining: 7
> - Successful Boot: 0
> - Verity Corrupted: 0
Signed-off-by: Dmitry Rokosov
---
boot/android_ab.c| 68
cmd/bcb.c| 35 +++
include
ce [1].
Links:
[1] -
https://source.android.com/docs/core/architecture/bootloader/updating#slots
Based-on:
https://android-review.googlesource.com/c/platform/external/u-boot/+/1446439
Signed-off-by: Dmitry Rokosov
Reviewed-by: Simon Glass
Reviewed-by: Mattijs Korpershoek
---
boot/android_ab.
There are new function documentation requirements in U-Boot, so apply
these changes for android_ab.
Signed-off-by: Dmitry Rokosov
---
boot/android_ab.c| 43 ---
include/android_ab.h | 7 ---
2 files changed, 28 insertions(+), 22 deletions
The ab_dump command allows you to display ABC data directly on the
U-Boot console. During an A/B test execution, this test verifies the
accuracy of each field within the ABC data.
Signed-off-by: Dmitry Rokosov
Reviewed-by: Mattijs Korpershoek
---
test/py/tests/test_android/test_ab.py | 23
In the entire cmd/bcb.c file, the return value of strcmp() is not
directly compared to 0. Therefore, it would be better to maintain this
style in the new do_bcb_ab_select() function as well.
Signed-off-by: Dmitry Rokosov
---
cmd/bcb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
. 28, 2024 at 13:36, Simon Glass wrote:
> >
> > > Hi Dmitry,
> > >
> > > On Thu, 25 Jul 2024 at 14:55, Dmitry Rokosov
> > > wrote:
> > >>
> > >> It's really helpful to have the ability to dump BCB block for debugging
> >
On Tue, Jul 30, 2024 at 10:43:13AM +0200, Mattijs Korpershoek wrote:
> Hi Dmitry,
>
> Thank you for the patch.
>
> On jeu., juil. 25, 2024 at 22:47, Dmitry Rokosov
> wrote:
>
> > To align with the official Android BCB (Boot Control Block)
> > specifications
On Sun, Jul 28, 2024 at 01:36:04PM -0600, Simon Glass wrote:
> Hi Dmitry,
>
> On Thu, 25 Jul 2024 at 14:55, Dmitry Rokosov
> wrote:
> >
> > It's really helpful to have the ability to dump BCB block for debugging
> > A/B logic on the board supported this partiti
On Sun, Jul 28, 2024 at 01:36:06PM -0600, Simon Glass wrote:
> Hi Dmitry,
>
> On Thu, 25 Jul 2024 at 14:55, Dmitry Rokosov
> wrote:
> >
> > To align with the official Android BCB (Boot Control Block)
> > specifications, it's important to note that the s
Hello Simon,
On Sun, Jul 28, 2024 at 01:36:05PM -0600, Simon Glass wrote:
> Hi Dmitry,
>
> On Thu, 25 Jul 2024 at 14:55, Dmitry Rokosov
> wrote:
> >
> > The ab_dump command allows you to display ABC data directly on the
> > U-Boot console. During an A/B test exe
Azure pipeline is successfully DONE
https://github.com/u-boot/u-boot/pull/625/checks
On Thu, Jul 25, 2024 at 10:47:00PM +0300, Dmitry Rokosov wrote:
> The patch series include changes:
> - fix indentation problems for --no-dec parameter in the ab_select
> command
> - i
Command ab_select has wrong help description from indentation
perspective.
Signed-off-by: Dmitry Rokosov
---
cmd/ab_select.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/cmd/ab_select.c b/cmd/ab_select.c
index bfb67b8236b6..9e2f74573c22 100644
--- a/cmd/ab_select.c
s:
[1] -
https://source.android.com/docs/core/architecture/bootloader/updating#slots
Signed-off-by: Dmitry Rokosov
---
boot/android_ab.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/boot/android_ab.c b/boot/android_ab.c
index 359cc1a00428..45c154b10f1a 100644
--- a
5
> - Successful Boot: 0
> - Verity Corrupted: 0
Signed-off-by: Dmitry Rokosov
---
boot/android_ab.c| 68
cmd/ab_select.c | 30 +++
include/android_ab.h | 9 ++
3 files changed, 107 insert
The ab_dump command allows you to display ABC data directly on the
U-Boot console. During an A/B test execution, this test verifies the
accuracy of each field within the ABC data.
Signed-off-by: Dmitry Rokosov
---
test/py/tests/test_android/test_ab.py | 23 +++
1 file
nd to verify the accuracy of each
field within the ABC data displayed.
- fix the slot suffix format in the ABC block to align with official
Android BCB specifications
Dmitry Rokosov (4):
cmd: ab_select: fix indentation problems for --no-dec parameter
cmd: ab: introduce &#x
62 matches
Mail list logo
