In the entire cmd/bcb.c file, the return value of strcmp() is not
directly compared to 0. Therefore, it would be better to maintain this
style in the new do_bcb_ab_select() function as well.

Reviewed-by: Mattijs Korpershoek <mkorpersh...@baylibre.com>
Reviewed-by: Simon Glass <s...@chromium.org>
Tested-by: Guillaume La Roque <glaro...@baylibre.com>
Signed-off-by: Dmitry Rokosov <ddroko...@salutedevices.com>
---
 cmd/bcb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmd/bcb.c b/cmd/bcb.c
index 
bf28726da91134fa287ca8aada884ed74ecc8f2b..3935b7f8d535e87593020b91a6b37d7c5ef02a83
 100644
--- a/cmd/bcb.c
+++ b/cmd/bcb.c
@@ -439,7 +439,7 @@ static int do_bcb_ab_select(struct cmd_tbl *cmdtp, int 
flag, int argc,
        bool dec_tries = true;
 
        for (int i = 4; i < argc; i++) {
-               if (strcmp(argv[i], "--no-dec") == 0)
+               if (!strcmp(argv[i], "--no-dec"))
                        dec_tries = false;
                else
                        return CMD_RET_USAGE;

-- 
2.43.0

Reply via email to