Re: [PATCH 4/6] firmware: ti_sci.c: Add a function to request DM metadata using ti_sci* calls

2025-06-03 Thread Dhruva Gole
On May 28, 2025 at 13:35:17 +0530, Moteen Shah wrote: > Add a function to retrieve information of the DM firmware's ABI versions, > RM/PM HAL, firmware version, etc using TI_SCI protocol. > > Signed-off-by: Moteen Shah > --- Reviewed-by: Dhruva Gole -- Best regard

Re: [PATCH 1/6] ti_sci_*: Add utility to access tisci firmware and SOC capability

2025-06-03 Thread Dhruva Gole
gt; > Signed-off-by: Moteen Shah > --- Reviewed-by: Dhruva Gole -- Best regards, Dhruva Gole Texas Instruments Incorporated

Re: [PATCH 3/6] firmware: ti_sci.c: Add a function to query DM firmware's capability

2025-06-03 Thread Dhruva Gole
by: Moteen Shah > --- > drivers/firmware/ti_sci.c | 45 +++ > 1 file changed, 45 insertions(+) > Reviewed-by: Dhruva Gole -- Best regards, Dhruva Gole Texas Instruments Incorporated

Re: [PATCH 2/6] ti_sci_* : Add capability to access DM firmware's metadata

2025-06-03 Thread Dhruva Gole
ry else appropriate error value. > */ > struct ti_sci_firmware_ops { > int (*query_dm_cap)(struct ti_sci_handle *handle, > u64 *dm_cap); > + int (*get_dm_version)(struct ti_sci_handle *handle, > + struct ti_sci_dm_version_info *get_dm_version); Reviewed-by: Dhruva Gole -- Best regards, Dhruva Gole Texas Instruments Incorporated

Re: [PATCH] doc: board: ti: Add missing firmware for BB-AI64

2025-05-27 Thread Dhruva Gole
R5 build as sysfw.itb Thanks for adding this, and I am okay with the changes. But also, does it make sense to make all of this inherit from a label that we can add inside [1] and include that here directly? I am okay if you just wanna label the gp part and include it here as well. Either way, Revi

Re: [PATCH] doc: board: ti: Add optee rng support

2025-04-10 Thread Dhruva Gole
; $ export OPTEE_PLATFORM=k3-am62x > - $ export OPTEE_EXTRA_ARGS="CFG_WITH_SOFTWARE_PRNG=y" Fine by me, Reviewed-by: Dhruva Gole -- Best regards, Dhruva Gole Texas Instruments Incorporated

Re: [PATCH V2] firmware: ti_sci: Scan all device instances when releasing exclusive devices

2025-04-10 Thread Dhruva Gole
7ae0a ("firmware: ti_sci: Add a command for releasing all > exclusive devices") > Signed-off-by: Nishanth Menon > --- > Changes since V1: > * commit message: s/intent/intend (review comment) > * Added comment to indicate am64x-sk > * No functional changes. Thanks for addressing concerns from previous series and also discussing about alternate approaches. Reviewed-by: Dhruva Gole -- Best regards, Dhruva Gole Texas Instruments Incorporated

Re: [PATCH] firmware: ti_sci: Scan all device instances when releasing exclusive devices

2025-04-01 Thread Dhruva Gole
..aa4d105ee988 100644 > --- a/include/linux/soc/ti/ti_sci_protocol.h > +++ b/include/linux/soc/ti/ti_sci_protocol.h > @@ -143,7 +143,7 @@ struct ti_sci_dev_ops { >u32 reset_state); > int (*get_device_resets)(const struct ti_sci_handle *handle, u32 id, >u32 *reset_state); > - int (*release_exclusive_devices)(const struct ti_sci_handle *handle); > + int (*release_exclusive_devices)(void); Nit: Just update the copyright dates of the files you're touching... -- Best regards, Dhruva Gole Texas Instruments Incorporated

Re: [PATCH v2 1/3] arch: arm: dts: phyboard-electra-uboot.dtsi: Add bootph props to i2c

2025-02-04 Thread Dhruva Gole
; + bootph-all; > +}; > + > +&main_i2c0_pins_default { > + bootph-all; > +}; > + Reviewed-by: Dhruva Gole -- Best regards, Dhruva Gole Texas Instruments Incorporated

Re: [PATCH v2 2/3] board: phytec: phycore_am64x: Add support for 1 GB RAM variant and ECC

2025-02-04 Thread Dhruva Gole
= gd->bd->bi_dram[bank].size; > + } > + > + return fdt_fixup_memory_banks(fdt, start, size, CONFIG_NR_DRAM_BANKS); > +} > +#endif Nit: Try and end #endifs like this: #endif /* CONFIG_K3_DDRSS */ Follow the convention everywhere else as it really improves code readability. > + > +#if IS_ENABLED(CONFIG_XPL_BUILD) > +void spl_perform_fixups(struct spl_image_info *spl_image) > +{ > + if (IS_ENABLED(CONFIG_K3_DDRSS) && IS_ENABLED(CONFIG_K3_INLINE_ECC)) > + fixup_ddr_driver_for_ecc(spl_image); > + else > + fixup_memory_node(spl_image); > } > +#endif > > #define CTRLMMR_USB0_PHY_CTRL0x43004008 > #define CORE_VOLTAGE 0x8000 > -- > 2.34.1 > -- Best regards, Dhruva Gole Texas Instruments Incorporated

Re: [PATCH v2 3/3] configs: phycore_am64x_r5_defconfig: Enable PHYTEC_SOM_DETECTION

2025-02-04 Thread Dhruva Gole
On Feb 05, 2025 at 05:30:13 +0100, Wadim Egorov wrote: > Enable configs required for detecting and fixing up for different RAM > variants. > Also resync after savedefconfig. > > Signed-off-by: Wadim Egorov > Tested-by: Daniel Schultz > --- Reviewed-by: Dhruva Gole --

Re: [PATCH] arm64: configs: Remove SYS_BOOTM_LEN for TI devices

2025-01-29 Thread Dhruva Gole
-base parameter while generating the patch file to include the commit SHA on which your patch is based on. Otherwise, LGTM Reviewed-by: Dhruva Gole > > Reference patch: > https://lore.kernel.org/u-boot/20240708-remove-bootm-len-v1-1-2a5370614...@ti.com/ > > --- &

Re: [PATCH 1/3] arch: arm: dts: phyboard-electra-uboot.dtsi: Add bootph props to i2c

2025-01-26 Thread Dhruva Gole
torvalds/linux.git/tree/arch/arm64/boot/dts/ti/k3-am642-phyboard-electra-rdk.dts -- Best regards, Dhruva Gole Texas Instruments Incorporated

Re: [PATCH v2 2/2] doc: board: phytec: Add phyCORE-AM62ax

2024-11-18 Thread Dhruva Gole
On Nov 18, 2024 at 15:16:06 -0800, Garrett Giordano wrote: > Add documentation for PHYTEC phyCORE-AM62ax SoM. > > Signed-off-by: Garrett Giordano > Reviewed-by: Wadim Egorov > --- Reviewed-by: Dhruva Gole -- Best regards, Dhruva Gole Texas Instruments Incorporated

[PATCH V8 7/7] arm: dts: phycore-am62x: Package TIFS Stub

2024-08-05 Thread Dhruva Gole
Wadim Egorov Signed-off-by: Dhruva Gole --- arch/arm/dts/k3-am625-phycore-som-binman.dtsi | 101 +- doc/board/phytec/phycore-am62x.rst| 2 +- 2 files changed, 100 insertions(+), 3 deletions(-) diff --git a/arch/arm/dts/k3-am625-phycore-som-binman.dtsi b/arch/arm/dts/

[PATCH V8 6/7] doc: beagle: am62x_beagleplay: Document the use of TIFS Stub

2024-08-05 Thread Dhruva Gole
Signed-off-by: Dhruva Gole --- doc/board/beagle/am62x_beagleplay.rst | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/doc/board/beagle/am62x_beagleplay.rst b/doc/board/beagle/am62x_beagleplay.rst index 01f04beb55aa..bc71aabaac3e 100644 --- a/doc/board/beagle

[PATCH V8 5/7] arm: dts: k3-am625-beagleplay: Package TIFS Stub

2024-08-05 Thread Dhruva Gole
by TI, Since TI doesn't have access to the customer key it cannot have a component that is signed by customer key. Hence, it's left as part of binman to be signed and packaged. Reviewed-by: Nishanth Menon Acked-by: Neha Malcom Francis Signed-off-by: Dhruva Gole --- arch/arm/dts/k3-am6

[PATCH V8 4/7] doc: ti: am62*: Mention TIFS Stub in img fmts and boot flow

2024-08-05 Thread Dhruva Gole
Since AM62x, AM62P and AM62A all use similar boot flows and their low power mode s/w ARCH is also similar in the way that they make use of the TIFS Stub, update their documentation to show where TIFS Stub is. Reviewed-by: Nishanth Menon Signed-off-by: Dhruva Gole --- doc/board/ti/am62ax_sk.rst

[PATCH V8 3/7] doc: board: ti: Update to use the new boot firmware labels

2024-08-05 Thread Dhruva Gole
Use the new boot_firmwares labels that help make documentation more specific as to which firmwares are used in which devices Signed-off-by: Dhruva Gole --- doc/board/beagle/j721e_beagleboneai64.rst | 4 doc/board/phytec/phycore-am62x.rst| 4 doc/board/phytec/phycore-am64x.rst

[PATCH V8 2/7] doc: ti: k3: Add TIFS Stub documentation

2024-08-05 Thread Dhruva Gole
split the firmware documentation chunks. This will make it easier to include them one by one wherever applicable Reviewed-by: Nishanth Menon Signed-off-by: Dhruva Gole --- doc/board/ti/am62ax_sk.rst| 4 +++ doc/board/ti/am62px_sk.rst| 4 +++ doc/board/ti/am62x_sk.rst |

[PATCH V8 1/7] MAINTAINERS: Include the TI docs under ARM TI

2024-08-05 Thread Dhruva Gole
Add entry for the TI boards documentation under ARM TI Reviewed-by: Nishanth Menon Signed-off-by: Dhruva Gole --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ddcb7128db4e..f1fe19e0f002 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -732,6

[PATCH V8 0/7] Low Power Mode: Package TIFS Stub in BeaglePlay

2024-08-05 Thread Dhruva Gole
includes the binman related changes required to package TIFS Stub to support Low Power Modes on BeaglePlay and phycore-am625 SOM. Changelog: ** No changes other than picking up R-by's and rebased. Link to v7: https://lore.kernel.org/all/20240725093546.4193107-1-d-g...@ti.com/ Dhruva

[PATCH V7 7/7] arm: dts: phycore-am62x: Package TIFS Stub

2024-07-25 Thread Dhruva Gole
by TI, Since TI doesn't have access to the customer key it cannot have a component that is signed by customer key. Hence, it's left as part of binman to be signed and packaged. While at it, also make sure it's documented in phycore-am62x Signed-off-by: Dhruva Gole --- arch/arm/

[PATCH V7 6/7] doc: beagle: am62x_beagleplay: Document the use of TIFS Stub

2024-07-25 Thread Dhruva Gole
* Include the actual common documentation about the TIFS Stub and role it plays to enable Low Power Modes in the platform. * Add the AM62x boot flow to show at which point the TIFS Stub actually gets loaded. * Mention the TIFS Stub in the TISPL image format. Signed-off-by: Dhruva Gole

[PATCH V7 5/7] arm: dts: k3-am625-beagleplay: Package TIFS Stub

2024-07-25 Thread Dhruva Gole
by TI, Since TI doesn't have access to the customer key it cannot have a component that is signed by customer key. Hence, it's left as part of binman to be signed and packaged. Acked-by: Neha Malcom Francis Signed-off-by: Dhruva Gole --- arch/arm/dts/k3-am625-beagleplay-u

[PATCH V7 4/7] doc: ti: am62*: Mention TIFS Stub in img fmts and boot flow

2024-07-25 Thread Dhruva Gole
Since AM62x, AM62P and AM62A all use similar boot flows and their low power mode s/w ARCH is also similar in the way that they make use of the TIFS Stub, update their documentation to show where TIFS Stub is. Signed-off-by: Dhruva Gole --- doc/board/ti/am62ax_sk.rst |4

[PATCH V7 3/7] doc: board: ti: Update to use the new boot firmware labels

2024-07-25 Thread Dhruva Gole
Use the new boot_firmwares labels that help make documentation more specific as to which firmwares are used in which devices Signed-off-by: Dhruva Gole --- doc/board/beagle/j721e_beagleboneai64.rst | 4 doc/board/phytec/phycore-am62x.rst| 4 doc/board/phytec/phycore-am64x.rst

[PATCH V7 2/7] doc: ti: k3: Add TIFS Stub documentation

2024-07-25 Thread Dhruva Gole
split the firmware documentation chunks. This will make it easier to include them one by one wherever applicable Signed-off-by: Dhruva Gole --- doc/board/ti/am62ax_sk.rst| 4 +++ doc/board/ti/am62px_sk.rst| 4 +++ doc/board/ti/am62x_sk.rst | 4 +++ doc/board

[PATCH V7 1/7] MAINTAINERS: Include the TI docs under ARM TI

2024-07-25 Thread Dhruva Gole
Add entry for the TI boards documentation under ARM TI Signed-off-by: Dhruva Gole --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index a6e47e8a2179..d9af2aac6251 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -732,6 +732,7 @@ F: arch/arm/mach-omap2

[PATCH V7 0/7] Low Power Mode: Package TIFS Stub in BeaglePlay

2024-07-25 Thread Dhruva Gole
fixup in am64-phycore docs include sysfw Link to v6: https://lore.kernel.org/all/20240719070312.3771755-1-d-g...@ti.com/ Dhruva Gole (7): MAINTAINERS: Include the TI docs under ARM TI doc: ti: k3: Add TIFS Stub documentation doc: board: ti: Update to use the new boot firmware labels doc

[PATCH V6 5/6] arm: dts: k3-am625-beagleplay: Package TIFS Stub

2024-07-19 Thread Dhruva Gole
by TI, Since TI doesn't have access to the customer key it cannot have a component that is signed by customer key. Hence, it's left as part of binman to be signed and packaged. Acked-by: Neha Malcom Francis Signed-off-by: Dhruva Gole --- arch/arm/dts/k3-am625-beagleplay-u

[PATCH V6 0/6] Low Power Mode: Package TIFS Stub in BeaglePlay

2024-07-19 Thread Dhruva Gole
documentation in each soc. * Reword the TIFS Stub documentation slightly to show that DM can be built by customers and is open source. Link to v5: https://lore.kernel.org/all/20240705164833.2386549-1-d-g...@ti.com/ Dhruva Gole (6): MAINTAINERS: Include the TI docs under ARM TI doc: ti: k3

[PATCH V6 6/6] doc: beagle: am62x_beagleplay: Document the use of TIFS Stub

2024-07-19 Thread Dhruva Gole
* Include the actual common documentation about the TIFS Stub and role it plays to enable Low Power Modes in the platform. * Add the AM62x boot flow to show at which point the TIFS Stub actually gets loaded. * Mention the TIFS Stub in the TISPL image format. Signed-off-by: Dhruva Gole

[PATCH V6 4/6] doc: ti: am62*: Mention TIFS Stub in img fmts and boot flow

2024-07-19 Thread Dhruva Gole
Since AM62x, AM62P and AM62A all use similar boot flows and their low power mode s/w ARCH is also similar in the way that they make use of the TIFS Stub, update their documentation to show where TIFS Stub is. Signed-off-by: Dhruva Gole --- doc/board/ti/am62ax_sk.rst |4

[PATCH V6 2/6] doc: ti: k3: Add TIFS Stub documentation

2024-07-19 Thread Dhruva Gole
split the firmware documentation chunks. This will make it easier to include them one by one wherever applicable Signed-off-by: Dhruva Gole --- doc/board/ti/am62ax_sk.rst| 4 +++ doc/board/ti/am62px_sk.rst| 4 +++ doc/board/ti/am62x_sk.rst | 4 +++ doc/board

[PATCH V6 3/6] doc: board: ti: Update to use the new boot firmware labels

2024-07-19 Thread Dhruva Gole
Use the new boot_firmwares labels that help make documentation more specific as to which firmwares are used in which devices Signed-off-by: Dhruva Gole --- doc/board/beagle/j721e_beagleboneai64.rst | 4 doc/board/phytec/phycore-am62x.rst| 4 doc/board/phytec/phycore-am64x.rst

[PATCH V6 1/6] MAINTAINERS: Include the TI docs under ARM TI

2024-07-19 Thread Dhruva Gole
Add entry for the TI boards documentation under ARM TI Signed-off-by: Dhruva Gole --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 19ca57d200b9..23246414d6f4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -732,6 +732,7 @@ F: arch/arm/mach-omap2

Re: [PATCH V5 0/6] Low Power Mode: Package TIFS Stub in BeaglePlay

2024-07-18 Thread Dhruva Gole
On Jul 17, 2024 at 13:49:07 -0500, Nishanth Menon wrote: > On 22:18-20240705, Dhruva Gole wrote: > > This series includes the binman related changes required to package TIFS > > Stub to support Low Power Modes on BeaglePlay. > > It also documents the boot flow and tispl packag

Re: [PATCH V5 4/6] doc: ti: k3: Add TIFS Stub documentation

2024-07-18 Thread Dhruva Gole
On Jul 17, 2024 at 13:47:19 -0500, Nishanth Menon wrote: > On 22:18-20240705, Dhruva Gole wrote: > > Add documentation to briefly explain the role of TIFS Stub in relevant > > K3 SoC's. > > This also sheds light on why TIFS Stub isn't package with the DM firmware >

[PATCH V5 6/6] MAINTAINERS: Include the TI docs under ARM TI

2024-07-05 Thread Dhruva Gole
Add entry for the TI boards documentation under ARM TI Signed-off-by: Dhruva Gole --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6b32a6d94644..da730c6e4840 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -733,6 +733,7 @@ F: arch/arm/mach-omap2

[PATCH V5 4/6] doc: ti: k3: Add TIFS Stub documentation

2024-07-05 Thread Dhruva Gole
Add documentation to briefly explain the role of TIFS Stub in relevant K3 SoC's. This also sheds light on why TIFS Stub isn't package with the DM firmware itself. Signed-off-by: Dhruva Gole --- doc/board/ti/k3.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/b

[PATCH V5 5/6] doc: ti: am62*: Mention TIFS Stub in img fmts and boot flow

2024-07-05 Thread Dhruva Gole
Since AM62x, AM62P and AM62A all use similar boot flows and their low power mode s/w ARCH is also similar in the way that they make use of the TIFS Stub, update their documentation to show where TIFS Stub is. Signed-off-by: Dhruva Gole --- doc/board/ti/am62ax_sk.rst | 4 ++-- doc/board/ti

[PATCH V5 3/6] doc: beagle: am62x_beagleplay: Add TIFS Stub in image format

2024-07-05 Thread Dhruva Gole
Mention the TIFS Stub in the TISP image format Signed-off-by: Dhruva Gole --- doc/board/beagle/am62x_beagleplay.rst | 2 +- doc/board/ti/img/tifsstub_dm_tispl.bin.svg | 353 + 2 files changed, 354 insertions(+), 1 deletion(-) create mode 100644 doc/board/ti/img

[PATCH V5 2/6] doc: beagle: am62x_beagleplay: Update the boot flow to show TIFS Stub

2024-07-05 Thread Dhruva Gole
Add the AM62x boot flow to show at which point the TIFS Stub actually gets loaded. Signed-off-by: Dhruva Gole --- doc/board/beagle/am62x_beagleplay.rst |2 +- doc/board/ti/img/boot_diagram_am62.svg | 1983 2 files changed, 1984 insertions(+), 1 deletion(-) create

[PATCH V5 1/6] arm: dts: k3-am625-beagleplay: Package TIFS Stub

2024-07-05 Thread Dhruva Gole
by TI, Since TI doesn't have access to the customer key it cannot have a component that is signed by customer key. Hence, it's left as part of binman to be signed and packaged. Acked-by: Neha Malcom Francis Signed-off-by: Dhruva Gole --- arch/arm/dts/k3-am625-beagleplay-u

[PATCH V5 0/6] Low Power Mode: Package TIFS Stub in BeaglePlay

2024-07-05 Thread Dhruva Gole
ub in DM. Link to previous series: https://lore.kernel.org/u-boot/20240704084207.2211801-1-d-g...@ti.com/ [1] https://lore.kernel.org/u-boot/20240705151753.7v3geqkupqu673x3@ambiance/ Thanks for the explanation given in [1] Sebin, Cc: Sebin Francis Dhruva Gole (6): arm: dts: k3-am625-beagl

Re: [PATCH v3 01/10] common: spl: spl: Init DRAM size in R5/A53 SPL

2024-07-04 Thread Dhruva Gole
On Jul 05, 2024 at 10:20:21 +0530, Chintan Vankar wrote: > Initialize DRAM size in SPL stage since networking requires DDR > to be initialized. > > Signed-off-by: Kishon Vijay Abraham I > Signed-off-by: Chintan Vankar > --- > Reviewed-by: Dhruva Gole Best regards,

Re: [PATCH 8/9] board: phytec: phycore_am62x: Use k3_mmc.env logic

2024-07-04 Thread Dhruva Gole
On Jul 02, 2024 at 22:42:01 -0700, Daniel Schultz wrote: > Use our common environment file to implement MMC boot. > > Signed-off-by: Daniel Schultz > --- Reviewed-by: Dhruva Gole > board/phytec/phycore_am62x/phycore_am62x.env | 11 +-- > 1 file changed, 1 insertio

[PATCH V4 6/6] MAINTAINERS: Include the TI docs under ARM TI

2024-07-04 Thread Dhruva Gole
Add entry for the TI boards documentation under ARM TI Signed-off-by: Dhruva Gole --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6b32a6d94644..da730c6e4840 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -733,6 +733,7 @@ F: arch/arm/mach-omap2

[PATCH V4 4/6] doc: ti: k3: Add TIFS Stub documentation

2024-07-04 Thread Dhruva Gole
Add documentation to briefly explain the role of TIFS Stub in relevant K3 SoC's. Signed-off-by: Dhruva Gole --- doc/board/ti/k3.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/board/ti/k3.rst b/doc/board/ti/k3.rst index 67b066a07d3a..2f63852b3801 100644 --- a/doc/board/

[PATCH V4 5/6] doc: ti: am62*: Mention TIFS Stub in img fmts and boot flow

2024-07-04 Thread Dhruva Gole
Since AM62x, AM62P and AM62A all use similar boot flows and their low power mode s/w ARCH is also similar in the way that they make use of the TIFS Stub, update their documentation to show where TIFS Stub is. Signed-off-by: Dhruva Gole --- doc/board/ti/am62ax_sk.rst | 4 ++-- doc/board/ti

[PATCH V4 3/6] doc: beagle: am62x_beagleplay: Add TIFS Stub in image format

2024-07-04 Thread Dhruva Gole
Mention the TIFS Stub in the TISP image format Signed-off-by: Dhruva Gole --- doc/board/beagle/am62x_beagleplay.rst | 2 +- doc/board/ti/img/tifsstub_dm_tispl.bin.svg | 353 + 2 files changed, 354 insertions(+), 1 deletion(-) create mode 100644 doc/board/ti/img

[PATCH V4 2/6] doc: beagle: am62x_beagleplay: Update the boot flow to show TIFS Stub

2024-07-04 Thread Dhruva Gole
Add the AM62x boot flow to show at which point the TIFS Stub actually gets loaded. Signed-off-by: Dhruva Gole --- doc/board/beagle/am62x_beagleplay.rst |2 +- doc/board/ti/img/boot_diagram_am62.svg | 1983 2 files changed, 1984 insertions(+), 1 deletion(-) create

[PATCH V4 1/6] arm: dts: k3-am625-beagleplay: Package TIFS Stub

2024-07-04 Thread Dhruva Gole
Add support for packaging the TIFS Stub as it's required for basic Low Power Modes like Deep Sleep. Acked-by: Neha Malcom Francis Signed-off-by: Dhruva Gole --- arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 33 +++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --

[PATCH V4 0/6] Low Power Mode: Package TIFS Stub in BeaglePlay

2024-07-04 Thread Dhruva Gole
formatting errors. * Add entry to MAINTAINERS for doc/board/ti Link to previous series: https://lore.kernel.org/u-boot/20240628093252.1864609-1-d-g...@ti.com/ Dhruva Gole (6): arm: dts: k3-am625-beagleplay: Package TIFS Stub doc: beagle: am62x_beagleplay: Update the boot flow to show TIFS Stub

[PATCH] doc: ti: am62*: Add in TIFS Stub boot flow and img fmts

2024-06-28 Thread Dhruva Gole
Since AM62x, AM62P and AM62A all use similar boot flows and their low power mode s/w ARCH is also similar in the way that they make use of the TIFS Stub, update their documentation to show where TIFS Stub is. Signed-off-by: Dhruva Gole --- This series depends on TIFS Stub BeaglePlay series sent

[PATCH V3 4/4] doc: ti: k3: Add TIFS Stub documentation

2024-06-28 Thread Dhruva Gole
Add documentation to briefly explain the role of TIFS Stub in relevant K3 SoC's. Signed-off-by: Dhruva Gole --- doc/board/ti/k3.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/board/ti/k3.rst b/doc/board/ti/k3.rst index 88821a15e4c6..f45a285db21b 100644 --- a/doc/board/

[PATCH V3 3/4] doc: beagle: am62x_beagleplay: Add TIFS Stub in image format

2024-06-28 Thread Dhruva Gole
Mention the TIFS Stub in the TISP image format Signed-off-by: Dhruva Gole --- doc/board/beagle/am62x_beagleplay.rst | 2 +- doc/board/ti/img/tifsstub_dm_tispl.bin.svg | 4 2 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 doc/board/ti/img/tifsstub_dm_tispl.bin.svg

[PATCH V3 2/4] doc: beagle: am62x_beagleplay: Update the boot flow to show TIFS Stub

2024-06-28 Thread Dhruva Gole
Add the AM62x boot flow to show at which point the TIFS Stub actually gets loaded. Signed-off-by: Dhruva Gole --- doc/board/beagle/am62x_beagleplay.rst | 2 +- doc/board/ti/img/boot_diagram_am62.svg | 4 2 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 doc/board/ti/img

[PATCH V3 0/4] Low Power Mode: Pakage TIFS Stub on BeaglePlay

2024-06-28 Thread Dhruva Gole
image format for TISPL * Add new changes in boot flow for am62 family of devices. [0] https://lore.kernel.org/u-boot/20240618045610.271884-1-d-g...@ti.com/ Dhruva Gole (4): arm: dts: k3-am625-beagleplay: Package TIFS Stub doc: beagle: am62x_beagleplay: Update the boot flow to show TIFS Stub

[PATCH V3 1/4] arm: dts: k3-am625-beagleplay: Package TIFS Stub

2024-06-28 Thread Dhruva Gole
Add support for packaging the TIFS Stub as it's required for basic Low Power Modes like Deep Sleep. Acked-by: Neha Malcom Francis Signed-off-by: Dhruva Gole --- arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 33 +++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --

Re: [PATCH v2] arm: dts: k3-am625-beagleplay: Package TIFS Stub

2024-06-20 Thread Dhruva Gole
Nishanth, On Jun 19, 2024 at 13:47:36 -0500, Nishanth Menon wrote: > On 10:26-20240618, Dhruva Gole wrote: > > Add support for packaging the TIFS Stub as it's required for basic Low > > Power Modes like Deep Sleep. > > What the heck is tifs stub? > https://docs.u-boo

Re: [PATCH v2] arm: dts: k3-am625-beagleplay: Package TIFS Stub

2024-06-20 Thread Dhruva Gole
Bryan, On Jun 19, 2024 at 16:44:48 -0500, Bryan Brattlof wrote: > On June 18, 2024 thus sayeth Dhruva Gole: > > Add support for packaging the TIFS Stub as it's required for basic Low > > Power Modes like Deep Sleep. > > > > Acked-by: Neha Malcom Francis

Re: [PATCH] board: beagle: beagleplay: enable OF_SYSTEM_SETUP

2024-06-19 Thread Dhruva Gole
allocator to clobber TF-A and break its boot. > > > > Enable OF_SYSTEM_SETUP to fixup the kernel's FDT to inform it of the > > actual location of the firmware > > > > CC: Andrew Davis > > CC: Nishanth Menon > > CC: Robert Nelson > > Rep

Re: [PATCH 1/6] arm: mach-k3: Add default ATF location for AM62/AM62a

2024-06-19 Thread Dhruva Gole
implications there are of reverting this so I don't suggest immediately dropping it, however some hints around what's missing on beagleplay vs other platforms would be helpful. Because other platforms based off the same SoC don't seem to be affected. -- Best regards, Dhruva Gole

[PATCH v2] arm: dts: k3-am625-beagleplay: Package TIFS Stub

2024-06-17 Thread Dhruva Gole
Add support for packaging the TIFS Stub as it's required for basic Low Power Modes like Deep Sleep. Acked-by: Neha Malcom Francis Signed-off-by: Dhruva Gole --- No changes from v1, just picked Neha's ack and rebased on master again. Link to v1: https://lore.kernel.

[PATCH v2] board: beagleplay: Fix the bootpart to pick from root partition

2024-06-17 Thread Dhruva Gole
by: Chirag Shilwant Signed-off-by: Dhruva Gole --- No changes, just picked the r-by's and acks. Link to v1: https://lore.kernel.org/u-boot/20240613080604.3828083-1-d-g...@ti.com/ board/beagle/beagleplay/beagleplay.env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v4 2/2] doc: beagle: am62x_beagleplay: Rename the boot bins

2024-06-17 Thread Dhruva Gole
Rename the boot bins as the _unsigned postfixes are not longer required. We have symlinks in place for having generic names for all the boot bins now. Signed-off-by: Dhruva Gole --- doc/board/beagle/am62x_beagleplay.rst | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a

[PATCH v4 1/2] arm: dts: k3-am625-beagleplay: Add symlinks for tiboot3 and tispl

2024-06-17 Thread Dhruva Gole
Add symlinks for both tiboot3.bin and tispl.bin because a user has to anyway rename these files to get the platform to boot up. This just makes it more intuitive and convenient. Reviewed-by: Manorit Chawdhry Signed-off-by: Dhruva Gole --- arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 1

[PATCH v4 0/2] k3-am625-beagleplay: Add symlinks for tiboot3 and tispl

2024-06-17 Thread Dhruva Gole
Add symlinks for both tiboot3.bin and tispl.bin because a user has to anyway rename these files to get the platform to boot up. Also update the documentation to reflect above change. Changes in v4: * Add the docs patch. Cc: Nishant Menon Cc: Robert Nelson Dhruva Gole (2): arm: dts: k3-am625

Re: [PATCH] mtd: spi-nor: ids: Add IS25LP01GG flash support

2024-06-16 Thread Dhruva Gole
t;, 0x9d5a1a, 0, 64 * 1024, 1024, > SECT_4K | USE_FSR | SPI_NOR_4B_OPCODES | > SPI_NOR_HAS_TB) }, > + { INFO("is25lp01gg", 0x9d6021, 0, 64 * 1024, 2048, > + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | > SPI_NOR_HAS_TB) }, Otherwise looks good to me, Reviewed-by: Dhruva Gole -- Best regards, Dhruva

Re: [PATCH] board: beagleplay: Fix the bootpart to pick from root partition

2024-06-16 Thread Dhruva Gole
Hi Robert and Bryan, On Jun 15, 2024 at 21:30:55 -0500, Robert Nelson wrote: > On Sat, Jun 15, 2024 at 8:55 PM Bryan Brattlof wrote: > > > > On June 13, 2024 thus sayeth Dhruva Gole: > > > The Kernel Image and DTB files are supposed to be picked from the rootfs > >

[PATCH v3] arm: dts: k3-am625-beagleplay: Add symlinks for tiboot3 and tispl

2024-06-14 Thread Dhruva Gole
Add symlinks for both tiboot3.bin and tispl.bin because a user has to anyway rename these files to get the platform to boot up. This just makes it more intuitive and convenient. Signed-off-by: Dhruva Gole --- This is just a RESEND of v1, because the changes in v2 were not required. Link to

Re: [PATCH V2] arm: dts: k3-am625-beagleplay: Add symlinks for boot binaries

2024-06-14 Thread Dhruva Gole
On Jun 14, 2024 at 17:23:40 +0530, Dhruva Gole wrote: > Add symlinks for tiboot3.bin, tispl.bin & u-boot.img because a user has to > anyway rename these files to get the platform to boot up. > This just makes it more intuitive and convenient. > > Signed-off-by: Dhruva Gole

Re: [PATCH] arm: dts: k3-am625-beagleplay: Add symlinks for tiboot3 and tispl

2024-06-14 Thread Dhruva Gole
On Jun 14, 2024 at 15:16:30 +0530, Manorit Chawdhry wrote: > Hi Dhruva, > > On 14:10-20240614, Dhruva Gole wrote: > > Add symlinks for both tiboot3.bin and tispl.bin because a user has to > > anyway rename these files to get the platform to boot up. > > This just

[PATCH V2] arm: dts: k3-am625-beagleplay: Add symlinks for boot binaries

2024-06-14 Thread Dhruva Gole
Add symlinks for tiboot3.bin, tispl.bin & u-boot.img because a user has to anyway rename these files to get the platform to boot up. This just makes it more intuitive and convenient. Signed-off-by: Dhruva Gole --- Changes: Add symlink for u-boot.img as well as per Manorit's suggestion.

[PATCH] arm: dts: k3-am625-beagleplay: Add symlinks for tiboot3 and tispl

2024-06-14 Thread Dhruva Gole
Add symlinks for both tiboot3.bin and tispl.bin because a user has to anyway rename these files to get the platform to boot up. This just makes it more intuitive and convenient. Signed-off-by: Dhruva Gole --- arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 1 + arch/arm/dts/k3-am625-r5

Re: [PATCH] board: beagleplay: Fix the bootpart to pick from root partition

2024-06-13 Thread Dhruva Gole
Robert, On Jun 13, 2024 at 16:51:24 -0500, Robert Nelson wrote: > On Thu, Jun 13, 2024 at 4:47 PM Robert Nelson wrote: > > > > On Thu, Jun 13, 2024 at 3:06 AM Dhruva Gole wrote: > > > > > > The Kernel Image and DTB files are supposed to be picked from the rootfs

[PATCH] board: beagleplay: Fix the bootpart to pick from root partition

2024-06-13 Thread Dhruva Gole
The Kernel Image and DTB files are supposed to be picked from the rootfs of the SD Card, this fails in legacy boot flow because bootpart is set to 1:1. Fix it. Fixes: a200f428b5b21 ("board: ti: am62x: Add am62x_beagleplay_* defconfigs and env file") Signed-off-by: Dhruva Gole --- bo

[PATCH] arm: dts: k3-am625-beagleplay: Package TIFS Stub

2024-06-11 Thread Dhruva Gole
Add support for packaging the TIFS Stub as it's required for basic Low Power Modes like Deep Sleep. Signed-off-by: Dhruva Gole --- arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 33 +++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/arch/arm/dts/k3-

[PATCH 2/2] arm: dts: k3: binman: am62p: add support for signing TIFSStub images

2024-06-07 Thread Dhruva Gole
Adds TIFS stub binaries, this is required for deepsleep functionality. This implements the same change as commit 128f81290b7d ("arm: dts: k3: binman: am625: add support for signing TIFSSTUB Images") did for TI AM62 SK board. Signed-off-by: Vibhore Vardhan Signed-off-by: Dhruva Gole

[PATCH 1/2] arm: dts: k3: binman: am62a: add support for signing TIFSStub Images

2024-06-07 Thread Dhruva Gole
ned-off-by: Vibhore Vardhan Signed-off-by: Dhruva Gole --- arch/arm/dts/k3-am62a-sk-binman.dtsi | 138 ++- 1 file changed, 136 insertions(+), 2 deletions(-) diff --git a/arch/arm/dts/k3-am62a-sk-binman.dtsi b/arch/arm/dts/k3-am62a-sk-binman.dtsi index ec3bf7ce913b..d7

[PATCH 0/2] binman: am62a/62p: add support for signing TIFSStub

2024-06-07 Thread Dhruva Gole
gets used in the Low Power Exit sequences. Boot tested on both platforms that are being touched: [0] AM62A, [1] AM62P [0] https://gist.github.com/DhruvaG2000/d5f2a46818d8025a540efe9289feacb4 [1] https://gist.github.com/DhruvaG2000/ce29f6e9315a78d3e9e5810f55f17f43 Dhruva Gole (2): arm: dts: k3: b

Re: [PATCH 0/3] arm: dts: am625/am62a7: Switch over to OF_UPSTREAM

2024-06-05 Thread Dhruva Gole
ts: am62a7_sk: Switch to OF_UPSTREAM > For the series, Reviewed-by: Dhruva Gole -- Best regards, Dhruva Gole

Re: [PATCH v2 0/8] Add DFU, emmc and usb boot for TI am62x

2024-05-28 Thread Dhruva Gole
> > > > I still carry your re-based series on top of latest master [1] and USB DFU > > is working very well on Verdin AM62. > > > > Thanks! > > > > [1] https://github.com/ziswiler/u-boot/tree/verdin-am62-usb-support > > As the am62 files have been re-synced, re-basing this and re-posting for > next would be appropriate at this point. Any updates on this? Do you have plans to rebase and resend this series? -- Best regards, Dhruva Gole

Re: [PATCH v2 2/5] board: phytec: Fix function definitions in AM6x SOM detection

2024-05-22 Thread Dhruva Gole
Egorov > Tested-by: John Ma > --- > board/phytec/common/am6_som_detection.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Dhruva Gole [...] -- Best regards, Dhruva Gole

Re: [PATCH v2 1/5] board: phytec: Make AM6 SoM detection depend on I2C

2024-05-22 Thread Dhruva Gole
Hi, On May 22, 2024 at 09:55:01 +0200, Wadim Egorov wrote: > SoM detection is using I2C driver model functions. > Let's depend on I2C. > > Signed-off-by: Wadim Egorov > Tested-by: John Ma > --- Reviewed-by: Dhruva Gole -- Best regards, Dhruva Gole

Re: [PATCH 2/2] configs: add defconfigs for the am625-lp-sk

2024-05-02 Thread Dhruva Gole
F_UPSTREAM=y > diff --git a/configs/am62x_lp_sk_r5_defconfig > b/configs/am62x_lp_sk_r5_defconfig > new file mode 100644 > index 0..93b3922e6fec5 > --- /dev/null > +++ b/configs/am62x_lp_sk_r5_defconfig > @@ -0,0 +1,2 @@ > +#include > +CONFIG_DEFAULT_DEVICE_TREE="k3-am62-r5-lp-sk" Reviewed-by: Dhruva Gole -- Best regards, Dhruva Gole

Re: [PATCH 1/2] arm: dts: add U-Boot dtbs for the am625-lp-sk

2024-05-02 Thread Dhruva Gole
k-u-boot.dtsi > b/arch/arm/dts/k3-am62-lp-sk-u-boot.dtsi > new file mode 100644 > index 0..08f572446657e > --- /dev/null > +++ b/arch/arm/dts/k3-am62-lp-sk-u-boot.dtsi > @@ -0,0 +1,17 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * AM62x LP SK dts file for SPLs > + * Copyright (C) 2021-2023 Texas Instruments Incorporated - > https://www.ti.com/ 2024 ^^ [...] With that fixed, Reviewed-by: Dhruva Gole -- Best regards, Dhruva Gole

Re: [PATCH v2 1/3] mtd: spi-nore-core: Fix 4KB erase opcode for s25fs-s

2024-04-10 Thread Dhruva Gole
BE_4K; > + > /* Support 8 x 4KB sectors at bottom */ > - return spansion_erase_non_uniform(nor, addr, SPINOR_OP_BE_4K_4B, 0, > SZ_32K); > + return spansion_erase_non_uniform(nor, addr, opcode, 0, SZ_32K); Reviewed-by: Dhruva Gole -- Best regards, Dhruva

Re: [PATCH v2 2/3] mtd: spi-nor-id: Use INFO6 macro for S25FL-S

2024-04-10 Thread Dhruva Gole
256 * 1024, 128, > SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) }, > + { INFO6("s25fl256s1", 0x010219, 0x4d0180, 64 * 1024, 512, > SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) }, Reviewed-by: Dhruva Gole -- Best regards, Dhruva

Re: [PATCH 2/2] arm: dts: k3: binman: am625: add support for signing TIFSSTUB Images

2024-04-04 Thread Dhruva Gole
Hi Neha! On Apr 04, 2024 at 10:20:21 +0530, Neha Malcom Francis wrote: > Hi Dhruva > > On 03/04/24 17:33, Dhruva Gole wrote: > > From: Kamlesh Gurudasani > > > > Add support for signing of TIFSSTUB images for HSSE, HSFS and GP devices > > and include them in

[PATCH 2/2] arm: dts: k3: binman: am625: add support for signing TIFSSTUB Images

2024-04-03 Thread Dhruva Gole
From: Kamlesh Gurudasani Add support for signing of TIFSSTUB images for HSSE, HSFS and GP devices and include them in tispl.bin and tispl.bin_unsigned. Signed-off-by: Kamlesh Gurudasani Signed-off-by: Dhruva Gole --- arch/arm/dts/k3-am625-sk-binman.dtsi | 141 ++- 1

[PATCH 1/2] arm: mach-k3: add support for detecting TIFSSTUB images

2024-04-03 Thread Dhruva Gole
discarded. Signed-off-by: Kamlesh Gurudasani Signed-off-by: Dhruva Gole --- arch/arm/mach-k3/r5/common.c | 24 1 file changed, 24 insertions(+) diff --git a/arch/arm/mach-k3/r5/common.c b/arch/arm/mach-k3/r5/common.c index c02f8d330998..0f6c294f1eb2 100644 --- a/arch

[PATCH 0/2] Add TIFS Stub support in AM62x

2024-04-03 Thread Dhruva Gole
Add support for signing, detection and loading of TIFSSTUB images for for HSSE, HSFS and GP AM62x devices. Boot tested and Deepsleep entry exist tested with ti-linux: https://gist.github.com/DhruvaG2000/036010f6ae75aa6443fc77f61fd74893 Patches are based on top of tag: v2024.04 Cc: Tom Rini Cc:

Re: [PATCH v1] verdin-am62: move verdin am62 to OF_UPSTREAM

2024-04-03 Thread Dhruva Gole
the > *-u-boot.dtsi files > - update MAINTAINERS file > > Signed-off-by: Marcel Ziswiler > > --- Reviewed-by: Dhruva Gole -- Best regards, Dhruva

Re: [PATCH v2 5/5] power: regulator: tps65941: Add TPS65224 PMIC regulator support

2024-03-08 Thread Dhruva Gole
R_TYPE_BUCK; > @@ -356,16 +591,35 @@ static int tps65941_buck_probe(struct udevice *dev) > case TPS65941_BUCK_ID_2: > case TPS65941_BUCK_ID_3: > case TPS65941_BUCK_ID_4: > - case TPS65941_BUCK_ID_5: > debug("Single phase regulator\n"); > break; > + case TPS65941_BUCK_ID_5: > + if (chip_id != TPS65224) { > + debug("Single phase regulator\n"); > + } else { > + printf("Wrong ID for regulator\n"); no printfs please. > + return -EINVAL; > + } > + break; > case TPS65941_BUCK_ID_12: > + idx = 1; > + break; > case TPS65941_BUCK_ID_123: > case TPS65941_BUCK_ID_1234: > - idx = 1; > + if (chip_id != TPS65224) { > + idx = 1; > + } else { > + printf("Wrong ID for regulator\n"); ditto. > + return -EINVAL; > + } > break; > case TPS65941_BUCK_ID_34: > - idx = 3; > + if (chip_id != TPS65224) { > + idx = 3; > + } else { > + printf("Wrong ID for regulator\n"); Like in your other patches, can you please use pr_err or friends? > + return -EINVAL; > + } > break; > default: > pr_err("Wrong ID for regulator\n"); > -- > 2.25.1 > -- Best regards, Dhruva Gole

Re: [PATCH v2 1/5] power: tps65941: Add macros of TPS65224 PMIC

2024-03-08 Thread Dhruva Gole
On Mar 06, 2024 at 19:09:43 +0530, Bhargav Raviprakash wrote: > Re-use the TPS65941 PMIC driver for TPS65224 PMIC. > Add additional macros of TPS65224 to aid in the driver > re-use. > > Signed-off-by: Bhargav Raviprakash > --- Reviewed-by: Dhruva Gole > include/

Re: [PATCH v2 3/5] power: regulator: tps65941: Added macros for BUCK ID

2024-03-08 Thread Dhruva Gole
UCK_ID_12: > + case TPS65941_BUCK_ID_123: > + case TPS65941_BUCK_ID_1234: > idx = 1; > - } else if (idx == 34) { > + break; > + case TPS65941_BUCK_ID_34: > idx = 3; > - } else if (idx == 123) { > - idx = 1; > - } else if (idx == 1234) { > - idx = 1; > - } else { > - printf("Wrong ID for regulator\n"); > + break; > + default: > + pr_err("Wrong ID for regulator\n"); > return -EINVAL; Reviewed-by: Dhruva Gole -- Best regards, Dhruva Gole

Re: [PATCH v2 2/5] power: pmic: tps65941: Add TI TPS65224 PMIC

2024-03-08 Thread Dhruva Gole
atible = "ti,tps659412", .data = TPS659411 }, > { .compatible = "ti,tps659413", .data = TPS659413 }, > { .compatible = "ti,lp876441", .data = LP876441 }, > + { .compatible = "ti,tps65224", .data = TPS65224 }, Reviewed-by: Dhruva Gole -- Best regards, Dhruva Gole

  1   2   >